[jira] [Comment Edited] (SUREFIRE-1840) Why sudo docker?

2020-11-26 Thread Matthew Wang (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239558#comment-17239558 ] Matthew Wang edited comment on SUREFIRE-1840 at 11/27/20, 7:52 AM: ---

[jira] [Comment Edited] (SUREFIRE-1840) Why sudo docker?

2020-11-26 Thread Matthew Wang (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239558#comment-17239558 ] Matthew Wang edited comment on SUREFIRE-1840 at 11/27/20, 7:51 AM: ---

[jira] [Commented] (SUREFIRE-1840) Why sudo docker?

2020-11-26 Thread Matthew Wang (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239558#comment-17239558 ] Matthew Wang commented on SUREFIRE-1840: I would expect that this is because the docker daemon

[GitHub] [maven-jlink-plugin] sparsick commented on pull request #20: (build) Add Java8 + Toolchain tests

2020-11-26 Thread GitBox
sparsick commented on pull request #20: URL: https://github.com/apache/maven-jlink-plugin/pull/20#issuecomment-734679429 @bmarwell I had a look on the output of the Github Action. I think the toolchain is used because of this debug line: ```shell DEBUG] Reading user toolchains

[jira] [Commented] (MNG-7019) Notify also at start when profile is missing

2020-11-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239445#comment-17239445 ] Hudson commented on MNG-7019: - Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7028 #2 See

[jira] [Commented] (MNG-7028) Upgrade Jansi to 2.0.1

2020-11-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239446#comment-17239446 ] Hudson commented on MNG-7028: - Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7028 #2 See

[jira] [Commented] (MNG-3485) unable to override wagons that are bundled with a different version via extensions

2020-11-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239447#comment-17239447 ] Hudson commented on MNG-3485: - Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7028 #2 See

[GitHub] [maven] slachiewicz opened a new pull request #401: [MNG-7028] Upgrade to Jansi 2.0.1

2020-11-26 Thread GitBox
slachiewicz opened a new pull request #401: URL: https://github.com/apache/maven/pull/401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (MPLUGIN-340) upgrade Ant version to 1.9.13

2020-11-26 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239436#comment-17239436 ] Sylwester Lachiewicz commented on MPLUGIN-340: -- With the upgrade to Ant 1.8+ few tests

[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion

2020-11-26 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239402#comment-17239402 ] Martin Kanters commented on MNG-6268: - [~pzygielo] no problem! I'm glad that we cleared that up and

[jira] [Commented] (MNG-7033) Excluded projects through -pl should not need to be in the reactor

2020-11-26 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239400#comment-17239400 ] Martin Kanters commented on MNG-7033: - Hi [~agentgt], thanks for your thorough explanation. I agree

[jira] [Commented] (DOXIA-542) Markdown module converts all apostrophes to quotation marks

2020-11-26 Thread Bertrand Martin (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239398#comment-17239398 ] Bertrand Martin commented on DOXIA-542: --- This is still true with the new FlexMark markdown Doxia

[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion

2020-11-26 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239397#comment-17239397 ] Piotr Zygielo commented on MNG-6268: [~martinkanters] - MNG-4660 - most probably! Thanks for reference

[jira] [Comment Edited] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion

2020-11-26 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239394#comment-17239394 ] Martin Kanters edited comment on MNG-6268 at 11/26/20, 7:09 PM:

[jira] [Commented] (MNG-6268) When a reactor build fails Maven should include -f (if used) in command line suggestion

2020-11-26 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239394#comment-17239394 ] Martin Kanters commented on MNG-6268: - [~michael-o] I agree with all or nothing, but it might get

[jira] [Commented] (MNG-7024) Directory instead of file in an artifact

2020-11-26 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239387#comment-17239387 ] Martin Kanters commented on MNG-7024: - I think I agree with that. If someone wants to take a shot on

[jira] [Updated] (DOXIA-616) Markdown: Properly expose the language specified in fenced code blocks

2020-11-26 Thread Bertrand Martin (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Martin updated DOXIA-616: -- Description: h1. Use Case Writers can specify the language used in a fenced code block

[jira] [Created] (DOXIA-616) Markdown: Properly expose the language specified in fenced code blocks

2020-11-26 Thread Bertrand Martin (Jira)
Bertrand Martin created DOXIA-616: - Summary: Markdown: Properly expose the language specified in fenced code blocks Key: DOXIA-616 URL: https://issues.apache.org/jira/browse/DOXIA-616 Project: Maven

[GitHub] [maven-jlink-plugin] elharo commented on pull request #19: [MJLINK-58] Remove usage of plexus utils, use commons lang or native …

2020-11-26 Thread GitBox
elharo commented on pull request #19: URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-734364680 In general import restrictions sound good. Probably bring it up on the dev mailing list to see if we want a policy for all of maven.

[GitHub] [maven] gnodet commented on pull request #400: [MNG-7035] Migrate all tests to JUnit 4

2020-11-26 Thread GitBox
gnodet commented on pull request #400: URL: https://github.com/apache/maven/pull/400#issuecomment-734361374 > please also look into #346 where I made a related changes This is mostly related to JSR330 afaik. I think the blocking issue for migrating to JSR330 is

[GitHub] [maven] gnodet commented on a change in pull request #400: [MNG-7035] Migrate all tests to JUnit 4

2020-11-26 Thread GitBox
gnodet commented on a change in pull request #400: URL: https://github.com/apache/maven/pull/400#discussion_r531099832 ## File path: maven-compat/src/test/java/org/apache/maven/PlexusTestCase.java ## @@ -0,0 +1,294 @@ +package org.apache.maven; + +/* + * Licensed to the Apache

[GitHub] [maven-deploy-plugin] rvesse commented on pull request #3: Skip specified attached artifacts from deploy

2020-11-26 Thread GitBox
rvesse commented on pull request #3: URL: https://github.com/apache/maven-deploy-plugin/pull/3#issuecomment-734331457 Another practical use case, due to the constraints of our CI/CD system some of our projects use Apache Maven as the overarching build tool but use plugins to invoke other

[GitHub] [maven] gnodet commented on a change in pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-11-26 Thread GitBox
gnodet commented on a change in pull request #399: URL: https://github.com/apache/maven/pull/399#discussion_r531053718 ## File path: maven-model-builder/src/test/java/org/apache/maven/model/building/CyclicParentTest.java ## @@ -0,0 +1,143 @@ +package

[GitHub] [maven] gnodet commented on a change in pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-11-26 Thread GitBox
gnodet commented on a change in pull request #399: URL: https://github.com/apache/maven/pull/399#discussion_r531053387 ## File path: maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderTest.java ## @@ -0,0 +1,151 @@ +package

[GitHub] [maven-jlink-plugin] bmarwell commented on a change in pull request #21: [MJLINK-53] Add classifier support

2020-11-26 Thread GitBox
bmarwell commented on a change in pull request #21: URL: https://github.com/apache/maven-jlink-plugin/pull/21#discussion_r531052492 ## File path: src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java ## @@ -428,11 +437,13 @@ private JLinkExecutor getExecutor()

[GitHub] [maven-jlink-plugin] bmarwell opened a new pull request #21: [MJLINK-53] Add classifier support

2020-11-26 Thread GitBox
bmarwell opened a new pull request #21: URL: https://github.com/apache/maven-jlink-plugin/pull/21 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJLINK) filed

[jira] [Commented] (MNG-7028) Upgrade Jansi to 2.0.1

2020-11-26 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239279#comment-17239279 ] Guillaume Nodet commented on MNG-7028: -- If there's any problem with the jansi, let me know so that I

[jira] [Assigned] (MSHARED-860) Deprecate obsolete functionality

2020-11-26 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MSHARED-860: Assignee: Elliotte Rusty Harold > Deprecate obsolete functionality >

[jira] [Closed] (MSHARED-860) Deprecate obsolete functionality

2020-11-26 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MSHARED-860. Resolution: Fixed > Deprecate obsolete functionality >

[jira] [Updated] (MSHARED-860) Deprecate obsolete functionality

2020-11-26 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-860: - Fix Version/s: maven-shared-utils-3.3.3 > Deprecate obsolete functionality >

[jira] [Updated] (MSHARED-848) Code Improvement in ReaderFactory to get rid of commons-io dependency

2020-11-26 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-848: - Fix Version/s: (was: maven-shared-utils-3.3.3) > Code Improvement in

[jira] [Created] (MSHARED-963) Require Maven 3.1.1 (drop dependency to Mave 3.0 Sonatype Aether)

2020-11-26 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MSHARED-963: Summary: Require Maven 3.1.1 (drop dependency to Mave 3.0 Sonatype Aether) Key: MSHARED-963 URL: https://issues.apache.org/jira/browse/MSHARED-963

[GitHub] [maven] slachiewicz commented on a change in pull request #400: [MNG-7035] Migrate all tests to JUnit 4

2020-11-26 Thread GitBox
slachiewicz commented on a change in pull request #400: URL: https://github.com/apache/maven/pull/400#discussion_r530970798 ## File path: maven-compat/src/test/java/org/apache/maven/PlexusTestCase.java ## @@ -0,0 +1,294 @@ +package org.apache.maven; + +/* + * Licensed to the

[GitHub] [maven] michael-o commented on pull request #346: [MNG-6909] Use CDI to inject objects under tests

2020-11-26 Thread GitBox
michael-o commented on pull request #346: URL: https://github.com/apache/maven/pull/346#issuecomment-734249917 Why wasn't this merged yet? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven] slachiewicz commented on pull request #400: [MNG-7035] Migrate all tests to JUnit 4

2020-11-26 Thread GitBox
slachiewicz commented on pull request #400: URL: https://github.com/apache/maven/pull/400#issuecomment-734248903 please also look into #346 where I made a related changes This is an automated message from the Apache Git

[jira] [Commented] (MNG-7036) Avoid non-compile goals (e.g., test) for --also-make introduced modules

2020-11-26 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/MNG-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239194#comment-17239194 ] Volkan Yazici commented on MNG-7036: See [the related StackOverflow

[jira] [Updated] (MNG-7036) Avoid non-compile goals (e.g., test) for --also-make introduced modules

2020-11-26 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/MNG-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici updated MNG-7036: --- Description: It is a common practice to execute goals for a single module, e.g., {{mvn \-pl son

[jira] [Created] (MNG-7036) Avoid non-compile goals (e.g., test) for --also-make introduced modules

2020-11-26 Thread Volkan Yazici (Jira)
Volkan Yazici created MNG-7036: -- Summary: Avoid non-compile goals (e.g., test) for --also-make introduced modules Key: MNG-7036 URL: https://issues.apache.org/jira/browse/MNG-7036 Project: Maven

[GitHub] [maven] gnodet opened a new pull request #400: [MNG-7035] Migrate all tests to JUnit 4

2020-11-26 Thread GitBox
gnodet opened a new pull request #400: URL: https://github.com/apache/maven/pull/400 Migration of all tests to Unit 4 without any refactoring beyond the bare minimum (i.e. add @Test, @Before and @After) methods. For plexus powered tests, I had to copy the migrated `PlexusTestCase` as

[jira] [Created] (MNG-7035) Migrate unit tests to Unit 4

2020-11-26 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7035: Summary: Migrate unit tests to Unit 4 Key: MNG-7035 URL: https://issues.apache.org/jira/browse/MNG-7035 Project: Maven Issue Type: Task

[GitHub] [maven-indexer] scela closed pull request #19: Migrate to Lucene 7

2020-11-26 Thread GitBox
scela closed pull request #19: URL: https://github.com/apache/maven-indexer/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-jlink-plugin] bmarwell commented on pull request #19: [MJLINK-58] Remove usage of plexus utils, use commons lang or native …

2020-11-26 Thread GitBox
bmarwell commented on pull request #19: URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-734213882 There’s also https://github.com/policeman-tools/forbidden-apis. I am not a committer, but I would like to see import restrictions as well. Maybe @elharo has an

[GitHub] [maven-jlink-plugin] bmarwell opened a new pull request #20: (build) Add Java8 + Toolchain tests

2020-11-26 Thread GitBox
bmarwell opened a new pull request #20: URL: https://github.com/apache/maven-jlink-plugin/pull/20 ### DO NOT MERGE YET The `toolchain.xml` file is not being used: https://github.com/bmarwell/maven-jlink-plugin/runs/1458231353?check_suite_focus=true Open up the "Build with

[GitHub] [maven-jlink-plugin] sparsick commented on pull request #19: [MJLINK-58] Remove usage of plexus utils, use commons lang or native …

2020-11-26 Thread GitBox
sparsick commented on pull request #19: URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-734206534 I found this [project](https://github.com/skuzzle/restrict-imports-enforcer-rule) that create enforce rule for this use case. Would be it OK, when I would introduce it

[GitHub] [maven-jlink-plugin] sparsick commented on pull request #19: [MJLINK-58] Remove usage of plexus utils, use commons lang or native …

2020-11-26 Thread GitBox
sparsick commented on pull request #19: URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-734204263 One question: Is there a possibility to prevent import package like `org.codehaus.plexus.util.*` via a maven plugin?

[GitHub] [maven-jlink-plugin] sparsick opened a new pull request #19: [MJLINK-58] Remove usage of plexus utils, use commons lang or native …

2020-11-26 Thread GitBox
sparsick opened a new pull request #19: URL: https://github.com/apache/maven-jlink-plugin/pull/19 …java instead. - replace org.codehaus.plexus.util.StringUtils by org.apache.commons.lang3.StringUtils - replace org.codehaus.plexus.util.FileUtils by org.apache.commons.io.FileUtils

[GitHub] [maven] pzygielo commented on a change in pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-11-26 Thread GitBox
pzygielo commented on a change in pull request #399: URL: https://github.com/apache/maven/pull/399#discussion_r530837309 ## File path: maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderTest.java ## @@ -0,0 +1,151 @@ +package