[ 
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239394#comment-17239394
 ] 

Martin Kanters commented on MNG-6268:
-------------------------------------

[~michael-o] I agree with all or nothing, but it might get complex if we would 
let the user decide on two different modes of resume. 
Perhaps we can work with a default: If the user only runs {mvn -r} all goals 
will be repeated, but if the user executes {mvn verify -r}, perhaps the 
original goals could be overwritten?
I don't think any of those solutions are good enough though. What to do with 
cli properties that are added to the -r request for example... should the 
override or be added to the original properties etc..

[~pzygielo] I think every phase should be resumable now. "compile" ends up with 
class files in {target/classes}, which can be used in a resumed build module 
(on master branch, not on 3.6.3).
https://issues.apache.org/jira/browse/MNG-4660 is the fix for that. (if I 
understand your concern correctly :) ). 3.6.3 does indeed (incorrectly) hint 
you -rf even when the sources were not installed yet (that resulted in the 
MNG-4660 bug).

> When a reactor build fails Maven should include -f (if used) in command line 
> suggestion
> ---------------------------------------------------------------------------------------
>
>                 Key: MNG-6268
>                 URL: https://issues.apache.org/jira/browse/MNG-6268
>             Project: Maven
>          Issue Type: Improvement
>    Affects Versions: 3.5.0
>            Reporter: Andreas Sewe
>            Assignee: Michael Osipov
>            Priority: Trivial
>             Fix For: 3.7.x-candidate
>
>
> When a reactor build fails, Maven prints out a helpful suggestion on how to 
> resume.
> {noformat}
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn <goals> -rf :example
> {noformat}
> Unfortunately, when running {{mvn}} with {{-f}}, this suggestion is wrong; 
> Maven will either pick the wrong {{pom.xml}} or simply won’t find any; in 
> either case, the {{pom.xml}} specified with {{-f}} is *crucial* information 
> that was left out of the suggestion.
> FYI, this is related to MNG-6028, but covers a different bit of info that 
> IMHO should be part of the suggestion. Hence this separate issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to