Jesus Salvo created MJAVADOC-671:
Summary: Generated javadoc.bat fails to execute in Windows10
Key: MJAVADOC-671
URL: https://issues.apache.org/jira/browse/MJAVADOC-671
Project: Maven Javadoc Plugin
[
https://issues.apache.org/jira/browse/MNGSITE-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284031#comment-17284031
]
Hudson commented on MNGSITE-430:
Build succeeded in Jenkins: Maven » Maven TLP » maven-s
[
https://issues.apache.org/jira/browse/MWRAPPER-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283984#comment-17283984
]
Anthony Whitford commented on MWRAPPER-11:
--
Is this a duplicate of MWRAPPER-6?
MartinKanters commented on pull request #98:
URL:
https://github.com/apache/maven-integration-testing/pull/98#issuecomment-778442266
> > > I've fixed the comments and change the tests to rely on the `verify`
goal rather than `install`.
> >
> >
> > Great. They are still running a
gnodet commented on pull request #98:
URL:
https://github.com/apache/maven-integration-testing/pull/98#issuecomment-778440870
> > I've fixed the comments and change the tests to rely on the `verify`
goal rather than `install`.
>
> Great. They are still running atm, but the results l
MartinKanters commented on pull request #444:
URL: https://github.com/apache/maven/pull/444#issuecomment-778436709
Cool, your ITs are looking good right now, so the PR can be merged in my
opinion. @mthmulders do you want to take another look? Otherwise I can merge
somewhere this weekend.
MartinKanters commented on pull request #98:
URL:
https://github.com/apache/maven-integration-testing/pull/98#issuecomment-778436035
> I've fixed the comments and change the tests to rely on the `verify` goal
rather than `install`.
Great. They are still running atm, but the results
gnodet commented on pull request #98:
URL:
https://github.com/apache/maven-integration-testing/pull/98#issuecomment-778426174
I've fixed the comments and change the tests to rely on the `verify` goal
rather than `install`.
MartinKanters commented on pull request #98:
URL:
https://github.com/apache/maven-integration-testing/pull/98#issuecomment-778420212
> I've rerun the GitHub Actions build on your maven PR, this should take
these new ITs into account as well (as both branches are named the same):
> https
[
https://issues.apache.org/jira/browse/MNG-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters reassigned MNG-7099:
---
Assignee: Martin Kanters
> Can not resume build without installing the artifacts
> ---
[
https://issues.apache.org/jira/browse/MNG-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters closed MNG-7099.
---
Resolution: Duplicate
> Can not resume build without installing the artifacts
> ---
[
https://issues.apache.org/jira/browse/MNG-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283945#comment-17283945
]
Martin Kanters commented on MNG-7099:
-
Thanks anyway for the PR and the bug report!
>
gnodet closed pull request #99:
URL: https://github.com/apache/maven-integration-testing/pull/99
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
gnodet commented on pull request #99:
URL:
https://github.com/apache/maven-integration-testing/pull/99#issuecomment-778414851
Duplicate, already fixed in maven 4
This is an automated message from the Apache Git Service.
To r
[
https://issues.apache.org/jira/browse/MNG-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283943#comment-17283943
]
Guillaume Nodet commented on MNG-7099:
--
Yes, this is clearly a duplicate. Feel free t
MartinKanters commented on pull request #98:
URL:
https://github.com/apache/maven-integration-testing/pull/98#issuecomment-778413713
Also I don't mind it too much, but perhaps we could avoid `install` now, if
MNG-4660 indeed has fixed the issue you described in MNG-7099.
MartinKanters edited a comment on pull request #444:
URL: https://github.com/apache/maven/pull/444#issuecomment-778412923
> > > @mthmulders @MartinKanters quick question.
> > > I'm working on improving the integration test and have the following
scenario: a parent, 3 modules named `A`, `
MartinKanters commented on pull request #444:
URL: https://github.com/apache/maven/pull/444#issuecomment-778412923
> > > @mthmulders @MartinKanters quick question.
> > > I'm working on improving the integration test and have the following
scenario: a parent, 3 modules named `A`, `B`, `C`
MartinKanters commented on pull request #98:
URL:
https://github.com/apache/maven-integration-testing/pull/98#issuecomment-778411008
I've rerun the GitHub Actions build on your maven PR, this should take these
new ITs into account as well (as both branches are named the same):
https://g
MartinKanters commented on a change in pull request #98:
URL:
https://github.com/apache/maven-integration-testing/pull/98#discussion_r57547
##
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5760ResumeFeatureTest.java
##
@@ -175,6 +179,112 @@ public v
[
https://issues.apache.org/jira/browse/MNG-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283935#comment-17283935
]
Martin Kanters commented on MNG-7099:
-
Hey [~gnodet], I totally understand you, this ha
MartinKanters commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575186110
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionAnalyzer.java
##
@@ -47,132 +41,49 @@
@Override
publi
gnodet commented on pull request #444:
URL: https://github.com/apache/maven/pull/444#issuecomment-778388548
I've raised MNG-7099 and provided a PR with an integration test.
This is an automated message from the Apache Git Ser
[
https://issues.apache.org/jira/browse/MNG-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283918#comment-17283918
]
Guillaume Nodet commented on MNG-7099:
--
Fwiw, I think that's the reason why I've never
[
https://issues.apache.org/jira/browse/MNG-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283917#comment-17283917
]
Guillaume Nodet commented on MNG-7099:
--
A PR with an integration test is available at
gnodet opened a new pull request #99:
URL: https://github.com/apache/maven-integration-testing/pull/99
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Guillaume Nodet created MNG-7099:
Summary: Can not resume build without installing the artifacts
Key: MNG-7099
URL: https://issues.apache.org/jira/browse/MNG-7099
Project: Maven
Issue Type: T
Andres Almiray created MSHADE-382:
-
Summary: Add an option to skip execution
Key: MSHADE-382
URL: https://issues.apache.org/jira/browse/MSHADE-382
Project: Maven Shade Plugin
Issue Type: Impr
gnodet commented on pull request #444:
URL: https://github.com/apache/maven/pull/444#issuecomment-778360471
> > @mthmulders @MartinKanters quick question.
> > I'm working on improving the integration test and have the following
scenario: a parent, 3 modules named `A`, `B`, `C` with `C` d
gnodet commented on pull request #98:
URL:
https://github.com/apache/maven-integration-testing/pull/98#issuecomment-778325826
I'll add another test
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/MNG-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283833#comment-17283833
]
Hudson commented on MNG-7077:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #
mthmulders commented on pull request #444:
URL: https://github.com/apache/maven/pull/444#issuecomment-778301747
> @mthmulders @MartinKanters quick question.
> I'm working on improving the integration test and have the following
scenario: a parent, 3 modules named `A`, `B`, `C` with `C` d
rfscholte closed pull request #432:
URL: https://github.com/apache/maven/pull/432
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
rfscholte commented on pull request #432:
URL: https://github.com/apache/maven/pull/432#issuecomment-778294714
Merged with
https://github.com/apache/maven/commit/48fc10889ef89d12ebe2258029937010d81aebb7
This is an automated
[
https://issues.apache.org/jira/browse/MNG-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MNG-7077.
---
Fix Version/s: 4.0.0-alpha-1
4.0.0
Assignee: Robert Scholte
Resolutio
gnodet commented on pull request #444:
URL: https://github.com/apache/maven/pull/444#issuecomment-778273066
I've added an integration test that tries to make sure the resume won't
rebuild already built projects,
see https://github.com/apache/maven-integration-testing/pull/98
Event
gnodet opened a new pull request #98:
URL: https://github.com/apache/maven-integration-testing/pull/98
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gnodet commented on pull request #444:
URL: https://github.com/apache/maven/pull/444#issuecomment-778266531
> @mthmulders @MartinKanters quick question.
> I'm working on improving the integration test and have the following
scenario: a parent, 3 modules named `A`, `B`, `C` with `C` depen
gnodet commented on pull request #444:
URL: https://github.com/apache/maven/pull/444#issuecomment-778264311
@mthmulders @MartinKanters quick question.
I'm working on improving the integration test and have the following
scenario: a parent, 3 modules named `A`, `B`, `C` with `C` depending
rfscholte commented on pull request #402:
URL: https://github.com/apache/maven/pull/402#issuecomment-778258696
ok, let me check that one first
This is an automated message from the Apache Git Service.
To respond to the messag
[
https://issues.apache.org/jira/browse/MNG-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283768#comment-17283768
]
Michael Osipov commented on MNG-7063:
-
[~cstamas], this is likely the same as your issu
gnodet commented on pull request #402:
URL: https://github.com/apache/maven/pull/402#issuecomment-778257427
> I just had another look at this. It looks to me that this commit has
become too big. We should split it into 2 pieces:
>
> * rewriting JUnit tests using maven-test-support.
rfscholte commented on pull request #402:
URL: https://github.com/apache/maven/pull/402#issuecomment-778249119
I just had another look at this. It looks to me that this commit has become
too big. We should split it into 2 pieces:
* rewriting JUnit tests using maven-test-support.
* R
gnodet commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575250093
##
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##
@@ -1032,20 +1031,6 @@ private int execute( CliRequest cliRequest )
MartinKanters commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575239494
##
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##
@@ -1032,20 +1031,6 @@ private int execute( CliRequest cliRequest )
[
https://issues.apache.org/jira/browse/MNG-6763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283700#comment-17283700
]
Michael Osipov commented on MNG-6763:
-
I believe that this can be down with {{maven-com
mthmulders commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575231766
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionDataRepository.java
##
@@ -133,22 +126,14 @@ private Properties lo
mthmulders commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575231427
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionDataRepository.java
##
@@ -133,22 +126,14 @@ private Properties lo
mthmulders commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575230619
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionAnalyzer.java
##
@@ -47,132 +41,49 @@
@Override
public O
gnodet commented on pull request #444:
URL: https://github.com/apache/maven/pull/444#issuecomment-778165900
> I like the fact that the solution becomes much simpler. Could you please
add a unit test or an [integration
test](https://github.com/apache/maven-integration-testing/) that proves
MartinKanters commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575186110
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionAnalyzer.java
##
@@ -47,132 +41,49 @@
@Override
publi
gnodet commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575184291
##
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##
@@ -1032,20 +1031,6 @@ private int execute( CliRequest cliRequest )
gnodet commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575182290
##
File path:
maven-core/src/test/java/org/apache/maven/execution/DefaultBuildResumptionDataRepositoryTest.java
##
@@ -54,38 +55,38 @@ public void
resumeFrom
gnodet commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575178829
##
File path:
maven-core/src/main/java/org/apache/maven/execution/BuildResumptionData.java
##
@@ -32,36 +29,20 @@
/**
* The project where the next
gnodet commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575178653
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionAnalyzer.java
##
@@ -47,132 +41,49 @@
@Override
public Optio
Robert Scholte created MNG-7098:
---
Summary: Project counter should be cumulative when using resume
Key: MNG-7098
URL: https://issues.apache.org/jira/browse/MNG-7098
Project: Maven
Issue Type: Im
mthmulders commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575106537
##
File path:
maven-core/src/main/java/org/apache/maven/execution/BuildResumptionData.java
##
@@ -32,36 +29,20 @@
/**
* The project where the n
57 matches
Mail list logo
