[GitHub] [maven-scm] michael-o commented on pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
michael-o commented on PR #153: URL: https://github.com/apache/maven-scm/pull/153#issuecomment-1186512316 > git executable leverages the ssh executable for authentication and therefore there is no change with regard to supported private keys formats That's not what I mean, I mean

[jira] [Updated] (MGPG-86) NullPointerException when gpg executable cannot be found

2022-07-17 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MGPG-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MGPG-86: - Fix Version/s: 3.1.0 > NullPointerException when gpg executable cannot be found >

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567629#comment-17567629 ] ASF GitHub Bot commented on SCM-945: kwin commented on PR #153: URL:

[GitHub] [maven-scm] kwin commented on pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
kwin commented on PR #153: URL: https://github.com/apache/maven-scm/pull/153#issuecomment-1186509299 git executable leverages the ssh executable for authentication and therefore there is no change with regard to supported private keys formats -- This is an automated message from the

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567628#comment-17567628 ] ASF GitHub Bot commented on SCM-945: michael-o commented on PR #153: URL:

[GitHub] [maven-scm] michael-o commented on pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
michael-o commented on PR #153: URL: https://github.com/apache/maven-scm/pull/153#issuecomment-1186508402 > Maybe split up into a) update JGit b) add credentials provider for JGit c) add IT for SSH authentication during git clone (both git providers) > > Then the environment variable

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567627#comment-17567627 ] ASF GitHub Bot commented on SCM-945: kwin commented on PR #153: URL:

[GitHub] [maven-scm] kwin commented on pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
kwin commented on PR #153: URL: https://github.com/apache/maven-scm/pull/153#issuecomment-1186505043 Maybe split up into a) update JGit b) add credentials provider for JGit c) add IT for SSH authentication during git clone (both git providers) Then the environment variable

[GitHub] [maven-scm] michael-o commented on pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
michael-o commented on PR #153: URL: https://github.com/apache/maven-scm/pull/153#issuecomment-1186494030 > > * Create three issues: (issue a) Upgrade JGit to XXX, (issue b) rework OpenSSH private key handing for gitexe and jgit providers, (issue c) Support alternative SSH private keys

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567617#comment-17567617 ] ASF GitHub Bot commented on SCM-945: michael-o commented on PR #153: URL:

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567616#comment-17567616 ] ASF GitHub Bot commented on SCM-945: michael-o commented on code in PR #153: URL:

[GitHub] [maven-scm] michael-o commented on a diff in pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
michael-o commented on code in PR #153: URL: https://github.com/apache/maven-scm/pull/153#discussion_r922820340 ##

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567615#comment-17567615 ] ASF GitHub Bot commented on SCM-945: michael-o commented on code in PR #153: URL:

[GitHub] [maven-scm] michael-o commented on a diff in pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
michael-o commented on code in PR #153: URL: https://github.com/apache/maven-scm/pull/153#discussion_r922820137 ##

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567614#comment-17567614 ] ASF GitHub Bot commented on SCM-945: michael-o commented on code in PR #153: URL:

[GitHub] [maven-scm] michael-o commented on a diff in pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
michael-o commented on code in PR #153: URL: https://github.com/apache/maven-scm/pull/153#discussion_r922819720 ## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java:

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567613#comment-17567613 ] ASF GitHub Bot commented on SCM-945: kwin commented on PR #153: URL:

[GitHub] [maven-scm] kwin commented on pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
kwin commented on PR #153: URL: https://github.com/apache/maven-scm/pull/153#issuecomment-1186492662 > * Create three issues: (issue a) Upgrade JGit to XXX, (issue b) rework OpenSSH private key handing for gitexe and jgit providers, (issue c) Support alternative SSH private keys with

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567611#comment-17567611 ] ASF GitHub Bot commented on SCM-945: kwin commented on code in PR #153: URL:

[GitHub] [maven-scm] kwin commented on a diff in pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
kwin commented on code in PR #153: URL: https://github.com/apache/maven-scm/pull/153#discussion_r922819277 ## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java: ## @@ -54,6 +58,12 @@

[jira] [Commented] (SCM-929) Release plugin does not work with central repository and always performs clone operation

2022-07-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567609#comment-17567609 ] Michael Osipov commented on SCM-929: [~infestator], do you want to pursue this? > Release plugin does

[jira] [Commented] (SCM-833) getLastChangedRevision() returns null whereas as getRevision() get correct versions

2022-07-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567607#comment-17567607 ] Michael Osipov commented on SCM-833: [~khmarbaise], do you want to pursue this? >

[jira] [Updated] (SCM-833) getLastChangedRevision() returns null whereas as getRevision() get correct versions

2022-07-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SCM-833: --- Fix Version/s: waiting-for-feedback > getLastChangedRevision() returns null whereas as getRevision()

[jira] [Updated] (SCM-929) Release plugin does not work with central repository and always performs clone operation

2022-07-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SCM-929: --- Fix Version/s: waiting-for-feedback > Release plugin does not work with central repository and always

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567608#comment-17567608 ] ASF GitHub Bot commented on SCM-945: kwin commented on code in PR #153: URL:

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567610#comment-17567610 ] ASF GitHub Bot commented on SCM-945: kwin commented on code in PR #153: URL:

[GitHub] [maven-scm] kwin commented on a diff in pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
kwin commented on code in PR #153: URL: https://github.com/apache/maven-scm/pull/153#discussion_r922819246 ## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/PlexusInteractivityCredentialsProvider.java:

[GitHub] [maven-scm] kwin commented on a diff in pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
kwin commented on code in PR #153: URL: https://github.com/apache/maven-scm/pull/153#discussion_r922819148 ## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java: ##

[jira] [Commented] (SCM-924) Enhance SCM changelog model to hold information about tagged commits

2022-07-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567606#comment-17567606 ] Michael Osipov commented on SCM-924: Is this still an issue with upcoming 2.0.0-M2? > Enhance SCM

[jira] [Updated] (SCM-924) Enhance SCM changelog model to hold information about tagged commits

2022-07-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SCM-924: --- Fix Version/s: waiting-for-feedback > Enhance SCM changelog model to hold information about tagged

[jira] [Commented] (SCM-914) InfoItem.lastChangedDate is leaky abstraction

2022-07-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567605#comment-17567605 ] Michael Osipov commented on SCM-914: Still interested in pursuing this? > InfoItem.lastChangedDate is

[GitHub] [maven-common-artifact-filters] michael-o commented on a diff in pull request #29: [MSHARED-1104] Four element pattern may be GATV or GATC

2022-07-17 Thread GitBox
michael-o commented on code in PR #29: URL: https://github.com/apache/maven-common-artifact-filters/pull/29#discussion_r922818348 ## src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java: ## @@ -481,15 +475,22 @@ else if ( ANY.equals(

[jira] [Assigned] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned SCM-945: -- Assignee: Michael Osipov > Support OpenSSH private keys with maven-scm-provider-jgit >

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567601#comment-17567601 ] ASF GitHub Bot commented on SCM-945: michael-o commented on PR #153: URL:

[GitHub] [maven-scm] michael-o commented on pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
michael-o commented on PR #153: URL: https://github.com/apache/maven-scm/pull/153#issuecomment-1186476412 Since the title of this PR is different to the JIRA issue, I have the following understanding: * It is hard to split apart to due to inter-PR dependencies * You need to upgrade

[jira] [Commented] (SCM-945) Support OpenSSH private keys with maven-scm-provider-jgit

2022-07-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567598#comment-17567598 ] ASF GitHub Bot commented on SCM-945: michael-o commented on code in PR #153: URL:

[GitHub] [maven-scm] michael-o commented on a diff in pull request #153: [SCM-945] Update to JGit 5.13.1 leveraging Apache Mina SSHD

2022-07-17 Thread GitBox
michael-o commented on code in PR #153: URL: https://github.com/apache/maven-scm/pull/153#discussion_r922809389 ## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java:

<    1   2