[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #110: Bump assertj-core from 3.21.0 to 3.23.1

2023-01-05 Thread GitBox
dependabot[bot] commented on PR #110: URL: https://github.com/apache/maven-jlink-plugin/pull/110#issuecomment-1373114537 Superseded by #130. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #110: Bump assertj-core from 3.21.0 to 3.23.1

2023-01-05 Thread GitBox
dependabot[bot] closed pull request #110: Bump assertj-core from 3.21.0 to 3.23.1 URL: https://github.com/apache/maven-jlink-plugin/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request, #130: Bump assertj-core from 3.21.0 to 3.24.0

2023-01-05 Thread GitBox
dependabot[bot] opened a new pull request, #130: URL: https://github.com/apache/maven-jlink-plugin/pull/130 Bumps assertj-core from 3.21.0 to 3.24.0. [![Dependabot compatibility

[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #164: Bump assertj-core from 3.23.1 to 3.24.0

2023-01-05 Thread GitBox
dependabot[bot] opened a new pull request, #164: URL: https://github.com/apache/maven-invoker-plugin/pull/164 Bumps assertj-core from 3.23.1 to 3.24.0. [![Dependabot compatibility

[GitHub] [maven-dependency-analyzer] dependabot[bot] opened a new pull request, #76: Bump assertj-core from 3.23.1 to 3.24.0

2023-01-05 Thread GitBox
dependabot[bot] opened a new pull request, #76: URL: https://github.com/apache/maven-dependency-analyzer/pull/76 Bumps assertj-core from 3.23.1 to 3.24.0. [![Dependabot compatibility

[GitHub] [maven-mvnd] alexandru-prigoreanu commented on issue #710: Too many open files on Mac OS with JDK 11 and mvnd 0.8.2

2023-01-05 Thread GitBox
alexandru-prigoreanu commented on issue #710: URL: https://github.com/apache/maven-mvnd/issues/710#issuecomment-1372746765 hello @ppalaga ! thank you for looking into this. it is `-XX:+MaxFDLimit` with `-`. have a look at

[jira] [Updated] (MWRAPPER-89) Update maven-parent to v39

2023-01-05 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MWRAPPER-89: - Fix Version/s: 3.2.0 > Update maven-parent to v39 > -- > >

[jira] [Resolved] (MWRAPPER-89) Update maven-parent to v39

2023-01-05 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MWRAPPER-89. -- Resolution: Fixed > Update maven-parent to v39 > -- > >

[jira] [Commented] (MNG-7664) consolidate Velocity templates used to generate code from models

2023-01-05 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655132#comment-17655132 ] Herve Boutemy commented on MNG-7664: [~gnodet] is there a reason to have different content, or is it

[jira] [Created] (MNG-7664) consolidate Velocity templates used to generate code from models

2023-01-05 Thread Herve Boutemy (Jira)
Herve Boutemy created MNG-7664: -- Summary: consolidate Velocity templates used to generate code from models Key: MNG-7664 URL: https://issues.apache.org/jira/browse/MNG-7664 Project: Maven

[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655129#comment-17655129 ] ASF GitHub Bot commented on MWRAPPER-89: bmarwell merged PR #81: URL:

[GitHub] [maven-wrapper] bmarwell merged pull request #81: [MWRAPPER-89] update to maven-parent v39; spotless code style;

2023-01-05 Thread GitBox
bmarwell merged PR #81: URL: https://github.com/apache/maven-wrapper/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-integration-testing] psiroky opened a new pull request, #225: [MNG-7661] Replace deprecated 'verifier.executeGoal()'

2023-01-05 Thread GitBox
psiroky opened a new pull request, #225: URL: https://github.com/apache/maven-integration-testing/pull/225 Another PR in the series, replacing the deprecated method `executeGoal()` with `addCliArgumenet(

[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655106#comment-17655106 ] ASF GitHub Bot commented on MWRAPPER-89: bmarwell commented on code in PR #81: URL:

[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #81: [MWRAPPER-89] update to maven-parent v39; spotless code style;

2023-01-05 Thread GitBox
bmarwell commented on code in PR #81: URL: https://github.com/apache/maven-wrapper/pull/81#discussion_r1062817962 ## maven-wrapper/src/main/java/org/apache/maven/wrapper/DefaultDownloader.java: ## @@ -1,3 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (MWRAPPER-88) mvnw is not POSIX compatible

2023-01-05 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MWRAPPER-88: - Description: * POSIX scripts should not use bash-specific features * Fix suggestions

[jira] [Assigned] (MRESOLVER-313) Artifact file permissions are 0600 and not implicitly set by umask

2023-01-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-313: - Assignee: Tamas Cservenak > Artifact file permissions are 0600 and not

[GitHub] [maven-enforcer] dependabot[bot] commented on pull request #217: Bump slf4j-api from 1.7.36 to 2.0.6

2023-01-05 Thread GitBox
dependabot[bot] commented on PR #217: URL: https://github.com/apache/maven-enforcer/pull/217#issuecomment-1372592113 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [maven-enforcer] slawekjaranowski closed pull request #217: Bump slf4j-api from 1.7.36 to 2.0.6

2023-01-05 Thread GitBox
slawekjaranowski closed pull request #217: Bump slf4j-api from 1.7.36 to 2.0.6 URL: https://github.com/apache/maven-enforcer/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #224: [MNG-7661] Remove deprecated 'verifier.resetStreams()'

2023-01-05 Thread GitBox
slawekjaranowski merged PR #224: URL: https://github.com/apache/maven-integration-testing/pull/224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MRESOLVER-313) Artifact file permissions are 0600 and not implicitly set by umask

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655088#comment-17655088 ] ASF GitHub Bot commented on MRESOLVER-313: -- cstamas opened a new pull request, #234: URL:

[GitHub] [maven-resolver] cstamas opened a new pull request, #234: [MRESOLVER-313] Wrong FS permissions on installed artifacts.

2023-01-05 Thread GitBox
cstamas opened a new pull request, #234: URL: https://github.com/apache/maven-resolver/pull/234 Collocated temp file should NOT use Files.createTempFile as it uses 0600 perms and not relies implicitly on umask. --- https://issues.apache.org/jira/browse/MRESOLVER-313 -- This

[jira] [Created] (MRESOLVER-313) Artifact file permissions are 0600 and not implicitly set by umask

2023-01-05 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-313: - Summary: Artifact file permissions are 0600 and not implicitly set by umask Key: MRESOLVER-313 URL: https://issues.apache.org/jira/browse/MRESOLVER-313

[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655086#comment-17655086 ] ASF GitHub Bot commented on MWRAPPER-89: slawekjaranowski commented on code in PR #81: URL:

[GitHub] [maven-wrapper] slawekjaranowski commented on a diff in pull request #81: [MWRAPPER-89] update to maven-parent v39; spotless code style;

2023-01-05 Thread GitBox
slawekjaranowski commented on code in PR #81: URL: https://github.com/apache/maven-wrapper/pull/81#discussion_r1062764007 ## maven-wrapper/src/main/java/org/apache/maven/wrapper/DefaultDownloader.java: ## @@ -1,3 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655084#comment-17655084 ] ASF GitHub Bot commented on MWRAPPER-88: bmarwell commented on PR #79: URL:

[GitHub] [maven-wrapper] bmarwell commented on pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity

2023-01-05 Thread GitBox
bmarwell commented on PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#issuecomment-1372564795 Needs a slight revert: https://stackoverflow.com/a/53116875/1549977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (MNG-7642) 4.0.0-alpha 3 not compatible with flatten plugin

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655065#comment-17655065 ] ASF GitHub Bot commented on MNG-7642: - michael-o commented on code in PR #947: URL:

[GitHub] [maven] michael-o commented on a diff in pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

2023-01-05 Thread GitBox
michael-o commented on code in PR #947: URL: https://github.com/apache/maven/pull/947#discussion_r1062712956 ## maven-model-builder/src/main/java/org/apache/maven/model/plugin/DefaultReportingConverter.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (MNG-7661) Fix IT build / compiler warnings

2023-01-05 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petr Široký updated MNG-7661: - Description: I noticed there is a quite a few build (from Maven) and also compiler warnings (e.g. using

[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request, #217: Bump slf4j-api from 1.7.36 to 2.0.6

2023-01-05 Thread GitBox
dependabot[bot] opened a new pull request, #217: URL: https://github.com/apache/maven-enforcer/pull/217 Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.36 to 2.0.6. Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818;>5ff6f2c

[jira] [Commented] (MCHECKSTYLE-421) Audit events should use Maven logging

2023-01-05 Thread Delany (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654991#comment-17654991 ] Delany commented on MCHECKSTYLE-421: Actually I don't agree - the authors of this plugin know

[jira] [Commented] (MNG-7662) Allow Graphbuilder to use session scoped components

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654988#comment-17654988 ] ASF GitHub Bot commented on MNG-7662: - laeubi commented on PR #948: URL:

[GitHub] [maven] laeubi commented on pull request #948: MNG-7662 - Allow Graphbuilder to use session scoped components

2023-01-05 Thread GitBox
laeubi commented on PR #948: URL: https://github.com/apache/maven/pull/948#issuecomment-1372300641 > Also, there is an existing workaround which I think I've used somewhere, but I can't recall where exactly. This seems simlar to my aproach here, jsut that I more liek to fix it in

[jira] [Commented] (MNG-7662) Allow Graphbuilder to use session scoped components

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654973#comment-17654973 ] ASF GitHub Bot commented on MNG-7662: - gnodet commented on PR #948: URL:

[GitHub] [maven] gnodet commented on pull request #948: MNG-7662 - Allow Graphbuilder to use session scoped components

2023-01-05 Thread GitBox
gnodet commented on PR #948: URL: https://github.com/apache/maven/pull/948#issuecomment-1372252880 Also, there is an existing workaround which I think I've used somewhere, but I can't recall where exactly. The idea is to define two beans: ``` @Named @Singleton class

[GitHub] [maven-mvnd] oehme commented on pull request #764: Fix core export provider

2023-01-05 Thread GitBox
oehme commented on PR #764: URL: https://github.com/apache/maven-mvnd/pull/764#issuecomment-1372212690 The underlying reason why the default logic doesn't work is because the [discovery

[GitHub] [maven-mvnd] oehme opened a new pull request, #764: Fix core export provider

2023-01-05 Thread GitBox
oehme opened a new pull request, #764: URL: https://github.com/apache/maven-mvnd/pull/764 Since https://github.com/apache/maven/pull/616, the default CoreExportProvider no longer uses the provided CoreExports, but instead tries (and fails) to discover them itself. This change fixes

[jira] [Commented] (MRESOLVER-289) Remove "Aether wiki" link from site

2023-01-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654946#comment-17654946 ] Tamas Cservenak commented on MRESOLVER-289: --- Yes, but Eclipse wiki will be gone once (as

[jira] [Updated] (MRESOLVER-298) javax.inject should not be provided or optional

2023-01-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-298: -- Fix Version/s: 1.10.0 > javax.inject should not be provided or optional >

[jira] [Updated] (MRESOLVER-311) Upgrade Parent to 39

2023-01-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-311: -- Fix Version/s: 1.10.0 > Upgrade Parent to 39 > > >

[jira] [Updated] (MRESOLVER-304) DirectoryUtils should consider interpolation

2023-01-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-304: -- Fix Version/s: 1.10.0 > DirectoryUtils should consider interpolation >

[GitHub] [maven-mvnd] ppalaga closed issue #763: how to use it in idea?

2023-01-05 Thread GitBox
ppalaga closed issue #763: how to use it in idea? URL: https://github.com/apache/maven-mvnd/issues/763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-mvnd] ppalaga commented on issue #763: how to use it in idea?

2023-01-05 Thread GitBox
ppalaga commented on issue #763: URL: https://github.com/apache/maven-mvnd/issues/763#issuecomment-1372140007 See https://youtrack.jetbrains.com/issue/IDEA-264396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654937#comment-17654937 ] ASF GitHub Bot commented on MWRAPPER-89: bmarwell commented on PR #81: URL:

[GitHub] [maven-wrapper] bmarwell commented on pull request #81: [MWRAPPER-89] update to maven-parent v39; spotless code style;

2023-01-05 Thread GitBox
bmarwell commented on PR #81: URL: https://github.com/apache/maven-wrapper/pull/81#issuecomment-1372137154 > Please create two commits - one with upgrade and one with refactor Second commit with refactor can be added to excluded from git blame > >

[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-05 Thread GitBox
timtebeek commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062399837 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java: ## @@ -31,23 +31,23 @@ import java.util.Map; import

[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654934#comment-17654934 ] ASF GitHub Bot commented on MWRAPPER-89: slawekjaranowski commented on PR #81: URL:

[GitHub] [maven-wrapper] slawekjaranowski commented on pull request #81: [MWRAPPER-89] update to maven-parent v39; spotless code style;

2023-01-05 Thread GitBox
slawekjaranowski commented on PR #81: URL: https://github.com/apache/maven-wrapper/pull/81#issuecomment-1372125545 Please create two commits - one with upgrade and one with refactor Second commit with refactor can be added to excluded from git blame

[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-05 Thread GitBox
bmarwell commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062397142 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java: ## @@ -31,23 +31,23 @@ import java.util.Map; import

[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-05 Thread GitBox
timtebeek commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062395101 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java: ## @@ -31,23 +31,23 @@ import java.util.Map; import

[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-05 Thread GitBox
bmarwell commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062387739 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java: ## @@ -31,23 +31,23 @@ import java.util.Map; import

[jira] [Commented] (MWRAPPER-89) Update maven-parent to v39

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654927#comment-17654927 ] ASF GitHub Bot commented on MWRAPPER-89: bmarwell opened a new pull request, #81: URL:

[GitHub] [maven-wrapper] bmarwell opened a new pull request, #81: [MWRAPPER-89] update to maven-parent v39; spotless code style;

2023-01-05 Thread GitBox
bmarwell opened a new pull request, #81: URL: https://github.com/apache/maven-wrapper/pull/81 We need (should use) v38+ for this PR: https://github.com/apache/maven-wrapper/pull/61 However, v39 requires the new style to be applied. --- Following this checklist to help

[jira] [Created] (MWRAPPER-89) Update maven-parent to v39

2023-01-05 Thread Benjamin Marwell (Jira)
Benjamin Marwell created MWRAPPER-89: Summary: Update maven-parent to v39 Key: MWRAPPER-89 URL: https://issues.apache.org/jira/browse/MWRAPPER-89 Project: Maven Wrapper Issue Type:

[jira] [Commented] (MWRAPPER-81) mvnw does not remove return chars from jvm.config

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654923#comment-17654923 ] ASF GitHub Bot commented on MWRAPPER-81: bmarwell commented on code in PR #67: URL:

[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #67: [MWRAPPER-81] mvnw does not remove return chars from jvm.config

2023-01-05 Thread GitBox
bmarwell commented on code in PR #67: URL: https://github.com/apache/maven-wrapper/pull/67#discussion_r1062378797 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -160,7 +160,7 @@ find_maven_basedir() { # concatenates all lines of a file concat_lines() { if [ -f

[jira] [Commented] (MWRAPPER-33) Use java 8 in maven-wrapper

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654912#comment-17654912 ] ASF GitHub Bot commented on MWRAPPER-33: timtebeek commented on PR #80: URL:

[GitHub] [maven-wrapper] timtebeek commented on pull request #80: [MWRAPPER-33] Adopt Java 8 constructs

2023-01-05 Thread GitBox
timtebeek commented on PR #80: URL: https://github.com/apache/maven-wrapper/pull/80#issuecomment-1372066485 And a small note perhaps that [the recent shellcheck step](https://github.com/apache/maven-wrapper/commit/ccaa27d6e7db433e6c3e71b3a74985d28bbfcf03) also runs (and fails) on forks, so

[GitHub] [maven-wrapper] timtebeek opened a new pull request, #80: [MWRAPPER-33] Adopt Java 8 constructs

2023-01-05 Thread GitBox
timtebeek opened a new pull request, #80: URL: https://github.com/apache/maven-wrapper/pull/80 Java 8 brought some possible code improvements over the previous Java 7. These have been applied through: ``` mvn org.openrewrite.maven:rewrite-maven-plugin:4.38.2:run

[jira] [Commented] (MWRAPPER-33) Use java 8 in maven-wrapper

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654911#comment-17654911 ] ASF GitHub Bot commented on MWRAPPER-33: timtebeek opened a new pull request, #80: URL:

[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654907#comment-17654907 ] ASF GitHub Bot commented on MWRAPPER-88: michael-o commented on PR #79: URL:

[GitHub] [maven-wrapper] michael-o commented on pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity

2023-01-05 Thread GitBox
michael-o commented on PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#issuecomment-1372039127 Put this into consideration: https://issues.apache.org/jira/browse/MWRAPPER-45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible

2023-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654906#comment-17654906 ] ASF GitHub Bot commented on MWRAPPER-88: bmarwell commented on code in PR #79: URL:

[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity

2023-01-05 Thread GitBox
bmarwell commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1062317792 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -71,38 +71,38 @@ esac if [ -z "$JAVA_HOME" ] ; then if [ -r /etc/gentoo-release ] ; then -

[GitHub] [maven-wrapper] bmarwell merged pull request #74: [BUILD] add shellcheck

2023-01-05 Thread GitBox
bmarwell merged PR #74: URL: https://github.com/apache/maven-wrapper/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-wrapper] bmarwell opened a new pull request, #79: Mwrapper 88 posix

2023-01-05 Thread GitBox
bmarwell opened a new pull request, #79: URL: https://github.com/apache/maven-wrapper/pull/79 Fix shellcheck warnings --- Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA

[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #74: [BUILD] add shellcheck

2023-01-05 Thread GitBox
bmarwell commented on code in PR #74: URL: https://github.com/apache/maven-wrapper/pull/74#discussion_r1062272774 ## .github/workflows/shellcheck-posix.yml: ## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [maven-wrapper] pzygielo commented on a diff in pull request #74: [BUILD] add shellcheck

2023-01-05 Thread GitBox
pzygielo commented on code in PR #74: URL: https://github.com/apache/maven-wrapper/pull/74#discussion_r1062266573 ## .github/workflows/shellcheck-posix.yml: ## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [maven-wrapper] pzygielo commented on a diff in pull request #74: [BUILD] add shellcheck

2023-01-05 Thread GitBox
pzygielo commented on code in PR #74: URL: https://github.com/apache/maven-wrapper/pull/74#discussion_r1062266573 ## .github/workflows/shellcheck-posix.yml: ## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [maven-wrapper] bmarwell merged pull request #78: [GitHub] enable autolink references

2023-01-05 Thread GitBox
bmarwell merged PR #78: URL: https://github.com/apache/maven-wrapper/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-wrapper] bmarwell opened a new pull request, #78: [GitHub] enable autolink references

2023-01-05 Thread GitBox
bmarwell opened a new pull request, #78: URL: https://github.com/apache/maven-wrapper/pull/78 Enables links to JIRA --- Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[jira] [Created] (MWRAPPER-88) mvnw is not POSIX compatible

2023-01-05 Thread Benjamin Marwell (Jira)
Benjamin Marwell created MWRAPPER-88: Summary: mvnw is not POSIX compatible Key: MWRAPPER-88 URL: https://issues.apache.org/jira/browse/MWRAPPER-88 Project: Maven Wrapper Issue Type: Bug

[GitHub] [maven-wrapper] bmarwell commented on pull request #74: [BUILD] add shellcheck

2023-01-05 Thread GitBox
bmarwell commented on PR #74: URL: https://github.com/apache/maven-wrapper/pull/74#issuecomment-1371954691 Will add another PR which fixes the failed checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (MRESOLVER-312) Raise build required Java to 11, target remains 8

2023-01-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654850#comment-17654850 ] Michael Osipov commented on MRESOLVER-312: -- I would recommend to first complete 1.9.3 which