Re: [PR] Change bootstrap syntax to align with the usual one [maven-integration-testing]

2023-11-25 Thread via GitHub
gnodet merged PR #316: URL: https://github.com/apache/maven-integration-testing/pull/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNG-7945) Fix profile settings being injected into consumer POMs

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789763#comment-17789763 ] ASF GitHub Bot commented on MNG-7945: - gnodet commented on code in PR #1323: URL:

Re: [PR] [MNG-7945] Fix profile settings being injected into consumer POM [maven]

2023-11-25 Thread via GitHub
gnodet commented on code in PR #1323: URL: https://github.com/apache/maven/pull/1323#discussion_r1405329274 ## maven-core/src/main/java/org/apache/maven/internal/transformation/DefaultConsumerPomBuilder.java: ## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (MNG-7945) Fix profile settings being injected into consumer POMs

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789762#comment-17789762 ] ASF GitHub Bot commented on MNG-7945: - gnodet commented on code in PR #1323: URL:

Re: [PR] [MNG-7945] Fix profile settings being injected into consumer POM [maven]

2023-11-25 Thread via GitHub
gnodet commented on code in PR #1323: URL: https://github.com/apache/maven/pull/1323#discussion_r1405327196 ## maven-core/src/test/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformerTest.java: ## @@ -60,9 +56,15 @@ void transform() throws Exception {

[jira] [Commented] (MNG-7945) Fix profile settings being injected into consumer POMs

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789757#comment-17789757 ] ASF GitHub Bot commented on MNG-7945: - gnodet commented on code in PR #1323: URL:

Re: [PR] [MNG-7945] Fix profile settings being injected into consumer POM [maven]

2023-11-25 Thread via GitHub
gnodet commented on code in PR #1323: URL: https://github.com/apache/maven/pull/1323#discussion_r1405327196 ## maven-core/src/test/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformerTest.java: ## @@ -60,9 +56,15 @@ void transform() throws Exception {

[jira] [Closed] (MJAVADOC-781) Upgrade plugins and components (in ITs)

2023-11-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MJAVADOC-781. --- Resolution: Fixed Fixed with

[jira] [Commented] (MJAVADOC-781) Upgrade plugins and components (in ITs)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789741#comment-17789741 ] ASF GitHub Bot commented on MJAVADOC-781: - asfgit closed pull request #250: [MJAVADOC-781]

Re: [PR] [MJAVADOC-781] Upgrade plugins and components (in ITs) [maven-javadoc-plugin]

2023-11-25 Thread via GitHub
asfgit closed pull request #250: [MJAVADOC-781] Upgrade plugins and components (in ITs) URL: https://github.com/apache/maven-javadoc-plugin/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (MNG-7943) Upgrade default plugin bindings

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789739#comment-17789739 ] ASF GitHub Bot commented on MNG-7943: - slawekjaranowski opened a new pull request, #1327: URL:

[PR] [MNG-7943] Upgrade default plugin bindings [maven]

2023-11-25 Thread via GitHub
slawekjaranowski opened a new pull request, #1327: URL: https://github.com/apache/maven/pull/1327 - surefire from 3.1.2 to 3.2.2 - dependency from 3.6.0 to 3.6.1 --- Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make

[jira] [Updated] (MJAVADOC-781) Upgrade plugins and components (in ITs)

2023-11-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MJAVADOC-781: Description: * Upgrade to Maven Compiler Plugin 3.11.0 * Upgrade to Maven Source Plugin

Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.8.0 to 4.9.0 [maven-javadoc-plugin]

2023-11-25 Thread via GitHub
michael-o commented on PR #248: URL: https://github.com/apache/maven-javadoc-plugin/pull/248#issuecomment-1826434761 Superseded by #250. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.8.0 to 4.9.0 [maven-javadoc-plugin]

2023-11-25 Thread via GitHub
dependabot[bot] commented on PR #248: URL: https://github.com/apache/maven-javadoc-plugin/pull/248#issuecomment-1826434767 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.8.0 to 4.9.0 [maven-javadoc-plugin]

2023-11-25 Thread via GitHub
michael-o closed pull request #248: Bump org.codehaus.plexus:plexus-archiver from 4.8.0 to 4.9.0 URL: https://github.com/apache/maven-javadoc-plugin/pull/248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (MJAVADOC-781) Upgrade plugins and components (in ITs)

2023-11-25 Thread Michael Osipov (Jira)
Michael Osipov created MJAVADOC-781: --- Summary: Upgrade plugins and components (in ITs) Key: MJAVADOC-781 URL: https://issues.apache.org/jira/browse/MJAVADOC-781 Project: Maven Javadoc Plugin

[PR] update deps [maven-javadoc-plugin]

2023-11-25 Thread via GitHub
michael-o opened a new pull request, #250: URL: https://github.com/apache/maven-javadoc-plugin/pull/250 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC)

[jira] [Closed] (MNG-7934) Upgrade Resolver version to 1.9.18

2023-11-25 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-7934. Resolution: Fixed > Upgrade Resolver version to 1.9.18 > -- > >

[jira] [Commented] (MNG-7934) Upgrade Resolver version to 1.9.18

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789734#comment-17789734 ] ASF GitHub Bot commented on MNG-7934: - cstamas merged PR #1326: URL:

Re: [PR] [MNG-7934] Update to Resolver 1.9.18 [maven]

2023-11-25 Thread via GitHub
cstamas merged PR #1326: URL: https://github.com/apache/maven/pull/1326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SUREFIRE-2216) Upgrade plugins and components (in ITs)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789732#comment-17789732 ] ASF GitHub Bot commented on SUREFIRE-2216: -- asfgit closed pull request #690: [SUREFIRE-2216]

[jira] [Closed] (SUREFIRE-2216) Upgrade plugins and components (in ITs)

2023-11-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed SUREFIRE-2216. Resolution: Fixed Fixed with

Re: [PR] [SUREFIRE-2216] Upgrade plugins and components (in ITs) [maven-surefire]

2023-11-25 Thread via GitHub
asfgit closed pull request #690: [SUREFIRE-2216] Upgrade plugins and components (in ITs) URL: https://github.com/apache/maven-surefire/pull/690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (MNG-7934) Upgrade Resolver version to 1.9.18

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789731#comment-17789731 ] ASF GitHub Bot commented on MNG-7934: - cstamas opened a new pull request, #1326: URL:

[jira] [Updated] (MNG-7943) Upgrade default plugin bindings

2023-11-25 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MNG-7943: - Description: - surefire from 3.1.2 to 3.2.2 - dependency from 3.6.0 to 3.6.1 > Upgrade

[jira] [Closed] (MASSEMBLY-1010) Use IOUtils from commons-io instead of plexus

2023-11-25 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MASSEMBLY-1010. -- Resolution: Fixed > Use IOUtils from commons-io instead of plexus >

[jira] [Commented] (MASSEMBLY-1010) Use IOUtils from commons-io instead of plexus

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789720#comment-17789720 ] ASF GitHub Bot commented on MASSEMBLY-1010: --- slawekjaranowski merged PR #168: URL:

Re: [PR] [MASSEMBLY-1010] Use IOUtils from commons-io instead of plexus [maven-assembly-plugin]

2023-11-25 Thread via GitHub
slawekjaranowski merged PR #168: URL: https://github.com/apache/maven-assembly-plugin/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (MNG-7943) Upgrade default plugin bindings

2023-11-25 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MNG-7943: Assignee: Slawomir Jaranowski > Upgrade default plugin bindings >

[jira] [Commented] (MASSEMBLY-1010) Use IOUtils from commons-io instead of plexus

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789711#comment-17789711 ] ASF GitHub Bot commented on MASSEMBLY-1010: --- slawekjaranowski opened a new pull request,

[PR] [MASSEMBLY-1010] Use IOUtils from commons-io instead of plexus [maven-assembly-plugin]

2023-11-25 Thread via GitHub
slawekjaranowski opened a new pull request, #168: URL: https://github.com/apache/maven-assembly-plugin/pull/168 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA

[jira] [Created] (MASSEMBLY-1010) Use IOUtils from commons-io instead of plexus

2023-11-25 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MASSEMBLY-1010: -- Summary: Use IOUtils from commons-io instead of plexus Key: MASSEMBLY-1010 URL: https://issues.apache.org/jira/browse/MASSEMBLY-1010 Project:

[jira] [Updated] (MASSEMBLY-992) Facility to define assembly descriptor in body of POM

2023-11-25 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MASSEMBLY-992: -- Fix Version/s: next-release (was:

[jira] [Assigned] (MASSEMBLY-992) Facility to define assembly descriptor in body of POM

2023-11-25 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MASSEMBLY-992: - Assignee: Slawomir Jaranowski > Facility to define assembly

[jira] [Closed] (MASSEMBLY-1009) Bump commons-io from 2.13.0 to 2.15.0

2023-11-25 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MASSEMBLY-1009. -- Resolution: Fixed > Bump commons-io from 2.13.0 to 2.15.0 >

[jira] [Commented] (MASSEMBLY-1009) Bump commons-io from 2.13.0 to 2.15.0

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789704#comment-17789704 ] ASF GitHub Bot commented on MASSEMBLY-1009: --- slawekjaranowski merged PR #167: URL:

Re: [PR] [MASSEMBLY-1009] Bump commons-io from 2.13.0 to 2.15.0 [maven-assembly-plugin]

2023-11-25 Thread via GitHub
slawekjaranowski merged PR #167: URL: https://github.com/apache/maven-assembly-plugin/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MASSEMBLY-1009) Bump commons-io from 2.13.0 to 2.15.0

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789696#comment-17789696 ] ASF GitHub Bot commented on MASSEMBLY-1009: --- slawekjaranowski opened a new pull request,

[PR] [MASSEMBLY-1009] Bump commons-io from 2.13.0 to 2.15.0 [maven-assembly-plugin]

2023-11-25 Thread via GitHub
slawekjaranowski opened a new pull request, #167: URL: https://github.com/apache/maven-assembly-plugin/pull/167 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA

[jira] [Created] (MASSEMBLY-1009) Bump commons-io from 2.13.0 to 2.15.0

2023-11-25 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MASSEMBLY-1009: -- Summary: Bump commons-io from 2.13.0 to 2.15.0 Key: MASSEMBLY-1009 URL: https://issues.apache.org/jira/browse/MASSEMBLY-1009 Project: Maven

[jira] [Commented] (MNG-7945) Fix profile settings being injected into consumer POMs

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789682#comment-17789682 ] ASF GitHub Bot commented on MNG-7945: - elharo commented on code in PR #1323: URL:

Re: [PR] [MNG-7945] Fix profile settings being injected into consumer POM [maven]

2023-11-25 Thread via GitHub
elharo commented on code in PR #1323: URL: https://github.com/apache/maven/pull/1323#discussion_r1405140221 ## maven-core/src/main/java/org/apache/maven/internal/transformation/DefaultConsumerPomBuilder.java: ## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software

Re: [PR] Create dependabot.yml [maven-site]

2023-11-25 Thread via GitHub
1MaviS commented on PR #468: URL: https://github.com/apache/maven-site/pull/468#issuecomment-1826356372 teşekkür ederim saplasın  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (MASSEMBLY-992) Facility to define assembly descriptor in body of POM

2023-11-25 Thread Wojtek (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789681#comment-17789681 ] Wojtek commented on MASSEMBLY-992: -- I concur that allowing inlining configuration of assembly

Re: [PR] Create dependabot.yml [maven-site]

2023-11-25 Thread via GitHub
1MaviS commented on PR #468: URL: https://github.com/apache/maven-site/pull/468#issuecomment-1826352665 acemilik :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Create dependabot.yml [maven-site]

2023-11-25 Thread via GitHub
1MaviS closed pull request #468: Create dependabot.yml URL: https://github.com/apache/maven-site/pull/468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (MASSEMBLY-903) Allow defining descriptors within pom.xml

2023-11-25 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MASSEMBLY-903: -- Fix Version/s: (was: waiting-for-feedback) > Allow defining descriptors

[jira] [Commented] (MASSEMBLY-903) Allow defining descriptors within pom.xml

2023-11-25 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789678#comment-17789678 ] Slawomir Jaranowski commented on MASSEMBLY-903: --- As we have more discussion in

[jira] [Closed] (MASSEMBLY-903) Allow defining descriptors within pom.xml

2023-11-25 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MASSEMBLY-903. - Resolution: Duplicate > Allow defining descriptors within pom.xml >

[jira] [Commented] (MASSEMBLY-803) Add file name mapping option when extracting dependencies

2023-11-25 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789677#comment-17789677 ] Slawomir Jaranowski commented on MASSEMBLY-803: --- There is a

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789667#comment-17789667 ] ASF GitHub Bot commented on MCOMPILER-381: -- jorsol commented on code in PR #181: URL:

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
jorsol commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404882575 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1577,31 +1589,35 @@ protected boolean isDependencyChanged() { }

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789666#comment-17789666 ] ASF GitHub Bot commented on MCOMPILER-381: -- jorsol commented on code in PR #181: URL:

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
jorsol commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404881234 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1577,31 +1589,35 @@ protected boolean isDependencyChanged() { }

[jira] [Commented] (SUREFIRE-2216) Upgrade plugins and components (in ITs)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789662#comment-17789662 ] ASF GitHub Bot commented on SUREFIRE-2216: -- michael-o commented on code in PR #690: URL:

Re: [PR] [SUREFIRE-2216] Upgrade plugins and components (in ITs) [maven-surefire]

2023-11-25 Thread via GitHub
michael-o commented on code in PR #690: URL: https://github.com/apache/maven-surefire/pull/690#discussion_r1404865812 ## pom.xml: ## @@ -306,17 +308,13 @@ runtime + org.junit junit-bom 5.9.3 pom

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789661#comment-17789661 ] ASF GitHub Bot commented on MCOMPILER-381: -- olamy commented on code in PR #181: URL:

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
olamy commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404865372 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1577,31 +1589,35 @@ protected boolean isDependencyChanged() { }

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789660#comment-17789660 ] ASF GitHub Bot commented on MCOMPILER-381: -- olamy commented on code in PR #181: URL:

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
olamy commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404864669 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1156,6 +1151,16 @@ public void execute() throws MojoExecutionException,

[jira] [Commented] (SUREFIRE-2216) Upgrade plugins and components (in ITs)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789659#comment-17789659 ] ASF GitHub Bot commented on SUREFIRE-2216: -- slawekjaranowski commented on code in PR #690:

Re: [PR] [SUREFIRE-2216] Upgrade plugins and components (in ITs) [maven-surefire]

2023-11-25 Thread via GitHub
slawekjaranowski commented on code in PR #690: URL: https://github.com/apache/maven-surefire/pull/690#discussion_r1404861469 ## pom.xml: ## @@ -306,17 +308,13 @@ runtime + org.junit junit-bom 5.9.3 pom

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789657#comment-17789657 ] ASF GitHub Bot commented on MCOMPILER-381: -- jorsol commented on code in PR #181: URL:

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
jorsol commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404858082 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1156,6 +1151,16 @@ public void execute() throws MojoExecutionException,

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789649#comment-17789649 ] ASF GitHub Bot commented on MCOMPILER-381: -- jorsol commented on code in PR #181: URL:

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
jorsol commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404827601 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1400,10 +1406,11 @@ protected int getRequestThreadCount() {

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789643#comment-17789643 ] ASF GitHub Bot commented on MCOMPILER-381: -- olamy commented on code in PR #181: URL:

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
olamy commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404816887 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1400,10 +1406,11 @@ protected int getRequestThreadCount() {

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789637#comment-17789637 ] ASF GitHub Bot commented on MCOMPILER-381: -- olamy commented on code in PR #181: URL:

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
olamy commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404817131 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1539,36 +1546,41 @@ private static List

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
olamy commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404816887 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1400,10 +1406,11 @@ protected int getRequestThreadCount() {

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789636#comment-17789636 ] ASF GitHub Bot commented on MCOMPILER-381: -- jorsol commented on code in PR #181: URL:

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789635#comment-17789635 ] ASF GitHub Bot commented on MCOMPILER-381: -- olamy commented on code in PR #181: URL:

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
jorsol commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404817879 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1539,36 +1546,41 @@ private static List

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789630#comment-17789630 ] ASF GitHub Bot commented on MCOMPILER-381: -- jorsol commented on code in PR #181: URL:

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
jorsol commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404815615 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1539,36 +1546,41 @@ private static List

[jira] [Commented] (MCOMPILER-381) Refactoring needed for isDependencyChanged / Using fileExtensions (AbstractCompilerMojo)

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789627#comment-17789627 ] ASF GitHub Bot commented on MCOMPILER-381: -- jorsol commented on code in PR #181: URL:

Re: [PR] [MCOMPILER-381] - Refactor incremental detection [maven-compiler-plugin]

2023-11-25 Thread via GitHub
jorsol commented on code in PR #181: URL: https://github.com/apache/maven-compiler-plugin/pull/181#discussion_r1404812699 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1400,10 +1406,11 @@ protected int getRequestThreadCount() {