[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800119#comment-17800119 ] ASF GitHub Bot commented on DOXIA-711: -- michael-o commented on code in PR #184: URL:

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
michael-o commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435721892 ## doxia-core/src/main/java/org/apache/maven/doxia/parser/SinkWrapper.java: ## Review Comment: > Should we move this to another package? Maybe

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800117#comment-17800117 ] ASF GitHub Bot commented on DOXIA-711: -- kwin commented on code in PR #184: URL:

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800118#comment-17800118 ] ASF GitHub Bot commented on DOXIA-711: -- kwin commented on code in PR #184: URL:

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
kwin commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435720272 ## doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/PipelineSink.java: ## @@ -28,8 +28,10 @@ /** * May be used to invoke the same method on a List of

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
kwin commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435720203 ## doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/BufferingSinkProxyFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800116#comment-17800116 ] ASF GitHub Bot commented on DOXIA-711: -- kwin commented on code in PR #184: URL:

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
kwin commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435720047 ## doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/BufferingSinkProxyFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800115#comment-17800115 ] ASF GitHub Bot commented on DOXIA-711: -- michael-o commented on code in PR #184: URL:

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
michael-o commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435719871 ## doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/BufferingSinkProxyFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800114#comment-17800114 ] ASF GitHub Bot commented on DOXIA-711: -- kwin commented on code in PR #184: URL:

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
kwin commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435718876 ## doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/BufferingSinkProxyFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (SUREFIRE-1744) Enable system-out for successfuly passed tests as well

2023-12-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800113#comment-17800113 ] Michael Osipov commented on SUREFIRE-1744: -- For all those who suffer, please follow and

[jira] [Commented] (SUREFIRE-1934) Ability to disable system-out/system-err for successfuly passed tests

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800112#comment-17800112 ] ASF GitHub Bot commented on SUREFIRE-1934: -- michael-o commented on PR #670: URL:

Re: [PR] [SUREFIRE-1934] Ability to disable system-out/system-err for successfuly passed tests. [maven-surefire]

2023-12-23 Thread via GitHub
michael-o commented on PR #670: URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1868376997 I have now re-read the code and your change. I fail to see how this change only applies to successful tests. It applies to *all* type of results: `SUCCESS` and non-`SUCCESS`

Re: [PR] User uppercase convention for enum member names [maven-surefire]

2023-12-23 Thread via GitHub
michael-o commented on PR #704: URL: https://github.com/apache/maven-surefire/pull/704#issuecomment-1868376091 No functional change here... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] User uppercase convention for enum member names [maven-surefire]

2023-12-23 Thread via GitHub
michael-o opened a new pull request, #704: URL: https://github.com/apache/maven-surefire/pull/704 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed

[jira] [Closed] (SUREFIRE-2223) Surefire evaluates parameter jvm before skip

2023-12-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed SUREFIRE-2223. Resolution: Fixed Fixed with

[jira] [Commented] (SUREFIRE-2223) Surefire evaluates parameter jvm before skip

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800110#comment-17800110 ] ASF GitHub Bot commented on SUREFIRE-2223: -- asfgit merged PR #703: URL:

Re: [PR] [SUREFIRE-2223] Surefire evaluates parameter jvm before skip [maven-surefire]

2023-12-23 Thread via GitHub
asfgit merged PR #703: URL: https://github.com/apache/maven-surefire/pull/703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Switch to JLine to provide line editing [maven]

2023-12-23 Thread via GitHub
gnodet commented on PR #1279: URL: https://github.com/apache/maven/pull/1279#issuecomment-1868371504 > > eg. > > ``` > > mvn buildplan:list-phase > > ``` > > It works when using a terminal. However, when the output is redirected to a file, the ansi sequences are not stripped

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800107#comment-17800107 ] ASF GitHub Bot commented on DOXIA-711: -- michael-o commented on code in PR #184: URL:

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800106#comment-17800106 ] ASF GitHub Bot commented on DOXIA-711: -- michael-o commented on code in PR #184: URL:

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
michael-o commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435695159 ## doxia-core/src/main/java/org/apache/maven/doxia/parser/SinkWrapper.java: ## Review Comment: I need to think about this... -- This is an automated

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
michael-o commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435694330 ## doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/BufferingSinkProxyFactory.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (MPOM-399) Upgrade minimalMavenBuildVersion from 3.2.5 to 3.6.3 - the minimum used by plugins

2023-12-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPOM-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800100#comment-17800100 ] Michael Osipov commented on MPOM-399: - I am not happy as well... > Upgrade minimalMavenBuildVersion

[jira] [Commented] (DOXIA-710) Inconsistent anchors between toc macro and headers

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800099#comment-17800099 ] ASF GitHub Bot commented on DOXIA-710: -- michael-o commented on code in PR #180: URL:

Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-23 Thread via GitHub
michael-o commented on code in PR #180: URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1435692207 ## doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java: ## @@ -53,10 +56,41 @@ public class IndexEntry { */ private List childEntries

[jira] [Commented] (DOXIA-710) Inconsistent anchors between toc macro and headers

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800097#comment-17800097 ] ASF GitHub Bot commented on DOXIA-710: -- michael-o commented on code in PR #180: URL:

Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-23 Thread via GitHub
michael-o commented on code in PR #180: URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1428911493 ## doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java: ## @@ -304,7 +310,7 @@ public String toString(int depth) { message.append(",

[jira] [Updated] (DOXIA-712) Add validation capability to Sink API

2023-12-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated DOXIA-712: -- Description: The Sink API comes with several limitations with regards to valid order of

[jira] [Updated] (DOXIA-712) Add validation capability to Sink API

2023-12-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated DOXIA-712: -- Description: The Sink API comes with several limitations with regards to valid order of

[jira] [Updated] (DOXIA-712) Add validation capability to Sink API

2023-12-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated DOXIA-712: -- Description: The Sink API comes with several limitations with regards to valid order of

[jira] [Created] (DOXIA-712) Add validation capability to Sink API

2023-12-23 Thread Konrad Windszus (Jira)
Konrad Windszus created DOXIA-712: - Summary: Add validation capability to Sink API Key: DOXIA-712 URL: https://issues.apache.org/jira/browse/DOXIA-712 Project: Maven Doxia Issue Type:

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800095#comment-17800095 ] ASF GitHub Bot commented on DOXIA-711: -- kwin commented on code in PR #184: URL:

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
kwin commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435685833 ## doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/RandomAccessSink.java: ## @@ -27,19 +27,21 @@ import java.util.List; import

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
kwin commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435685799 ## doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/PipelineSink.java: ## @@ -28,8 +28,10 @@ /** * May be used to invoke the same method on a List of

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800094#comment-17800094 ] ASF GitHub Bot commented on DOXIA-711: -- kwin commented on code in PR #184: URL:

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800093#comment-17800093 ] ASF GitHub Bot commented on DOXIA-711: -- kwin commented on code in PR #184: URL:

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
kwin commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435685688 ## doxia-core/src/main/java/org/apache/maven/doxia/parser/SinkWrapper.java: ## Review Comment: I moved now to the existing `o.a.m.doxia.sink.impl` although I find

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
kwin commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435679435 ## doxia-core/src/main/java/org/apache/maven/doxia/parser/SinkWrapper.java: ## Review Comment: Should we move this to another package? Maybe

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800090#comment-17800090 ] ASF GitHub Bot commented on DOXIA-711: -- kwin commented on code in PR #184: URL:

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800089#comment-17800089 ] ASF GitHub Bot commented on DOXIA-711: -- kwin commented on code in PR #184: URL:

Re: [PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
kwin commented on code in PR #184: URL: https://github.com/apache/maven-doxia/pull/184#discussion_r1435679435 ## doxia-core/src/main/java/org/apache/maven/doxia/parser/SinkWrapper.java: ## Review Comment: Should we move this to another package? Maybe

[jira] [Assigned] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_()

2023-12-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned DOXIA-699: - Assignee: Konrad Windszus > Xhtml5Parser may emit sectionX() without sectionX_() >

[jira] [Commented] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800087#comment-17800087 ] ASF GitHub Bot commented on DOXIA-711: -- kwin opened a new pull request, #184: URL:

[PR] [DOXIA-711] Introduce SinkWrapper and according SinkWrapperFactory [maven-doxia]

2023-12-23 Thread via GitHub
kwin opened a new pull request, #184: URL: https://github.com/apache/maven-doxia/pull/184 Add a BufferingSinkProxyWrapper which buffers all calls on the underlying sink until it is flushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (DOXIA-711) Introduce SinkWrapper with factory

2023-12-23 Thread Konrad Windszus (Jira)
Konrad Windszus created DOXIA-711: - Summary: Introduce SinkWrapper with factory Key: DOXIA-711 URL: https://issues.apache.org/jira/browse/DOXIA-711 Project: Maven Doxia Issue Type:

[jira] [Commented] (MJARSIGNER-74) Allow usage of multiple Time Stamping Authority (TSA) servers

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJARSIGNER-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800080#comment-17800080 ] ASF GitHub Bot commented on MJARSIGNER-74: -- schedin opened a new pull request, #19: URL:

[PR] [MJARSIGNER-74] Allow usage of multiple Time Stamping Authority (TSA) servers [maven-jarsigner-plugin]

2023-12-23 Thread via GitHub
schedin opened a new pull request, #19: URL: https://github.com/apache/maven-jarsigner-plugin/pull/19 Implementation of support for multiple TSA servers. A new server will be tried if the jarsigner command fails. The failure could be with communication with the TSA server, or could be

[jira] [Commented] (MPLUGINTESTING-72) release 3.4.0

2023-12-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800054#comment-17800054 ] Slawomir Jaranowski commented on MPLUGINTESTING-72: --- [~singingbush] You can try

[jira] [Commented] (MPLUGINTESTING-72) release 3.4.0

2023-12-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800052#comment-17800052 ] Sylwester Lachiewicz commented on MPLUGINTESTING-72: Sorry, I had no time to

[jira] [Reopened] (MPLUGINTESTING-72) release 3.4.0

2023-12-23 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reopened MPLUGINTESTING-72: > release 3.4.0 > - > > Key:

[jira] [Commented] (MPLUGINTESTING-62) use maven API 3.6.0 and Plexus 2.0.0

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800051#comment-17800051 ] ASF GitHub Bot commented on MPLUGINTESTING-62: -- SingingBush opened a new pull

[PR] [MPLUGINTESTING-62] target maven 3.6.0 and Plexus 2.0.0 [maven-plugin-testing]

2023-12-23 Thread via GitHub
SingingBush opened a new pull request, #8: URL: https://github.com/apache/maven-plugin-testing/pull/8 pretty frustrating that in 2019 people are still targeting ancient Java versions. In this pull request I've set JDK 8 as the target and also updated to a more recent maven api level and

[jira] [Comment Edited] (MPLUGINTESTING-72) release 3.4.0

2023-12-23 Thread Samael Bate (Jira)
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800050#comment-17800050 ] Samael Bate edited comment on MPLUGINTESTING-72 at 12/23/23 1:03 PM:

[jira] [Commented] (MPLUGINTESTING-72) release 3.4.0

2023-12-23 Thread Samael Bate (Jira)
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800050#comment-17800050 ] Samael Bate commented on MPLUGINTESTING-72: --- How come this is closed, there's still no

[jira] [Commented] (MJLINK-77) Update description and parameters of --compress to reflect JDK21 changes

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800049#comment-17800049 ] ASF GitHub Bot commented on MJLINK-77: -- bmarwell commented on PR #181: URL:

[jira] [Commented] (MJLINK-77) Update description and parameters of --compress to reflect JDK21 changes

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800048#comment-17800048 ] ASF GitHub Bot commented on MJLINK-77: -- bmarwell closed pull request #181: [MJLINK-77] accept JDK21+

Re: [PR] [MJLINK-77] accept JDK21+ compress parameters [maven-jlink-plugin]

2023-12-23 Thread via GitHub
bmarwell closed pull request #181: [MJLINK-77] accept JDK21+ compress parameters URL: https://github.com/apache/maven-jlink-plugin/pull/181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [MJLINK-77] accept JDK21+ compress parameters [maven-jlink-plugin]

2023-12-23 Thread via GitHub
bmarwell commented on PR #181: URL: https://github.com/apache/maven-jlink-plugin/pull/181#issuecomment-1868289842 > I'm for simplify code and pass parameter as it to external tools Yes, see #183. Closing this one, we all agree on it. -- This is an automated message from the Apache

[jira] [Commented] (MJLINK-77) Update description and parameters of --compress to reflect JDK21 changes

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800047#comment-17800047 ] ASF GitHub Bot commented on MJLINK-77: -- bmarwell opened a new pull request, #183: URL:

[PR] [MJLINK-77] compress parameters jdk21 no validation [maven-jlink-plugin]

2023-12-23 Thread via GitHub
bmarwell opened a new pull request, #183: URL: https://github.com/apache/maven-jlink-plugin/pull/183 Similar to #181, but no validation. This is a breaking behaviour change as the user now could add any parameter. But it is not breaking in terms of project compilation. ---

[jira] [Commented] (DOXIA-710) Inconsistent anchors between toc macro and headers

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800043#comment-17800043 ] ASF GitHub Bot commented on DOXIA-710: -- kwin commented on code in PR #180: URL:

Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-23 Thread via GitHub
kwin commented on code in PR #180: URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1435592379 ## doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java: ## @@ -304,7 +310,7 @@ public String toString(int depth) { message.append(",

Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.0 [maven-build-cache-extension]

2023-12-23 Thread via GitHub
olamy commented on PR #122: URL: https://github.com/apache/maven-build-cache-extension/pull/122#issuecomment-1868251746 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (MBUILDCACHE-73) Add project version as additional property for reconcilation

2023-12-23 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800027#comment-17800027 ] Olivier Lamy commented on MBUILDCACHE-73: - the PR of the linked issue has been merged. this

Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.15.1 [maven-build-cache-extension]

2023-12-23 Thread via GitHub
dependabot[bot] merged PR #118: URL: https://github.com/apache/maven-build-cache-extension/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.14.0 [maven-build-cache-extension]

2023-12-23 Thread via GitHub
olamy merged PR #119: URL: https://github.com/apache/maven-build-cache-extension/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (MBUILDCACHE-76) pom project version change not detected

2023-12-23 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MBUILDCACHE-76: Fix Version/s: 1.2.0 > pom project version change not detected >

[jira] [Closed] (MBUILDCACHE-76) pom project version change not detected

2023-12-23 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MBUILDCACHE-76. --- Resolution: Fixed > pom project version change not detected >

[jira] [Assigned] (MBUILDCACHE-76) pom project version change not detected

2023-12-23 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy reassigned MBUILDCACHE-76: --- Assignee: Olivier Lamy > pom project version change not detected >

[jira] [Commented] (MBUILDCACHE-76) pom project version change not detected

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800026#comment-17800026 ] ASF GitHub Bot commented on MBUILDCACHE-76: --- olamy merged PR #117: URL:

Re: [PR] [MBUILDCACHE-76] add project version as part of hash key [maven-build-cache-extension]

2023-12-23 Thread via GitHub
olamy merged PR #117: URL: https://github.com/apache/maven-build-cache-extension/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MJLINK-77) Update description and parameters of --compress to reflect JDK21 changes

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800019#comment-17800019 ] ASF GitHub Bot commented on MJLINK-77: -- slawekjaranowski commented on code in PR #181: URL:

Re: [PR] [MJLINK-77] accept JDK21+ compress parameters [maven-jlink-plugin]

2023-12-23 Thread via GitHub
slawekjaranowski commented on code in PR #181: URL: https://github.com/apache/maven-jlink-plugin/pull/181#discussion_r1435534795 ## src/it/projects/MJLINK-77_compress-parameters/verify.groovy: ## @@ -0,0 +1,62 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (MJLINK-77) Update description and parameters of --compress to reflect JDK21 changes

2023-12-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800017#comment-17800017 ] ASF GitHub Bot commented on MJLINK-77: -- rmannibucau commented on PR #181: URL:

Re: [PR] [MJLINK-77] accept JDK21+ compress parameters [maven-jlink-plugin]

2023-12-23 Thread via GitHub
rmannibucau commented on PR #181: URL: https://github.com/apache/maven-jlink-plugin/pull/181#issuecomment-1868239770 @bmarwell if you dont passthru you know so you validate and forbid future usage until the plugin is upgraded IMHO otherwise it does not make sense to make it specific. --

[jira] [Comment Edited] (MCOMPILER-424) Annotation processor fails with AnnotationTypeMismatchException on Java 11 which targets Java 8

2023-12-23 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800016#comment-17800016 ] Alexander Kriegisch edited comment on MCOMPILER-424 at 12/23/23 8:17 AM:

[jira] [Commented] (MCOMPILER-424) Annotation processor fails with AnnotationTypeMismatchException on Java 11 which targets Java 8

2023-12-23 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800016#comment-17800016 ] Alexander Kriegisch commented on MCOMPILER-424: --- The bug was accepted as