[GitHub] [maven] bmarwell commented on pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

bmarwell commented on pull request #415: URL: https://github.com/apache/maven/pull/415#issuecomment-751812135 > My bad, I did not notice that you have moved the code. But still, The property needs to be in the new method now for consistency reasons. I see. I could just move that

[GitHub] [maven] bmarwell commented on pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

bmarwell commented on pull request #415: URL: https://github.com/apache/maven/pull/415#issuecomment-751754398 > This looks OK, but incomplete. When if you at `org.apache.maven.cli.MavenCli.logging(CliRequest)` in the block marked with `// LOG COLOR` you see duplicate code now. It is

[GitHub] [maven] bmarwell commented on pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

bmarwell commented on pull request #415: URL: https://github.com/apache/maven/pull/415#issuecomment-750395178 Huh, I need some help with the tests. I do not think any IT should fail because of my change, but they did fail: