[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)

2023-05-04 Thread via GitHub
cstamas commented on code in PR #1098: URL: https://github.com/apache/maven/pull/1098#discussion_r1184662324 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -309,6 +320,47 @@ void initialize(CliRequest cliRequest) throws ExitException { }

[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)

2023-05-03 Thread via GitHub
cstamas commented on code in PR #1098: URL: https://github.com/apache/maven/pull/1098#discussion_r1184010397 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -526,8 +578,39 @@ private void commands(CliRequest cliRequest) { // Needed to make this

[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)

2023-05-03 Thread via GitHub
cstamas commented on code in PR #1098: URL: https://github.com/apache/maven/pull/1098#discussion_r1183884537 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -140,9 +146,14 @@ public class MavenCli { private static final String EXT_CLASS_PATH =

[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)

2023-05-03 Thread via GitHub
cstamas commented on code in PR #1098: URL: https://github.com/apache/maven/pull/1098#discussion_r1183386394 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -526,8 +578,39 @@ private void commands(CliRequest cliRequest) { // Needed to make this

[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)

2023-05-03 Thread via GitHub
cstamas commented on code in PR #1098: URL: https://github.com/apache/maven/pull/1098#discussion_r1183386394 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -526,8 +578,39 @@ private void commands(CliRequest cliRequest) { // Needed to make this

[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)

2023-05-03 Thread via GitHub
cstamas commented on code in PR #1098: URL: https://github.com/apache/maven/pull/1098#discussion_r1183386394 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -526,8 +578,39 @@ private void commands(CliRequest cliRequest) { // Needed to make this

[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)

2023-05-03 Thread via GitHub
cstamas commented on code in PR #1098: URL: https://github.com/apache/maven/pull/1098#discussion_r1183365054 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -526,8 +578,39 @@ private void commands(CliRequest cliRequest) { // Needed to make this

[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)

2023-05-03 Thread via GitHub
cstamas commented on code in PR #1098: URL: https://github.com/apache/maven/pull/1098#discussion_r1183365054 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -526,8 +578,39 @@ private void commands(CliRequest cliRequest) { // Needed to make this

[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)

2023-05-03 Thread via GitHub
cstamas commented on code in PR #1098: URL: https://github.com/apache/maven/pull/1098#discussion_r1183331161 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -526,8 +578,39 @@ private void commands(CliRequest cliRequest) { // Needed to make this

[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)

2023-05-03 Thread via GitHub
cstamas commented on code in PR #1098: URL: https://github.com/apache/maven/pull/1098#discussion_r1183331161 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -526,8 +578,39 @@ private void commands(CliRequest cliRequest) { // Needed to make this

[GitHub] [maven] cstamas commented on a diff in pull request #1098: [MNG-7774] Maven config and command line interpolation (take two)

2023-05-03 Thread via GitHub
cstamas commented on code in PR #1098: URL: https://github.com/apache/maven/pull/1098#discussion_r1183330513 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -140,9 +146,14 @@ public class MavenCli { private static final String EXT_CLASS_PATH =