[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1325782731 ## maven-model/src/test/java/org/apache/maven/model/v4/Xpp3DomPerfTest.java: ## @@ -18,22 +18,6 @@ */ package org.apache.maven.model.v4; -/* Review Comment: Possi

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1325779523 ## maven-model/src/test/java/org/apache/maven/model/v4/Xpp3DomPerfTest.java: ## @@ -18,22 +18,6 @@ */ package org.apache.maven.model.v4; -/* Review Comment: We ne

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1324435432 ## maven-core/src/main/java/org/apache/maven/plugin/ReflectionValueExtractor.java: ## @@ -0,0 +1,303 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1322972137 ## maven-core/src/main/java/org/apache/maven/toolchain/java/JavaToolchainFactory.java: ## @@ -86,9 +86,9 @@ public ToolchainPrivate createToolchain(ToolchainModel model)

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1321373092 ## maven-core/src/main/java/org/apache/maven/utils/dag/Dag.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1316362150 ## maven-model-builder/src/main/java/org/apache/maven/utils/Os.java: ## @@ -0,0 +1,383 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1311520008 ## maven-core/src/main/java/org/apache/maven/utils/dag/DAG.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1310423407 ## maven-core/src/main/java/org/apache/maven/utils/dag/DAG.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1310422373 ## maven-core/src/main/java/org/apache/maven/utils/dag/Vertex.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1310379975 ## maven-core/src/main/java/org/apache/maven/utils/dag/DAG.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1307372298 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305624838 ## maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java: ## @@ -122,12 +153,54 @@ private boolean determineFamilyMatch(Stri

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305624838 ## maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java: ## @@ -122,12 +153,54 @@ private boolean determineFamilyMatch(Stri

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1305598002 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1304233854 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1274774380 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1304137698 ## maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java: ## @@ -465,6 +469,28 @@ public void getRemoteFile( } } +priv

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1274768736 ## maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java: ## @@ -18,17 +18,48 @@ */ package org.apache.maven.profiles.act