Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769070764 > > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > > > > > Yes and it makes sense. The fast delete moves the entire directory. If

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

chabala commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769067418 > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > Yes and it makes sense. The fast delete moves the entire directory. If you want

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769046065 > > So it looks like when we use includes/excludes fastDelete will not works - correct? > > Yes and it makes sense. The fast delete moves the entire directory. If y

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

wilx commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1364294236 ## src/it/fast-delete/pom.xml: ## @@ -0,0 +1,52 @@ + + + + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instanc

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1769003627 > So it looks like when we use includes/excludes fastDelete will not works - correct? Yes and it makes sense. The fast delete moves the entire directory. If you want to delete

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

slawekjaranowski commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1364259343 ## src/it/fast-delete/pom.xml: ## @@ -0,0 +1,52 @@ + + + + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://www.w3.org/2001/XMLSc

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768998145 So it looks like when we use includes/excludes fastDelete will not works - correct? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768991916 > Is this a symptom of `GlobSelector` not working on Windows at all? The issue is not with `GlobSelector`. The issue is that the `GlobSelector` instance passed into `cleaner.de

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768876305 > Is this a symptom of `GlobSelector` not working on Windows at all? Good point - it should be also checked. -- This is an automated message from the Apache Git S

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

chabala commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768742507 Is this a symptom of `GlobSelector` not working on Windows at all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

wilx commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1363961577 ## src/it/fast-delete/invoker.properties: ## @@ -0,0 +1 @@ +invoker.goals = install clean -Dorg.slf4j.simpleLogger.showThreadName=true -X -e Review Comment: Fi

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

slawekjaranowski commented on code in PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#discussion_r1363956331 ## src/it/fast-delete/invoker.properties: ## @@ -0,0 +1 @@ +invoker.goals = install clean -Dorg.slf4j.simpleLogger.showThreadName=true -X -e Review Co

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

wilx commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768492359 @slawekjaranowski I have added the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [MCLEAN-111] Fix fast delete feature. [maven-clean-plugin]

slawekjaranowski commented on PR #32: URL: https://github.com/apache/maven-clean-plugin/pull/32#issuecomment-1768441320 @wilx thanks Is it possible to make an IT to be sure for regressions with next changes? -- This is an automated message from the Apache Git Service. To respond to the