gnodet merged PR #311:
URL: https://github.com/apache/maven-integration-testing/pull/311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
juulhobert commented on PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#issuecomment-1767064068
> Nice work, thanks for providing these extensive test cases!
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
mthmulders commented on PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#issuecomment-1763424268
The two extensions are completely identical. Can't we reuse them?
Also, in the testing of
[MNG-7772](https://github.com/apache/maven/pull/1280), building the Ext
mthmulders commented on PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#issuecomment-1763408996
I've kicked off the GitHub Action build for the corresponding PR in Maven
Core. If those changes build correctly, it should trigger these new tests.
--
This is an au
mthmulders commented on code in PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#discussion_r1359868326
##
core-it-suite/src/test/resources/mng-7772-core-extensions-lib-ext/extension/.gitignore:
##
Review Comment:
Nit: this wasn't covered by exist
juulhobert commented on code in PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#discussion_r1359376079
##
core-it-suite/src/test/java/org/apache/maven/it/ItUtils.java:
##
@@ -56,4 +63,24 @@ public static String calcHash(File file, String algo) throws
slawekjaranowski commented on code in PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#discussion_r1359372962
##
core-it-suite/src/test/java/org/apache/maven/it/ItUtils.java:
##
@@ -56,4 +63,24 @@ public static String calcHash(File file, String algo) t
juulhobert commented on code in PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#discussion_r1359360272
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7772CoreExtensionsNotFoundTest.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache
juulhobert commented on code in PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#discussion_r1359321315
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7772CoreExtensionsNotFoundTest.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache
slawekjaranowski commented on code in PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#discussion_r1358681241
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7772CoreExtensionsNotFoundTest.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the
mthmulders commented on PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#issuecomment-1761781889
I'd love to also see a "positive" test case, e.g., one that demonstrates
that Maven indeed activates an extension that is installed in the user-level
Maven directory.
mthmulders commented on code in PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#discussion_r1358476213
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7772CoreExtensionsNotFoundTest.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache
juulhobert opened a new pull request, #311:
URL: https://github.com/apache/maven-integration-testing/pull/311
Integration test for [PR](https://github.com/apache/maven/pull/1280) and
[Jira issue](https://issues.apache.org/jira/browse/MNG-7772)
--
This is an automated message from the Apac
13 matches
Mail list logo
