OLibutzki commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1987934181
> The release is still under vote.
@gnodet Thanks for pushing that release ahead!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
reckart commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985714575
@OLibutzki the development process of Apache projects generally is public -
you can help by testing and casting your vote as well - just reply to the
voting mail. However, unless you
reckart commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985709598
https://lists.apache.org/list?d...@maven.apache.org:2024-3:vote
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
OLibutzki commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985701031
> The release is still under vote.
Thanks for the feedback... this is not a publicly visible process, right?
--
This is an automated message from the Apache Git Service.
To
gnodet commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985677119
> > I'm doing a review of maven shared projects now and will do a release
for this project also.
>
> Any progress, @slachiewicz?
>
> There is a [3.3.2
tag](https://github
OLibutzki commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985381882
> I'm doing a review of maven shared projects now and will do a release for
this project also.
Any progress, @slachiewicz?
--
This is an automated message from the Apache G
slachiewicz commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1888918418
I'm doing a review of maven shared projects now and will do a release for
this project also.
--
This is an automated message from the Apache Git Service.
To respond to the mess
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-138328
> > Do you have any approx. arrival date for a release including this fix?
>
> We do not plan releases. Someone has to stand up as RM for this.
Then the question is maybe i
michael-o commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-129990
> Do you have any approx. arrival date for a release including this fix?
We do not plan releases. Someone has to stand up as RM for this.
--
This is an automated message fro
OLibutzki commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1884404140
Do you have any approx. arrival date for a release including this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
elharo merged PR #77:
URL: https://github.com/apache/maven-filtering/pull/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.ap
akuhtz commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1863016485
Can this be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
laeubi commented on code in PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#discussion_r1420419510
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##
@@ -189,20 +190,44 @@ public void filterResources(MavenResourcesExecution
elharo commented on code in PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#discussion_r1420408887
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##
@@ -189,20 +190,44 @@ public void filterResources(MavenResourcesExecution
laeubi commented on code in PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#discussion_r1420403517
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##
@@ -321,19 +347,20 @@ public void filterResources(MavenResourcesExecution
elharo commented on code in PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#discussion_r1420397992
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##
@@ -321,19 +347,20 @@ public void filterResources(MavenResourcesExecution
laeubi commented on code in PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#discussion_r1420394454
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##
@@ -321,19 +347,20 @@ public void filterResources(MavenResourcesExecution
elharo commented on code in PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#discussion_r1420388359
##
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##
@@ -321,19 +347,20 @@ public void filterResources(MavenResourcesExecution
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1846852881
All checks have passed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1846830645
@lalmeras sounds reasonable, I have now adjust the code accordingly (and
slightly restructured the flow), now my local build shows all test passing!
--
This is an automated message f
lalmeras commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1844896414
I think ignoreDelta for this case is a well-founded behavior. It checks
specifically filter files (not filtered files). If source for filters values is
changed, I think it is expecte
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1844620007
@lalmeras thanks for clarification, thinking more about it I wonder if
`ignoreDelta` is actually useful for anything given we use `isUptodate()`,
because for me it looks like `ignoreDe
lalmeras commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1843346851
They are test-cases that handle filter modification. Expected behavior
(checked by these tests) is to perform a full-build (this is the case where
ignoreDelta := true is delta is fou
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1842459505
It currently fails on test-time will need to investigate what it wants
here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
lalmeras commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837140171
@laeubi PR #83 with failing test cases and updated commit messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837123822
@lalmeras can you open a PR here so we see the test is currently failing?
I'll then fetch the PR and add my one on top of it to prove it fixes the
failing test!
--
This is an automa
lalmeras commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837123168
Thank you for your feedback.
@laeubi Do you want to update your PR with my proposal so we now both have
unit test demonstrating your use case (and failing with the current code
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837114983
@lalmeras I think you are right that m2e assumes that if the target is newer
than the source it is up-todate... but I think that can be ignored for now as
this is an implementation det
lalmeras commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837113152
@laeubi Can you check
https://github.com/lalmeras/maven-filtering/commit/dbe13673489c61a5c277b507310083bdcaa87c92#diff-a52a7b8a0ff570c181fe18ab238b693c21243d40870dd2d8178340247755bba5
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1837037738
@lalmeras great to see you make progress on this :+1:
For the second case assume the following:
1. A resource (e.g. `source.txt`) was recently copied to the output folder
lalmeras commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1836797752
I update my branch
https://github.com/lalmeras/maven-filtering/commits/MSHARED-1285 with the
following change :
* rebased on origin/master with the refactored tests
* I added a
lalmeras commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1833477761
Done ! #82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1833089113
> I do not open another PR; feel free to integrate my proposal in this PR.
@lalmeras just open a PR for the testcases I think that can be easier to
manage also we then have direc
lalmeras commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1832907067
Here is a branch with my proposal :
https://github.com/lalmeras/maven-filtering/commits/MSHARED-1285
* first commit is a test refactor applied to existing master codebase
*
lalmeras commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1831557819
Already done it (copy/fix TestIncrementalBuildContext). It doesn't work out
of the box as there is other tests that rely on this bug to work. And another
bug in getRelpath.
Bu
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1831210021
@lalmeras many many thanks for looking into the test!
> So the issue for this test failure is in TestIncrementalBuildContext
(org.sonatype.plexus:plexus-build-api:tests). Not sur
lalmeras commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1830852620
I dig into the test issue.
Test verifies the following behavior:
* two files with resource filtering are filtered; both files are copied to
target with `${time}` replaced by
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1820426240
> @laeubi would it be possible to add a unit test that showcases the issue
and the proposed fix?
It should be possible to reproduce the problem a testcase should be setup
like t
mickaelistria commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1820418224
@laeubi would it be possible to add a unit test that showcases the issue and
the proposed fix?
--
This is an automated message from the Apache Git Service.
To respond to the m
pcdavid commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1787352103
FWIW, the (single) test failure I get with this PR is this one:
```
[ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.162 s <<< FAILURE! - in
org.apa
laeubi commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1774104149
> Is there any way to do thsi that doesn't use plexus at all? E.g. something
in commons-io instead?
obviously not...
--
This is an automated message from the Apache Git Servic
OLibutzki commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1752774319
Any chances to get some progress into this PR? From an Eclipse user
perspective this issue is really annoying as some resources are not copied to
the target/classes folder.
/
42 matches
Mail list logo
