[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=362037#comment-362037 ] Michael Osipov commented on MPMD-199: - Probably a config problem. You should seek help with the

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=362046#comment-362046 ] Michael Osipov edited comment on MPMD-199 at 1/29/15 3:16 PM: -- Another

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPMD-199. --- Resolution: Fixed Fix Version/s: 3.4 Assignee: Michael Osipov Fixed with

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=362046#comment-362046 ] Michael Osipov commented on MPMD-199: - Another tip for further contributions: Name your patch by

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361910#comment-361910 ] Michael Osipov commented on MPMD-199: - Hi Tom, I'll have a look at it. 1) What do you mean by

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361922#comment-361922 ] Tom Williamson commented on MPMD-199: - The test cases in the maven plugin project all work

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361823#comment-361823 ] Tom Williamson commented on MPMD-199: - I hope to have a new patch for you tomorrow unless the

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Williamson updated MPMD-199: Attachment: jsp_support_20150126_1633.patch I have attached a new patch (jsp_support_20150126_1633.patch)

[jira] (MPMD-199) Support PMD functionality on JSP files

in this plugin. It would ultimately add all JSP and JS files to a JAR/WAR as source which does not make sense at all. This is worth another issue in JIRA. Support PMD functionality on JSP files -- Key: MPMD-199 URL: https

[jira] (MPMD-199) Support PMD functionality on JSP files

-designed in this plugin. It would ultimately add all JSP and JS files to a JAR/WAR as source which does not make sense at all. This is worth another issue in JIRA. Support PMD functionality on JSP files -- Key: MPMD-199 URL

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361511#comment-361511 ] Michael Osipov commented on MPMD-199: - OK, thanks. I will have a look. Just a note for the

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361543#comment-361543 ] Tom Williamson commented on MPMD-199: - Thanks for the tip on Github. And thanks for your help

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Williamson updated MPMD-199: Attachment: Patch_for_JSP_support.patch Patch for JSP support. There are some spurious whitespace/line

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361469#comment-361469 ] Dan Tran commented on MPMD-199: --- It is best for a committer reformat and remove unwanted white space

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361465#comment-361465 ] Michael Osipov commented on MPMD-199: - Please rework the patch without IntelliJ, there are too

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361476#comment-361476 ] Dan Tran commented on MPMD-199: --- I reformat the code. Please redo the patch and make sure to use

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361479#comment-361479 ] Tom Williamson commented on MPMD-199: - I will redo the patch and post a corrected one. Support

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361494#comment-361494 ] Tom Williamson commented on MPMD-199: - I noticed that sample.jsp was in the patch file twice, not

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Williamson updated MPMD-199: Attachment: JSP_support_201501201523.patch I have updated the text in the jspReport.apt.vm file, and

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361482#comment-361482 ] Michael Osipov commented on MPMD-199: - Tom, way better now. A few issues though: 1.

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Williamson updated MPMD-199: Attachment: Jsp_support_201501201341.patch New patch file attached, made with SVN from original files,

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361473#comment-361473 ] Michael Osipov commented on MPMD-199: - Dan, feel free if you want. Too much changes in the patch

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=361412#comment-361412 ] Tom Williamson commented on MPMD-199: - Great, I am tuning up the patch and I hope to have it

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=360835#comment-360835 ] Michael Osipov commented on MPMD-199: - Hi Tom, thanks for helping out. Only project admins can

[jira] (MPMD-199) Support PMD functionality on JSP files

[ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=360820#comment-360820 ] Tom Williamson commented on MPMD-199: - I created this Jira, and would really like to assign it to

[jira] (MPMD-199) Support PMD functionality on JSP files

Tom Williamson created MPMD-199: --- Summary: Support PMD functionality on JSP files Key: MPMD-199 URL: https://jira.codehaus.org/browse/MPMD-199 Project: Maven PMD Plugin Issue Type: Improvement