[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_82258
]
Leonardo Quijano Vincenzi commented on MNGECLIPSE-59:
-
This seems pretty much implemented by now, isn't it?
> Allow artifact resolution from workspa
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_73728
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
I think this scenario is already in the works under MNGECLIPSE-182
> Allow artifact resolution from workspace pro
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_73452
]
Marek Bieganski commented on MNGECLIPSE-59:
---
Step 0:
Turn on auto build
Step 1:
Import attached simple projects
Step 2:
Deploy library project (jar and po
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_73203
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
Marek, please provide exact steps to reproduce. Thanks.
> Allow artifact resolution from workspace projects
> ---
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_73187
]
Marek Bieganski commented on MNGECLIPSE-59:
---
There are still problems on open/close or checkout/delete projects declared as
dependencies in other project's po
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72701
]
Scott Cytacki commented on MNGECLIPSE-59:
-
I created a sub-task to work on the patch for initializing the artifact map:
MNGECLIPSE-182
I've posted a patch there
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72630
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
Good catch. Maven2ClasspathContainerInitializer should invoke
updateMavenModel(..) method when recreating maven c
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72627
]
Scott Cytacki commented on MNGECLIPSE-59:
-
I think I tracked down the source of my problems. The artifacts map in the
MavenModelManager is not be initialized c
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72573
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
I pushed some fixes. Namely: changed key in models Map to string (I wonder if
it would fix your issue) and fixed
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72565
]
Scott Cytacki commented on MNGECLIPSE-59:
-
I just checked it out. The refactoring looks good, and thanks for updating the
eclipse formater settings. But...
I
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72531
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
I took last patch from Scott, refactored it to be more integrated with builder
and committed changes to svn.
The
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72496
]
Dimitry Voytenko commented on MNGECLIPSE-59:
Maven and WTP: MNGECLIPSE-107
Maven and PDE: MNGECLIPSE-106
> Allow artifact resolution from workspace project
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72485
]
Robert Elliot commented on MNGECLIPSE-59:
-
created http://jira.codehaus.org/browse/MNGECLIPSE-181 to discuss updating
projects that depend on the changed projec
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72482
]
Scott Cytacki commented on MNGECLIPSE-59:
-
created MNGECLIPSE-179 to dicuss this option of using the resolver in forked
maven builds.
created MNGECLIPSE-180 to
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72477
]
Yuri Schimke commented on MNGECLIPSE-59:
Eugene, We've got a multimodule maven project. I've tried both approaches,
i.e. seperate eclipse projects and a single
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72475
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
Scott, thanks for update and great explanation. I applied patch, but it require
some cleanup and refactoring befo
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72474
]
Sualeh Fatehi commented on MNGECLIPSE-59:
-
Please could someone publish 0.10 to the website, so that I can update using
the Eclipse update manager. This way, we
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72473
]
Scott Cytacki commented on MNGECLIPSE-59:
-
Dimitry, some testing would be great.
Robert,
Regarding the duplicate project dependencies. I would expect the JDT t
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72444
]
Robert Elliot commented on MNGECLIPSE-59:
-
Very minor point - if you have project A in the workspace specifying version
0.1 of project B in its POM and project
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72440
]
Robert Elliot commented on MNGECLIPSE-59:
-
I applied the patch to a clean check out from Trunk last night, built and
upgraded to the 0.0.10 plugin. It appears
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72437
]
Dimitry Voytenko commented on MNGECLIPSE-59:
I believe it should definetely be a version with the eclipse artifact
resolution. Again, I can do the accepting
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72391
]
Scott Cytacki commented on MNGECLIPSE-59:
-
The embedder has been updated already to include the changes: MNG-1937
The embedder checked into the m2eclipse svn inc
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72044
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
Folks, I see 4 different patches that presumably take 4 different approaces to
resolve this issue. Unfortunately
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72039
]
Jimisola Laursen commented on MNGECLIPSE-59:
I just assumed that the reason that this hadn't been resolved was due to the
Maven Embedder. Obviously there is
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_72031
]
Dimitry Voytenko commented on MNGECLIPSE-59:
We've been using the patch provided by "Mark J. Sinke" for quite a long time
now. It works very well for us, al
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_71970
]
Leonardo Quijano Vincenzi commented on MNGECLIPSE-59:
-
It's been a long time for this one. Is anyone committing changes?
> Allow artifact resolutio
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_71776
]
Scott Cytacki commented on MNGECLIPSE-59:
-
I just checked the attachements and it seems they are back. I see that this
issue has been marked unassigned.
Ca
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_69923
]
andrew commented on MNGECLIPSE-59:
--
Scott Cytacki
Can you repost your patch? all attachment seems lost from this server.
thanks
Andrew
> Allow artifact resolution from
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_69483
]
Yuri Schimke commented on MNGECLIPSE-59:
False alarm. Was actually to do with some of my eclipse source paths being out
of date. Just something to watch out for when you
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_69440
]
Yuri Schimke commented on MNGECLIPSE-59:
The patch fixes a number of issues that I had reported in MNGECLIPSE-147,
however it does not seem to find resources, only the actu
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_68386
]
Scott Cytacki commented on MNGECLIPSE-59:
-
After looking more closely at the two patches: Mark's and Kenney's. I realized
they are not the same. Kenney did add the eclips
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_68375
]
Scott Cytacki commented on MNGECLIPSE-59:
-
Hi Dimitry and Eugene,
I'm sorry for any confusion that I caused, but I assumed that Kenney's patch
was the most uptodate. Base
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_68368
]
Dimitry Voytenko commented on MNGECLIPSE-59:
Hi Eugene,
There seems to quite a bit of confusion around this issue now. I just wanted to
see if if something can be done
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_68229
]
Marek Bieganski commented on MNGECLIPSE-59:
---
Caching artifact key in Maven2Nature instead of parsing model/project every
time seems to be good idea too
> Allow artifact
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_68227
]
Marek Bieganski commented on MNGECLIPSE-59:
---
in patched Maven2Plugin class:
Why method: getModel(IFile file)
uses:
getMavenEmbedder().readProjectWithDependencies( file
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_67376
]
Damien Lecan commented on MNGECLIPSE-59:
I'm using lastest trunk sources for maven eclipse plugin (with embedder
2.1-SNAPSHOT inside)
I would like to use theses patches to
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_67370
]
Marek Bieganski commented on MNGECLIPSE-59:
---
getWorkspaceNature(Artifact) method iterates over all projects every time it is
called.
Isn't it a good idea to cache natures
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_66896
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
Kenney, can you please merge your code with trunk changes and recreate patch
afte that? I can't apply this one.
> Allow arti
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_66895
]
Marek Bieganski commented on MNGECLIPSE-59:
---
In my opinion main goal of this functionality is to have only one version of
.classpath and pom for each project. It should b
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_66854
]
Drew Farris commented on MNGECLIPSE-59:
---
There's no need to patch or rebuild the embedder with the approach I
contributed -- which may be useful for people without the time o
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_66847
]
Dimitry Voytenko commented on MNGECLIPSE-59:
I believe this is what Mark J. Sinke's original patch does and it does it in a
rather elegant way. I had it running on our
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_66846
]
Drew Farris commented on MNGECLIPSE-59:
---
Dimitry,
It's an attempt to get the eclipse plugin to resolve artifact dependencies by
looking at workspace projects instead of look
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_66840
]
Dimitry Voytenko commented on MNGECLIPSE-59:
Drew, what is this fix for exactly?
> Allow artifact resolution from workspace projects
> -
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_66828
]
Drew Farris commented on MNGECLIPSE-59:
---
I've hacked together a solution that seems to work for now and only touches the
Maven2Plugin class. I've generated the attached patch
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_66754
]
Dimitry Voytenko commented on MNGECLIPSE-59:
Hi Kenney,
While ago I tried the patch and ran into issues described in one of the
comments above above (see "It still cr
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_66724
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
Primary constraint is my time. So, patch against trunk will help and would
allow to cleanup outdated attachments... Thanks.
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_66722
]
Dimitry Voytenko commented on MNGECLIPSE-59:
Eugene, is something still holding the patch suggested by Mark? I had it
running in our environment for some time now, it w
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_65525
]
Dimitry Voytenko commented on MNGECLIPSE-59:
I see :)
I made a note in Eclipse's bug system:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=142135
They're planning to re
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_65504
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
Dmitry, belive me, I've gone trough this already. This if why it is how it is
now. :-)
> Allow artifact resolution from work
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_65502
]
Dimitry Voytenko commented on MNGECLIPSE-59:
Unfortunetely, it looks like Eclipse's classpath containers cannot contain
variable entries. Per IClasspathContainer JavaDo
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_65481
]
Dimitry Voytenko commented on MNGECLIPSE-59:
There's one outstanding issue here though. It doesn't block the progress on
this item, but it'll be very nice to have.
Cur
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_65478
]
Dimitry Voytenko commented on MNGECLIPSE-59:
I believe the patch can be applied already. The blocking issues have been
resolved, although, I don't know if they have bee
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_65193
]
Jacob Robertson commented on MNGECLIPSE-59:
---
My company is evaluating using m2eclipse. Our culture is to check out multiple
projects at once while developing, but refere
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_64235
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
Thanks Dmitry. Please attach some example projects to reproduce those issue.
> Allow artifact resolution from workspace proje
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_64234
]
Dimitry Voytenko commented on MNGECLIPSE-59:
I agree. These are two different issues:
1) WebTools is actually not a classpath container, they use the regular project
d
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_64208
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
Guys, before you go too far here. I'd like to suggest to investigate options to
somehow make WTP classpath containers to pick
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_64206
]
Dimitry Voytenko commented on MNGECLIPSE-59:
Hi Mark,
Another issue that should also be considered is WebTools support. It, pretty
much, has the same issue. I.e. WebTo
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_64187
]
Mark J. Sinke commented on MNGECLIPSE-59:
-
Hi Dimitry,
Unfortunately, I have not walked through the scenario you described. The
colleague I worked with is on holiday for a
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_64136
]
Dimitry Voytenko commented on MNGECLIPSE-59:
Hi Mark,
There's another issue with this implementation. It's in the area of PDE
development and probably is only particul
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_63914
]
Dimitry Voytenko commented on MNGECLIPSE-59:
Hi Mark,
I managed to recompile and run the plugin. It works well. But there were couple
issues I ran into:
1) It still c
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_63553
]
Mark J. Sinke commented on MNGECLIPSE-59:
-
Hi Dimitry,
Milos Kleint is working to get the patch applied to the trunk (in MNG-1937, in
an effort to solve MNG-1665). So you
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_63442
]
Dimitry Voytenko commented on MNGECLIPSE-59:
Will this patch be included in the future release? Could you estimate when this
would happen? It's a rather serious enhance
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_61823
]
Brad Davis commented on MNGECLIPSE-59:
--
The patch appears to be missing the EclipseMavenEmbedder referenced in one
file. In addition if you have a project that is closed in y
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_61424
]
Mark J. Sinke commented on MNGECLIPSE-59:
-
All right - here you go. A corrected patch file. This time I checked the
contents and they look benign. So have a go and let me k
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_61396
]
Mark J. Sinke commented on MNGECLIPSE-59:
-
Jochen,
I apologize for the issue with the patch file. I'll try and fix the patch this
weekend or the Monday after and upload a
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_61392
]
Jochen Kuhnle commented on MNGECLIPSE-59:
-
I tried applying the attached patch (EclipseArtifactResolver.patch), but it
seems garbled starting with line 862. Looks like a co
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_61240
]
Mark J. Sinke commented on MNGECLIPSE-59:
-
In order to use the patch, you need to use a newer version of the embedder jar
file. Uploaded as well. As soon as the embedder pa
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_61231
]
Mark J. Sinke commented on MNGECLIPSE-59:
-
I took the liberty to resolve the problem of workspace artifact resolution. The
attached patch file has it all.
The way it works
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_60540
]
Eugene Kuleshov commented on MNGECLIPSE-59:
---
The plan is to always use code from Workspace if version matches. It won't be
necessary to have anything special in pom. Thou
69 matches
Mail list logo
