Re: [PR] [MNG-7541] Implement powershell command [maven]

2024-04-28 Thread via GitHub
michael-o commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1582075348 ## apache-maven/src/assembly/shared/validate.ps1: ## @@ -0,0 +1,53 @@ +<# +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

Re: [PR] [MNG-7541] Implement powershell command [maven]

2024-04-28 Thread via GitHub
michael-o commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1582075212 ## apache-maven/src/assembly/shared/mvnvalidate.ps1: ## @@ -0,0 +1,7 @@ +# check mvn home +$MAVEN_HOME = (Get-Item $PSScriptRoot).Parent + +# check if maven command

Re: [PR] [MNG-7541] Implement powershell command [maven]

2024-04-28 Thread via GitHub
michael-o commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1582075040 ## apache-maven/src/assembly/shared/init.ps1: ## @@ -0,0 +1,83 @@ +# END VALIDATION + +$CLASSWORLDS_CONF = "$MAVEN_HOME\bin\m2.conf" + +# Find the project

Re: [PR] [MNG-7541] Implement powershell command [maven]

2024-04-16 Thread via GitHub
JurrianFahner commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1567902958 ## apache-maven/src/assembly/shared/validate.ps1: ## @@ -0,0 +1,53 @@ +<# +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

Re: [PR] [MNG-7541] Implement powershell command [maven]

2024-04-16 Thread via GitHub
JurrianFahner commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1567900347 ## apache-maven/src/assembly/shared/mvnvalidate.ps1: ## @@ -0,0 +1,7 @@ +# check mvn home +$MAVEN_HOME = (Get-Item $PSScriptRoot).Parent + +# check if maven command

Re: [PR] [MNG-7541] Implement powershell command [maven]

2024-04-16 Thread via GitHub
JurrianFahner commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1567897655 ## apache-maven/src/assembly/shared/init.ps1: ## @@ -0,0 +1,83 @@ +# END VALIDATION + +$CLASSWORLDS_CONF = "$MAVEN_HOME\bin\m2.conf" + +# Find the project

Re: [PR] [MNG-7541] Implement powershell command [maven]

2024-04-15 Thread via GitHub
michael-o commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1565386307 ## apache-maven/src/assembly/shared/init.ps1: ## @@ -0,0 +1,83 @@ +# END VALIDATION + +$CLASSWORLDS_CONF = "$MAVEN_HOME\bin\m2.conf" + +# Find the project

Re: [PR] [MNG-7541] Implement powershell command [maven]

2023-10-14 Thread via GitHub
JurrianFahner commented on PR #878: URL: https://github.com/apache/maven/pull/878#issuecomment-1763182870 > It would be nice to fix the command terminal title, the rest LGTM I've created an issue to improve the command terminal title: https://issues.apache.org/jira/browse/MNG-7907

Re: [PR] [MNG-7541] Implement powershell command [maven]

2023-10-13 Thread via GitHub
Giovds commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1358102359 ## apache-maven/src/assembly/shared/validate.ps1: ## @@ -0,0 +1,53 @@ +<# +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

Re: [PR] [MNG-7541] Implement powershell command [maven]

2023-10-13 Thread via GitHub
michael-o commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1358087993 ## apache-maven/src/assembly/shared/validate.ps1: ## @@ -0,0 +1,53 @@ +<# +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

Re: [PR] [MNG-7541] Implement powershell command [maven]

2023-10-13 Thread via GitHub
Giovds commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1358084618 ## apache-maven/src/assembly/shared/validate.ps1: ## @@ -0,0 +1,53 @@ +<# +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

Re: [PR] [MNG-7541] Implement powershell command [maven]

2023-10-13 Thread via GitHub
Giovds commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1358075540 ## apache-maven/src/assembly/shared/init.ps1: ## @@ -0,0 +1,83 @@ +# END VALIDATION + +$CLASSWORLDS_CONF = "$MAVEN_HOME\bin\m2.conf" Review Comment: Should

Re: [PR] [MNG-7541] Implement powershell command [maven]

2023-10-13 Thread via GitHub
Giovds commented on code in PR #878: URL: https://github.com/apache/maven/pull/878#discussion_r1358059984 ## apache-maven/src/assembly/maven/bin/mvnDebug.ps1: ## @@ -0,0 +1,43 @@ +<# +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license