Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]

2024-04-20 Thread via GitHub
olamy commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067829609 > you should just search global "artefact" and fix :) > Both are correct it only depends if we consider speaking English from UK or English from US But hey

[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839303#comment-17839303 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- olamy commented on PR #104: URL:

Re: [PR] Add option: `maven.build.cache.forceRenew` [maven-build-cache-extension]

2024-04-20 Thread via GitHub
zorglube commented on PR #137: URL: https://github.com/apache/maven-build-cache-extension/pull/137#issuecomment-2067805611 Damn I didn't understood that. Do you have any examples of the configuration needed to achieve that? -- This is an automated message from the Apache Git

[PR] Enable GitHUb issues [maven-apache-parent]

2024-04-20 Thread via GitHub
slawekjaranowski opened a new pull request, #216: URL: https://github.com/apache/maven-apache-parent/pull/216 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Enable GitHUb issues [maven-parent]

2024-04-20 Thread via GitHub
slawekjaranowski opened a new pull request, #175: URL: https://github.com/apache/maven-parent/pull/175 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add option: `maven.build.cache.forceRenew` [maven-build-cache-extension]

2024-04-20 Thread via GitHub
AlexanderAshitkin commented on PR #137: URL: https://github.com/apache/maven-build-cache-extension/pull/137#issuecomment-2067799173 Hi @zorglube You are likely looking for the `maven.build.cache.skipCache` property. If the property is set to true, the build doesn't use any of the

[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839294#comment-17839294 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- AlexanderAshitkin commented on PR #104: URL:

Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]

2024-04-20 Thread via GitHub
AlexanderAshitkin commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067786122 Hi, @kbuntrock @hboutemy. This PR looks good. How can we move it from a draft to an open state? -- This is an automated message from the Apache Git

Re: [PR] [PR-103] A "mandatory clean" option to enable the caching functionnality [maven-build-cache-extension]

2024-04-20 Thread via GitHub
AlexanderAshitkin commented on code in PR #103: URL: https://github.com/apache/maven-build-cache-extension/pull/103#discussion_r1573409460 ## src/test/java/org/apache/maven/buildcache/util/LogFileUtils.java: ## @@ -60,4 +61,32 @@ public static String

Re: [PR] [PR-103] A "mandatory clean" option to enable the caching functionnality [maven-build-cache-extension]

2024-04-20 Thread via GitHub
AlexanderAshitkin commented on code in PR #103: URL: https://github.com/apache/maven-build-cache-extension/pull/103#discussion_r1573409460 ## src/test/java/org/apache/maven/buildcache/util/LogFileUtils.java: ## @@ -60,4 +61,32 @@ public static String

Re: [PR] Add Release Drafter [maven-parent]

2024-04-20 Thread via GitHub
slawekjaranowski merged PR #174: URL: https://github.com/apache/maven-parent/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (MNG-8094) Resolver 1.9.19

2024-04-20 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8094. Resolution: Fixed > Resolver 1.9.19 > --- > > Key: MNG-8094 >

[jira] [Commented] (MNG-8094) Resolver 1.9.19

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839286#comment-17839286 ] ASF GitHub Bot commented on MNG-8094: - cstamas merged PR #1468: URL:

Re: [PR] [MNG-8094] Resolver 1.9.19 [maven]

2024-04-20 Thread via GitHub
cstamas merged PR #1468: URL: https://github.com/apache/maven/pull/1468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNG-8011) Minimize and make generic the README.txt

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839285#comment-17839285 ] ASF GitHub Bot commented on MNG-8011: - cstamas merged PR #1470: URL:

[jira] [Closed] (MNG-8030) Backport: Add ability to ignore dependency repositories: mvn -itr

2024-04-20 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8030. Resolution: Fixed > Backport: Add ability to ignore dependency repositories: mvn -itr >

Re: [PR] [MNG-8030] Backport itr: ignore transitive repositories [maven]

2024-04-20 Thread via GitHub
cstamas merged PR #1469: URL: https://github.com/apache/maven/pull/1469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (MNG-8011) Minimize and make generic the README.txt

2024-04-20 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8011. Resolution: Fixed > Minimize and make generic the README.txt >

[jira] [Commented] (MNG-8030) Backport: Add ability to ignore dependency repositories: mvn -itr

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839284#comment-17839284 ] ASF GitHub Bot commented on MNG-8030: - cstamas merged PR #1469: URL:

Re: [PR] [MNG-8011] Neuter the README [maven]

2024-04-20 Thread via GitHub
cstamas merged PR #1470: URL: https://github.com/apache/maven/pull/1470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839283#comment-17839283 ] ASF GitHub Bot commented on MNG-8031: - cstamas merged PR #1471: URL:

[jira] [Closed] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly

2024-04-20 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8031. Resolution: Fixed > Backport: Make Maven transfer listener used with Resolver more concurrent >

Re: [PR] [MNG-8031] Backport concurrent friendly transport listener [maven]

2024-04-20 Thread via GitHub
cstamas merged PR #1471: URL: https://github.com/apache/maven/pull/1471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNG-8100) Upgrade default plugin bindings

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839277#comment-17839277 ] ASF GitHub Bot commented on MNG-8100: - slawekjaranowski merged PR #1474: URL:

Re: [PR] [MNG-8100] Upgrade default plugin bindings [maven]

2024-04-20 Thread via GitHub
slawekjaranowski merged PR #1474: URL: https://github.com/apache/maven/pull/1474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [MNG-8100] Upgrade default plugin bindings - fix ITs [maven-integration-testing]

2024-04-20 Thread via GitHub
slawekjaranowski merged PR #335: URL: https://github.com/apache/maven-integration-testing/pull/335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add Release Drafter [maven-apache-parent]

2024-04-20 Thread via GitHub
slawekjaranowski merged PR #215: URL: https://github.com/apache/maven-apache-parent/pull/215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Make our lives simpler: mvnd is Java17 [maven-mvnd]

2024-04-20 Thread via GitHub
gnodet commented on PR #956: URL: https://github.com/apache/maven-mvnd/pull/956#issuecomment-2067761716 > But, locally am not building native, so how does mvnd work for me then? The native binary is preferred when available. Then `java-mvnd` is used to run mvnd in JVM mode and JDK

Re: [PR] Make our lives simpler: mvnd is Java17 [maven-mvnd]

2024-04-20 Thread via GitHub
cstamas commented on PR #956: URL: https://github.com/apache/maven-mvnd/pull/956#issuecomment-2067756679 But, locally am not building native, so how does mvnd work for me then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (MNG-8101) Upgrade Parent to 42

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839273#comment-17839273 ] ASF GitHub Bot commented on MNG-8101: - slawekjaranowski merged PR #1473: URL:

Re: [PR] [MNG-8101] Upgrade Parent to 42 [maven]

2024-04-20 Thread via GitHub
slawekjaranowski merged PR #1473: URL: https://github.com/apache/maven/pull/1473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839272#comment-17839272 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on PR #150:

Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]

2024-04-20 Thread via GitHub
michael-o commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2067752090 Rename to `SiteSourceDirectory`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839271#comment-17839271 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on code in PR

Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]

2024-04-20 Thread via GitHub
michael-o commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573364171 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -260,9 +279,9 @@ public void

Re: [I] Make mvnd Java17 [maven-mvnd]

2024-04-20 Thread via GitHub
gnodet commented on issue #954: URL: https://github.com/apache/maven-mvnd/issues/954#issuecomment-2067749362 > Fully. So both m39 and m40 should require Java17. This is basically to simplify our own lives, and easier maintain. Maven4 is already Java17. If someone must have Java8 to build,

[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839269#comment-17839269 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on PR #150:

Re: [I] Make client thin [maven-mvnd]

2024-04-20 Thread via GitHub
gnodet commented on issue #955: URL: https://github.com/apache/maven-mvnd/issues/955#issuecomment-2067748092 The goal is to fully respect what the user environment as usually loaded by maven. The compatibility is defined by two simple things: * the JVM path (a `String`) * a

[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839268#comment-17839268 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on code in PR

Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]

2024-04-20 Thread via GitHub
michael-o commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2067747899 @hboutemy Any comments on the binary compat? I am OK to break it since it this is a major version and the sole public user is Maven Site Plugin... -- This is an

Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]

2024-04-20 Thread via GitHub
michael-o commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573361548 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -271,7 +290,7 @@ public void

[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839266#comment-17839266 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on code in PR

[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839267#comment-17839267 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- michael-o commented on code in PR

Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]

2024-04-20 Thread via GitHub
michael-o commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573358826 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -260,9 +279,9 @@ public void

Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]

2024-04-20 Thread via GitHub
michael-o commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573358753 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -260,9 +279,9 @@ public void

[jira] [Resolved] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-04-20 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved DOXIASITETOOLS-324. Fix Version/s: 2.0.0 2.0.0-M18

Re: [PR] Default value must be manually handled [maven-mvnd]

2024-04-20 Thread via GitHub
cstamas commented on PR #953: URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2067741336 The code change is OK and fixes issue, but something is wrong. Created https://github.com/apache/maven-mvnd/issues/957 -- This is an automated message from the Apache Git Service.

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839265#comment-17839265 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin merged PR #140: URL:

[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839264#comment-17839264 ] ASF GitHub Bot commented on DOXIASITETOOLS-336: --- kwin commented on code in PR #150:

Re: [PR] [DOXIASITETOOLS-324] Allow configuration of parsers [maven-doxia-sitetools]

2024-04-20 Thread via GitHub
kwin merged PR #140: URL: https://github.com/apache/maven-doxia-sitetools/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]

2024-04-20 Thread via GitHub
kwin commented on code in PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573354321 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java: ## @@ -271,7 +290,7 @@ public void addSiteDirectory(File

[I] Make client thin [maven-mvnd]

2024-04-20 Thread via GitHub
cstamas opened a new issue, #955: URL: https://github.com/apache/maven-mvnd/issues/955 Currently there is some heavy logic in client, but IMHO it is superfluous. Instead, make client thin as possible: * it should collect all maven config and create "seed" (ie. by hashing these things

[I] Make mvnd Java17 [maven-mvnd]

2024-04-20 Thread via GitHub
cstamas opened a new issue, #954: URL: https://github.com/apache/maven-mvnd/issues/954 Fully. So both m39 and m40 should require Java17. This is basically this simplify our own lives, and easier maintain. Maven4 is already Java17. If someone must have Java8 to build, should use Maven

[jira] [Commented] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839263#comment-17839263 ] ASF GitHub Bot commented on MNG-8031: - cstamas commented on code in PR #1471: URL:

Re: [PR] [MNG-8031] Backport concurrent friendly transport listener [maven]

2024-04-20 Thread via GitHub
cstamas commented on code in PR #1471: URL: https://github.com/apache/maven/pull/1471#discussion_r1573344072 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839259#comment-17839259 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- hboutemy commented on code in PR #104: URL:

Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]

2024-04-20 Thread via GitHub
hboutemy commented on code in PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#discussion_r1573334304 ## src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java: ## @@ -92,16 +92,17 @@ import static

[jira] [Updated] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated MBUILDCACHE-86: -- Labels: pull-request-available (was: ) > Bugfix and enhancements with the

[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839258#comment-17839258 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- hboutemy commented on PR #104: URL:

Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]

2024-04-20 Thread via GitHub
hboutemy commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067720981 @kbuntrock I see you created MBUILDCACHE-86 and renamed the PR title can you also update the Git commit to `[MBUILDCACHE-86]` instead of `[PR-104]` please? --

[jira] [Commented] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839257#comment-17839257 ] ASF GitHub Bot commented on MNG-8031: - CrazyHZM commented on code in PR #1471: URL:

Re: [PR] [MNG-8031] Backport concurrent friendly transport listener [maven]

2024-04-20 Thread via GitHub
CrazyHZM commented on code in PR #1471: URL: https://github.com/apache/maven/pull/1471#discussion_r1573331701 ## maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (MSHADE-472) upgrade parent POM

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839253#comment-17839253 ] ASF GitHub Bot commented on MSHADE-472: --- hboutemy merged PR #222: URL:

[jira] [Closed] (MSHADE-472) upgrade parent POM

2024-04-20 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MSHADE-472. Assignee: Herve Boutemy Resolution: Fixed > upgrade parent POM > -- > >

Re: [PR] [MSHADE-472] upgrade parent POM [maven-shade-plugin]

2024-04-20 Thread via GitHub
hboutemy merged PR #222: URL: https://github.com/apache/maven-shade-plugin/pull/222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MSHADE-472) upgrade parent POM

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839252#comment-17839252 ] ASF GitHub Bot commented on MSHADE-472: --- hboutemy opened a new pull request, #222: URL:

[jira] [Created] (MSHADE-472) upgrade parent POM

2024-04-20 Thread Herve Boutemy (Jira)
Herve Boutemy created MSHADE-472: Summary: upgrade parent POM Key: MSHADE-472 URL: https://issues.apache.org/jira/browse/MSHADE-472 Project: Maven Shade Plugin Issue Type: Task Affects

[jira] [Commented] (MSHADE-471) still timestamp issues with timezones (DST?)

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839250#comment-17839250 ] ASF GitHub Bot commented on MSHADE-471: --- hboutemy commented on PR #220: URL:

Re: [PR] [MSHADE-471] deal with DST [maven-shade-plugin]

2024-04-20 Thread via GitHub
hboutemy commented on PR #220: URL: https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067704248 disagree: tests show reproducible builds independent from TZ = what they are supposed to be you are looking for something else: detail what you are looking for and work

Re: [PR] [MSHADE-471] deal with DST [maven-shade-plugin]

2024-04-20 Thread via GitHub
rmannibucau commented on PR #220: URL: https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067699038 * reproducible tests don't check the time is accurate whatever the timezone is (it is the opposite as shown by the test) * UTC tests do not use UTC time so they are iso

[jira] [Commented] (MSHADE-471) still timestamp issues with timezones (DST?)

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839248#comment-17839248 ] ASF GitHub Bot commented on MSHADE-471: --- rmannibucau commented on PR #220: URL:

[jira] [Commented] (MSHADE-471) still timestamp issues with timezones (DST?)

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839246#comment-17839246 ] ASF GitHub Bot commented on MSHADE-471: --- hboutemy commented on PR #220: URL:

Re: [PR] [MSHADE-471] deal with DST [maven-shade-plugin]

2024-04-20 Thread via GitHub
hboutemy commented on PR #220: URL: https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067694954 test done with Reproducible Central: https://github.com/hboutemy/reproducible-central/tree/MSHADE-471/MSHADE-471 tests that using UTC does not any more get a different

[PR] Add Release Drafter [maven-parent]

2024-04-20 Thread via GitHub
slawekjaranowski opened a new pull request, #174: URL: https://github.com/apache/maven-parent/pull/174 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Add Release Drafter [maven-apache-parent]

2024-04-20 Thread via GitHub
slawekjaranowski opened a new pull request, #215: URL: https://github.com/apache/maven-apache-parent/pull/215 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

2024-04-20 Thread via GitHub
wendigo commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067648142 Adding `-Dmodernizer.violationsFile=${session.rootDirectory}/.mvn/modernizer/violations.xml` to the `.mvn/maven.config` ends with the exception: ``` [ERROR] Failed to execute

Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

2024-04-20 Thread via GitHub
wendigo commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067647836 @cstamas unfortunately still doesn't work for our case. I've tried reapplying: https://github.com/trinodb/trino/commit/ff1cddbd31d70610952922b19c13bd957e33f00f and that works in mvn

Re: [PR] Default value must be manually handled [maven-mvnd]

2024-04-20 Thread via GitHub
cstamas commented on PR #953: URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2067647961 Am adding IT (something I'd done initially would catch this), and will merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Default value must be manually handled [maven-mvnd]

2024-04-20 Thread via GitHub
wendigo commented on PR #953: URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2067647580 That works :) Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]

2024-04-20 Thread via GitHub
cstamas commented on PR #916: URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2067646317 Def value handling here https://github.com/apache/maven-mvnd/pull/953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (MNG-8100) Upgrade default plugin bindings

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839224#comment-17839224 ] ASF GitHub Bot commented on MNG-8100: - slawekjaranowski opened a new pull request, #1474: URL:

[PR] [MNG-8100] Upgrade default plugin bindings [maven]

2024-04-20 Thread via GitHub
slawekjaranowski opened a new pull request, #1474: URL: https://github.com/apache/maven/pull/1474 https://issues.apache.org/jira/browse/MNG-8100 https://github.com/apache/maven-integration-testing/pull/335 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]

2024-04-20 Thread via GitHub
wendigo commented on PR #916: URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2067641748 Just tested the master build with Trino and it seems to ignore the default property value for `MVND_CORE_EXTENSIONS_EXCLUDE` while the explicitly passed `-Dmvnd.coreExtensionsExclude`

Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]

2024-04-20 Thread via GitHub
cstamas commented on PR #916: URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2067640854 ``` [INFO] [ERROR] class io.takari.maven.builder.smart.DependencyGraph cannot be cast to class

[jira] [Commented] (MNG-8101) Upgrade Parent to 42

2024-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839217#comment-17839217 ] ASF GitHub Bot commented on MNG-8101: - slawekjaranowski opened a new pull request, #1473: URL:

Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

2024-04-20 Thread via GitHub
wendigo commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067628962 Will do @cstamas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]

2024-04-20 Thread via GitHub
cstamas commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067628217 @wendigo Would be grateful if you build mvnd locally and try it with Trino build, it should now work OOTB. No need for native and all that, just `mvn clean install` and use it on Trino

[PR] [MNG-8100] Upgrade default plugin bindings - fix ITs [maven-integration-testing]

2024-04-20 Thread via GitHub
slawekjaranowski opened a new pull request, #335: URL: https://github.com/apache/maven-integration-testing/pull/335 https://issues.apache.org/jira/browse/MNG-8100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Update GitHub actions to v4 [maven]

2024-04-20 Thread via GitHub
slawekjaranowski merged PR #1472: URL: https://github.com/apache/maven/pull/1472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [MNG-8100] Upgrade default plugin bindings - fix ITs [maven-integration-testing]

2024-04-20 Thread via GitHub
slawekjaranowski opened a new pull request, #334: URL: https://github.com/apache/maven-integration-testing/pull/334 https://issues.apache.org/jira/browse/MNG-8100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the