[jira] [Commented] (METRON-1816) Date format Stellar function

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655951#comment-16655951 ] ASF GitHub Bot commented on METRON-1816: Github user asfgit closed the pull requ

[GitHub] metron pull request #1233: METRON-1816: Date format Stellar function

2018-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1233 ---

[jira] [Commented] (METRON-1829) Large Error Message Causes Slow Search Performance

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655948#comment-16655948 ] ASF GitHub Bot commented on METRON-1829: Github user merrimanr commented on a di

[GitHub] metron pull request #1239: METRON-1829: Large Error Message Causes Slow Sear...

2018-10-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1239#discussion_r226479283 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -118,12 +118,15 @@ public void commit(Bulk

[jira] [Commented] (METRON-1829) Large Error Message Causes Slow Search Performance

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655870#comment-16655870 ] ASF GitHub Bot commented on METRON-1829: Github user nickwallen commented on a d

[GitHub] metron pull request #1239: METRON-1829: Large Error Message Causes Slow Sear...

2018-10-18 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1239#discussion_r226466569 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -118,12 +118,15 @@ public void commit(Bul

[jira] [Commented] (METRON-1829) Large Error Message Causes Slow Search Performance

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655856#comment-16655856 ] ASF GitHub Bot commented on METRON-1829: Github user merrimanr commented on a di

[GitHub] metron pull request #1239: METRON-1829: Large Error Message Causes Slow Sear...

2018-10-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1239#discussion_r226460423 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -118,12 +118,15 @@ public void commit(Bulk

[GitHub] metron pull request #1213: METRON-1681: Decouple the ParserBolt from the Par...

2018-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1213 ---

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655753#comment-16655753 ] ASF GitHub Bot commented on METRON-1681: Github user asfgit closed the pull requ

[jira] [Commented] (METRON-1823) Refactor Elasticsearch Configuration Settings

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655722#comment-16655722 ] ASF GitHub Bot commented on METRON-1823: Github user mmiklavc commented on the i

[GitHub] metron issue #1235: METRON-1823 Refactor Elasticsearch Configuration Setting...

2018-10-18 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1235 @justinleet correct, I have a number of changes that will overlap with or replace this in the ES client upgrade/migration. In particular the utils class changes. ---

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655695#comment-16655695 ] ASF GitHub Bot commented on METRON-1681: Github user justinleet commented on the

[GitHub] metron issue #1213: METRON-1681: Decouple the ParserBolt from the Parse exec...

2018-10-18 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1213 +1, thanks! ---

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655693#comment-16655693 ] ASF GitHub Bot commented on METRON-1681: Github user ottobackwards commented on

[GitHub] metron issue #1213: METRON-1681: Decouple the ParserBolt from the Parse exec...

2018-10-18 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1213 +1, ship it ---

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655685#comment-16655685 ] ASF GitHub Bot commented on METRON-1681: Github user mmiklavc commented on the i

[GitHub] metron issue #1213: METRON-1681: Decouple the ParserBolt from the Parse exec...

2018-10-18 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1213 Good suggestion @ottobackwards. lgtm @merrimanr, still +1 from me. ---

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655677#comment-16655677 ] ASF GitHub Bot commented on METRON-1681: Github user merrimanr commented on the

[GitHub] metron issue #1213: METRON-1681: Decouple the ParserBolt from the Parse exec...

2018-10-18 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1213 Latest commit adds some logging around parser initialization. Let me know what you think. ---

[jira] [Commented] (METRON-1816) Date format Stellar function

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655614#comment-16655614 ] ASF GitHub Bot commented on METRON-1816: Github user ottobackwards commented on

[GitHub] metron issue #1233: METRON-1816: Date format Stellar function

2018-10-18 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1233 +1 ---

[jira] [Commented] (METRON-1829) Large Error Message Causes Slow Search Performance

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655581#comment-16655581 ] ASF GitHub Bot commented on METRON-1829: Github user nickwallen commented on a d

[GitHub] metron pull request #1239: METRON-1829: Large Error Message Causes Slow Sear...

2018-10-18 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1239#discussion_r226386542 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -118,12 +118,15 @@ public void commit(Bul

[jira] [Commented] (METRON-1816) Date format Stellar function

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655565#comment-16655565 ] ASF GitHub Bot commented on METRON-1816: Github user merrimanr commented on a di

[GitHub] metron pull request #1233: METRON-1816: Date format Stellar function

2018-10-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1233#discussion_r226383027 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/DateFunctions.java --- @@ -109,6 +110,13 @@ public static l

[jira] [Commented] (METRON-1816) Date format Stellar function

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1669#comment-1669 ] ASF GitHub Bot commented on METRON-1816: Github user merrimanr commented on a di

[GitHub] metron pull request #1233: METRON-1816: Date format Stellar function

2018-10-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1233#discussion_r226382248 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java --- @@ -225,4 +226,36 @@ public void

[jira] [Commented] (METRON-1829) Large Error Message Causes Slow Search Performance

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1662#comment-1662 ] ASF GitHub Bot commented on METRON-1829: Github user nickwallen commented on a d

[GitHub] metron pull request #1239: METRON-1829: Large Error Message Causes Slow Sear...

2018-10-18 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1239#discussion_r226380891 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -118,12 +118,15 @@ public void commit(Bul

[jira] [Commented] (METRON-1829) Large Error Message Causes Slow Search Performance

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655543#comment-16655543 ] ASF GitHub Bot commented on METRON-1829: Github user merrimanr commented on a di

[jira] [Commented] (METRON-1829) Large Error Message Causes Slow Search Performance

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655542#comment-16655542 ] ASF GitHub Bot commented on METRON-1829: Github user merrimanr commented on a di

[GitHub] metron pull request #1239: METRON-1829: Large Error Message Causes Slow Sear...

2018-10-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1239#discussion_r226377917 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -118,12 +118,15 @@ public void commit(Bulk

[GitHub] metron pull request #1239: METRON-1829: Large Error Message Causes Slow Sear...

2018-10-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1239#discussion_r226378008 --- Diff: metron-platform/metron-writer/src/test/java/org/apache/metron/writer/BulkWriterComponentTest.java --- @@ -161,9 +165,12 @@ public void writeSh

[jira] [Commented] (METRON-1829) Large Error Message Causes Slow Search Performance

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655506#comment-16655506 ] ASF GitHub Bot commented on METRON-1829: Github user nickwallen commented on a d

[jira] [Commented] (METRON-1829) Large Error Message Causes Slow Search Performance

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655505#comment-16655505 ] ASF GitHub Bot commented on METRON-1829: Github user nickwallen commented on a d

[GitHub] metron pull request #1239: METRON-1829: Large Error Message Causes Slow Sear...

2018-10-18 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1239#discussion_r226369605 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -118,12 +118,15 @@ public void commit(Bul

[GitHub] metron pull request #1239: METRON-1829: Large Error Message Causes Slow Sear...

2018-10-18 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1239#discussion_r226371234 --- Diff: metron-platform/metron-writer/src/test/java/org/apache/metron/writer/BulkWriterComponentTest.java --- @@ -161,9 +165,12 @@ public void writeS

[jira] [Commented] (METRON-1790) Unsubscribe from every observable in the pcap panel UI component

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655287#comment-16655287 ] ASF GitHub Bot commented on METRON-1790: Github user nickwallen commented on the

[GitHub] metron issue #1208: METRON-1790: Unsubscribe from every observable in the pc...

2018-10-18 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1208 Thanks for the explanation @tiborm . @ruffle1986 - Can you create an Apache JIRA describing the next phase of this work as described by @tiborm? Pending that JIRA, I am +1 on

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655258#comment-16655258 ] ASF GitHub Bot commented on METRON-1681: Github user ottobackwards commented on

[GitHub] metron issue #1213: METRON-1681: Decouple the ParserBolt from the Parse exec...

2018-10-18 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1213 This is really nice. My only addition would be logging. I think it would be valuable for the worker log to state what parsers where loaded and running in a given topology. I think we can

[jira] [Commented] (METRON-1823) Refactor Elasticsearch Configuration Settings

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655250#comment-16655250 ] ASF GitHub Bot commented on METRON-1823: Github user justinleet commented on the

[GitHub] metron issue #1235: METRON-1823 Refactor Elasticsearch Configuration Setting...

2018-10-18 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1235 @mmiklavc You were looking at migration of some of the ES stuff, right? Is this something worth pulling in with your changes, or should we just hold off for now? ---