[
https://issues.apache.org/jira/browse/METRON-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682128#comment-16682128
]
ASF GitHub Bot commented on METRON-1865:
Github user asfgit closed the pull requ
[
https://issues.apache.org/jira/browse/METRON-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682133#comment-16682133
]
ASF GitHub Bot commented on METRON-1866:
Github user JonZeolla commented on a di
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/17#discussion_r232435113
--- Diff: README.md ---
@@ -12,24 +12,72 @@ This software is a part of the [Apache
Metron](http://metron.apache.org/) projec
##
[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682132#comment-16682132
]
ASF GitHub Bot commented on METRON-1304:
Github user JonZeolla commented on the
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
Okay, pushed that fix and merged in master.
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron-bro-plugin-kafka/pull/16
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
Yes that's why I said it depends on #16 and mentioned the order of review
should be #16 -> #2 -> #17 -> #13
---
[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682120#comment-16682120
]
ASF GitHub Bot commented on METRON-1304:
Github user JonZeolla commented on the
[
https://issues.apache.org/jira/browse/METRON-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682119#comment-16682119
]
ASF GitHub Bot commented on METRON-1740:
Github user JonZeolla commented on the
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1171
Yes, I outlined the specifics in my prior comments
---
[
https://issues.apache.org/jira/browse/METRON-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682026#comment-16682026
]
ASF GitHub Bot commented on METRON-1866:
Github user nickwallen commented on a d
[
https://issues.apache.org/jira/browse/METRON-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682037#comment-16682037
]
ASF GitHub Bot commented on METRON-1866:
Github user nickwallen commented on a d
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/17#discussion_r232417353
--- Diff: README.md ---
@@ -145,23 +217,35 @@ event bro_init() &priority=-5
Notes
* `logs_to_send` is mutually exclu
[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682033#comment-16682033
]
ASF GitHub Bot commented on METRON-1304:
Github user nickwallen commented on the
[
https://issues.apache.org/jira/browse/METRON-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682025#comment-16682025
]
ASF GitHub Bot commented on METRON-1866:
Github user nickwallen commented on a d
Github user nickwallen commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
I am getting a test failure.
```
[root@localhost ~]# bro-pkg install
http://github.com/jonzeolla/metron-bro-plugin-kafka --version=METRON-1304
The following packages will
[
https://issues.apache.org/jira/browse/METRON-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682030#comment-16682030
]
ASF GitHub Bot commented on METRON-1865:
Github user nickwallen commented on the
Github user nickwallen commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/16
+1 Thanks!
I was able to test like this...
```
bro-pkg install http://github.com/jonzeolla/metron-bro-plugin-kafka
--version=METRON-1865
```
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/17#discussion_r232414752
--- Diff: README.md ---
@@ -145,23 +217,35 @@ event bro_init() &priority=-5
Notes
* `logs_to_send` is mutually exclu
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/17#discussion_r232413911
--- Diff: README.md ---
@@ -12,24 +12,72 @@ This software is a part of the [Apache
Metron](http://metron.apache.org/) projec
#
[
https://issues.apache.org/jira/browse/METRON-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681996#comment-16681996
]
ASF GitHub Bot commented on METRON-1740:
Github user nickwallen commented on the
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1171
> @JonZeolla: +0 only performed functional testing.
What testing did you do? Did you run this up against some Panos logs?
---
[
https://issues.apache.org/jira/browse/METRON-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681990#comment-16681990
]
ASF GitHub Bot commented on METRON-1740:
Github user JonZeolla commented on the
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1171
+0 only performed functional testing.
---
[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681987#comment-16681987
]
ASF GitHub Bot commented on METRON-1304:
Github user JonZeolla commented on a di
[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681988#comment-16681988
]
ASF GitHub Bot commented on METRON-1304:
Github user JonZeolla commented on a di
[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681986#comment-16681986
]
ASF GitHub Bot commented on METRON-1304:
Github user JonZeolla commented on a di
[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681985#comment-16681985
]
ASF GitHub Bot commented on METRON-1304:
Github user JonZeolla commented on a di
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r232405844
--- Diff: README.md ---
@@ -11,6 +11,32 @@ This software is a part of the [Apache
Metron](http://metron.apache.org/) projec
## I
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r232405772
--- Diff: README.md ---
@@ -42,22 +68,47 @@ This software is a part of the [Apache
Metron](http://metron.apache.org/) projec
The
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r232405800
--- Diff: README.md ---
@@ -144,23 +194,35 @@ event bro_init() &priority=-5
Notes
* `logs_to_send` is mutually exclusi
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r232405751
--- Diff: README.md ---
@@ -11,6 +11,32 @@ This software is a part of the [Apache
Metron](http://metron.apache.org/) projec
## I
[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681981#comment-16681981
]
ASF GitHub Bot commented on METRON-1304:
Github user JonZeolla commented on the
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
Suggested order of review: #16 -> #2 -> #17 -> #13
---
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/17
METRON-1866: Improve metron-bro-plugin-kafka documentation
## Contributor Comments
This depends on METRON-1304. Pure documentation change
You can merge this pull request into
[
https://issues.apache.org/jira/browse/METRON-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681977#comment-16681977
]
ASF GitHub Bot commented on METRON-1866:
GitHub user JonZeolla opened a pull req
[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681962#comment-16681962
]
ASF GitHub Bot commented on METRON-1304:
Github user JonZeolla commented on the
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
Note that this one now depends on apache/metron-bro-plugin-kafka#16 to work
properly because I split out the btest bugfix.
---
[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681959#comment-16681959
]
ASF GitHub Bot commented on METRON-1304:
Github user JonZeolla commented on the
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
Good to go on this one @nickwallen
---
[
https://issues.apache.org/jira/browse/METRON-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681946#comment-16681946
]
ASF GitHub Bot commented on METRON-1865:
GitHub user JonZeolla opened a pull req
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/16
METRON-1865: Fix metron-bro-plugin-kafka tests
## Contributor Comments
This fixes the btests which were unintentionally broken as a part of
apache/metron-bro-plugin-kafka#6.
Jon Zeolla created METRON-1865:
--
Summary: Fix metron-bro-plugin-kafka tests
Key: METRON-1865
URL: https://issues.apache.org/jira/browse/METRON-1865
Project: Metron
Issue Type: Task
R
Jon Zeolla created METRON-1866:
--
Summary: Improve metron-bro-plugin-kafka documentation
Key: METRON-1866
URL: https://issues.apache.org/jira/browse/METRON-1866
Project: Metron
Issue Type: Task
[
https://issues.apache.org/jira/browse/METRON-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681939#comment-16681939
]
ASF GitHub Bot commented on METRON-1862:
Github user JonZeolla commented on the
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/15
This should be resolved by apache/metron-bro-plugin-kafka#2 as it currently
stands, since it adds the `bro-pkg` example in the documentation and `btest`
fix which isn't otherwise ob
[
https://issues.apache.org/jira/browse/METRON-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681629#comment-16681629
]
ASF GitHub Bot commented on METRON-1862:
Github user nickwallen commented on a d
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/15#discussion_r232298989
--- Diff: README.md ---
@@ -50,7 +51,7 @@ The goal in this example is to send all HTTP and DNS
records to a Kafka topic na
* By def
[
https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681608#comment-16681608
]
ASF GitHub Bot commented on METRON-1304:
Github user nickwallen commented on the
Github user nickwallen commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
@JonZeolla Yes, I would definitely appreciate if you could break this into
separate, focused PRs.
This PR itself has been open since Nov 2017 and it seems like it has been
[
https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681536#comment-16681536
]
ASF GitHub Bot commented on METRON-1563:
Github user justinleet commented on the
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1014
@ottobackwards If it's a feature branch, the PR on Github doesn't
automatically close. It only happens for merges into a master. It's a bit
annoying, but I'm not sure there's a whole lot to do a
52 matches
Mail list logo