[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308922184 ## File path: metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/stellar/Get

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308923711 ## File path: metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/stellar/Get

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r309002330 ## File path: metron-analytics/metron-profiler-storm/src/main/config/profiler.properties ## @@ -61,6 +6

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r309003649 ## File path: metron-analytics/metron-profiler-storm/src/test/java/org/apache/metron/profiler/storm/integration/P

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r309002603 ## File path: metron-analytics/metron-profiler-storm/src/main/java/org/apache/metron/hbase/bolt/HBaseBolt.java #

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308915461 ## File path: metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/HBaseProfil

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308898766 ## File path: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/HBaseProfil

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308921540 ## File path: metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/ProfileWrit

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308910926 ## File path: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/Ver

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308999830 ## File path: metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/SaltyRowKeyB

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308921042 ## File path: metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/ProfileGene

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308897952 ## File path: dependencies_with_url.csv ## @@ -146,6 +146,7 @@ com.codahale.metrics:metrics-core:jar:3.

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r309001264 ## File path: metron-analytics/metron-profiler-spark/src/main/java/org/apache/metron/profiler/spark/function/HBas

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r309002912 ## File path: metron-analytics/metron-profiler-storm/src/test/java/org/apache/metron/hbase/bolt/Widget.java

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r309001816 ## File path: metron-analytics/metron-profiler-spark/src/test/java/org/apache/metron/profiler/spark/function/HBas

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308904532 ## File path: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/Get

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308909674 ## File path: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/Ver

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308902696 ## File path: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/ProfilerCli

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308907036 ## File path: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/Ver

[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r308906231 ## File path: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/Get

[jira] [Commented] (METRON-2195) Add defensive log level checks when constructing logs is expensive

[ https://issues.apache.org/jira/browse/METRON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896512#comment-16896512 ] Otto Fowler commented on METRON-2195: - I'm fine with however you want to slice the w

[GitHub] [metron] merrimanr commented on issue #1436: METRON-2149: Shaded jar classifier is not consistent

merrimanr commented on issue #1436: METRON-2149: Shaded jar classifier is not consistent URL: https://github.com/apache/metron/pull/1436#issuecomment-516579063 Due the the extensive testing that will be required for this, I am planning on closing and reopening against the METRON-2088-suppo

[GitHub] [metron] merrimanr closed pull request #1436: METRON-2149: Shaded jar classifier is not consistent

merrimanr closed pull request #1436: METRON-2149: Shaded jar classifier is not consistent URL: https://github.com/apache/metron/pull/1436 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [metron] merrimanr commented on issue #1462: METRON-2181: SolrDao should include aliases

merrimanr commented on issue #1462: METRON-2181: SolrDao should include aliases URL: https://github.com/apache/metron/pull/1462#issuecomment-516578530 I agree, wildcards is probably a better option here. Will open a separate PR for that. ---

[GitHub] [metron] merrimanr closed pull request #1462: METRON-2181: SolrDao should include aliases

merrimanr closed pull request #1462: METRON-2181: SolrDao should include aliases URL: https://github.com/apache/metron/pull/1462 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (METRON-2195) Add defensive log level checks when constructing logs is expensive

[ https://issues.apache.org/jira/browse/METRON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896427#comment-16896427 ] Michael Miklavcic commented on METRON-2195: --- I created and linked a separate t

[jira] [Created] (METRON-2198) Optimize JSON serialization and deserialization

Michael Miklavcic created METRON-2198: - Summary: Optimize JSON serialization and deserialization Key: METRON-2198 URL: https://issues.apache.org/jira/browse/METRON-2198 Project: Metron Is

[jira] [Comment Edited] (METRON-2195) Add defensive log level checks when constructing logs is expensive

[ https://issues.apache.org/jira/browse/METRON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896406#comment-16896406 ] Otto Fowler edited comment on METRON-2195 at 7/30/19 6:55 PM:

[jira] [Commented] (METRON-2195) Add defensive log level checks when constructing logs is expensive

[ https://issues.apache.org/jira/browse/METRON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896406#comment-16896406 ] Otto Fowler commented on METRON-2195: - Honestly, anywhere in the topology pipeline w

[jira] [Commented] (METRON-2195) Add defensive log level checks when constructing logs is expensive

[ https://issues.apache.org/jira/browse/METRON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896404#comment-16896404 ] Otto Fowler commented on METRON-2195: - There are a couple of angles to search for al

[jira] [Commented] (METRON-2195) Add defensive log level checks when constructing logs is expensive

[ https://issues.apache.org/jira/browse/METRON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896363#comment-16896363 ] Michael Miklavcic commented on METRON-2195: --- {quote}We have other on demand te

[jira] [Commented] (METRON-2195) Add defensive log level checks when constructing logs is expensive

[ https://issues.apache.org/jira/browse/METRON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896360#comment-16896360 ] Michael Miklavcic commented on METRON-2195: --- {quote}My next question is does a

[jira] [Commented] (METRON-2195) Add defensive log level checks when constructing logs is expensive

[ https://issues.apache.org/jira/browse/METRON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896338#comment-16896338 ] Otto Fowler commented on METRON-2195: - We have other on demand testing code for perf

[GitHub] [metron] sardell commented on issue #1425: METRON-2134: Add NgRx reducers to perform parser and group changes in the store

sardell commented on issue #1425: METRON-2134: Add NgRx reducers to perform parser and group changes in the store URL: https://github.com/apache/metron/pull/1425#issuecomment-516484776 +1 This is an automated message from the

[jira] [Commented] (METRON-2195) Add defensive log level checks when constructing logs is expensive

[ https://issues.apache.org/jira/browse/METRON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896263#comment-16896263 ] Michael Miklavcic commented on METRON-2195: --- We probably need to tweak that co

[jira] [Commented] (METRON-2195) Add defensive log level checks when constructing logs is expensive

[ https://issues.apache.org/jira/browse/METRON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896121#comment-16896121 ] Otto Fowler commented on METRON-2195: - As I stated in the PR, I would like to see th

[jira] [Commented] (METRON-2195) Add defensive log level checks when constructing logs is expensive

[ https://issues.apache.org/jira/browse/METRON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896117#comment-16896117 ] Dale Richardson commented on METRON-2195: - Ok, we seem to have some consensus to

[GitHub] [metron] tigerquoll commented on a change in pull request #1473: METRON-2195 rebase onto master

tigerquoll commented on a change in pull request #1473: METRON-2195 rebase onto master URL: https://github.com/apache/metron/pull/1473#discussion_r308709556 ## File path: metron-platform/metron-common/src/main/java/org/apache/metron/common/utils/LazyLogger.java ## @@ -0,0

[GitHub] [metron] ruffle1986 commented on a change in pull request #1430: METRON-2139: Refactoring sensor-parser-config.component and wire NgRx

ruffle1986 commented on a change in pull request #1430: METRON-2139: Refactoring sensor-parser-config.component and wire NgRx URL: https://github.com/apache/metron/pull/1430#discussion_r308685706 ## File path: metron-interface/metron-config/src/app/sensors/reducers/sensors.reducers

[GitHub] [metron] sardell commented on a change in pull request #1430: METRON-2139: Refactoring sensor-parser-config.component and wire NgRx

sardell commented on a change in pull request #1430: METRON-2139: Refactoring sensor-parser-config.component and wire NgRx URL: https://github.com/apache/metron/pull/1430#discussion_r308683716 ## File path: metron-interface/metron-config/src/app/sensors/reducers/sensors.reducers.ts

[GitHub] [metron] sardell commented on a change in pull request #1425: METRON-2134: Add NgRx reducers to perform parser and group changes in the store

sardell commented on a change in pull request #1425: METRON-2134: Add NgRx reducers to perform parser and group changes in the store URL: https://github.com/apache/metron/pull/1425#discussion_r308679646 ## File path: metron-interface/metron-config/src/app/sensors/reducers/sensors.r

[GitHub] [metron] sardell commented on a change in pull request #1425: METRON-2134: Add NgRx reducers to perform parser and group changes in the store

sardell commented on a change in pull request #1425: METRON-2134: Add NgRx reducers to perform parser and group changes in the store URL: https://github.com/apache/metron/pull/1425#discussion_r308679646 ## File path: metron-interface/metron-config/src/app/sensors/reducers/sensors.r