[GitHub] [metron] JonZeolla commented on pull request #1282: METRON-1881: Update the bro plugin used in metron development

2021-02-25 Thread GitBox
JonZeolla commented on pull request #1282: URL: https://github.com/apache/metron/pull/1282#issuecomment-785972885 Closing due to the official decision to move Apache Metron to the ASF attic This is an automated message from t

[GitHub] [metron] JonZeolla closed pull request #1282: METRON-1881: Update the bro plugin used in metron development

2021-02-25 Thread GitBox
JonZeolla closed pull request #1282: URL: https://github.com/apache/metron/pull/1282 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [metron-bro-plugin-kafka] JonZeolla closed pull request #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter.

2020-11-25 Thread GitBox
JonZeolla closed pull request #40: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-10-22 Thread GitBox
JonZeolla commented on pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#issuecomment-714611136 Hi @vikgmdev yeah unfortunately those are known issues. If you manually download [nitroba](https://github.com/open-nsm/course/blob/master/pcaps/nitroba.pcap?raw=

[GitHub] [metron-bro-plugin-kafka] vikgmdev edited a comment on pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-10-10 Thread GitBox
vikgmdev edited a comment on pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#issuecomment-706576041 Hey, @JonZeolla I encountered two issues when running the end to end `docker/` tests... The link to download the [nitroba.pcap](http://downloads.digi

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-10-10 Thread GitBox
vikgmdev commented on pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#issuecomment-706576041 Hey, @JonZeolla I encountered two issues when running the end to end `docker/` tests... The link to download the [nitroba.pcap](http://downloads.digitalcorp

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-10-09 Thread GitBox
JonZeolla commented on pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#issuecomment-705538753 Thanks @vikgmdev looking good. Have you tested with the end to end `docker/` tests? I think after the initial spin-up you'll need to configure the environment us

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-10-08 Thread GitBox
JonZeolla commented on pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#issuecomment-705538753 Thanks @vikgmdev looking good. Have you tested with the end to end `docker/` tests? I think after the initial spin-up you'll need to configure the environment us

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-10-01 Thread GitBox
vikgmdev commented on pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#issuecomment-702370870 Hey, @JonZeolla just noticed I had the changes since a few months ago but haven't pushed them before. We'll wait for you re-review. Thanks. --

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-10-01 Thread GitBox
vikgmdev commented on a change in pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r498486281 ## File path: README.md ## @@ -179,6 +179,48 @@ event zeek_init() &priority=-10 } ``` + Dynamically send each zeek log to a topic wi

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-09-23 Thread GitBox
vikgmdev commented on pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#issuecomment-697312918 Hi @JonZeolla hadn't the chance to push the updates. Let me retake the issue and I'll push the updates soon. Thanks a lot for your patience. -

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-09-23 Thread GitBox
JonZeolla commented on pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#issuecomment-697271265 Hi @vikgmdev thanks again for the contribution. Do you have an update? If not we will unfortunately need to mark this as abandoned

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #48: METRON-2360 BRO-PLUGIN: does not build with 3.2.1

2020-09-22 Thread GitBox
JonZeolla commented on pull request #48: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/48#issuecomment-696788728 Tests are broken because `diff` isn't installed in our zeek docker image; we need to add `diffutils`. Since it's only required for the tests which are run during

[GitHub] [metron-bro-plugin-kafka] asfgit closed pull request #48: METRON-2360 BRO-PLUGIN: does not build with 3.2.1

2020-09-22 Thread GitBox
asfgit closed pull request #48: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/48 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [metron-bro-plugin-kafka] asfgit closed pull request #48: METRON-2360 BRO-PLUGIN: does not build with 3.2.1

2020-09-22 Thread GitBox
asfgit closed pull request #48: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/48 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #48: METRON-2360 BRO-PLUGIN: does not build with 3.2.1

2020-09-22 Thread GitBox
JonZeolla commented on pull request #48: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/48#issuecomment-696788728 Tests are broken because `diff` isn't installed in our zeek docker image; we need to add `diffutils`. Since it's only required for the tests which are run during

[GitHub] [metron-bro-plugin-kafka] ottobackwards opened a new pull request #48: METRON-2360 BRO-PLUGIN: does not build with 3.2.1

2020-09-16 Thread GitBox
ottobackwards opened a new pull request #48: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/48 Cleanup namespace and includes change to newer zeek. NOTE: new zeek does not like our pcaps used with docker testing. -

[GitHub] [metron] pbhalesain closed pull request #1583: Merge pull request #1 from apache/master

2020-08-07 Thread GitBox
pbhalesain closed pull request #1583: URL: https://github.com/apache/metron/pull/1583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [metron] pbhalesain opened a new pull request #1583: Merge pull request #1 from apache/master

2020-08-07 Thread GitBox
pbhalesain opened a new pull request #1583: URL: https://github.com/apache/metron/pull/1583 merge with original ## Contributor Comments [Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.]

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-06-12 Thread GitBox
JonZeolla commented on pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#issuecomment-643479496 Hi @vikgmdev any update on this? Thanks! This is an automated message from the Apache Git Servic

[GitHub] [metron] sziszo commented on pull request #1576: METRON-2336 Stack advisor provides some components multiple times (santal)

2020-06-08 Thread GitBox
sziszo commented on pull request #1576: URL: https://github.com/apache/metron/pull/1576#issuecomment-640424335 @mmiklavc Is there anything further to do to merge? This is an automated message from the Apache Git Service. To r

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-22 Thread GitBox
JonZeolla commented on a change in pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r429223738 ## File path: README.md ## @@ -179,6 +179,48 @@ event zeek_init() &priority=-10 } ``` + Dynamically send each zeek log to a topic w

[GitHub] [metron] asfgit closed pull request #1582: METRON-2358:Fix typo in descriptions.

2020-05-22 Thread GitBox
asfgit closed pull request #1582: URL: https://github.com/apache/metron/pull/1582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [metron] ottobackwards commented on pull request #1582: METRON-2358:Fix typo in descriptions.

2020-05-22 Thread GitBox
ottobackwards commented on pull request #1582: URL: https://github.com/apache/metron/pull/1582#issuecomment-632665258 +1 thanks! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-22 Thread GitBox
ottobackwards commented on a change in pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r429198652 ## File path: README.md ## @@ -179,6 +179,48 @@ event zeek_init() &priority=-10 } ``` + Dynamically send each zeek log to a top

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-22 Thread GitBox
JonZeolla commented on a change in pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r429162878 ## File path: README.md ## @@ -179,6 +179,48 @@ event zeek_init() &priority=-10 } ``` + Dynamically send each zeek log to a topic w

[GitHub] [metron] LeeJiangchuan opened a new pull request #1582: METRON-2358:Fix typo in descriptions.

2020-05-22 Thread GitBox
LeeJiangchuan opened a new pull request #1582: URL: https://github.com/apache/metron/pull/1582 ## Contributor Comments I modified some misspelled word. So this pull request is a trivial rework without any test coverage ## Pull Request Checklist Thank you for submitting

[GitHub] [metron] ottobackwards commented on pull request #1581: [MINOR] study

2020-05-21 Thread GitBox
ottobackwards commented on pull request #1581: URL: https://github.com/apache/metron/pull/1581#issuecomment-632196780 Hi @LeeJiangchuan, thanks for the contribution. Can you change your pr title to start with the jira number? METRON-. If you have not opened a jira for this change

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-21 Thread GitBox
vikgmdev commented on a change in pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r428765442 ## File path: README.md ## @@ -179,6 +179,48 @@ event zeek_init() &priority=-10 } ``` + Dynamically send each zeek log to a topic wi

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-21 Thread GitBox
vikgmdev commented on a change in pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r428759769 ## File path: README.md ## @@ -179,6 +179,48 @@ event zeek_init() &priority=-10 } ``` + Dynamically send each zeek log to a topic wi

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-21 Thread GitBox
vikgmdev commented on a change in pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r428759024 ## File path: README.md ## @@ -179,6 +179,48 @@ event zeek_init() &priority=-10 } ``` + Dynamically send each zeek log to a topic wi

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-21 Thread GitBox
ottobackwards commented on pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#issuecomment-632103636 I have added Victor to the jira contributors role and assigned the jira to him This is an au

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-21 Thread GitBox
JonZeolla commented on a change in pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r428631726 ## File path: README.md ## @@ -179,6 +179,48 @@ event zeek_init() &priority=-10 } ``` + Dynamically send each zeek log to a topic w

[GitHub] [metron] LeeJiangchuan opened a new pull request #1581: [MINOR] study

2020-05-21 Thread GitBox
LeeJiangchuan opened a new pull request #1581: URL: https://github.com/apache/metron/pull/1581 ## Contributor Comments [Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.] I modified a misspelled wo

[GitHub] [metron-bro-plugin-kafka] vikgmdev opened a new pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-20 Thread GitBox
vikgmdev opened a new pull request #47: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/47 ## Contributor Comments [Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.] - Extends the curr

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on pull request #39: Feat/Add sensor_name to the tagged json

2020-05-20 Thread GitBox
vikgmdev commented on pull request #39: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/39#issuecomment-631637805 Hey @ottobackwards, I saw the changed this morning, It's exactly what I was looking for thanks for that! -

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #39: Feat/Add sensor_name to the tagged json

2020-05-20 Thread GitBox
ottobackwards commented on pull request #39: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/39#issuecomment-631628406 @vikgmdev https://github.com/apache/metron-bro-plugin-kafka/pull/46 has landed and will give you the functionality you are looking for I think --

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on pull request #39: Feat/Add sensor_name to the tagged json

2020-05-20 Thread GitBox
vikgmdev commented on pull request #39: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/39#issuecomment-631575681 Hi @JonZeolla, to be honest, I don't know too much about C++ but It's a good opportunity to learn, so take me into account for contributions, do you have a backlog

[GitHub] [metron-bro-plugin-kafka] asfgit closed pull request #46: METRON-2343 Bro Kafka plugin - ability to dynamically modify JSON

2020-05-19 Thread GitBox
asfgit closed pull request #46: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #46: METRON-2343 Bro Kafka plugin - ability to dynamically modify JSON

2020-05-19 Thread GitBox
JonZeolla commented on pull request #46: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/46#issuecomment-631134572 LGTM +1 thanks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #46: METRON-2343 Bro Kafka plugin - ability to dynamically modify JSON

2020-05-19 Thread GitBox
ottobackwards commented on pull request #46: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/46#issuecomment-631090146 I think that jira captures why the change is beyond this pr This is an automated message from

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #46: METRON-2343 Bro Kafka plugin - ability to dynamically modify JSON

2020-05-19 Thread GitBox
ottobackwards commented on pull request #46: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/46#issuecomment-631089959 https://issues.apache.org/jira/browse/METRON-2356 <-- @JonZeolla This is an automated messag

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #46: METRON-2343 Bro Kafka plugin - ability to dynamically modify JSON

2020-05-19 Thread GitBox
JonZeolla commented on pull request #46: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/46#issuecomment-631050619 Looks good. Noticed we are lacking btests - I'm fine with having that as a follow-on. +1 pending JIRA creation

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #46: METRON-2343 Bro Kafka plugin - ability to dynamically modify JSON

2020-05-19 Thread GitBox
ottobackwards commented on a change in pull request #46: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/46#discussion_r427535179 ## File path: README.md ## @@ -224,6 +224,22 @@ event zeek_init() &priority=-10 } ``` +### Example 6 - Add static values to each ou

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #46: METRON-2343 Bro Kafka plugin - ability to dynamically modify JSON

2020-05-19 Thread GitBox
JonZeolla commented on a change in pull request #46: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/46#discussion_r427518350 ## File path: scripts/init.zeek ## @@ -53,6 +53,14 @@ export { ["metadata.broker.list"] = "localhost:9092" ) &red

[GitHub] [metron-bro-plugin-kafka] ottobackwards opened a new pull request #46: METRON-2343 Bro Kafka plugin - ability to dynamically modify JSON

2020-05-19 Thread GitBox
ottobackwards opened a new pull request #46: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/46 Add the ability to define static json fields and values to be added to the top level object when tagged_json is T. ### Testing - run_end_to_end.sh - look at any of the

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #39: Feat/Add sensor_name to the tagged json

2020-05-19 Thread GitBox
JonZeolla commented on pull request #39: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/39#issuecomment-630714126 Hi, checking in to see how things are coming along and if you were interested in contributing to the package 😁 --

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter.

2020-05-19 Thread GitBox
JonZeolla commented on pull request #40: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/40#issuecomment-630712041 As much as I would love to get this in, I have to mark it as abandoned. I'll be closing this soon if there's no response ---

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #45: METRON-2353: Plugin e2e tests should support multiple brokers

2020-05-18 Thread GitBox
ottobackwards commented on pull request #45: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/45#issuecomment-630470979 Great work @JonZeolla, thanks! This is an automated message from the Apache Git Service. To r

[GitHub] [metron-bro-plugin-kafka] asfgit closed pull request #45: METRON-2353: Plugin e2e tests should support multiple brokers

2020-05-18 Thread GitBox
asfgit closed pull request #45: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #45: METRON-2353: Plugin e2e tests should support multiple brokers

2020-05-18 Thread GitBox
JonZeolla commented on pull request #45: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/45#issuecomment-630408339 @ottobackwards ready for review now. In troubleshooting some issues running this up locally I found that I was hitting the consumer timeout; hence increasing it

[GitHub] [metron] asfgit closed pull request #1580: METRON-2348 fix prepare-commit

2020-05-17 Thread GitBox
asfgit closed pull request #1580: URL: https://github.com/apache/metron/pull/1580 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [metron] JonZeolla commented on pull request #1580: METRON-2348 fix prepare-commit

2020-05-17 Thread GitBox
JonZeolla commented on pull request #1580: URL: https://github.com/apache/metron/pull/1580#issuecomment-629842633 +1 stands This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [metron] ottobackwards commented on pull request #1580: METRON-2348 fix prepare-commit

2020-05-17 Thread GitBox
ottobackwards commented on pull request #1580: URL: https://github.com/apache/metron/pull/1580#issuecomment-629804321 @JonZeolla one last check please This is an automated message from the Apache Git Service. To respond to th

[GitHub] [metron] JonZeolla commented on pull request #1580: METRON-2348 fix prepare-commit

2020-05-06 Thread GitBox
JonZeolla commented on pull request #1580: URL: https://github.com/apache/metron/pull/1580#issuecomment-624664769 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-06 Thread GitBox
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-624657441 That's just a side effect of our merging process, which doesn't use the github built-ins. This was squash merged as 587e9dac9b915f7d0c1116a4432447b5d92e mean

[GitHub] [metron-bro-plugin-kafka] dcode commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-06 Thread GitBox
dcode commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-624639843 @JonZeolla thanks for the heads up. @rocknsm does still use this plugin. Looks like this PR was closed without merging though? Is this still happening? -

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #12: METRON-1817: Remove bro package dependency on bro source

2020-05-05 Thread GitBox
ottobackwards commented on pull request #12: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/12#issuecomment-624390051 +1, ship it This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter.

2020-05-05 Thread GitBox
JonZeolla commented on pull request #40: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/40#issuecomment-624383143 Also please align the title of the PR exactly with your [JIRA](https://issues.apache.org/jira/browse/METRON-2309) ---

[GitHub] [metron-bro-plugin-kafka] JonZeolla edited a comment on pull request #8: METRON-1768: Adjust versioning of metron-bro-plugin-kafka to be x.y.z

2020-05-05 Thread GitBox
JonZeolla edited a comment on pull request #8: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/8#issuecomment-425690228 This is on hold, pending https://github.com/zeek/zeek/issues/152 This is an automated messag

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter.

2020-05-05 Thread GitBox
JonZeolla commented on pull request #40: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/40#issuecomment-624373988 @mauropalumbo75 the issue you were seeing was fixed as of 587e9da and I just confirmed that everything is now passing on this branch. I would love to get th

[GitHub] [metron] ottobackwards commented on a change in pull request #1580: METRON-2348 fix prepare-commit

2020-05-05 Thread GitBox
ottobackwards commented on a change in pull request #1580: URL: https://github.com/apache/metron/pull/1580#discussion_r420479572 ## File path: dev-utilities/committer-utils/metron-committer-common ## @@ -135,8 +135,8 @@ function read_pull_request { exit 1 fi -

[GitHub] [metron] JonZeolla commented on a change in pull request #1580: METRON-2348 fix prepare-commit

2020-05-05 Thread GitBox
JonZeolla commented on a change in pull request #1580: URL: https://github.com/apache/metron/pull/1580#discussion_r420477673 ## File path: dev-utilities/committer-utils/metron-committer-common ## @@ -135,8 +135,8 @@ function read_pull_request { exit 1 fi -if [

[GitHub] [metron] JonZeolla commented on a change in pull request #1580: METRON-2348 fix prepare-commit

2020-05-05 Thread GitBox
JonZeolla commented on a change in pull request #1580: URL: https://github.com/apache/metron/pull/1580#discussion_r420477673 ## File path: dev-utilities/committer-utils/metron-committer-common ## @@ -135,8 +135,8 @@ function read_pull_request { exit 1 fi -if [

[GitHub] [metron] JonZeolla commented on a change in pull request #1580: METRON-2348 fix prepare-commit

2020-05-05 Thread GitBox
JonZeolla commented on a change in pull request #1580: URL: https://github.com/apache/metron/pull/1580#discussion_r420477673 ## File path: dev-utilities/committer-utils/metron-committer-common ## @@ -135,8 +135,8 @@ function read_pull_request { exit 1 fi -if [

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
ottobackwards commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-624366596 for the love of puppies, merge this already This is an automated message from the Apache Git

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420364150 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420359510 ## File path: README.md ## @@ -63,11 +63,11 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec ### Man

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420304901 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg`

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420299628 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420274006 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg`

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420178988 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420173786 ## File path: README.md ## @@ -63,11 +63,11 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec ###

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420173561 ## File path: README.md ## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg`

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-624043661 @ottobackwards Unit tests and e2e are both passing now. This is an automated message from the Apa

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420092815 ## File path: README.md ## @@ -12,68 +12,68 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec ## Inst

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623701958 End to end tests are succeeding, but the unit tests appear to be failing so that needs addressed. Converting this PR to a draft since it's still WIP it seems.

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox
JonZeolla commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r419702207 ## File path: README.md ## @@ -12,68 +12,68 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec ## Inst

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623645487 My concern with writing it in a README is that it would be prone to being incorrect. In `zkg.meta` do we say it requires `zeek >=3.0.0`. I tested against 3.0.5

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623587568 Done This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox
ottobackwards commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623586512 We should mention specifically in the PR description that we are updating to zeek version X. If this is the PR that does it

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #8: METRON-1768: Adjust versioning of metron-bro-plugin-kafka to be x.y.z

2020-05-04 Thread GitBox
JonZeolla commented on pull request #8: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/8#issuecomment-623586297 This is no longer waiting on a 3.0 release. Depends on #44 This is an automated message from the

[GitHub] [metron-bro-plugin-kafka] JonZeolla opened a new pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox
JonZeolla opened a new pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44 ## Contributor Comments This is a breaking change in order to update the plugin to work with more recent versions of zeek (previously bro). There were a few cascading issues that req

[GitHub] [metron] ottobackwards commented on pull request #1580: METRON-2348 fix prepare-commit

2020-05-01 Thread GitBox
ottobackwards commented on pull request #1580: URL: https://github.com/apache/metron/pull/1580#issuecomment-622401627 @JonZeolla can you check the latest. If we can't commit when unstable, we can't fix anything. This is an

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter.

2020-04-29 Thread GitBox
JonZeolla commented on pull request #40: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/40#issuecomment-621417174 Hi @mauropalumbo75 thanks again for the contribution. Can you rebase this on master and see if the e2e tests pass? It should include the `btest`s within Docker

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #43: METRON-2349: [BRO-PLUGIN-KAFKA] Fix hard coded topic_name in e2e tests

2020-04-29 Thread GitBox
JonZeolla commented on pull request #43: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/43#issuecomment-621396855 Force pushed to rebase on master without merge conflicts. This is an automated message from the A

[GitHub] [metron] JonZeolla commented on pull request #1580: METRON-2348 fix prepare-commit

2020-04-29 Thread GitBox
JonZeolla commented on pull request #1580: URL: https://github.com/apache/metron/pull/1580#issuecomment-621391223 FYI tested this to merge apache/metron-bro-plugin-kafka#42 successfully. This is an automated message from the

[GitHub] [metron-bro-plugin-kafka] JonZeolla opened a new pull request #43: METRON-2349: [BRO-PLUGIN-KAFKA] Fix hard coded topic_name in e2e tests

2020-04-29 Thread GitBox
JonZeolla opened a new pull request #43: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/43 ## Contributor Comments Fixes e2e tests when a custom kafka topic is specified. Previously everything would have completed without error, but the bro container would have sent to a h

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-29 Thread GitBox
ottobackwards commented on pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#issuecomment-621382174 +1 nice work This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-29 Thread GitBox
JonZeolla commented on pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#issuecomment-621380805 Ok, back to you @ottobackwards should have addressed all of your feedback now This is an automate

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-29 Thread GitBox
JonZeolla commented on pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#issuecomment-621248256 Thanks - give me a bit to wrap up responses to your feedback, hopefully I'll get time in the next couple of days. ---

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-29 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417359367 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#issuecomment-620974069 I am +1 on this. Review and run, seems good to me. The wait for it can be a follow on. Please create a jira. -

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417050898 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417050675 ## File path: docker/containers/kafka/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing permissi

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417050279 ## File path: docker/containers/kafka/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing permissions

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417046810 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka w

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417045900 ## File path: docker/README.md ## @@ -209,33 +140,21 @@ testing scripts to be added to a pull request, and subsequently to a test suite.

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417045301 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417045301 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with

  1   2   3   4   5   6   7   8   9   10   >