[GitHub] [metron] justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-11 Thread GitBox
justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-552508098 @mmiklavc This should be good for review now, dependent on https://github.com/apache/metron/pull/1557 to fix our modules compiling against

[GitHub] [metron] justinleet commented on issue #1557: METRON-2310: Remove metron-integration-test from compile dependencies

2019-11-10 Thread GitBox
justinleet commented on issue #1557: METRON-2310: Remove metron-integration-test from compile dependencies URL: https://github.com/apache/metron/pull/1557#issuecomment-552273332 Looks like this occurred in https://github.com/apache/metron/pull/1389/ The dropping of `test` can be

[GitHub] [metron] justinleet commented on issue #1557: METRON-2310: Remove metron-integration-test from compile dependencies

2019-11-10 Thread GitBox
justinleet commented on issue #1557: METRON-2310: Remove metron-integration-test from compile dependencies URL: https://github.com/apache/metron/pull/1557#issuecomment-552271257 Example of jar contents before and after The resulting jar from this PR, which produces no results:

[GitHub] [metron] justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-10 Thread GitBox
justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-552270381 I added the commit from https://github.com/apache/metron/pull/1557 into here. It seems to resolve the problem, but I'm honestly not sure entirely why.

[GitHub] [metron] justinleet opened a new pull request #1557: METRON-2310: Remove metron-integration-test from compile dependencies

2019-11-10 Thread GitBox
justinleet opened a new pull request #1557: METRON-2310: Remove metron-integration-test from compile dependencies URL: https://github.com/apache/metron/pull/1557 ## Contributor Comments Came out of debugging https://github.com/apache/metron/pull/1554, and was worth pulling out

[GitHub] [metron] mmiklavc commented on issue #1556: METRON-2284 Metron Profiler for Spark doesn't work as expected

2019-11-08 Thread GitBox
mmiklavc commented on issue #1556: METRON-2284 Metron Profiler for Spark doesn't work as expected URL: https://github.com/apache/metron/pull/1556#issuecomment-552001931 +1 by inspection, thanks @nickwallen This is an

[GitHub] [metron] nickwallen opened a new pull request #1556: METRON-2284 Metron Profiler for Spark doesn't work as expected

2019-11-08 Thread GitBox
nickwallen opened a new pull request #1556: METRON-2284 Metron Profiler for Spark doesn't work as expected URL: https://github.com/apache/metron/pull/1556 ### The Problem Some profile "update" expressions execute incorrectly in the Batch Profiler. The bug report provides an

[GitHub] [metron] nickwallen commented on issue #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1

2019-11-08 Thread GitBox
nickwallen commented on issue #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#issuecomment-551970326 Yeah it looks like there are some centos6 installation files in Ansible that are effectively dead code now. I can remove

[GitHub] [metron] mmiklavc commented on issue #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1

2019-11-08 Thread GitBox
mmiklavc commented on issue #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#issuecomment-551966762 I see a file here named manual install centos 6 - after https://github.com/apache/metron/pull/1542, should this file be

[GitHub] [metron] mmiklavc commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1

2019-11-08 Thread GitBox
mmiklavc commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#discussion_r344327837 ## File path: pom.xml ## @@ -185,11 +167,6 @@ mockito-core

[GitHub] [metron] mmiklavc commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1

2019-11-08 Thread GitBox
mmiklavc commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#discussion_r344326846 ## File path: pom.xml ## @@ -185,11 +167,6 @@ mockito-core

[GitHub] [metron] justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-08 Thread GitBox
justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-551848986 @nickwallen I meant more the last upgrade cycle. Right now we package up storm 1.0.x stuff, but dev deploys Storm 1.1.0, I believe. I'm wondering if

[GitHub] [metron] nickwallen commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-08 Thread GitBox
nickwallen commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-551846834 > I'll have to dig in more, but if there's any leads/knowledge from the Storm upgrade stuff, I'd be happy to hear it. @justinleet The HDP 3.1

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on issue #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter.

2019-11-08 Thread GitBox
JonZeolla commented on issue #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter. URL: https://github.com/apache/metron-bro-plugin-kafka/pull/40#issuecomment-551817260 I @mauropalumbo75 thanks for the contribution! I haven't had a chance to take a look at it,

[GitHub] [metron] justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-07 Thread GitBox
justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-551138832 Running dev up gives some issues starting index ``` Running: /usr/jdk64/jdk1.8.0_112/bin/java -server -Ddaemon.name= -Dstorm.options=

[GitHub] [metron-bro-plugin-kafka] mauropalumbo75 commented on issue #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter.

2019-11-07 Thread GitBox
mauropalumbo75 commented on issue #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter. URL: https://github.com/apache/metron-bro-plugin-kafka/pull/40#issuecomment-551028311 Just a quick follow-up. I run the tests on the master branch (without the changes iin

[GitHub] [metron-bro-plugin-kafka] mauropalumbo75 opened a new pull request #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter.

2019-11-07 Thread GitBox
mauropalumbo75 opened a new pull request #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter. URL: https://github.com/apache/metron-bro-plugin-kafka/pull/40 Hi, in examples 4-5 in readme.md file it seems like you can set a different kafka broker list for

[GitHub] [metron] nickwallen commented on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-06 Thread GitBox
nickwallen commented on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-550527276 Sure, I will take a look and see. This is an automated

[GitHub] [metron] sardell commented on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-06 Thread GitBox
sardell commented on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-550526935 @nickwallen I made the change as promised above, but the build for centos6 fails for me. I tried troubleshooting locally, but

[GitHub] [metron] nickwallen opened a new pull request #1555: METRON-2308 Fix 'Degrees' Example Profile

2019-11-06 Thread GitBox
nickwallen opened a new pull request #1555: METRON-2308 Fix 'Degrees' Example Profile URL: https://github.com/apache/metron/pull/1555 One of the example profiles uses "in" as a variable name. This is now a reserved keyword and cannot be used as a variable name. The example should be

[GitHub] [metron] justinleet edited a comment on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-06 Thread GitBox
justinleet edited a comment on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-550291563 @mmiklavc Given how large this PR is, here's a git command that *should* just pull out the `src` files that changed. `git difftool` will also

[GitHub] [metron] justinleet edited a comment on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-06 Thread GitBox
justinleet edited a comment on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-550291563 @mmiklavc Given how large this PR is, here's a git command that *should* just pull out the `src` files that changed. `git difftool` will also

[GitHub] [metron] justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-06 Thread GitBox
justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-550291563 @mmiklavc Given how large this PR is, here's a git command that *should* just pull out the `src` files that changed. `git difftool` will also work if

[GitHub] [metron] tigerquoll commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-11-05 Thread GitBox
tigerquoll commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-550076315 +1 (non-binding) I gave these scripts a test when updating Metron 0.7.1 (HDP 2.6) -> Metron HDP 3.1 support branch. They worked

[GitHub] [metron] sardell edited a comment on issue #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField

2019-11-05 Thread GitBox
sardell edited a comment on issue #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField URL: https://github.com/apache/metron/pull/1553#issuecomment-550058047 @mmiklavc > Anyhow, where is/was the other "TIMESTAMP" property being set if not in the "parserConfig" object?

[GitHub] [metron] sardell commented on issue #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField

2019-11-05 Thread GitBox
sardell commented on issue #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField URL: https://github.com/apache/metron/pull/1553#issuecomment-550058047 @mmiklavc > Anyhow, where is/was the other "TIMESTAMP" property being set if not in the "parserConfig" object?

[GitHub] [metron] nickwallen commented on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-05 Thread GitBox
nickwallen commented on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-550006997 @sardell Yes, you are right. Just spinning up the dev environments is the way to go. Just testing centos6 is sufficient.

[GitHub] [metron] sardell commented on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-05 Thread GitBox
sardell commented on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-550002615 @nickwallen You're correct, that doesn't look right. It looks like we'll have to update there as well, and you're correct about

[GitHub] [metron] nickwallen commented on issue #1550: METRON-2304: Update node and npm version to LTS releases

2019-11-05 Thread GitBox
nickwallen commented on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-549985021 Hi @sardell - On the [container that we use to build the

[GitHub] [metron] mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-11-05 Thread GitBox
mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-549958850 > As far as linking to the wiki I don't think people will find Metron or the update from the wiki. I would like to it from the main

[GitHub] [metron] mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-11-05 Thread GitBox
mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-549956618 > I don't think I would call the existing bash scripts style and practice. Wouldn't call them what? > I think it is a

[GitHub] [metron] justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-05 Thread GitBox
justinleet commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-549935562 > Any reason we specifically still need/want PowerMock? That was purely for special static mocking purposes, right? Personally, I'm happy to see this

[GitHub] [metron] ottobackwards commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-11-05 Thread GitBox
ottobackwards commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-549914003 As far as linking to the wiki I don't think people will find Metron or the update from the wiki. I would like to it from the

[GitHub] [metron] ottobackwards commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-11-05 Thread GitBox
ottobackwards commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-549912826 @JonZeolla and I have been using shellcheck for all of our bro testing scripts, and I used it for the RC scripts and the common

[GitHub] [metron] mmiklavc commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-11-05 Thread GitBox
mmiklavc commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-549907637 @justinleet wowowow, this is an awesome contribution. It's going to take me a bit of time to work through this. > PowerMock is gone. Doesn't work

[GitHub] [metron] mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-11-05 Thread GitBox
mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-549877351 @ottobackwards Any thoughts on this comment also? https://github.com/apache/metron/pull/1546#issuecomment-548510246 WRT

[GitHub] [metron] asfgit closed pull request #1534: METRON-2290: [UI] Delaying first auto polling request on app start

2019-11-04 Thread GitBox
asfgit closed pull request #1534: METRON-2290: [UI] Delaying first auto polling request on app start URL: https://github.com/apache/metron/pull/1534 This is an automated message from the Apache Git Service. To respond to

[GitHub] [metron] ottobackwards commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-11-04 Thread GitBox
ottobackwards commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-549572670 I have not run spellcheck again, does it pass now? This is an

[GitHub] [metron] mmiklavc commented on issue #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField

2019-11-04 Thread GitBox
mmiklavc commented on issue #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField URL: https://github.com/apache/metron/pull/1553#issuecomment-549564015 @sardell - I'm a little confused - the only place I think we deal with timestamp fields and/or properties is in the

[GitHub] [metron] mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-11-04 Thread GitBox
mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-549518096 @ottobackwards Any other thoughts on this? This is an automated

[GitHub] [metron] asfgit closed pull request #1536: METRON-2293 Fix some inaccuracies in the MaaS README example

2019-11-04 Thread GitBox
asfgit closed pull request #1536: METRON-2293 Fix some inaccuracies in the MaaS README example URL: https://github.com/apache/metron/pull/1536 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [metron] sardell commented on a change in pull request #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField

2019-11-04 Thread GitBox
sardell commented on a change in pull request #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField URL: https://github.com/apache/metron/pull/1553#discussion_r342186993 ## File path:

[GitHub] [metron] sardell commented on a change in pull request #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField

2019-11-04 Thread GitBox
sardell commented on a change in pull request #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField URL: https://github.com/apache/metron/pull/1553#discussion_r342186048 ## File path: metron-interface/metron-config/src/app/model/sensor-parser-config.ts ##

[GitHub] [metron] justinleet opened a new pull request #1554: METRON-2307: Migrate to JUnit5

2019-11-04 Thread GitBox
justinleet opened a new pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554 ## Contributor Comments Moves to JUnit 5. This came out of my forever ago desire to look into JUnit5 extensions to share test infra (Kafka, ZK, etc.) across our

[GitHub] [metron] tiborm commented on a change in pull request #1534: METRON-2290: [UI] Delaying first auto polling request on app start

2019-11-04 Thread GitBox
tiborm commented on a change in pull request #1534: METRON-2290: [UI] Delaying first auto polling request on app start URL: https://github.com/apache/metron/pull/1534#discussion_r341985772 ## File path:

[GitHub] [metron] sardell opened a new pull request #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField

2019-11-02 Thread GitBox
sardell opened a new pull request #1553: METRON-2306: [UI] Grok parsers' have duplicate timestampField URL: https://github.com/apache/metron/pull/1553 ## Contributor Comments WIP! Link to original ASF Jira ticket: https://issues.apache.org/jira/browse/METRON-2306 ## Pull

[GitHub] [metron] nickwallen commented on issue #1536: METRON-2293 Fix some inaccuracies in the MaaS README example

2019-11-01 Thread GitBox
nickwallen commented on issue #1536: METRON-2293 Fix some inaccuracies in the MaaS README example URL: https://github.com/apache/metron/pull/1536#issuecomment-548898301 +1 Thanks for the updates. This is an automated

[GitHub] [metron] dependabot[bot] opened a new pull request #1552: Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest

2019-11-01 Thread GitBox
dependabot[bot] opened a new pull request #1552: Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest URL: https://github.com/apache/metron/pull/1552 Bumps [nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 4.41.2 to 7.9. Changelog

[GitHub] [metron] justinleet commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1

2019-10-31 Thread GitBox
justinleet commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#discussion_r341392736 ## File path: pom.xml ## @@ -185,11 +167,6 @@ mockito-core

[GitHub] [metron] asfgit closed pull request #1547: METRON-2302: [UI] Change the default polling interval for Alerts UI to longer time

2019-10-31 Thread GitBox
asfgit closed pull request #1547: METRON-2302: [UI] Change the default polling interval for Alerts UI to longer time URL: https://github.com/apache/metron/pull/1547 This is an automated message from the Apache Git Service.

[GitHub] [metron] asfgit closed pull request #1543: METRON-2295: [UI] Displaying "No Data" message in the Alerts UI screen

2019-10-31 Thread GitBox
asfgit closed pull request #1543: METRON-2295: [UI] Displaying "No Data" message in the Alerts UI screen URL: https://github.com/apache/metron/pull/1543 This is an automated message from the Apache Git Service. To respond

[GitHub] [metron] mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-10-31 Thread GitBox
mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-548510246 I could link to it in our wiki. I had considered if we had another release, however most of the work done since our last release has

[GitHub] [metron] ottobackwards commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-10-31 Thread GitBox
ottobackwards commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-548501734 Have we thought about any other possibilities other than "go to current master and download and run this script"? That seems a

[GitHub] [metron] asfgit closed pull request #1540: METRON-2294: [UI] Fixing Stale mode issue in Alert UI Manual Query Mode

2019-10-31 Thread GitBox
asfgit closed pull request #1540: METRON-2294: [UI] Fixing Stale mode issue in Alert UI Manual Query Mode URL: https://github.com/apache/metron/pull/1540 This is an automated message from the Apache Git Service. To respond

[GitHub] [metron] asfgit closed pull request #1535: METRON-2291: [UI] Fixing and rephrasing warning messages on Alerts UI

2019-10-31 Thread GitBox
asfgit closed pull request #1535: METRON-2291: [UI] Fixing and rephrasing warning messages on Alerts UI URL: https://github.com/apache/metron/pull/1535 This is an automated message from the Apache Git Service. To respond to

[GitHub] [metron] nickwallen commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1

2019-10-31 Thread GitBox
nickwallen commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#discussion_r341145770 ## File path: pom.xml ## @@ -185,11 +167,6 @@ mockito-core

[GitHub] [metron] nickwallen commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1

2019-10-31 Thread GitBox
nickwallen commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#discussion_r341145376 ## File path: pom.xml ## @@ -185,11 +167,6 @@ mockito-core

[GitHub] [metron] nickwallen commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1

2019-10-31 Thread GitBox
nickwallen commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#discussion_r341145376 ## File path: pom.xml ## @@ -185,11 +167,6 @@ mockito-core

[GitHub] [metron] nickwallen commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1

2019-10-31 Thread GitBox
nickwallen commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#discussion_r341144155 ## File path: pom.xml ## @@ -138,38 +141,17 @@ true Review comment:

[GitHub] [metron] nickwallen commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1

2019-10-31 Thread GitBox
nickwallen commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#discussion_r341143847 ## File path: pom.xml ## @@ -138,38 +141,17 @@ true Review comment:

[GitHub] [metron] ruffle1986 commented on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI

2019-10-31 Thread GitBox
ruffle1986 commented on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI URL: https://github.com/apache/metron/pull/1533#issuecomment-548279622 Nice catch! I'll take a look at it. This is an

[GitHub] [metron] mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-10-30 Thread GitBox
mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-548151163 Updated this to include a new `Upgrade_steps.md" readme. This should provide more context on how/where to run this script.

[GitHub] [metron] mmiklavc edited a comment on issue #1546: METRON-2239 Metron Automated backup and restore

2019-10-30 Thread GitBox
mmiklavc edited a comment on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-548151163 Updated this to include a new `Upgrade_steps.md` readme. This should provide more context on how/where to run this script.

[GitHub] [metron] mmiklavc commented on issue #1551: METRON-2232 Reconcile Versions in Root POM with HDP 3.1

2019-10-30 Thread GitBox
mmiklavc commented on issue #1551: METRON-2232 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#issuecomment-548127114 This is labeled "METRON-2232", but is this actually "METRON-2223"? It's not syncing with Jira currently.

[GitHub] [metron] sardell edited a comment on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI

2019-10-30 Thread GitBox
sardell edited a comment on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI URL: https://github.com/apache/metron/pull/1533#issuecomment-548101122 I just tested this and I noticed that after I make and save a few searches where I edit the timestamp out of the

[GitHub] [metron] sardell commented on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI

2019-10-30 Thread GitBox
sardell commented on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI URL: https://github.com/apache/metron/pull/1533#issuecomment-548101122 I just tested this and I noticed that after I make and save a few searches where I edit the timestamp out of the search,

[GitHub] [metron] nickwallen commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-10-30 Thread GitBox
nickwallen commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-548060674 > @ottobackwards: what would be the steps for a current user to use this to prepare for the next big upgrade? We will

[GitHub] [metron] nickwallen opened a new pull request #1551: METRON-2232 Reconcile Versions in Root POM with HDP 3.1

2019-10-30 Thread GitBox
nickwallen opened a new pull request #1551: METRON-2232 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551 This change includes a few clean-up items that are needed prior to the `feature/METRON-2088-support-hdp-3.1` feature branch being merged into

[GitHub] [metron] mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore

2019-10-30 Thread GitBox
mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-548057601 @ottobackwards - I ran shellcheck and modified some exit codes. Other than that, it's warnings about shell expansion on variables,

[GitHub] [metron] nickwallen commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos

2019-10-30 Thread GitBox
nickwallen commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos URL: https://github.com/apache/metron/pull/1549#issuecomment-548010087 This has been merged into the feature branch. Thanks @MohanDV !

[GitHub] [metron] nickwallen closed pull request #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos

2019-10-30 Thread GitBox
nickwallen closed pull request #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos URL: https://github.com/apache/metron/pull/1549 This is an automated message from the Apache Git Service. To respond to

[GitHub] [metron] asfgit closed pull request #1548: METRON-2303 Change Default HDFS Port for Batch Profiler

2019-10-30 Thread GitBox
asfgit closed pull request #1548: METRON-2303 Change Default HDFS Port for Batch Profiler URL: https://github.com/apache/metron/pull/1548 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [metron] nickwallen closed pull request #1542: METRON-2233 Deprecate CentOS 6 Development Environment

2019-10-30 Thread GitBox
nickwallen closed pull request #1542: METRON-2233 Deprecate CentOS 6 Development Environment URL: https://github.com/apache/metron/pull/1542 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [metron] nickwallen commented on issue #1542: METRON-2233 Deprecate CentOS 6 Development Environment

2019-10-30 Thread GitBox
nickwallen commented on issue #1542: METRON-2233 Deprecate CentOS 6 Development Environment URL: https://github.com/apache/metron/pull/1542#issuecomment-547997647 Thanks for the review @mmiklavc . This has been merged into the feature branch.

[GitHub] [metron] mmiklavc commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1

2019-10-30 Thread GitBox
mmiklavc commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1 URL: https://github.com/apache/metron/pull/1523#issuecomment-547996513 Wanted to add 1 note for posterity. This was/is a big PR, however 5,045 lines out of the 5,218 are simply classes we had to copy from HBase in order

[GitHub] [metron] nickwallen closed pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1

2019-10-30 Thread GitBox
nickwallen closed pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1 URL: https://github.com/apache/metron/pull/1523 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [metron] nickwallen commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1

2019-10-30 Thread GitBox
nickwallen commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1 URL: https://github.com/apache/metron/pull/1523#issuecomment-547995461 This has been merged into the feature branch; yay! This is an automated message

[GitHub] [metron] mmiklavc closed pull request #1362: METRON-2043 Fix profiler-client dependencies

2019-10-30 Thread GitBox
mmiklavc closed pull request #1362: METRON-2043 Fix profiler-client dependencies URL: https://github.com/apache/metron/pull/1362 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [metron] mmiklavc commented on issue #1362: METRON-2043 Fix profiler-client dependencies

2019-10-30 Thread GitBox
mmiklavc commented on issue #1362: METRON-2043 Fix profiler-client dependencies URL: https://github.com/apache/metron/pull/1362#issuecomment-547991621 Closing this PR - this was addressed in part via another fix here - https://github.com/apache/metron/pull/1525

[GitHub] [metron] mmiklavc commented on issue #1542: METRON-2233 Deprecate CentOS 6 Development Environment

2019-10-30 Thread GitBox
mmiklavc commented on issue #1542: METRON-2233 Deprecate CentOS 6 Development Environment URL: https://github.com/apache/metron/pull/1542#issuecomment-547989143 lgtm @nickwallen, thanks! +1 This is an automated message from

[GitHub] [metron] sardell opened a new pull request #1550: METRON-2304: Update node and npm version to LTS releases

2019-10-30 Thread GitBox
sardell opened a new pull request #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550 ## Contributor Comments Link to ASF ticket here: https://issues.apache.org/jira/browse/METRON-2304 We are currently using node 9.11.1

[GitHub] [metron] mmiklavc commented on issue #1547: METRON-2302: [UI] Change the default polling interval for Alerts UI to longer time

2019-10-30 Thread GitBox
mmiklavc commented on issue #1547: METRON-2302: [UI] Change the default polling interval for Alerts UI to longer time URL: https://github.com/apache/metron/pull/1547#issuecomment-547984938 +1 by inspection, thanks for the fix @tiborm. Made one small note about the test setup, if you're

[GitHub] [metron] mmiklavc commented on a change in pull request #1547: METRON-2302: [UI] Change the default polling interval for Alerts UI to longer time

2019-10-30 Thread GitBox
mmiklavc commented on a change in pull request #1547: METRON-2302: [UI] Change the default polling interval for Alerts UI to longer time URL: https://github.com/apache/metron/pull/1547#discussion_r340713898 ## File path:

[GitHub] [metron] mmiklavc commented on issue #1548: METRON-2303 Change Default HDFS Port for Batch Profiler

2019-10-30 Thread GitBox
mmiklavc commented on issue #1548: METRON-2303 Change Default HDFS Port for Batch Profiler URL: https://github.com/apache/metron/pull/1548#issuecomment-547981128 lgtm, thanks for the fix @nickwallen. I ran through this test recently, independent of this PR, and found the same. +1

[GitHub] [metron] mmiklavc commented on a change in pull request #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos

2019-10-30 Thread GitBox
mmiklavc commented on a change in pull request #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos URL: https://github.com/apache/metron/pull/1549#discussion_r340708849 ## File path:

[GitHub] [metron] mmiklavc commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos

2019-10-30 Thread GitBox
mmiklavc commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos URL: https://github.com/apache/metron/pull/1549#issuecomment-547980409 Piling on my +1 as well - thanks @MohanDV! This is an

[GitHub] [metron] nickwallen commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1

2019-10-30 Thread GitBox
nickwallen commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1 URL: https://github.com/apache/metron/pull/1523#issuecomment-547949974 +1 Looks good. I previously ran this through a bulk of the testing steps described above.

[GitHub] [metron] nickwallen commented on a change in pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1

2019-10-30 Thread GitBox
nickwallen commented on a change in pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1 URL: https://github.com/apache/metron/pull/1523#discussion_r340669150 ## File path: metron-platform/metron-common/pom.xml ## @@ -347,11 +347,6 @@

[GitHub] [metron] mmiklavc commented on a change in pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1

2019-10-30 Thread GitBox
mmiklavc commented on a change in pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1 URL: https://github.com/apache/metron/pull/1523#discussion_r340660373 ## File path: metron-platform/metron-common/pom.xml ## @@ -347,11 +347,6 @@

[GitHub] [metron] mmiklavc commented on a change in pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1

2019-10-30 Thread GitBox
mmiklavc commented on a change in pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1 URL: https://github.com/apache/metron/pull/1523#discussion_r340660373 ## File path: metron-platform/metron-common/pom.xml ## @@ -347,11 +347,6 @@

[GitHub] [metron] nickwallen commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos

2019-10-30 Thread GitBox
nickwallen commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos URL: https://github.com/apache/metron/pull/1549#issuecomment-547936910 +1 Looks great. Thanks for the fix. This is an

[GitHub] [metron] nickwallen commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor.

2019-10-30 Thread GitBox
nickwallen commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor. URL: https://github.com/apache/metron/pull/1549#discussion_r340647115 ## File path:

[GitHub] [metron] nickwallen commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor.

2019-10-30 Thread GitBox
nickwallen commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor. URL: https://github.com/apache/metron/pull/1549#discussion_r340647115 ## File path:

[GitHub] [metron] MohanDV commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor.

2019-10-30 Thread GitBox
MohanDV commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor. URL: https://github.com/apache/metron/pull/1549#discussion_r340642524 ## File path:

[GitHub] [metron] nickwallen commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor.

2019-10-30 Thread GitBox
nickwallen commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor. URL: https://github.com/apache/metron/pull/1549#discussion_r340639509 ## File path:

[GitHub] [metron] MohanDV opened a new pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor.

2019-10-30 Thread GitBox
MohanDV opened a new pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor. URL: https://github.com/apache/metron/pull/1549 ## Contributor Comments metron enrichment topology fails to star on pre kerberized

[GitHub] [metron] nickwallen commented on issue #1544: METRON-2301 Building Against Wrong Storm Flux Version

2019-10-30 Thread GitBox
nickwallen commented on issue #1544: METRON-2301 Building Against Wrong Storm Flux Version URL: https://github.com/apache/metron/pull/1544#issuecomment-547876138 Thanks for the review @ottobackwards . I have merged this into the feature branch.

[GitHub] [metron] nickwallen closed pull request #1544: METRON-2301 Building Against Wrong Storm Flux Version

2019-10-30 Thread GitBox
nickwallen closed pull request #1544: METRON-2301 Building Against Wrong Storm Flux Version URL: https://github.com/apache/metron/pull/1544 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [metron] nickwallen closed pull request #1545: METRON-2222 Remove Overrides for Storm 1.0.x

2019-10-29 Thread GitBox
nickwallen closed pull request #1545: METRON- Remove Overrides for Storm 1.0.x URL: https://github.com/apache/metron/pull/1545 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [metron] nickwallen commented on issue #1545: METRON-2222 Remove Overrides for Storm 1.0.x

2019-10-29 Thread GitBox
nickwallen commented on issue #1545: METRON- Remove Overrides for Storm 1.0.x URL: https://github.com/apache/metron/pull/1545#issuecomment-547637032 Thanks @mmiklavc . This has been merged into `feature/METRON-2088-support-hdp-3.1`

<    1   2   3   4   5   6   7   8   9   10   >