nickwallen commented on a change in pull request #36: METRON-2069 Add btests
for bro plugin topic_name selection
URL:
https://github.com/apache/metron-bro-plugin-kafka/pull/36#discussion_r327791468
##
File path: .gitignore
##
@@ -39,5 +39,5 @@ build
# Log files
*.log
asfgit closed pull request #1496: METRON-2235 - Increase server startup timeout
URL: https://github.com/apache/metron/pull/1496
This is an automated message from the Apache Git Service.
To respond to the message, please log
mmiklavc commented on issue #1496: METRON-2235 - Increase server startup timeout
URL: https://github.com/apache/metron/pull/1496#issuecomment-534704934
+1
This is an automated message from the Apache Git Service.
To respond
mmiklavc commented on issue #1518: METRON-2264 Upgrade metron-hbase-client to
HBase 2.0.2
URL: https://github.com/apache/metron/pull/1518#issuecomment-534652334
Really nice to be able to clean that up! Looks good, +1. Thanks @nickwallen!
nickwallen commented on a change in pull request #1519: METRON-2265: Update
Kerberos settings
URL: https://github.com/apache/metron/pull/1519#discussion_r327704690
##
File path: metron-platform/metron-parsing/metron-parsing-storm/pom.xml
##
@@ -36,6 +37,28 @@
nickwallen commented on a change in pull request #1519: METRON-2265: Update
Kerberos settings
URL: https://github.com/apache/metron/pull/1519#discussion_r327704257
##
File path: metron-platform/metron-parsing/metron-parsing-storm/pom.xml
##
@@ -36,6 +37,28 @@
nickwallen commented on a change in pull request #1519: METRON-2265: Update
Kerberos settings
URL: https://github.com/apache/metron/pull/1519#discussion_r327704930
##
File path:
metron-platform/metron-management/src/main/java/org/apache/metron/management/KafkaFunctions.java
nickwallen commented on a change in pull request #1519: METRON-2265: Update
Kerberos settings
URL: https://github.com/apache/metron/pull/1519#discussion_r327704348
##
File path: metron-platform/metron-parsing/metron-parsing-storm/pom.xml
##
@@ -36,6 +37,28 @@
nickwallen commented on a change in pull request #1519: METRON-2265: Update
Kerberos settings
URL: https://github.com/apache/metron/pull/1519#discussion_r327707957
##
File path:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/KafkaConfig.java
##
merrimanr opened a new pull request #1519: METRON-2265: Update Kerberos settings
URL: https://github.com/apache/metron/pull/1519
## Contributor Comments
This PR includes code and documentation changes for enabling Kerberos in HDP
3.1. The primary changes needed were minor Maven
nickwallen opened a new pull request #1518: METRON-2264 Upgrade
metron-hbase-client to HBase 2.0.2
URL: https://github.com/apache/metron/pull/1518
The `metron-hbase-client` which is used by `metron-rest` has some special
handling for pulling in a shaded HBase client library. This pulls
justinleet commented on issue #36: METRON-2069 Add btests for bro plugin
topic_name selection
URL:
https://github.com/apache/metron-bro-plugin-kafka/pull/36#issuecomment-534548167
@nickwallen Do you have any other concerns? Were you able to get things
running?
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327094011
##
File path: metron-interface/metron-alerts/src/app/utils/httpUtil.ts
tiborm opened a new pull request #1514: METRON-2190: [UI] Alerts UI: Indicating
loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514
## Contributor Comments
As a part of this pull request I introduce the concepts of blocking and non
blocking
tiborm closed pull request #1514: METRON-2190: [UI] Alerts UI: Indicating
loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514
This is an automated message from the Apache Git Service.
To
tiborm commented on issue #1514: METRON-2190: [UI] Alerts UI: Indicating
loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#issuecomment-534076602
closing and opening to trigger new build
ruffle1986 commented on a change in pull request #1514: METRON-2190: [UI]
Alerts UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327016495
##
File path: metron-interface/metron-alerts/src/app/utils/httpUtil.ts
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327021709
##
File path: metron-interface/metron-alerts/src/app/utils/httpUtil.ts
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327021709
##
File path: metron-interface/metron-alerts/src/app/utils/httpUtil.ts
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326994513
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327008834
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326996126
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327018486
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327005220
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326998004
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327007289
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327004638
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327004408
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327004808
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327001281
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327021709
##
File path: metron-interface/metron-alerts/src/app/utils/httpUtil.ts
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326992592
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327005089
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326999623
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327009938
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327020559
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326993769
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327019632
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327017385
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327021175
##
File path: metron-interface/metron-alerts/src/app/utils/constants.ts
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327003814
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327003056
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327019294
##
File path: metron-interface/metron-alerts/src/app/model/table-metadata.ts
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326996827
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327004201
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327009244
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326997272
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326995509
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327019948
##
File path: metron-interface/metron-alerts/src/app/service/search.service.ts
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326992280
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326991804
##
File path:
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326991079
##
File path: metron-interface/metron-alerts/cypress/fixtures/search-1.1.json
tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326991248
##
File path: metron-interface/metron-alerts/cypress/fixtures/search-1.2.json
justinleet commented on issue #36: METRON-2069 Add btests for bro plugin
topic_name selection
URL:
https://github.com/apache/metron-bro-plugin-kafka/pull/36#issuecomment-533678357
Created https://issues.apache.org/jira/browse/METRON-2263 to track.
As a note, I don't know enough
JonZeolla commented on issue #36: METRON-2069 Add btests for bro plugin
topic_name selection
URL:
https://github.com/apache/metron-bro-plugin-kafka/pull/36#issuecomment-533671648
I agree we should track those. When Macs move to zsh we can probably just
change the env to that and fix the
ottobackwards commented on issue #36: METRON-2069 Add btests for bro plugin
topic_name selection
URL:
https://github.com/apache/metron-bro-plugin-kafka/pull/36#issuecomment-533662563
Bash 3.2.57 is from 2007 I think.
This
ottobackwards commented on issue #36: METRON-2069 Add btests for bro plugin
topic_name selection
URL:
https://github.com/apache/metron-bro-plugin-kafka/pull/36#issuecomment-533656904
The script does have
```bash
echo "COMPATABILITY"
echo " bash >= 4.0 is required."
nickwallen commented on issue #36: METRON-2069 Add btests for bro plugin
topic_name selection
URL:
https://github.com/apache/metron-bro-plugin-kafka/pull/36#issuecomment-533652512
> wget isn't installed by default on Mac, iirc (I have it installed via
brew). We should either be using
merrimanr commented on issue #1516: METRON-2262: Upgrade to Curator 4.2.0
URL: https://github.com/apache/metron/pull/1516#issuecomment-533648484
Ah makes sense @nickwallen. Done with latest commit.
This is an automated
nickwallen commented on issue #1516: METRON-2262: Upgrade to Curator 4.2.0
URL: https://github.com/apache/metron/pull/1516#issuecomment-533643192
Hey @merrimanr - We don't need the following changes on this PR. I know
these are just due to the iterations and changes I went through on
justinleet edited a comment on issue #36: METRON-2069 Add btests for bro plugin
topic_name selection
URL:
https://github.com/apache/metron-bro-plugin-kafka/pull/36#issuecomment-533641585
wget isn't installed by default on Mac, iirc (I have it installed via brew).
We should either be
justinleet commented on issue #36: METRON-2069 Add btests for bro plugin
topic_name selection
URL:
https://github.com/apache/metron-bro-plugin-kafka/pull/36#issuecomment-533641585
wget isn't installed by default on Mac, iirc. We should either be using
curl, or documenting the
nickwallen commented on issue #36: METRON-2069 Add btests for bro plugin
topic_name selection
URL:
https://github.com/apache/metron-bro-plugin-kafka/pull/36#issuecomment-533622387
This doesn't seem to work for me? Anyone else seeing the same?
```
nallen:
nickwallen commented on issue #1515: METRON-2261 Isolate Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#issuecomment-533591854
This has been merged into the feature branch.
This is an automated message
nickwallen closed pull request #1515: METRON-2261 Isolate Curator Dependencies
URL: https://github.com/apache/metron/pull/1515
This is an automated message from the Apache Git Service.
To respond to the message, please log
nickwallen commented on issue #1515: METRON-2261 Isolate Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#issuecomment-533572093
All smoke tests passed. I updated the PR description with the tests I went
through.
tigerquoll commented on issue #1509: METRON-2253 optimise npm builds towards
compile time rather then runtime for dev builds
URL: https://github.com/apache/metron/pull/1509#issuecomment-533439281
CI tests die due to 50 minute timeout. Perhaps we should use some of the
flags in the CI
tigerquoll opened a new pull request #1517: METRON-2256 NodeJS Module puppeteer
moved to be a dev dependency.
URL: https://github.com/apache/metron/pull/1517
The puppeteer module is used for GUI testing, and allows Chrome to be driven
headless for GUI testing purposes. Every time that
tigerquoll closed pull request #1511: METRON-2256 - NodeJS testing module
puppeteer should only be installed for testing
URL: https://github.com/apache/metron/pull/1511
This is an automated message from the Apache Git
ottobackwards commented on issue #1516: METRON-2262: Upgrade to Curator 4.2.0
URL: https://github.com/apache/metron/pull/1516#issuecomment-52429
- another idea would be for them to support multiple implementations with
the builder and have a non-caching, distributed friendly version
ottobackwards commented on issue #1516: METRON-2262: Upgrade to Curator 4.2.0
URL: https://github.com/apache/metron/pull/1516#issuecomment-50876
So the bug is that we register and un-register in different processes.
I think we could think about
- Implementing our own
nickwallen edited a comment on issue #1515: METRON-2261 Isolate Curator
Dependencies
URL: https://github.com/apache/metron/pull/1515#issuecomment-533309394
Thanks. I'm just going to double check the integration tests and run up dev
environment after the latest commits (before merging).
nickwallen commented on issue #1515: METRON-2261 Isolate Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#issuecomment-533309394
Thanks. I'm just going to double check the integration tests and run up dev
environment after the latest commits.
mmiklavc commented on issue #1515: METRON-2261 Isolate Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#issuecomment-533309052
Looked over the recent run of commits. Based on my initial tests, this looks
pretty good. When you're confident in the manual testing I'm +1 on
mmiklavc commented on issue #1509: METRON-2253 optimise npm builds towards
compile time rather then runtime for dev builds
URL: https://github.com/apache/metron/pull/1509#issuecomment-533307781
@tigerquoll fyi 2257 has been merged
https://github.com/apache/metron/pull/1513
mmiklavc commented on issue #1516: METRON-2262: Upgrade to Curator 4.2.0
URL: https://github.com/apache/metron/pull/1516#issuecomment-533296308
> Almost all correct. There are other `ServiceDiscoverer` instances created
merrimanr commented on issue #1516: METRON-2262: Upgrade to Curator 4.2.0
URL: https://github.com/apache/metron/pull/1516#issuecomment-533274592
Almost all correct. There are other `ServiceDiscoverer` instances created
mmiklavc commented on issue #1516: METRON-2262: Upgrade to Curator 4.2.0
URL: https://github.com/apache/metron/pull/1516#issuecomment-533268931
@merrimanr This is pretty complicated so I want to talk through this a bit
and make sure this is clear.
It looks like the upshot is that
nickwallen commented on a change in pull request #1515: METRON-2261 Isolate
Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#discussion_r326336756
##
File path: metron-analytics/metron-maas-service/pom.xml
##
@@ -59,6 +59,23 @@
nickwallen commented on a change in pull request #1515: METRON-2261 Isolate
Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#discussion_r326336756
##
File path: metron-analytics/metron-maas-service/pom.xml
##
@@ -59,6 +59,23 @@
nickwallen commented on a change in pull request #1515: METRON-2261 Isolate
Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#discussion_r326336756
##
File path: metron-analytics/metron-maas-service/pom.xml
##
@@ -59,6 +59,23 @@
mmiklavc commented on issue #1515: METRON-2261 Isolate Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#issuecomment-533258155
I spun up full dev and telemetry is flowing through as expected. I'm seeing
geo enrichments working as well.
merrimanr opened a new pull request #1516: METRON-2262: Upgrade to Curator 4.2.0
URL: https://github.com/apache/metron/pull/1516
## Contributor Comments
This PR is based on
[METRON-2261](https://github.com/apache/metron/pull/1515) and includes those
changes. It must be merged before
mmiklavc commented on a change in pull request #1515: METRON-2261 Isolate
Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#discussion_r326308716
##
File path: metron-analytics/metron-maas-service/pom.xml
##
@@ -59,6 +59,23 @@
nickwallen edited a comment on issue #1515: METRON-2261 Isolate Curator
Dependencies
URL: https://github.com/apache/metron/pull/1515#issuecomment-533202420
> Is that all related to us having previously leveraged transitive deps for
curator and zookeeper?
Yes. For example,
nickwallen edited a comment on issue #1515: METRON-2261 Isolate Curator
Dependencies
URL: https://github.com/apache/metron/pull/1515#issuecomment-533202420
> Is that all related to us having previously leveraged transitive deps for
curator and zookeeper?
Yes. For example,
nickwallen commented on issue #1515: METRON-2261 Isolate Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#issuecomment-533202420
> Is that all related to us having previously leveraged transitive deps for
curator and zookeeper?
Yes
mmiklavc commented on issue #1515: METRON-2261 Isolate Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#issuecomment-533202218
My initial reaction to keeping our existing versions would be that we'd just
have a couple pom dep additions here and there, but it looks like
nickwallen commented on a change in pull request #1515: METRON-2261 Isolate
Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#discussion_r326260497
##
File path: metron-platform/metron-pcap-backend/pom.xml
##
@@ -36,10 +36,22 @@
nickwallen opened a new pull request #1515: METRON-2261 Isolate Curator
Dependencies
URL: https://github.com/apache/metron/pull/1515
As part of the HDP 3.1 upgrade, we need to upgrade to Curator 4.x. [There
was a discuss thread
tiborm opened a new pull request #1514: METRON-2190: [UI] Alerts UI: Indicating
loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514
## Contributor Comments
As a part of this pull request I introduce the concepts of blocking and non
blocking
JonZeolla commented on issue #36: METRON-2069 Add btests for bro plugin
topic_name selection
URL:
https://github.com/apache/metron-bro-plugin-kafka/pull/36#issuecomment-532788759
@nickwallen I'd like to get this one merged as it's the last blocker to
getting a plugin release out. Did
asfgit closed pull request #1513: METRON-2257: Metron-Alerts GUI testing
failing on MacOS builds
URL: https://github.com/apache/metron/pull/1513
This is an automated message from the Apache Git Service.
To respond to the
mmiklavc commented on issue #1513: METRON-2257: Metron-Alerts GUI testing
failing on MacOS builds
URL: https://github.com/apache/metron/pull/1513#issuecomment-532345303
+1. I also ran this up locally. Thanks @sardell for the contribution and
thanks @tigerquoll for the feedback and review
nickwallen closed pull request #1512: METRON-2250 : Missing services in HDP 3.1
metron mpack and installer stuck
URL: https://github.com/apache/metron/pull/1512
This is an automated message from the Apache Git Service.
To
nickwallen commented on issue #1512: METRON-2250 : Missing services in HDP 3.1
metron mpack and installer stuck
URL: https://github.com/apache/metron/pull/1512#issuecomment-532269794
This has been merged into the feature branch.
mmiklavc commented on issue #1512: METRON-2250 : Missing services in HDP 3.1
metron mpack and installer stuck
URL: https://github.com/apache/metron/pull/1512#issuecomment-532260687
Excellent work @MohanDV and @nickwallen, this looks great. Documentation is
solid, the code is simple, yet
asfgit closed pull request #1503: METRON-2247 - rpm-docker: Provide an option
to bypass running rpmlint
URL: https://github.com/apache/metron/pull/1503
This is an automated message from the Apache Git Service.
To respond to
nickwallen commented on issue #1512: METRON-2250 : Missing services in HDP 3.1
metron mpack and installer stuck
URL: https://github.com/apache/metron/pull/1512#issuecomment-532189410
+1 Thanks @MohanDV. Great job finding a work around to this issue.
MohanDV commented on issue #1512: METRON-2250 : Missing services in HDP 3.1
metron mpack and installer stuck
URL: https://github.com/apache/metron/pull/1512#issuecomment-532160316
Thanks @nickwallen !! I merged your PR changes and verified it on full dev
also on 5 node cluster. This is
701 - 800 of 3514 matches
Mail list logo
