[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1266 ---

[GitHub] metron pull request #1268: METRON-1877: Nested IF ELSE statements can cause ...

2018-11-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1268#discussion_r234305980 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java --- @@ -916,6 +916,53 @@ public v

[GitHub] metron pull request #1268: METRON-1877: Nested IF ELSE statements can cause ...

2018-11-16 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1268#discussion_r234303547 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java --- @@ -916,6 +916,53 @@ public void

[GitHub] metron pull request #1268: METRON-1877: Nested IF ELSE statements can cause ...

2018-11-16 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1268#discussion_r234302996 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/StellarCompiler.java --- @@ -219,14 +220,23 @@ public Object appl

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234296496 --- Diff: metron-interface/metron-alerts/src/app/service/app-config.service.ts --- @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] metron pull request #1268: METRON-1877: Nested IF ELSE statements can cause ...

2018-11-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1268#discussion_r234293803 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java --- @@ -916,6 +916,53 @@ public v

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234293206 --- Diff: metron-interface/metron-alerts/src/app/service/app-config.service.ts --- @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software Found

[GitHub] metron pull request #1268: METRON-1877: Nested IF ELSE statements can cause ...

2018-11-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1268#discussion_r234290697 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java --- @@ -916,6 +916,53 @@ public v

[GitHub] metron pull request #1268: METRON-1877: Nested IF ELSE statements can cause ...

2018-11-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1268#discussion_r234289745 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/StellarCompiler.java --- @@ -219,14 +220,23 @@ public Object a

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234289363 --- Diff: metron-interface/metron-alerts/src/app/pcap/service/pcap.service.ts --- @@ -47,47 +48,47 @@ export class PcapService { public submitRequest

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234288335 --- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts --- @@ -28,6 +28,7 @@ import {Utils} from '../utils/utils'; import {Patch} f

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234288280 --- Diff: metron-interface/metron-alerts/src/app/service/meta-alert.service.ts --- @@ -26,14 +26,15 @@ import {Alert} from '../model/alert'; import { H

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234288308 --- Diff: metron-interface/metron-alerts/src/app/service/search.service.ts --- @@ -30,6 +30,7 @@ import { RestError } from '../model/rest-error'; impor

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234288184 --- Diff: metron-interface/metron-alerts/src/app/service/authentication.service.ts --- @@ -22,26 +22,28 @@ import {Router} from '@angular/router'; impo

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234288118 --- Diff: metron-interface/metron-alerts/src/app/service/alerts.service.ts --- @@ -22,14 +22,15 @@ import {Alert} from '../model/alert'; import { HttpC

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234288233 --- Diff: metron-interface/metron-alerts/src/app/service/global-config.service.ts --- @@ -21,14 +21,15 @@ import { Injectable } from '@angular/core'; i

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234288029 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.spec.ts --- @@ -28,6 +28,7 @@ import { PcapRequest } from '../model/p

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234288056 --- Diff: metron-interface/metron-alerts/src/app/pcap/service/pcap.service.spec.ts --- @@ -33,6 +33,7 @@ import { PcapStatusResponse } from '../model/pcap-

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234288083 --- Diff: metron-interface/metron-alerts/src/app/pcap/service/pcap.service.ts --- @@ -25,6 +25,7 @@ import { HttpUtil } from '../../utils/httpUtil'; im

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234287914 --- Diff: metron-interface/metron-alerts/src/app/app.module.ts --- @@ -48,13 +48,11 @@ import { GlobalConfigService } from './service/global-config.service'

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234287807 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.spec.ts --- @@ -32,6 +32,14 @@ import { UpdateService } f

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234287609 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.spec.ts --- @@ -31,12 +31,20 @@ import { UpdateService

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-16 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1266#discussion_r234283406 --- Diff: metron-interface/metron-alerts/src/app/service/app-config.service.ts --- @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] metron pull request #1268: METRON-1877: Nested IF ELSE statements can cause ...

2018-11-16 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/metron/pull/1268 METRON-1877: Nested IF ELSE statements can cause parse errors in Stellar ## Contributor Comments When we're dealing with if-else, the existing code would simply say we need to skip an else.

[GitHub] metron pull request #1262: METRON-1871 Cannot Run Elasticsearch Integration ...

2018-11-16 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/1262 ---

[GitHub] metron pull request #1249: METRON-1815: Separate metron-parsers into metron-...

2018-11-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1249#discussion_r234230655 --- Diff: README.md --- @@ -132,7 +132,7 @@ component and Apache Kafka as the unified data bus. Some high level links to the relevant subpar

[GitHub] metron pull request #1249: METRON-1815: Separate metron-parsers into metron-...

2018-11-16 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1249#discussion_r234218876 --- Diff: README.md --- @@ -132,7 +132,7 @@ component and Apache Kafka as the unified data bus. Some high level links to the relevant subparts

[GitHub] metron pull request #1267: METRON-1873: Update Bootstrap version in Manageme...

2018-11-16 Thread sardell
GitHub user sardell opened a pull request: https://github.com/apache/metron/pull/1267 METRON-1873: Update Bootstrap version in Management UI ## Contributor Comments Link to original ticket here: https://jira.apache.org/jira/browse/METRON-1873 We are currently using an a

[GitHub] metron pull request #1242: METRON-1834: Migrate Elasticsearch from Transport...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1242 ---

[GitHub] metron pull request #1266: METRON-1875: Expose configurable global settings ...

2018-11-15 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1266 METRON-1875: Expose configurable global settings in the Alerts UI ## Contributor Comments This PR exposes a JSON file that can be used to configure the Alerts UI. Properties in this file are

[GitHub] metron pull request #1265: METRON-1874 Create a Parser Debugger

2018-11-15 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1265 METRON-1874 Create a Parser Debugger Users should be able to parse messages in a controlled environment like the Stellar REPL. This can help troubleshoot issues that are occurring at high velo

[GitHub] metron pull request #1249: METRON-1815: Separate metron-parsers into metron-...

2018-11-15 Thread justinleet
GitHub user justinleet reopened a pull request: https://github.com/apache/metron/pull/1249 METRON-1815: Separate metron-parsers into metron-parsers-common and metron-parsers-storm ## Contributor Comments Separating metron-parsers into metron-parsers-common and metron-parsers-st

[GitHub] metron pull request #1249: METRON-1815: Separate metron-parsers into metron-...

2018-11-15 Thread justinleet
Github user justinleet closed the pull request at: https://github.com/apache/metron/pull/1249 ---

[GitHub] metron pull request #1249: METRON-1815: Separate metron-parsers into metron-...

2018-11-15 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1249#discussion_r233920015 --- Diff: README.md --- @@ -132,7 +132,7 @@ component and Apache Kafka as the unified data bus. Some high level links to the relevant subpar

[GitHub] metron pull request #526: Metron-846: Add E2E tests for metron management ui

2018-11-14 Thread gmcdonald
Github user gmcdonald closed the pull request at: https://github.com/apache/metron/pull/526 ---

[GitHub] metron pull request #857: METRON-1340: Improve e2e tests for metron alerts

2018-11-14 Thread gmcdonald
Github user gmcdonald closed the pull request at: https://github.com/apache/metron/pull/857 ---

[GitHub] metron pull request #1217: METRON-1749: Update Angular to latest release in ...

2018-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1217 ---

[GitHub] metron pull request #1181: METRON-1762: Change default Elasticsearch field r...

2018-11-14 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1181 ---

[GitHub] metron pull request #1263: METRON-1870: Intermittent Stellar REST test failu...

2018-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1263 ---

[GitHub] metron pull request #1264: METRON-1872: Move rat plugin away from snapshot v...

2018-11-14 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/metron/pull/1264 METRON-1872: Move rat plugin away from snapshot version ## Contributor Comments Removes the Apache dev snapshot plugin repo, and bumps the rat version to 0.13 instead of 0.13-SNAPSHOT

[GitHub] metron pull request #1263: METRON-1870: Intermittent Stellar REST test failu...

2018-11-14 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1263 METRON-1870: Intermittent Stellar REST test failures ## Contributor Comments This PR attempts to fix the intermittent test failures reported in the Jira. For this failure: ```

[GitHub] metron pull request #1260: METRON-1868: metron-committer-common incorrectly ...

2018-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1260 ---

[GitHub] metron pull request #1262: METRON-1871 Cannot Run Elasticsearch Integration ...

2018-11-14 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1262 METRON-1871 Cannot Run Elasticsearch Integration Tests in IDE There are some log4j dependencies in the metron-elasticsearch that cause problems when attempting to run the Elasticsearch integrati

[GitHub] metron pull request #1261: METRON-1860 [WIP] new developer option for ansibl...

2018-11-13 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/1261 METRON-1860 [WIP] new developer option for ansible in docker to deploy to vagrant The goal of this PR is to provide a new "full_dev" option for new and old users that does not require as muc

[GitHub] metron pull request #1260: METRON-1868: metron-committer-common incorrectly ...

2018-11-13 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron/pull/1260 METRON-1868: metron-committer-common incorrectly checking CHOSEN_REPO ## Contributor Comments I found a minor bug when trying to use `prepare-commit` against the metron-bro-plugin-kafka repo.

[GitHub] metron pull request #1259: METRON-1867 Remove `/api/v1/update/replace` endpo...

2018-11-13 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1259 METRON-1867 Remove `/api/v1/update/replace` endpoint The `/api/v1/update/replace` endpoint is no longer used. This is dead code and should be removed. This is dependent on the followin

[GitHub] metron pull request #1171: METRON-1740 make parser support CONFIG and SYSTEM...

2018-11-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1171 ---

[GitHub] metron pull request #1245: METRON-1795: Initial Commit for Regular Expressio...

2018-11-12 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1245#discussion_r232347905 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/Constants.java --- @@ -127,5 +127,48 @@ public String getType() {

[GitHub] metron pull request #1245: METRON-1795: Initial Commit for Regular Expressio...

2018-11-12 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1245#discussion_r232356461 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/regex/RegularExpressionsParser.java --- @@ -0,0 +1,427 @@ +/**

[GitHub] metron pull request #1245: METRON-1795: Initial Commit for Regular Expressio...

2018-11-12 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1245#discussion_r232362818 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/regex/RegularExpressionsParser.java --- @@ -0,0 +1,427 @@ +/**

[GitHub] metron pull request #1245: METRON-1795: Initial Commit for Regular Expressio...

2018-11-12 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1245#discussion_r232352458 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/regex/RegularExpressionsParser.java --- @@ -0,0 +1,427 @@ +/**

[GitHub] metron pull request #1245: METRON-1795: Initial Commit for Regular Expressio...

2018-11-12 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1245#discussion_r232346004 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/Constants.java --- @@ -127,5 +127,48 @@ public String getType() {

[GitHub] metron pull request #1245: METRON-1795: Initial Commit for Regular Expressio...

2018-11-12 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1245#discussion_r232689398 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/regex/RegularExpressionsParserTest.java --- @@ -0,0 +1,118 @@ +/**

[GitHub] metron pull request #1245: METRON-1795: Initial Commit for Regular Expressio...

2018-11-12 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1245#discussion_r232354644 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/regex/RegularExpressionsParser.java --- @@ -0,0 +1,427 @@ +/**

[GitHub] metron pull request #1245: METRON-1795: Initial Commit for Regular Expressio...

2018-11-12 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1245#discussion_r232353483 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/regex/RegularExpressionsParser.java --- @@ -0,0 +1,427 @@ +/**

[GitHub] metron pull request #1248: METRON-1847 break out functions from prepare-comm...

2018-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1248 ---

[GitHub] metron pull request #1014: METRON-1563 : Base Stellar assign for feature bra...

2018-11-08 Thread ottobackwards
Github user ottobackwards closed the pull request at: https://github.com/apache/metron/pull/1014 ---

[GitHub] metron pull request #1250: METRON-1850: Stellar REST function

2018-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1250 ---

[GitHub] metron pull request #1255: METRON-1858 Fix Fireeye formatting and some optim...

2018-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1255 ---

[GitHub] metron pull request #1258: METRON-1864 fix issue where daylight savings brea...

2018-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1258 ---

[GitHub] metron pull request #1250: METRON-1850: Stellar REST function

2018-11-08 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1250 ---

[GitHub] metron pull request #1250: METRON-1850: Stellar REST function

2018-11-08 Thread merrimanr
GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/1250 METRON-1850: Stellar REST function ## Contributor Comments This PR adds a Stellar REST function that can be used to enrich messages with data from 3rd party REST services. This function le

[GitHub] metron pull request #1258: METRON-1864 fix issue where daylight savings brea...

2018-11-08 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/1258 METRON-1864 fix issue where daylight savings breaks tests Thanks to @justinleet for the fix. I would have use a totally awesome but overdone regex. ### For all changes: - [x] Is

[GitHub] metron pull request #1256: METRON-1861: REST fails to start when LDAP enable...

2018-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1256 ---

[GitHub] metron pull request #1256: METRON-1861: REST fails to start when LDAP enable...

2018-11-08 Thread anandsubbu
GitHub user anandsubbu opened a pull request: https://github.com/apache/metron/pull/1256 METRON-1861: REST fails to start when LDAP enabled and 'Active Spring profiles' config is empty ## Contributor Comments Set 'Active Spring profiles' to just `ldap`, when `metron_spring_prof

[GitHub] metron pull request #1242: METRON-1834: Migrate Elasticsearch from Transport...

2018-11-07 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1242#discussion_r231704912 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/client/ElasticsearchClient.java --- @@ -0,0 +1,147 @@ +/*

[GitHub] metron pull request #1242: METRON-1834: Migrate Elasticsearch from Transport...

2018-11-06 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1242#discussion_r231369990 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/ElasticsearchWriter.java --- @@ -76,7 +76,8 @@ public

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1251 ---

[GitHub] metron pull request #1255: METRON-1858 Fix Fireeye formatting and some optim...

2018-11-06 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/1255 METRON-1858 Fix Fireeye formatting and some optimization Reformat and fix checkstyle. Changed to not compile patterns every parse() All tests should pass as before, no behavior c

[GitHub] metron pull request #1253: METRON-1857 Fix Metaalert Nested Alert Field Name...

2018-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1253 ---

[GitHub] metron pull request #1252: METRON-1855: Make unified enrichment topology the...

2018-11-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1252 ---

[GitHub] metron pull request #1254: METRON-1849 Elasticsearch Index Write Functionali...

2018-11-05 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1254 METRON-1849 Elasticsearch Index Write Functionality Should be Shared The Elasticsearch index write functionality is currently duplicated between the `ElasticsearchWriter` and the `ElasticsearchU

[GitHub] metron pull request #1252: METRON-1855: Make unified enrichment topology the...

2018-11-05 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1252#discussion_r230869589 --- Diff: metron-platform/metron-enrichment/README.md --- @@ -76,6 +62,19 @@ intel bolt, the configurations will be taken from the respective join bolt

[GitHub] metron pull request #1252: METRON-1855: Make unified enrichment topology the...

2018-11-05 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1252#discussion_r230867139 --- Diff: metron-platform/metron-enrichment/src/main/scripts/start_enrichment_topology.sh --- @@ -20,7 +20,7 @@ METRON_VERSION=${project.version} MET

[GitHub] metron pull request #1252: METRON-1855: Make unified enrichment topology the...

2018-11-05 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1252#discussion_r230864542 --- Diff: metron-platform/metron-enrichment/README.md --- @@ -76,6 +62,19 @@ intel bolt, the configurations will be taken from the respective join bolt

[GitHub] metron pull request #1252: METRON-1855: Make unified enrichment topology the...

2018-11-05 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1252#discussion_r230803329 --- Diff: metron-platform/metron-enrichment/src/main/scripts/start_enrichment_topology.sh --- @@ -20,7 +20,7 @@ METRON_VERSION=${project.version} M

[GitHub] metron pull request #1252: METRON-1855: Make unified enrichment topology the...

2018-11-05 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1252#discussion_r230802749 --- Diff: metron-platform/metron-enrichment/README.md --- @@ -76,6 +62,19 @@ intel bolt, the configurations will be taken from the respective join bolt

[GitHub] metron pull request #1208: METRON-1790: Unsubscribe from every observable in...

2018-11-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1208 ---

[GitHub] metron pull request #1253: METRON-1857 Fix Metaalert Nested Alert Field Name...

2018-11-05 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1253 METRON-1857 Fix Metaalert Nested Alert Field Name in Index Template In #1049 the metaalert index template was updated to rename the alert field 'metron_alert'. The nested alert field was missed

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1251#discussion_r230586264 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/BaseFunctionResolver.java --- @@ -94,6 +95,16

[GitHub] metron pull request #1252: METRON-1855: Make unified enrichment topology the...

2018-11-03 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/1252 METRON-1855: Make unified enrichment topology the default and deprecate split-join ## Contributor Comments https://issues.apache.org/jira/browse/METRON-1855 Deprecates the split-

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-03 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1251#discussion_r230560963 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/BaseFunctionResolver.java --- @@ -94,6 +95,16 @@ pu

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-03 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1251#discussion_r230560387 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/BaseFunctionResolver.java --- @@ -94,6 +95,16 @@ pu

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-03 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1251#discussion_r230560366 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/FunctionResolver.java --- @@ -43,4 +45,11 @@

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-02 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1251#discussion_r230517539 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/FunctionResolver.java --- @@ -43,4 +45,11 @@

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-02 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1251#discussion_r230517250 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/BaseFunctionResolver.java --- @@ -94,6 +95,16

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-02 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1251#discussion_r230485589 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/StellarFunction.java --- @@ -23,4 +23,5 @@ Object apply(List ar

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-02 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1251#discussion_r230484974 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/StellarFunctions.java --- @@ -30,4 +30,8 @@ public static FunctionRes

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-02 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1251#discussion_r230480258 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/StellarFunction.java --- @@ -23,4 +23,5 @@ Object apply(Li

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-02 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1251#discussion_r230480099 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/StellarFunction.java --- @@ -23,4 +23,5 @@ Object apply(Li

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-02 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1251#discussion_r230479920 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/StellarFunctions.java --- @@ -30,4 +30,8 @@ public static Functio

[GitHub] metron pull request #1251: METRON-1853: Add shutdown hook to Stellar BaseFun...

2018-11-02 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/1251 METRON-1853: Add shutdown hook to Stellar BaseFunctionResolver ## Contributor Comments https://issues.apache.org/jira/browse/METRON-1853 Noodling on a method to add shutdown hooks

[GitHub] metron pull request #1250: METRON-1850: Stellar REST function

2018-11-02 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1250#discussion_r230468297 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/RestFunctions.java --- @@ -0,0 +1,351 @@ +/** + * L

[GitHub] metron pull request #1226: METRON-1803: Integrate Cypress with Travis

2018-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1226 ---

[GitHub] metron pull request #1246: METRON-1844: Allow for LDAP to be used for authen...

2018-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1246 ---

[GitHub] metron pull request #1250: METRON-1850: Stellar REST function

2018-11-02 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1250 ---

[GitHub] metron pull request #1250: METRON-1850: Stellar REST function

2018-11-02 Thread merrimanr
GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/1250 METRON-1850: Stellar REST function ## Contributor Comments This PR adds a Stellar REST function that can be used to enrich messages with data from 3rd party REST services. This function le

[GitHub] metron pull request #1250: METRON-1850: Stellar REST function

2018-11-02 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1250#discussion_r230386648 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/RestFunctions.java --- @@ -0,0 +1,351 @@ +/** + * L

[GitHub] metron pull request #1250: METRON-1850: Stellar REST function

2018-11-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1250#discussion_r230382737 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/RestFunctions.java --- @@ -0,0 +1,351 @@ +/** + *

[GitHub] metron pull request #1250: METRON-1850: Stellar REST function

2018-11-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1250#discussion_r230375318 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/RestFunctions.java --- @@ -0,0 +1,351 @@ +/** + *

<    1   2   3   4   5   6   7   8   9   10   >