[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401471#comment-16401471 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on the issue:

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-15 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Apologises, won't be able to finish the review this evening. I reviewed the restapi nar License and Notice files they look good to go. Just need to do a bit of functional testing and verify

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401452#comment-16401452 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on the issue:

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-15 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 The nifi-elasticsearch-client-service-nar is missing a license and notice. ---

[jira] [Commented] (NIFI-4246) OAuth 2 Authorization support - Client Credentials Grant

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401289#comment-16401289 ] ASF GitHub Bot commented on NIFI-4246: -- Github user alopresto commented on a diff in the pull request:

[GitHub] nifi pull request #2085: NIFI-4246 - Client Credentials Grant based OAuth2 C...

2018-03-15 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2085#discussion_r174967440 --- Diff: nifi-nar-bundles/nifi-oauth-bundle/nifi-oauth/src/main/java/org/apache/nifi/oauth/OAuth2ClientCredentialsGrantControllerService.java --- @@ -0,0

[jira] [Commented] (NIFI-4246) OAuth 2 Authorization support - Client Credentials Grant

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401287#comment-16401287 ] ASF GitHub Bot commented on NIFI-4246: -- Github user alopresto commented on a diff in the pull request:

[GitHub] nifi pull request #2085: NIFI-4246 - Client Credentials Grant based OAuth2 C...

2018-03-15 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2085#discussion_r174967129 --- Diff: nifi-nar-bundles/nifi-oauth-bundle/nifi-oauth/src/main/java/org/apache/nifi/oauth/httpclient/OAuthHTTPConnectionClient.java --- @@ -0,0 +1,252

[jira] [Commented] (NIFI-4950) MergeContent: Defragment can improperly reassemble

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401259#comment-16401259 ] ASF GitHub Bot commented on NIFI-4950: -- GitHub user markobean opened a pull request:

[GitHub] nifi pull request #2557: NIFI-4950 Defining behavior for MergeContent when m...

2018-03-15 Thread markobean
GitHub user markobean opened a pull request: https://github.com/apache/nifi/pull/2557 NIFI-4950 Defining behavior for MergeContent when more than 1 FlowFil… …e has the same fragment.index value Thank you for submitting a contribution to Apache NiFi. In order to

[jira] [Commented] (NIFI-4980) Typo in ReportAtlasLineage kafka kerberos service name property

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401245#comment-16401245 ] ASF GitHub Bot commented on NIFI-4980: -- Github user ijokarumawak commented on the issue:

[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...

2018-03-15 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2550 @pvillard31 Yes, it's a breaking change. I wrote a comment on the JIRA.

[jira] [Commented] (NIFI-4908) Add Consumer and Producer Processors for Apache Pulsar

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401126#comment-16401126 ] ASF GitHub Bot commented on NIFI-4908: -- Github user david-streamlio commented on the issue:

[GitHub] nifi issue #2540: Nifi 4914

2018-03-15 Thread david-streamlio
Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2540 This branch is based on NIFI-4908 which you are also reviewing. Therefore, once we complete that code review, I will cherry pick those commits into this branch. ---

[jira] [Commented] (NIFI-4246) OAuth 2 Authorization support - Client Credentials Grant

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401121#comment-16401121 ] ASF GitHub Bot commented on NIFI-4246: -- Github user jdye64 commented on a diff in the pull request:

[GitHub] nifi pull request #2085: NIFI-4246 - Client Credentials Grant based OAuth2 C...

2018-03-15 Thread jdye64
Github user jdye64 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2085#discussion_r174933983 --- Diff: nifi-nar-bundles/nifi-oauth-bundle/nifi-oauth/src/main/java/org/apache/nifi/oauth/httpclient/OAuthHTTPConnectionClient.java --- @@ -0,0 +1,252 @@

[jira] [Commented] (NIFI-4246) OAuth 2 Authorization support - Client Credentials Grant

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401120#comment-16401120 ] ASF GitHub Bot commented on NIFI-4246: -- Github user jdye64 commented on a diff in the pull request:

[GitHub] nifi pull request #2085: NIFI-4246 - Client Credentials Grant based OAuth2 C...

2018-03-15 Thread jdye64
Github user jdye64 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2085#discussion_r174933433 --- Diff: nifi-nar-bundles/nifi-oauth-bundle/nifi-oauth/src/main/java/org/apache/nifi/oauth/httpclient/OAuthHTTPConnectionClient.java --- @@ -0,0 +1,252 @@

[jira] [Commented] (NIFI-3599) Add nifi.properties value to globally set the default backpressure size threshold for each connection

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401115#comment-16401115 ] ASF GitHub Bot commented on NIFI-3599: -- Github user mosermw commented on the issue:

[GitHub] nifi issue #2497: NIFI-3599 Allowed back pressure object count and data size...

2018-03-15 Thread mosermw
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2497 @mcgilma @markap14 I'm not sure I was able to fully grok "add a ConfigDTO which is set on the AboutDTO" but I gave it a shot. Rebased from master and pushed a new commit. Let me know what you

[jira] [Commented] (NIFI-4246) OAuth 2 Authorization support - Client Credentials Grant

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1640#comment-1640 ] ASF GitHub Bot commented on NIFI-4246: -- Github user jdye64 commented on a diff in the pull request:

[GitHub] nifi pull request #2085: NIFI-4246 - Client Credentials Grant based OAuth2 C...

2018-03-15 Thread jdye64
Github user jdye64 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2085#discussion_r174931088 --- Diff: nifi-nar-bundles/nifi-oauth-bundle/nifi-oauth/src/main/java/org/apache/nifi/oauth/OAuth2ClientCredentialsGrantControllerService.java --- @@ -0,0

[jira] [Updated] (NIFI-4981) Allow to use the flowfile content as body in PutEmail

2018-03-15 Thread Pierre Villard (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-4981: - Status: Patch Available (was: Open) > Allow to use the flowfile content as body in PutEmail >

[jira] [Commented] (NIFI-4981) Allow to use the flowfile content as body in PutEmail

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401093#comment-16401093 ] ASF GitHub Bot commented on NIFI-4981: -- GitHub user pvillard31 opened a pull request:

[GitHub] nifi pull request #2556: NIFI-4981 - Allow using FF's content as message in ...

2018-03-15 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2556 NIFI-4981 - Allow using FF's content as message in PutEmail Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi pull request #2540: Nifi 4914

2018-03-15 Thread david-streamlio
Github user david-streamlio closed the pull request at: https://github.com/apache/nifi/pull/2540 ---

[jira] [Commented] (NIFI-4959) HandleHttpRequest processor doesn't close/release incomplete message error

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401072#comment-16401072 ] ASF GitHub Bot commented on NIFI-4959: -- Github user markap14 commented on a diff in the pull request:

[GitHub] nifi pull request #2544: NIFI-4959: Remove flowfiles and close connection fo...

2018-03-15 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2544#discussion_r174922021 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java --- @@

[jira] [Updated] (NIFI-4935) Support Schema Branches when using HWX Schema Registry

2018-03-15 Thread Mark Payne (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-4935: - Resolution: Fixed Fix Version/s: 1.6.0 Status: Resolved (was: Patch Available) >

[jira] [Commented] (NIFI-4935) Support Schema Branches when using HWX Schema Registry

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401059#comment-16401059 ] ASF GitHub Bot commented on NIFI-4935: -- Github user asfgit closed the pull request at:

[GitHub] nifi pull request #2523: NIFI-4935 Support Schema Branches when using HWX Sc...

2018-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2523 ---

[jira] [Commented] (NIFI-4935) Support Schema Branches when using HWX Schema Registry

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401058#comment-16401058 ] ASF GitHub Bot commented on NIFI-4935: -- Github user markap14 commented on the issue:

[jira] [Commented] (NIFI-4935) Support Schema Branches when using HWX Schema Registry

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401056#comment-16401056 ] ASF subversion and git services commented on NIFI-4935: --- Commit

[GitHub] nifi issue #2523: NIFI-4935 Support Schema Branches when using HWX Schema Re...

2018-03-15 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2523 Great thanks @bbende all looks good to me. +1 merged to master. ---

[jira] [Updated] (NIFI-4809) Implement a SiteToSiteMetricsReportingTask

2018-03-15 Thread Matt Burgess (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-4809: --- Fix Version/s: 1.6.0 > Implement a SiteToSiteMetricsReportingTask >

[jira] [Updated] (NIFI-4809) Implement a SiteToSiteMetricsReportingTask

2018-03-15 Thread Matt Burgess (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-4809: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Implement a

[jira] [Commented] (NIFI-4809) Implement a SiteToSiteMetricsReportingTask

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401047#comment-16401047 ] ASF GitHub Bot commented on NIFI-4809: -- Github user asfgit closed the pull request at:

[GitHub] nifi pull request #2430: NIFI-4809 - Implement a SiteToSiteMetricsReportingT...

2018-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2430 ---

[jira] [Commented] (NIFI-4809) Implement a SiteToSiteMetricsReportingTask

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401042#comment-16401042 ] ASF GitHub Bot commented on NIFI-4809: -- Github user mattyb149 commented on the issue:

[jira] [Commented] (NIFI-4809) Implement a SiteToSiteMetricsReportingTask

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401043#comment-16401043 ] ASF subversion and git services commented on NIFI-4809: --- Commit

[jira] [Commented] (NIFI-4809) Implement a SiteToSiteMetricsReportingTask

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401044#comment-16401044 ] ASF subversion and git services commented on NIFI-4809: --- Commit

[GitHub] nifi issue #2430: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-03-15 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2430 +1 LGTM, ran the unit tests and tried on a live NiFi instance with both Ambari and Record modes. The only thing I noticed (that should be its own Jira) is that the RecordWriter used by the

[GitHub] nifi issue #2523: NIFI-4935 Support Schema Branches when using HWX Schema Re...

2018-03-15 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2523 @markap14 pushed another commit that addresses 3 of the 4 comments, I didn't add the branch option to the attributes access strategy, let me know if you think we need to do that. ---

[jira] [Commented] (NIFI-4935) Support Schema Branches when using HWX Schema Registry

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401038#comment-16401038 ] ASF GitHub Bot commented on NIFI-4935: -- Github user bbende commented on the issue:

[jira] [Created] (MINIFICPP-429) RPG won't work if curl isn't built.

2018-03-15 Thread marco polo (JIRA)
marco polo created MINIFICPP-429: Summary: RPG won't work if curl isn't built. Key: MINIFICPP-429 URL: https://issues.apache.org/jira/browse/MINIFICPP-429 Project: NiFi MiNiFi C++ Issue

[jira] [Commented] (NIFI-4895) Implement back-end for terminating a Processor

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401031#comment-16401031 ] ASF GitHub Bot commented on NIFI-4895: -- GitHub user markap14 opened a pull request:

[GitHub] nifi pull request #2555: NIFI-4895: Added backend code to give users the abi...

2018-03-15 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2555 NIFI-4895: Added backend code to give users the ability to forcibly t… …erminate a processor if the processor does not complete after clicking Stop Thank you for submitting a

[GitHub] nifi issue #2540: Nifi 4914

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2540 Saw you opened a new version of this. Can you close this one? ---

[jira] [Updated] (NIFI-4849) Add REST Endpoint for gathering Processor Diagnostics information

2018-03-15 Thread Matt Gilman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-4849: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Add REST Endpoint for gathering

[jira] [Commented] (NIFI-4849) Add REST Endpoint for gathering Processor Diagnostics information

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400976#comment-16400976 ] ASF GitHub Bot commented on NIFI-4849: -- Github user mcgilman commented on the issue:

[jira] [Commented] (NIFI-4849) Add REST Endpoint for gathering Processor Diagnostics information

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400977#comment-16400977 ] ASF GitHub Bot commented on NIFI-4849: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-4849) Add REST Endpoint for gathering Processor Diagnostics information

2018-03-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400975#comment-16400975 ] ASF subversion and git services commented on NIFI-4849: --- Commit

[GitHub] nifi pull request #2468: NIFI-4849: Implemented REST Endpoint and associated...

2018-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2468 ---

[GitHub] nifi issue #2468: NIFI-4849: Implemented REST Endpoint and associated backen...

2018-03-15 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2468 Thanks @markap14! This has been merged to master. ---

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread david-streamlio
Github user david-streamlio commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174898281 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java --- @@

[jira] [Commented] (NIFI-4935) Support Schema Branches when using HWX Schema Registry

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400964#comment-16400964 ] ASF GitHub Bot commented on NIFI-4935: -- Github user bbende commented on a diff in the pull request:

[GitHub] nifi pull request #2523: NIFI-4935 Support Schema Branches when using HWX Sc...

2018-03-15 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/2523#discussion_r174895925 --- Diff:

[jira] [Commented] (NIFI-4935) Support Schema Branches when using HWX Schema Registry

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400961#comment-16400961 ] ASF GitHub Bot commented on NIFI-4935: -- Github user bbende commented on a diff in the pull request:

[GitHub] nifi pull request #2523: NIFI-4935 Support Schema Branches when using HWX Sc...

2018-03-15 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/2523#discussion_r174895242 --- Diff:

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400947#comment-16400947 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on the issue:

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400945#comment-16400945 ] ASF GitHub Bot commented on NIFI-4325: -- Github user MikeThomsen commented on the issue:

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-15 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Thanks @MikeThomsen I should be able to take another look later tonight ---

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2113 @JPercivall It's ready for review. ---

[GitHub] nifi issue #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2553 @david-streamlio thanks for the link. > Is there another car bundle that uses a Docker image for integration testing that I can use as an example? The Mongo package, sorta. We

[jira] [Commented] (NIFI-4246) OAuth 2 Authorization support - Client Credentials Grant

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400923#comment-16400923 ] ASF GitHub Bot commented on NIFI-4246: -- Github user alopresto commented on the issue:

[jira] [Commented] (NIFI-4935) Support Schema Branches when using HWX Schema Registry

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400919#comment-16400919 ] ASF GitHub Bot commented on NIFI-4935: -- Github user bbende commented on a diff in the pull request:

[jira] [Commented] (NIFI-4935) Support Schema Branches when using HWX Schema Registry

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400924#comment-16400924 ] ASF GitHub Bot commented on NIFI-4935: -- Github user bbende commented on a diff in the pull request:

[GitHub] nifi issue #2085: NIFI-4246 - Client Credentials Grant based OAuth2 Controll...

2018-03-15 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2085 I believe Jeremy's focused on another task right now but when he is available, I will work with him to resolve the code issues and we will verify the behavior with the relevant auth servers. ---

[GitHub] nifi pull request #2523: NIFI-4935 Support Schema Branches when using HWX Sc...

2018-03-15 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/2523#discussion_r174888759 --- Diff:

[GitHub] nifi pull request #2523: NIFI-4935 Support Schema Branches when using HWX Sc...

2018-03-15 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/2523#discussion_r174888711 --- Diff: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/StandardSchemaIdentifier.java --- @@ -64,6 +75,49 @@ public boolean

[GitHub] nifi issue #2553: Nifi 4908 rebase

2018-03-15 Thread david-streamlio
Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2553 @MikeThomsen We have a pre-configured Docker image that has Pulsar if you want to use that for testing. See https://streaml.io/docs/getting-started. for detailed instructions. ---

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174883410 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174881995 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174874403 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/pool/ResourcePoolImpl.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174881541 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java --- @@ -0,0

[GitHub] nifi issue #2553: Nifi 4908 rebase

2018-03-15 Thread david-streamlio
Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2553 @MikeThomsen Is there another car bundle that uses a Docker image for integration testing that I can use as an example? I will clean up the formatting / style errors. ---

[jira] [Commented] (NIFI-4246) OAuth 2 Authorization support - Client Credentials Grant

2018-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400906#comment-16400906 ] ASF GitHub Bot commented on NIFI-4246: -- Github user alopresto commented on a diff in the pull request:

[GitHub] nifi pull request #2085: NIFI-4246 - Client Credentials Grant based OAuth2 C...

2018-03-15 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2085#discussion_r174886395 --- Diff: nifi-nar-bundles/nifi-oauth-bundle/nifi-oauth/src/main/java/org/apache/nifi/oauth/httpclient/OAuthHTTPConnectionClient.java --- @@ -0,0 +1,252

[GitHub] nifi issue #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2553 You should strongly consider setting up some integration tests that can be run against a simple Docker image. All you have to do with NiFi to get that done is add a few classes with "IT" at the

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174881132 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174873036 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174880893 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174872527 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174878320 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/test/java/org/apache/nifi/pulsar/TestStandardPulsarClientService.java ---

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174882988 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174884957 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/PublishPulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174883778 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/PublishPulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174884531 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/PublishPulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174879831 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174872630 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174874448 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/pool/ResourcePoolImpl.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174884100 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/PublishPulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174878122 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/pool/ResourcePoolImpl.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174879028 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/pom.xml --- @@ -0,0 +1,78 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174872872 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174879478 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174866298 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/pool/PoolableResource.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174882429 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174882522 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java --- @@ -0,0

[GitHub] nifi pull request #2553: Nifi 4908 rebase

2018-03-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2553#discussion_r174884863 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/PublishPulsar_1_0.java --- @@ -0,0

  1   2   >