[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r192049919 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchLookupService.

[jira] [Commented] (NIFI-5051) Create a LookupService that uses ElasticSearch

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496333#comment-16496333 ] ASF GitHub Bot commented on NIFI-5051: -- Github user MikeThomsen commented on a diff i

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r192050258 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml --- @@ -120,6 +132,22 @@ 1.7.0-SNAPSHOT

[jira] [Commented] (NIFI-5051) Create a LookupService that uses ElasticSearch

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496334#comment-16496334 ] ASF GitHub Bot commented on NIFI-5051: -- Github user MikeThomsen commented on a diff i

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r192050600 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml --- @@ -127,8 +133,104 @@ 5.6.8

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r192050863 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchLookupService.

[jira] [Commented] (NIFI-5051) Create a LookupService that uses ElasticSearch

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496335#comment-16496335 ] ASF GitHub Bot commented on NIFI-5051: -- Github user MikeThomsen commented on a diff i

[jira] [Commented] (NIFI-5051) Create a LookupService that uses ElasticSearch

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496336#comment-16496336 ] ASF GitHub Bot commented on NIFI-5051: -- Github user MikeThomsen commented on a diff i

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r192050876 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchLookupService.

[jira] [Commented] (NIFI-5051) Create a LookupService that uses ElasticSearch

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496337#comment-16496337 ] ASF GitHub Bot commented on NIFI-5051: -- Github user MikeThomsen commented on a diff i

[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-31 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @pvillard31 @mattyb149 changes checked in. ---

[jira] [Commented] (NIFI-5051) Create a LookupService that uses ElasticSearch

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496360#comment-16496360 ] ASF GitHub Bot commented on NIFI-5051: -- Github user MikeThomsen commented on the issu

[GitHub] nifi pull request #2594: NIFI-5024 Resolves deadlock in ExecuteStreamCommand...

2018-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2594 ---

[jira] [Resolved] (NIFI-5024) Deadlock in ExecuteStreamCommand processor

2018-05-31 Thread Mike Thomsen (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen resolved NIFI-5024. Resolution: Fixed Fix Version/s: 1.7.0 > Deadlock in ExecuteStreamCommand processor > ---

[jira] [Commented] (NIFI-5024) Deadlock in ExecuteStreamCommand processor

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496373#comment-16496373 ] ASF GitHub Bot commented on NIFI-5024: -- Github user asfgit closed the pull request at

[jira] [Commented] (NIFI-5024) Deadlock in ExecuteStreamCommand processor

2018-05-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496371#comment-16496371 ] ASF subversion and git services commented on NIFI-5024: --- Commit 498f

[jira] [Assigned] (NIFI-5254) Upgrade to Groovy 2.5.0

2018-05-31 Thread Mike Thomsen (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen reassigned NIFI-5254: -- Assignee: Mike Thomsen > Upgrade to Groovy 2.5.0 > --- > >

[jira] [Commented] (NIFI-5254) Upgrade to Groovy 2.5.0

2018-05-31 Thread Mike Thomsen (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496383#comment-16496383 ] Mike Thomsen commented on NIFI-5254: Apparently the jar isn't in maven central yet, bu

[GitHub] nifi issue #2747: NIFI-5249 Dockerfile enhancements

2018-05-31 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2747 Can you add explicit steps to test and verify, for those of use who don't work with docker as much? ---

[jira] [Commented] (NIFI-5249) Dockerfile enhancements

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496421#comment-16496421 ] ASF GitHub Bot commented on NIFI-5249: -- Github user ottobackwards commented on the is

[GitHub] nifi issue #2747: NIFI-5249 Dockerfile enhancements

2018-05-31 Thread pepov
Github user pepov commented on the issue: https://github.com/apache/nifi/pull/2747 yes, working on it ---

[jira] [Commented] (NIFI-5249) Dockerfile enhancements

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496444#comment-16496444 ] ASF GitHub Bot commented on NIFI-5249: -- Github user pepov commented on the issue:

[GitHub] nifi issue #2747: NIFI-5249 Dockerfile enhancements

2018-05-31 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2747 Thanks, I'd like to try this and help with the review ---

[GitHub] nifi issue #2594: NIFI-5024 Resolves deadlock in ExecuteStreamCommand proces...

2018-05-31 Thread nsanglar
Github user nsanglar commented on the issue: https://github.com/apache/nifi/pull/2594 @MikeThomsen It's strange because I removed this 1mb.txt file and the corresponding exclusion in the previous commits. Did you added something before merging? I can see that the build is failing on

[jira] [Commented] (NIFI-5249) Dockerfile enhancements

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496450#comment-16496450 ] ASF GitHub Bot commented on NIFI-5249: -- Github user ottobackwards commented on the is

[jira] [Commented] (NIFI-5024) Deadlock in ExecuteStreamCommand processor

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496451#comment-16496451 ] ASF GitHub Bot commented on NIFI-5024: -- Github user nsanglar commented on the issue:

[GitHub] nifi issue #2594: NIFI-5024 Resolves deadlock in ExecuteStreamCommand proces...

2018-05-31 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2594 Don't worry about it, it's just a checkstyle issue. I can fix with a simple commit. ---

[jira] [Commented] (NIFI-5024) Deadlock in ExecuteStreamCommand processor

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496459#comment-16496459 ] ASF GitHub Bot commented on NIFI-5024: -- Github user MikeThomsen commented on the issu

[GitHub] nifi issue #2594: NIFI-5024 Resolves deadlock in ExecuteStreamCommand proces...

2018-05-31 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2594 Also, that exclude you removed is why it broke, but I forgot to do contrib-check apparently... ---

[jira] [Commented] (NIFI-5024) Deadlock in ExecuteStreamCommand processor

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496464#comment-16496464 ] ASF GitHub Bot commented on NIFI-5024: -- Github user MikeThomsen commented on the issu

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-05-31 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r192083397 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml --- @@ -212,6 +212,31 @@

[jira] [Commented] (NIFI-5051) Create a LookupService that uses ElasticSearch

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496471#comment-16496471 ] ASF GitHub Bot commented on NIFI-5051: -- Github user mattyb149 commented on a diff in

[jira] [Commented] (NIFI-5024) Deadlock in ExecuteStreamCommand processor

2018-05-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496475#comment-16496475 ] ASF subversion and git services commented on NIFI-5024: --- Commit 83fc

[jira] [Created] (NIFI-5255) UI - ability to connect multiple output ports to one input port

2018-05-31 Thread Pierre Villard (JIRA)
Pierre Villard created NIFI-5255: Summary: UI - ability to connect multiple output ports to one input port Key: NIFI-5255 URL: https://issues.apache.org/jira/browse/NIFI-5255 Project: Apache NiFi

[jira] [Commented] (NIFI-5255) UI - ability to connect multiple output ports to one input port

2018-05-31 Thread Matt Gilman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496549#comment-16496549 ] Matt Gilman commented on NIFI-5255: --- As a workaround while the use case is evaluated, ha

[jira] [Commented] (NIFI-5255) UI - ability to connect multiple output ports to one input port

2018-05-31 Thread Pierre Villard (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496657#comment-16496657 ] Pierre Villard commented on NIFI-5255: -- Yeah that's what I'm doing at the moment (see

[jira] [Updated] (NIFI-5255) UI - ability to connect multiple output ports to one input port

2018-05-31 Thread Pierre Villard (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-5255: - Attachment: Screen Shot 2018-05-31 at 4.49.35 PM.png > UI - ability to connect multiple output por

[GitHub] nifi issue #2630: NIFI-5041 Adds SPNEGO authentication to LivySessionControl...

2018-05-31 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2630 +1 LGTM, ran full build with contrib-check, also tested on HDP 2.6.4 and HDP 3.0 with and without Kerberos enabled, verified all behaviors are as expected. Thanks for this improvement! Merging to ma

[jira] [Commented] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496679#comment-16496679 ] ASF GitHub Bot commented on NIFI-5041: -- Github user mattyb149 commented on the issue:

[jira] [Commented] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-05-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496682#comment-16496682 ] ASF subversion and git services commented on NIFI-5041: --- Commit a179

[jira] [Commented] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-05-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496684#comment-16496684 ] ASF subversion and git services commented on NIFI-5041: --- Commit a179

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2630 ---

[jira] [Commented] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-05-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496683#comment-16496683 ] ASF subversion and git services commented on NIFI-5041: --- Commit a179

[jira] [Commented] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-05-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496681#comment-16496681 ] ASF subversion and git services commented on NIFI-5041: --- Commit a179

[jira] [Commented] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-05-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496687#comment-16496687 ] ASF subversion and git services commented on NIFI-5041: --- Commit a179

[jira] [Commented] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-05-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496685#comment-16496685 ] ASF subversion and git services commented on NIFI-5041: --- Commit a179

[jira] [Updated] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-05-31 Thread Matt Burgess (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-5041: --- Fix Version/s: 1.7.0 > Add convenient SPNEGO/Kerberos authentication support to LivySessionController

[jira] [Commented] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496688#comment-16496688 ] ASF GitHub Bot commented on NIFI-5041: -- Github user asfgit closed the pull request at

[jira] [Commented] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-05-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496686#comment-16496686 ] ASF subversion and git services commented on NIFI-5041: --- Commit a179

[jira] [Updated] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-05-31 Thread Matt Burgess (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-5041: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Add convenient SPNEGO/Kerberos au

[GitHub] nifi issue #2747: NIFI-5249 Dockerfile enhancements

2018-05-31 Thread pepov
Github user pepov commented on the issue: https://github.com/apache/nifi/pull/2747 Now all the above described test steps can be executed with `mvn package -P docker` from the `nifi-docker` folder ---

[jira] [Commented] (NIFI-5249) Dockerfile enhancements

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496720#comment-16496720 ] ASF GitHub Bot commented on NIFI-5249: -- Github user pepov commented on the issue:

[GitHub] nifi-minifi-cpp pull request #349: Minificpp 467

2018-05-31 Thread achristianson
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/349 Minificpp 467 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi-minifi-cpp pull request #350: Minificpp 465

2018-05-31 Thread achristianson
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/350 Minificpp 465 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192153282 --- Diff: extensions/sensors/GetEnvironmentalSensors.cpp --- @@ -0,0 +1,156 @@ +/** + * + * Licensed to the Apache Software Foundat

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192153561 --- Diff: extensions/sensors/GetEnvironmentalSensors.cpp --- @@ -0,0 +1,156 @@ +/** + * + * Licensed to the Apache Software Foundation (

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496773#comment-16496773 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user achristianson comment

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192153700 --- Diff: extensions/sensors/GetEnvironmentalSensors.cpp --- @@ -0,0 +1,156 @@ +/** + * + * Licensed to the Apache Software Foundat

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496780#comment-16496780 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user achristianson comment

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496779#comment-16496779 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192153880 --- Diff: extensions/sensors/GetEnvironmentalSensors.cpp --- @@ -0,0 +1,156 @@ +/** + * + * Licensed to the Apache Software Foundat

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496781#comment-16496781 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user achristianson comment

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192154351 --- Diff: extensions/sensors/GetEnvironmentalSensors.cpp --- @@ -0,0 +1,156 @@ +/** + * + * Licensed to the Apache Software Foundation (

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192154395 --- Diff: extensions/sensors/GetEnvironmentalSensors.cpp --- @@ -0,0 +1,156 @@ +/** + * + * Licensed to the Apache Software Foundat

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496782#comment-16496782 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user phrocker commented on

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496783#comment-16496783 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user achristianson comment

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192154943 --- Diff: extensions/sensors/GetMovementSensors.cpp --- @@ -0,0 +1,109 @@ +/** + * + * Licensed to the Apache Software Foundation (

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496786#comment-16496786 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user achristianson comment

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192155217 --- Diff: extensions/sensors/GetMovementSensors.cpp --- @@ -0,0 +1,109 @@ +/** + * + * Licensed to the Apache Software Foundation (

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496787#comment-16496787 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user achristianson comment

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192155481 --- Diff: extensions/sensors/SensorLoader.cpp --- @@ -0,0 +1,30 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) un

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496789#comment-16496789 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user achristianson comment

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192156058 --- Diff: extensions/sensors/CMakeLists.txt --- @@ -0,0 +1,61 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192155951 --- Diff: extensions/sensors/SensorLoader.cpp --- @@ -0,0 +1,30 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under o

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496797#comment-16496797 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user achristianson comment

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496795#comment-16496795 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192158041 --- Diff: extensions/sensors/GetMovementSensors.cpp --- @@ -0,0 +1,109 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496808#comment-16496808 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192159057 --- Diff: extensions/sensors/GetEnvironmentalSensors.cpp --- @@ -0,0 +1,156 @@ +/** + * + * Licensed to the Apache Software Foundation (

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496812#comment-16496812 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192159538 --- Diff: extensions/sensors/GetEnvironmentalSensors.cpp --- @@ -0,0 +1,156 @@ +/** + * + * Licensed to the Apache Software Foundation (

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496816#comment-16496816 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192161587 --- Diff: extensions/sensors/GetEnvironmentalSensors.cpp --- @@ -0,0 +1,156 @@ +/** + * + * Licensed to the Apache Software Foundation (

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496824#comment-16496824 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192162123 --- Diff: extensions/sensors/CMakeLists.txt --- @@ -0,0 +1,61 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496826#comment-16496826 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192162588 --- Diff: extensions/sensors/GetMovementSensors.cpp --- @@ -0,0 +1,109 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (MINIFICPP-517) Port sensor reading processors

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496827#comment-16496827 ] ASF GitHub Bot commented on MINIFICPP-517: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #350: MINIFICPP-465 Implemented regex validatio...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/350#discussion_r192164378 --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp --- @@ -19,6 +19,7 @@ #include #include #include +#include --- En

[jira] [Commented] (MINIFICPP-465) Regex property validation

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496839#comment-16496839 ] ASF GitHub Bot commented on MINIFICPP-465: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #350: MINIFICPP-465 Implemented regex validatio...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/350#discussion_r192165204 --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp --- @@ -782,29 +783,59 @@ void YamlConfiguration::parsePropertiesNodeYaml(YAML::Node *prope

[jira] [Commented] (MINIFICPP-465) Regex property validation

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496841#comment-16496841 ] ASF GitHub Bot commented on MINIFICPP-465: -- Github user phrocker commented on

[jira] [Commented] (MINIFICPP-465) Regex property validation

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496843#comment-16496843 ] ASF GitHub Bot commented on MINIFICPP-465: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #350: MINIFICPP-465 Implemented regex validatio...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/350#discussion_r192165462 --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp --- @@ -782,29 +783,59 @@ void YamlConfiguration::parsePropertiesNodeYaml(YAML::Node *prope

[GitHub] nifi-minifi-cpp pull request #350: MINIFICPP-465 Implemented regex validatio...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/350#discussion_r192165690 --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp --- @@ -782,29 +783,59 @@ void YamlConfiguration::parsePropertiesNodeYaml(YAML::Node *prope

[GitHub] nifi-minifi-cpp pull request #350: MINIFICPP-465 Implemented regex validatio...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/350#discussion_r192165818 --- Diff: libminifi/test/unit/YamlConfigurationTests.cpp --- @@ -457,3 +456,64 @@ Flow Controller: REQUIRE(NULL != rootFlowConfig->findProces

[jira] [Commented] (MINIFICPP-465) Regex property validation

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496844#comment-16496844 ] ASF GitHub Bot commented on MINIFICPP-465: -- Github user phrocker commented on

[jira] [Commented] (MINIFICPP-465) Regex property validation

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496845#comment-16496845 ] ASF GitHub Bot commented on MINIFICPP-465: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #350: MINIFICPP-465 Implemented regex validatio...

2018-05-31 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/350#discussion_r192166370 --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp --- @@ -782,29 +783,59 @@ void YamlConfiguration::parsePropertiesNodeYaml(YAML::Node *prope

[jira] [Commented] (MINIFICPP-465) Regex property validation

2018-05-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496847#comment-16496847 ] ASF GitHub Bot commented on MINIFICPP-465: -- Github user phrocker commented on

  1   2   >