[jira] [Commented] (NIFI-5952) RAW Site-to-Site fails with java.nio.channels.IllegalBlockingModeException

2020-02-06 Thread Ryan Hendrickson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032097#comment-17032097 ] Ryan Hendrickson commented on NIFI-5952: [~mosermw] agree - Discussion on this top

[GitHub] [nifi] jfrazee commented on a change in pull request #4031: NIFI-6791 Add UUID3 and UUID5 functions to Expression Language

2020-02-06 Thread GitBox
jfrazee commented on a change in pull request #4031: NIFI-6791 Add UUID3 and UUID5 functions to Expression Language URL: https://github.com/apache/nifi/pull/4031#discussion_r376195035 ## File path: nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expres

[jira] [Created] (NIFIREG-358) Proxy authorization not working with groups

2020-02-06 Thread Bryan Bende (Jira)
Bryan Bende created NIFIREG-358: --- Summary: Proxy authorization not working with groups Key: NIFIREG-358 URL: https://issues.apache.org/jira/browse/NIFIREG-358 Project: NiFi Registry Issue Type:

[GitHub] [nifi] pvillard31 commented on issue #4026: NIFI-7087: Use FlowManager.findAllConnections() when available

2020-02-06 Thread GitBox
pvillard31 commented on issue #4026: NIFI-7087: Use FlowManager.findAllConnections() when available URL: https://github.com/apache/nifi/pull/4026#issuecomment-583181205 I just gave it a try and it LGTM as well. @markap14 do you want to have a look or are you happy with me merging it into m

[jira] [Resolved] (NIFI-2537) Allow specification of Custom-MimeTypes.xml for IdentifyMimeTypes processor

2020-02-06 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-2537. -- Fix Version/s: 1.12.0 Resolution: Fixed > Allow specification of Custom-MimeTypes.xml for

[GitHub] [nifi] asfgit closed pull request #4016: NIFI-2537: Add custom MIME type configuration support to IdentifyMime…

2020-02-06 Thread GitBox
asfgit closed pull request #4016: NIFI-2537: Add custom MIME type configuration support to IdentifyMime… URL: https://github.com/apache/nifi/pull/4016 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [nifi] pvillard31 commented on issue #4016: NIFI-2537: Add custom MIME type configuration support to IdentifyMime…

2020-02-06 Thread GitBox
pvillard31 commented on issue #4016: NIFI-2537: Add custom MIME type configuration support to IdentifyMime… URL: https://github.com/apache/nifi/pull/4016#issuecomment-583179185 Thanks for the improvement @trucemop - this looks good to me and is now merged into master.

[jira] [Commented] (NIFI-2537) Allow specification of Custom-MimeTypes.xml for IdentifyMimeTypes processor

2020-02-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032040#comment-17032040 ] ASF subversion and git services commented on NIFI-2537: --- Commit f738

[GitHub] [nifi-minifi-cpp] arpadboda commented on issue #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime

2020-02-06 Thread GitBox
arpadboda commented on issue #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727#issuecomment-583156912 Nice catch! Please fix the linter errors: ``` /Users/travis/build/apache/nifi-minifi-cpp/libminifi/src//io/win/C

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #728: MINIFICPP-1147 Implemented.

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #728: MINIFICPP-1147 Implemented. URL: https://github.com/apache/nifi-minifi-cpp/pull/728#discussion_r376129464 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -286,6 +301,103 @@ wel::WindowsEventL

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #728: MINIFICPP-1147 Implemented.

2020-02-06 Thread GitBox
am-c-p-p commented on a change in pull request #728: MINIFICPP-1147 Implemented. URL: https://github.com/apache/nifi-minifi-cpp/pull/728#discussion_r376126552 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -286,6 +301,103 @@ wel::WindowsEventLog

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #728: MINIFICPP-1147 Implemented.

2020-02-06 Thread GitBox
am-c-p-p commented on a change in pull request #728: MINIFICPP-1147 Implemented. URL: https://github.com/apache/nifi-minifi-cpp/pull/728#discussion_r376125019 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -226,20 +229,32 @@ void ConsumeWindowsE

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #728: MINIFICPP-1147 Implemented.

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #728: MINIFICPP-1147 Implemented. URL: https://github.com/apache/nifi-minifi-cpp/pull/728#discussion_r376123663 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -226,20 +229,32 @@ void ConsumeWindow

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #728: MINIFICPP-1147 Implemented.

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #728: MINIFICPP-1147 Implemented. URL: https://github.com/apache/nifi-minifi-cpp/pull/728#discussion_r376117286 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -286,6 +301,103 @@ wel::WindowsEventL

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #728: MINIFICPP-1147 Implemented.

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #728: MINIFICPP-1147 Implemented. URL: https://github.com/apache/nifi-minifi-cpp/pull/728#discussion_r376119197 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -286,6 +301,103 @@ wel::WindowsEventL

[GitHub] [nifi] natural commented on issue #4040: NIFI-6927 Fixes SSL socket factory for ES on JDK9

2020-02-06 Thread GitBox
natural commented on issue #4040: NIFI-6927 Fixes SSL socket factory for ES on JDK9 URL: https://github.com/apache/nifi/pull/4040#issuecomment-583144774 I think you're right. I'll refactor those bits. This is an automated me

[GitHub] [nifi-minifi-cpp] am-c-p-p opened a new pull request #728: MINIFICPP-1147 Implemented.

2020-02-06 Thread GitBox
am-c-p-p opened a new pull request #728: MINIFICPP-1147 Implemented. URL: https://github.com/apache/nifi-minifi-cpp/pull/728 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] [nifi] sburges commented on a change in pull request #4031: NIFI-6791 Add UUID3 and UUID5 functions to Expression Language

2020-02-06 Thread GitBox
sburges commented on a change in pull request #4031: NIFI-6791 Add UUID3 and UUID5 functions to Expression Language URL: https://github.com/apache/nifi/pull/4031#discussion_r376099727 ## File path: nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expres

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on issue #656: MINIFI-1013 Used soci library.

2020-02-06 Thread GitBox
am-c-p-p commented on issue #656: MINIFI-1013 Used soci library. URL: https://github.com/apache/nifi-minifi-cpp/pull/656#issuecomment-583103374 Yes, we need it. It is reviewed by @bakaid and pending testing before merging to apache. -

[GitHub] [nifi-minifi-cpp] am-c-p-p edited a comment on issue #656: MINIFI-1013 Used soci library.

2020-02-06 Thread GitBox
am-c-p-p edited a comment on issue #656: MINIFI-1013 Used soci library. URL: https://github.com/apache/nifi-minifi-cpp/pull/656#issuecomment-583103374 @arpadboda Yes, we need it. It is reviewed by @bakaid and pending testing before merging to apache. ---

[GitHub] [nifi] alopresto commented on issue #4040: NIFI-6927 Fixes SSL socket factory for ES on JDK9

2020-02-06 Thread GitBox
alopresto commented on issue #4040: NIFI-6927 Fixes SSL socket factory for ES on JDK9 URL: https://github.com/apache/nifi/pull/4040#issuecomment-583075052 It looks like we have similar/identical code for constructing these objects in [`OkHttpReplicationClient`](https://github.com/apache/n

[jira] [Updated] (NIFI-6491) Improve installation documentation

2020-02-06 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-6491: Affects Version/s: 1.11.1 Labels: documentation getting_started (was: )

[jira] [Updated] (NIFI-6491) Improve installation documentation

2020-02-06 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-6491: Fix Version/s: 1.12.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [nifi] alopresto commented on issue #4029: NIFI-6491 Improve installation instructions in Admin Guide and Gettin…

2020-02-06 Thread GitBox
alopresto commented on issue #4029: NIFI-6491 Improve installation instructions in Admin Guide and Gettin… URL: https://github.com/apache/nifi/pull/4029#issuecomment-583071738 Thanks Drew. This is an automated message from t

[GitHub] [nifi] asfgit closed pull request #4029: NIFI-6491 Improve installation instructions in Admin Guide and Gettin…

2020-02-06 Thread GitBox
asfgit closed pull request #4029: NIFI-6491 Improve installation instructions in Admin Guide and Gettin… URL: https://github.com/apache/nifi/pull/4029 This is an automated message from the Apache Git Service. To respond to t

[jira] [Commented] (NIFI-6491) Improve installation documentation

2020-02-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031874#comment-17031874 ] ASF subversion and git services commented on NIFI-6491: --- Commit 6283

[GitHub] [nifi] alopresto commented on a change in pull request #4029: NIFI-6491 Improve installation instructions in Admin Guide and Gettin…

2020-02-06 Thread GitBox
alopresto commented on a change in pull request #4029: NIFI-6491 Improve installation instructions in Admin Guide and Gettin… URL: https://github.com/apache/nifi/pull/4029#discussion_r376035063 ## File path: nifi-docs/src/main/asciidoc/getting-started.adoc ## @@ -58,14 +58

[GitHub] [nifi] alopresto commented on a change in pull request #4029: NIFI-6491 Improve installation instructions in Admin Guide and Gettin…

2020-02-06 Thread GitBox
alopresto commented on a change in pull request #4029: NIFI-6491 Improve installation instructions in Admin Guide and Gettin… URL: https://github.com/apache/nifi/pull/4029#discussion_r376032333 ## File path: nifi-docs/src/main/asciidoc/getting-started.adoc ## @@ -58,14 +58

[jira] [Updated] (NIFI-7075) Update list of flowfile core attributes in Developer Guide

2020-02-06 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-7075: Fix Version/s: 1.12.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[jira] [Updated] (NIFI-7075) Update list of flowfile core attributes in Developer Guide

2020-02-06 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-7075: Affects Version/s: 1.11.1 Labels: documentation (was: ) Status: Patch

[GitHub] [nifi] alopresto commented on issue #4030: NIFI-7075 Add missing FlowFile core attributes to Developer Guide

2020-02-06 Thread GitBox
alopresto commented on issue #4030: NIFI-7075 Add missing FlowFile core attributes to Developer Guide URL: https://github.com/apache/nifi/pull/4030#issuecomment-583065515 Thanks Drew, this is really helpful. This is an autom

[jira] [Commented] (NIFI-7075) Update list of flowfile core attributes in Developer Guide

2020-02-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031869#comment-17031869 ] ASF subversion and git services commented on NIFI-7075: --- Commit ac03

[GitHub] [nifi] alopresto merged pull request #4030: NIFI-7075 Add missing FlowFile core attributes to Developer Guide

2020-02-06 Thread GitBox
alopresto merged pull request #4030: NIFI-7075 Add missing FlowFile core attributes to Developer Guide URL: https://github.com/apache/nifi/pull/4030 This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (NIFI-7105) NPE in SiteToSiteStatusReportingTask for counters

2020-02-06 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-7105: Fix Version/s: 1.12.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[jira] [Commented] (NIFI-7105) NPE in SiteToSiteStatusReportingTask for counters

2020-02-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031863#comment-17031863 ] ASF subversion and git services commented on NIFI-7105: --- Commit 0890

[GitHub] [nifi] alopresto merged pull request #4038: NIFI-7105 - fix NPE for counters in SiteToSiteStatusReportingTask

2020-02-06 Thread GitBox
alopresto merged pull request #4038: NIFI-7105 - fix NPE for counters in SiteToSiteStatusReportingTask URL: https://github.com/apache/nifi/pull/4038 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi] alopresto commented on issue #4038: NIFI-7105 - fix NPE for counters in SiteToSiteStatusReportingTask

2020-02-06 Thread GitBox
alopresto commented on issue #4038: NIFI-7105 - fix NPE for counters in SiteToSiteStatusReportingTask URL: https://github.com/apache/nifi/pull/4038#issuecomment-583062502 Thanks Pierre. This looks good. Merging. This is an a

[GitHub] [nifi] alopresto commented on issue #4038: NIFI-7105 - fix NPE for counters in SiteToSiteStatusReportingTask

2020-02-06 Thread GitBox
alopresto commented on issue #4038: NIFI-7105 - fix NPE for counters in SiteToSiteStatusReportingTask URL: https://github.com/apache/nifi/pull/4038#issuecomment-583062360 Reviewing... This is an automated message from the Apa

[jira] [Commented] (NIFI-6718) New JMS Session/Producer created for each message published

2020-02-06 Thread Josh P (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031862#comment-17031862 ] Josh P commented on NIFI-6718: -- No longer working on this ticket. > New JMS Session/Producer

[jira] [Assigned] (NIFI-6718) New JMS Session/Producer created for each message published

2020-02-06 Thread Josh P (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh P reassigned NIFI-6718: Assignee: (was: Josh P) > New JMS Session/Producer created for each message published > ---

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r376018992 ## File path: libminifi/src/io/StreamFactory.cpp ## @@ -76,9 +77,8 @@ class SocketCreat

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r376018414 ## File path: libminifi/src/io/ClientSocket.cpp ## @@ -45,56 +42,68 @@ namespace nifi {

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r376018290 ## File path: libminifi/src/io/ClientSocket.cpp ## @@ -207,12 +209,31 @@ int8_t Socket:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r376017118 ## File path: libminifi/src/io/ClientSocket.cpp ## @@ -118,29 +127,26 @@ void Socket::s

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r376017118 ## File path: libminifi/src/io/ClientSocket.cpp ## @@ -118,29 +127,26 @@ void Socket::s

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727#discussion_r376000406 ## File path: libminifi/src/io/win/ClientSocket.cpp ## @@ -242,11 +237,17 @@ int16_t Socket::

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727#discussion_r376000406 ## File path: libminifi/src/io/win/ClientSocket.cpp ## @@ -242,11 +237,17 @@ int16_t Socket::

[jira] [Commented] (NIFI-7081) Improve handling of Load Balanced Connections when one node is slow

2020-02-06 Thread Tamas Palfy (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031835#comment-17031835 ] Tamas Palfy commented on NIFI-7081: --- [~markap14], [~joewitt] I have tested a setup that

[jira] [Commented] (NIFI-5813) ReplaceText regression: fails on mixed literal dollar signs and backreferences

2020-02-06 Thread Otto Fowler (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031793#comment-17031793 ] Otto Fowler commented on NIFI-5813: --- can you create a simple flow that reproduces the is

[jira] [Commented] (NIFI-5813) ReplaceText regression: fails on mixed literal dollar signs and backreferences

2020-02-06 Thread Su (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031787#comment-17031787 ] Su commented on NIFI-5813: -- Is there any ETA on this bug. Thanks! > ReplaceText regression: fail

[GitHub] [nifi] natural commented on issue #4040: NIFI-6927 Fixes SSL socket factory for ES on JDK9

2020-02-06 Thread GitBox
natural commented on issue #4040: NIFI-6927 Fixes SSL socket factory for ES on JDK9 URL: https://github.com/apache/nifi/pull/4040#issuecomment-583004240 OkHttp suggests we rely on the system trust factory, per the docs: https://square.github.io/okhttp/4.x/okhttp/okhttp3/-ok-http-client/-b

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727#discussion_r375947710 ## File path: libminifi/src/io/win/ClientSocket.cpp ## @@ -242,11 +237,17 @@ int16_t Socket::

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727#discussion_r375947710 ## File path: libminifi/src/io/win/ClientSocket.cpp ## @@ -242,11 +237,17 @@ int16_t Socket::

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727#discussion_r375939226 ## File path: libminifi/src/io/win/ClientSocket.cpp ## @@ -242,11 +237,17 @@ int16_t Socke

[GitHub] [nifi-minifi-cpp] bakaid commented on issue #726: MINIFICPP-1137 - Update RocksDB to 5.18.3

2020-02-06 Thread GitBox
bakaid commented on issue #726: MINIFICPP-1137 - Update RocksDB to 5.18.3 URL: https://github.com/apache/nifi-minifi-cpp/pull/726#issuecomment-582983788 @arpadboda CI is failing, going to look into it. This is an automated mes

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727#discussion_r375928102 ## File path: libminifi/src/io/win/ClientSocket.cpp ## @@ -242,11 +237,17 @@ int16_t Socket::

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727#discussion_r375928102 ## File path: libminifi/src/io/win/ClientSocket.cpp ## @@ -242,11 +237,17 @@ int16_t Socket::

[GitHub] [nifi-minifi-cpp] szaszm commented on issue #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime

2020-02-06 Thread GitBox
szaszm commented on issue #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727#issuecomment-582976390 With this change, SocketTests will no longer randomly fail on Windows and minifi will no longer randomly crash when a ClientSock

[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime

2020-02-06 Thread GitBox
szaszm opened a new pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you t

[GitHub] [nifi] ottobackwards opened a new pull request #4043: NIFI-7109 Unit tests should be able to determine if item validator wa…

2020-02-06 Thread GitBox
ottobackwards opened a new pull request #4043: NIFI-7109 Unit tests should be able to determine if item validator wa… URL: https://github.com/apache/nifi/pull/4043 Description of PR Adds a mock validator so that tests can verify that validators are called, used for exam

[jira] [Updated] (NIFI-6968) Create Connection Modal Allows Multiple Adds

2020-02-06 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-6968: Resolution: Fixed Status: Resolved (was: Patch Available) > Create Connection Modal Allows

[jira] [Updated] (NIFI-6968) Create Connection Modal Allows Multiple Adds

2020-02-06 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-6968: Fix Version/s: 1.12.0 Labels: modal ui (was: ) Status: Patch Available (was:

[GitHub] [nifi] tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor.

2020-02-06 Thread GitBox
tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor. URL: https://github.com/apache/nifi/pull/3977#discussion_r375908127 ## File path: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/ja

[GitHub] [nifi] nagasivanath commented on issue #4013: NIFI-6968 Create Connection Model Allows Multiple Adds

2020-02-06 Thread GitBox
nagasivanath commented on issue #4013: NIFI-6968 Create Connection Model Allows Multiple Adds URL: https://github.com/apache/nifi/pull/4013#issuecomment-582962346 TYSM @andy This is an automated message from the Apache Git Se

[jira] [Commented] (NIFI-6968) Create Connection Modal Allows Multiple Adds

2020-02-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031679#comment-17031679 ] ASF subversion and git services commented on NIFI-6968: --- Commit 425b

[GitHub] [nifi] asfgit closed pull request #4013: NIFI-6968 Create Connection Model Allows Multiple Adds

2020-02-06 Thread GitBox
asfgit closed pull request #4013: NIFI-6968 Create Connection Model Allows Multiple Adds URL: https://github.com/apache/nifi/pull/4013 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [nifi] alopresto commented on issue #4013: NIFI-6968 Create Connection Model Allows Multiple Adds

2020-02-06 Thread GitBox
alopresto commented on issue #4013: NIFI-6968 Create Connection Model Allows Multiple Adds URL: https://github.com/apache/nifi/pull/4013#issuecomment-582960498 I used Google Chrome Developer Tools to simulate a slow connection and verified that the buttons are disabled during the API call.

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375902215 ## File path: libminifi/include/core/state/Value.h ## @@ -87,6 +88,15

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375896103 ## File path: libminifi/test/integration/IntegrationBase.h ## @@ -42,6

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375895619 ## File path: libminifi/include/core/state/Value.h ## @@ -188,6 +264,1

[GitHub] [nifi-minifi-cpp] bakaid opened a new pull request #726: MINIFICPP-1137 - Update RocksDB to 5.18.3

2020-02-06 Thread GitBox
bakaid opened a new pull request #726: MINIFICPP-1137 - Update RocksDB to 5.18.3 URL: https://github.com/apache/nifi-minifi-cpp/pull/726 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure t

[GitHub] [nifi] woutifier-t commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor.

2020-02-06 Thread GitBox
woutifier-t commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor. URL: https://github.com/apache/nifi/pull/3977#discussion_r375886439 ## File path: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/ma

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375847455 ## File path: libminifi/include/core/state/Value.h ## @@ -188,6 +264,18 @

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375844201 ## File path: libminifi/include/core/state/Value.h ## @@ -115,6 +125,64 @

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375878858 ## File path: libminifi/include/core/state/Value.h ## @@ -87,6 +88,15 @@

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375870980 ## File path: libminifi/test/integration/OnScheduleErrorHandlingTests.cpp

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
szaszm commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375869797 ## File path: libminifi/test/integration/IntegrationBase.h ## @@ -42,6 +4

[GitHub] [nifi] alopresto commented on issue #4013: NIFI-6968 Create Connection Model Allows Multiple Adds

2020-02-06 Thread GitBox
alopresto commented on issue #4013: NIFI-6968 Create Connection Model Allows Multiple Adds URL: https://github.com/apache/nifi/pull/4013#issuecomment-582940914 Reviewing... This is an automated message from the Apache Git Ser

[jira] [Created] (NIFI-7112) UpdateAttribute processor should highlight when Advanced Rules are being used

2020-02-06 Thread Chris Sampson (Jira)
Chris Sampson created NIFI-7112: --- Summary: UpdateAttribute processor should highlight when Advanced Rules are being used Key: NIFI-7112 URL: https://issues.apache.org/jira/browse/NIFI-7112 Project: Apac

[jira] [Created] (NIFI-7111) JoltTransformRecord should have an Advanced UI like JoltTransformJSON

2020-02-06 Thread Chris Sampson (Jira)
Chris Sampson created NIFI-7111: --- Summary: JoltTransformRecord should have an Advanced UI like JoltTransformJSON Key: NIFI-7111 URL: https://issues.apache.org/jira/browse/NIFI-7111 Project: Apache NiFi

[jira] [Created] (NIFI-7110) Update Record should have an Advanced UI/Rules like Update Attribute

2020-02-06 Thread Chris Sampson (Jira)
Chris Sampson created NIFI-7110: --- Summary: Update Record should have an Advanced UI/Rules like Update Attribute Key: NIFI-7110 URL: https://issues.apache.org/jira/browse/NIFI-7110 Project: Apache NiFi

[GitHub] [nifi] jsferner commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import

2020-02-06 Thread GitBox
jsferner commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import URL: https://github.com/apache/nifi/pull/4023#discussion_r375847118 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/

[jira] [Resolved] (NIFI-5948) Cannot list users when a ldap user that belongs to a group is deleted

2020-02-06 Thread Matt Gilman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman resolved NIFI-5948. --- Fix Version/s: 1.10.0 1.9.2 Resolution: Fixed > Cannot list users when a lda

[jira] [Commented] (NIFI-5948) Cannot list users when a ldap user that belongs to a group is deleted

2020-02-06 Thread Matt Gilman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031603#comment-17031603 ] Matt Gilman commented on NIFI-5948: --- This issue was addressed by the same solution that

[GitHub] [nifi] mcgilman commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import

2020-02-06 Thread GitBox
mcgilman commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import URL: https://github.com/apache/nifi/pull/4023#discussion_r375842812 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375827761 ## File path: libminifi/test/integration/OnScheduleErrorHandlingTests.cpp #

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375835365 ## File path: libminifi/test/integration/OnScheduleErrorHandlingTests.cpp #

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375835044 ## File path: libminifi/test/integration/IntegrationBase.h ## @@ -42,6

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375827609 ## File path: libminifi/src/core/PropertyValidation.cpp ## @@ -27,6 +2

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375834407 ## File path: libminifi/include/core/state/Value.h ## @@ -115,6 +125,6

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375826987 ## File path: libminifi/include/core/state/Value.h ## @@ -188,6 +264,1

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-02-06 Thread GitBox
arpadboda commented on a change in pull request #710: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375834179 ## File path: libminifi/include/core/state/Value.h ## @@ -87,6 +88,15

[GitHub] [nifi] jsferner commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import

2020-02-06 Thread GitBox
jsferner commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import URL: https://github.com/apache/nifi/pull/4023#discussion_r375835725 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/

[GitHub] [nifi] jsferner commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import

2020-02-06 Thread GitBox
jsferner commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import URL: https://github.com/apache/nifi/pull/4023#discussion_r375833689 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/

[GitHub] [nifi] jsferner commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import

2020-02-06 Thread GitBox
jsferner commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import URL: https://github.com/apache/nifi/pull/4023#discussion_r375833689 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/

[GitHub] [nifi] jsferner commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import

2020-02-06 Thread GitBox
jsferner commented on a change in pull request #4023: NIFI-6873: Added support for replacing a process group via import URL: https://github.com/apache/nifi/pull/4023#discussion_r375827914 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/

[jira] [Created] (NIFI-7109) Unit tests should be able to determine if item validator was called

2020-02-06 Thread Otto Fowler (Jira)
Otto Fowler created NIFI-7109: - Summary: Unit tests should be able to determine if item validator was called Key: NIFI-7109 URL: https://issues.apache.org/jira/browse/NIFI-7109 Project: Apache NiFi

[GitHub] [nifi] ottobackwards commented on issue #4012: NIFI-7055 createListValidator should treat ", " as invalid

2020-02-06 Thread GitBox
ottobackwards commented on issue #4012: NIFI-7055 createListValidator should treat "," as invalid URL: https://github.com/apache/nifi/pull/4012#issuecomment-582900887 https://issues.apache.org/jira/browse/NIFI-7109 This is an

[GitHub] [nifi] ottobackwards commented on issue #4012: NIFI-7055 createListValidator should treat ", " as invalid

2020-02-06 Thread GitBox
ottobackwards commented on issue #4012: NIFI-7055 createListValidator should treat "," as invalid URL: https://github.com/apache/nifi/pull/4012#issuecomment-582899667 part of the issue here is our testing framework. we can't tell in the tests if something is not valid because of the valid

[GitHub] [nifi] ottobackwards commented on issue #4012: NIFI-7055 createListValidator should treat ", " as invalid

2020-02-06 Thread GitBox
ottobackwards commented on issue #4012: NIFI-7055 createListValidator should treat "," as invalid URL: https://github.com/apache/nifi/pull/4012#issuecomment-582897267 Ok, so " , " evaluates to a list of two, so this fix will not effect it ---

  1   2   >