[GitHub] [nifi] alopresto commented on pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-06-04 Thread GitBox
alopresto commented on pull request #4289: URL: https://github.com/apache/nifi/pull/4289#issuecomment-639223794 Thanks Mark. I replied to the comments and integrated most of what you had suggested (the exception being the complete removal of the marker interface).

[jira] [Created] (NIFI-7509) Add an optional Record Writer to List* Processors

2020-06-04 Thread Mark Payne (Jira)
Mark Payne created NIFI-7509: Summary: Add an optional Record Writer to List* Processors Key: NIFI-7509 URL: https://issues.apache.org/jira/browse/NIFI-7509 Project: Apache NiFi Issue Type:

[GitHub] [nifi] alopresto commented on pull request #4307: NIFI-6094 - Added the X-Content-Type-Options header to all web respon…

2020-06-04 Thread GitBox
alopresto commented on pull request #4307: URL: https://github.com/apache/nifi/pull/4307#issuecomment-639200142 Will review tomorrow. Thanks Nathan. This is an automated message from the Apache Git Service. To respond to

[GitHub] [nifi] alopresto commented on a change in pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-06-04 Thread GitBox
alopresto commented on a change in pull request #4289: URL: https://github.com/apache/nifi/pull/4289#discussion_r435634210 ## File path: nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/PeerStatusProvider.java ## @@ -52,12 +51,25 @@ *

[GitHub] [nifi] alopresto commented on a change in pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-06-04 Thread GitBox
alopresto commented on a change in pull request #4289: URL: https://github.com/apache/nifi/pull/4289#discussion_r435632547 ## File path: nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/PeerStatusProvider.java ## @@ -52,12 +51,25 @@ *

[GitHub] [nifi] alopresto commented on a change in pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-06-04 Thread GitBox
alopresto commented on a change in pull request #4289: URL: https://github.com/apache/nifi/pull/4289#discussion_r435629323 ## File path: nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/PeerSelector.java ## @@ -16,353 +16,559 @@ */ package

[GitHub] [nifi] markap14 commented on pull request #4306: NIFI-7476: Implemented FlowFileGating / FlowFileConcurrency at the Pr…

2020-06-04 Thread GitBox
markap14 commented on pull request #4306: URL: https://github.com/apache/nifi/pull/4306#issuecomment-639176333 Thanks @pvillard31 ! I do agree that we very much need to update the user guide. I intended to do that but totally forgot until I'd already pushed the PR. Created NIFI-7507 to

[jira] [Updated] (NIFI-7507) Update user guide to document FlowFile Concurrency and Outbound Policy of Process Groups

2020-06-04 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-7507: - Description: NIFI-7476 added the ability to select a Process Group's FlowFile concurrency and Outbound

[jira] [Created] (NIFI-7508) TestStandardControllerServiceInvocationHandler causes test failures in nifi-framework-core with Java 11

2020-06-04 Thread Joey Frazee (Jira)
Joey Frazee created NIFI-7508: - Summary: TestStandardControllerServiceInvocationHandler causes test failures in nifi-framework-core with Java 11 Key: NIFI-7508 URL: https://issues.apache.org/jira/browse/NIFI-7508

[jira] [Updated] (NIFI-7507) Update user guide to document FlowFile Concurrency and Outbound Policy of Process Groups

2020-06-04 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-7507: - Description: NIFI-7476 added the ability to select a Process Group's FlowFile concurrency and Outbound

[jira] [Created] (NIFI-7507) Update user guide to document FlowFile Concurrency and Outbound Policy of Process Groups

2020-06-04 Thread Mark Payne (Jira)
Mark Payne created NIFI-7507: Summary: Update user guide to document FlowFile Concurrency and Outbound Policy of Process Groups Key: NIFI-7507 URL: https://issues.apache.org/jira/browse/NIFI-7507

[GitHub] [nifi] alopresto commented on a change in pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-06-04 Thread GitBox
alopresto commented on a change in pull request #4289: URL: https://github.com/apache/nifi/pull/4289#discussion_r435607061 ## File path: nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/PeerSelector.java ## @@ -16,353 +16,559 @@ */ package

[GitHub] [nifi] alopresto commented on a change in pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-06-04 Thread GitBox
alopresto commented on a change in pull request #4289: URL: https://github.com/apache/nifi/pull/4289#discussion_r435606503 ## File path: nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/PeerSelector.java ## @@ -16,353 +16,559 @@ */ package

[GitHub] [nifi] alopresto commented on a change in pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-06-04 Thread GitBox
alopresto commented on a change in pull request #4289: URL: https://github.com/apache/nifi/pull/4289#discussion_r435606362 ## File path: nifi-commons/nifi-site-to-site-client/pom.xml ## @@ -76,6 +76,15 @@ httpasyncclient 4.1.4 + +

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #788: MINIFICPP-1229 - Fix and enable CompressContentTests

2020-06-04 Thread GitBox
arpadboda commented on a change in pull request #788: URL: https://github.com/apache/nifi-minifi-cpp/pull/788#discussion_r435584847 ## File path: libminifi/test/archive-tests/CompressContentTests.cpp ## @@ -91,851 +91,834 @@ class ReadCallback: public

[jira] [Resolved] (NIFI-7476) Allow users to configure FlowFile Concurrency on a Process Group

2020-06-04 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-7476. -- Fix Version/s: 1.12.0 Resolution: Fixed > Allow users to configure FlowFile Concurrency

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
szaszm commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435549817 ## File path: extensions/script/python/ExecutePythonProcessor.cpp ## @@ -35,155 +35,188 @@ namespace python { namespace processors {

[jira] [Commented] (NIFI-7476) Allow users to configure FlowFile Concurrency on a Process Group

2020-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126194#comment-17126194 ] ASF subversion and git services commented on NIFI-7476: --- Commit

[GitHub] [nifi] pvillard31 commented on pull request #4306: NIFI-7476: Implemented FlowFileGating / FlowFileConcurrency at the Pr…

2020-06-04 Thread GitBox
pvillard31 commented on pull request #4306: URL: https://github.com/apache/nifi/pull/4306#issuecomment-639125212 Merged to master, thanks for this great new feature @markap14. Do you mind creating a JIRA for the doc part?

[jira] [Commented] (NIFI-4911) NiFi CompressContent Snappy incompatible behavior with Spark

2020-06-04 Thread Noe (Jira)
[ https://issues.apache.org/jira/browse/NIFI-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126195#comment-17126195 ] Noe commented on NIFI-4911: --- nifi-7506 will solve this > NiFi CompressContent Snappy incompatible behavior with

[GitHub] [nifi] asfgit closed pull request #4306: NIFI-7476: Implemented FlowFileGating / FlowFileConcurrency at the Pr…

2020-06-04 Thread GitBox
asfgit closed pull request #4306: URL: https://github.com/apache/nifi/pull/4306 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (NIFI-7506) CompressContent Add Snappy-Hadoop

2020-06-04 Thread Noe (Jira)
Noe created NIFI-7506: - Summary: CompressContent Add Snappy-Hadoop Key: NIFI-7506 URL: https://issues.apache.org/jira/browse/NIFI-7506 Project: Apache NiFi Issue Type: Improvement Reporter:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
szaszm commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435525577 ## File path: libminifi/include/core/ClassLoader.h ## @@ -636,9 +612,9 @@ T *ClassLoader::instantiateRaw(const std::string _name, utils::Identifier

[GitHub] [nifi] jfrazee commented on pull request #4233: NIFI-7393: add max idle time and max idle connections parameter to InvokeHTTP

2020-06-04 Thread GitBox
jfrazee commented on pull request #4233: URL: https://github.com/apache/nifi/pull/4233#issuecomment-639056744 @Woutifier We'll be good to go after that little `name()` / `displayName()`. This is an automated message from the

[GitHub] [nifi] jfrazee commented on a change in pull request #4233: NIFI-7393: add max idle time and max idle connections parameter to InvokeHTTP

2020-06-04 Thread GitBox
jfrazee commented on a change in pull request #4233: URL: https://github.com/apache/nifi/pull/4233#discussion_r435485319 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java ## @@ -214,6

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435437798 ## File path: libminifi/include/utils/TestUtils.h ## @@ -0,0 +1,80 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435437263 ## File path: extensions/script/python/ExecutePythonProcessor.cpp ## @@ -35,7 +35,11 @@ namespace python { namespace processors {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435437097 ## File path: extensions/script/python/ExecutePythonProcessor.cpp ## @@ -46,144 +50,177 @@ core::Relationship

[jira] [Created] (NIFI-7505) Add InvokeHTTPRecord processor

2020-06-04 Thread Andy LoPresto (Jira)
Andy LoPresto created NIFI-7505: --- Summary: Add InvokeHTTPRecord processor Key: NIFI-7505 URL: https://issues.apache.org/jira/browse/NIFI-7505 Project: Apache NiFi Issue Type: Improvement

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435431799 ## File path: libminifi/include/utils/TestUtils.h ## @@ -0,0 +1,80 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435430949 ## File path: libminifi/include/utils/TestUtils.h ## @@ -0,0 +1,80 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435404598 ## File path: extensions/script/python/ExecutePythonProcessor.cpp ## @@ -35,7 +35,11 @@ namespace python { namespace processors {

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
arpadboda commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435407683 ## File path: extensions/script/python/ExecutePythonProcessor.cpp ## @@ -35,7 +35,11 @@ namespace python { namespace processors {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435404598 ## File path: extensions/script/python/ExecutePythonProcessor.cpp ## @@ -35,7 +35,11 @@ namespace python { namespace processors {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435404598 ## File path: extensions/script/python/ExecutePythonProcessor.cpp ## @@ -35,7 +35,11 @@ namespace python { namespace processors {

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #776: MINIFICPP-1202 - Handle C2 requests/responses using MinifiConcurrentQueue

2020-06-04 Thread GitBox
arpadboda closed pull request #776: URL: https://github.com/apache/nifi-minifi-cpp/pull/776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
arpadboda commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435341599 ## File path: libminifi/include/utils/TestUtils.h ## @@ -0,0 +1,80 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
arpadboda commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435340201 ## File path: extensions/script/python/ExecutePythonProcessor.cpp ## @@ -35,7 +35,11 @@ namespace python { namespace processors {

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
arpadboda commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435339793 ## File path: libminifi/include/utils/TestUtils.h ## @@ -0,0 +1,80 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435334768 ## File path: extensions/script/python/ExecutePythonProcessor.cpp ## @@ -35,7 +35,11 @@ namespace python { namespace processors {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #784: MINIFICPP-1206 - Rework and test ExecutePythonProcessor, add in-place script support

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435333611 ## File path: libminifi/include/utils/TestUtils.h ## @@ -0,0 +1,80 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435329784 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +230,65 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435325700 ## File path: extensions/standard-processors/tests/unit/TailFileTests.cpp ## @@ -47,7 +47,33 @@ static std::string NEWLINE_FILE = "" // NOLINT

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435325310 ## File path: libminifi/test/unit/FileUtilsTests.cpp ## @@ -178,3 +179,157 @@ TEST_CASE("TestFileUtils::getFullPath", "[TestGetFullPath]") {

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435323181 ## File path: libminifi/src/utils/file/FileUtils.cpp ## @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435322591 ## File path: libminifi/src/utils/file/FileUtils.cpp ## @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435321877 ## File path: libminifi/src/utils/RegexUtils.cpp ## @@ -158,6 +158,16 @@ const std::vector& Regex::getResult() const { return results_; }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435321877 ## File path: libminifi/src/utils/RegexUtils.cpp ## @@ -158,6 +158,16 @@ const std::vector& Regex::getResult() const { return results_; }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435320644 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -469,6 +470,14 @@ void ProcessSession::import(std::string source, const

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435320821 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -574,15 +589,16 @@ void ProcessSession::import(const std::string& source,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435319933 ## File path: extensions/standard-processors/processors/TailFile.h ## @@ -33,38 +33,40 @@ namespace nifi { namespace minifi { namespace

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435318031 ## File path: libminifi/include/io/CRCStream.h ## @@ -45,6 +45,7 @@ class CRCStream : public BaseStream { * it will exceed our lifetime.

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435316889 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +435,136 @@ void TailFile::onTrigger(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435311535 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +435,136 @@ void TailFile::onTrigger(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435310291 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +435,136 @@ void TailFile::onTrigger(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435309190 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +249,78 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435308461 ## File path: libminifi/src/utils/file/PathUtils.cpp ## @@ -84,6 +108,19 @@ std::string PathUtils::getFullPath(const std::string& path) { #endif

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435308929 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -335,65 +387,45 @@ bool TailFile::storeState(const std::shared_ptr&

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435306719 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +249,78 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

2020-06-04 Thread GitBox
fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435306612 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -58,42 +47,108 @@ #define S_ISDIR(mode) (((mode) & S_IFMT) ==

[jira] [Resolved] (NIFI-7299) Create OAuth2TokenProvider controller service

2020-06-04 Thread Jeremy Dyer (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Dyer resolved NIFI-7299. --- Fix Version/s: 1.12.0 Resolution: Fixed > Create OAuth2TokenProvider controller service >

[jira] [Commented] (NIFI-7299) Create OAuth2TokenProvider controller service

2020-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125896#comment-17125896 ] ASF subversion and git services commented on NIFI-7299: --- Commit

[GitHub] [nifi] asfgit closed pull request #4173: NIFI-7299 Add basic OAuth2 token provider controller service

2020-06-04 Thread GitBox
asfgit closed pull request #4173: URL: https://github.com/apache/nifi/pull/4173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] jdye64 commented on pull request #4173: NIFI-7299 Add basic OAuth2 token provider controller service

2020-06-04 Thread GitBox
jdye64 commented on pull request #4173: URL: https://github.com/apache/nifi/pull/4173#issuecomment-638763248 CI is a fickle creature. Ok, looks good to me. I'm going to squash and merge. Thank you! This is an automated

[GitHub] [nifi] MikeThomsen commented on pull request #4173: NIFI-7299 Add basic OAuth2 token provider controller service

2020-06-04 Thread GitBox
MikeThomsen commented on pull request #4173: URL: https://github.com/apache/nifi/pull/4173#issuecomment-638759059 @jdye64 no idea, but it cleared up when I reran it. This is an automated message from the Apache Git Service.

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435125386 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -264,8 +265,8 @@ class Device { char mac[32];

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435124236 ## File path: libminifi/include/utils/file/FileManager.h ## @@ -92,12 +96,12 @@ class FileManager { #ifdef BOOST_VERSION return

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435123793 ## File path: libminifi/include/utils/MinifiConcurrentQueue.h ## @@ -87,8 +88,8 @@ class ConcurrentQueue { } private: -

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435106574 ## File path: libminifi/include/utils/file/FileManager.h ## @@ -72,12 +76,12 @@ class FileManager {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435102753 ## File path: libminifi/include/utils/file/FileUtils.h ## @@ -696,13 +695,13 @@ class FileUtils { return {}; } #endif /* WIN32 */ -};

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435102753 ## File path: libminifi/include/utils/file/FileUtils.h ## @@ -696,13 +695,13 @@ class FileUtils { return {}; } #endif /* WIN32 */ -};

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435102753 ## File path: libminifi/include/utils/file/FileUtils.h ## @@ -696,13 +695,13 @@ class FileUtils { return {}; } #endif /* WIN32 */ -};

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435102753 ## File path: libminifi/include/utils/file/FileUtils.h ## @@ -696,13 +695,13 @@ class FileUtils { return {}; } #endif /* WIN32 */ -};

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435100797 ## File path: libminifi/include/utils/Id.h ## @@ -52,8 +53,7 @@ namespace utils { template class IdentifierBase { public: - -

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435100517 ## File path: libminifi/include/utils/Id.h ## @@ -110,7 +109,7 @@ typedef uint8_t UUID_FIELD[16]; class Identifier : public IdentifierBase {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435100915 ## File path: libminifi/include/utils/Id.h ## @@ -119,7 +118,7 @@ class Identifier : public IdentifierBase { * I believe these exist to

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435100205 ## File path: libminifi/include/utils/HTTPClient.h ## @@ -176,12 +179,10 @@ class HTTPRequestResponse { HTTPRequestResponse(const

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435099625 ## File path: libminifi/include/utils/HTTPClient.h ## @@ -138,7 +143,7 @@ struct HTTPHeaderResponse { size_t separator_pos =

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435099183 ## File path: libminifi/include/utils/HTTPClient.h ## @@ -77,9 +82,9 @@ enum class SSLVersion : uint8_t { struct HTTPHeaderResponse {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435097593 ## File path: libminifi/include/utils/BackTrace.h ## @@ -46,7 +48,7 @@ class BackTrace { public: BackTrace() = default; -

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435097359 ## File path: libminifi/include/sitetosite/RawSocketProtocol.h ## @@ -52,21 +57,21 @@ namespace sitetosite { */ typedef struct

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435096754 ## File path: libminifi/include/io/tls/TLSSocket.h ## @@ -56,7 +62,7 @@ class OpenSSLInitializer { class TLSContext : public SocketContext {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435096240 ## File path: libminifi/include/io/StreamFactory.h ## @@ -88,15 +91,15 @@ class StreamFactory { } protected: - StreamFactory(const

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

2020-06-04 Thread GitBox
hunyadi-dev commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435096460 ## File path: libminifi/include/properties/Properties.h ## @@ -31,13 +33,12 @@ namespace minifi { class Properties { public: -

[GitHub] [nifi-minifi-cpp] adam-markovics commented on pull request #771: MINIFICPP-1183 Cleanup C2 tests

2020-06-04 Thread GitBox
adam-markovics commented on pull request #771: URL: https://github.com/apache/nifi-minifi-cpp/pull/771#issuecomment-638692073 @msharee9 Would you like to continue working on this PR? This is an automated message from the

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #797: MINIFICPP-1231 - General property validation + use them in MergeContent.

2020-06-04 Thread GitBox
adamdebreceni commented on a change in pull request #797: URL: https://github.com/apache/nifi-minifi-cpp/pull/797#discussion_r435033689 ## File path: libminifi/include/core/CachedValueValidator.h ## @@ -0,0 +1,103 @@ +/** + * + * Licensed to the Apache Software Foundation

[jira] [Resolved] (MINIFICPP-1235) Warning message on GetFile

2020-06-04 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ádám Markovics resolved MINIFICPP-1235. --- Resolution: Fixed [https://github.com/apache/nifi-minifi-cpp/pull/800] >