adamdebreceni commented on a change in pull request #853:
URL: https://github.com/apache/nifi-minifi-cpp/pull/853#discussion_r463406369
##
File path: .travis.yml
##
@@ -1,189 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
i
adamdebreceni commented on a change in pull request #848:
URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463404637
##
File path: libminifi/include/io/Serializable.h
##
@@ -44,8 +44,9 @@ Integral byteSwap(Integral i) {
#ifdef htonll
return htonll(i);
#e
jfrazee opened a new pull request #:
URL: https://github.com/apache/nifi/pull/
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
MuazmaZ commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463327284
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
##
@@
[
https://issues.apache.org/jira/browse/MINIFICPP-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168269#comment-17168269
]
Jeremy Dyer commented on MINIFICPP-1288:
[~hunyadi] I merged
[MINIFICPP-1288
asfgit merged pull request #855:
URL: https://github.com/apache/nifi-minifi-cpp/pull/855
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jfrazee commented on a change in pull request #4438:
URL: https://github.com/apache/nifi/pull/4438#discussion_r463293125
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureDataLakeStorage.java
szaszm commented on a change in pull request #854:
URL: https://github.com/apache/nifi-minifi-cpp/pull/854#discussion_r463270534
##
File path: CMakeSettings.json
##
@@ -2,97 +2,97 @@
// See https://go.microsoft.com//fwlink//?linkid=834763 for more information
about this fil
[
https://issues.apache.org/jira/browse/NIFI-7640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168195#comment-17168195
]
Tamás Bunth commented on NIFI-7640:
---
The temporary directory can be configured using jav
[
https://issues.apache.org/jira/browse/NIFI-7640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamás Bunth resolved NIFI-7640.
---
Resolution: Won't Fix
> HandleHttpRequest - define temporary files location
>
jfrazee commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463246197
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
#
stijn192 commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463237030
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/DeleteAzureBlobStorage.java
#
jfrazee commented on pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#issuecomment-53028
I have a very general concern about this change. The return type of
`createBlobServiceClient()` changes from `CloudBlobClient` to
`BlobServiceClient` in `AzureStorageUtils`, and `c
stijn192 commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463239345
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
##
@
stijn192 commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463234889
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
stijn192 commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463238291
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
stijn192 commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463237030
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/DeleteAzureBlobStorage.java
#
[
https://issues.apache.org/jira/browse/NIFI-7693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joey Frazee updated NIFI-7693:
--
Description:
NiFi cannot start using early Java 11 releases including Java 11 2018-09-25. It
throws:
{
stijn192 commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463234889
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
[
https://issues.apache.org/jira/browse/NIFI-7693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joey Frazee updated NIFI-7693:
--
Description:
NiFi cannot start using early Java 11 releases including Java 11 2018-09-25. It
throws
{{
[
https://issues.apache.org/jira/browse/NIFI-7693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joey Frazee updated NIFI-7693:
--
Description:
NiFi cannot start using early Java 11 releases including Java 11 2018-09-25. It
throws
{{
stijn192 commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463234889
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
Joey Frazee created NIFI-7693:
-
Summary: BeanCreationException when starting NiFi on Java 11
2018-09-25
Key: NIFI-7693
URL: https://issues.apache.org/jira/browse/NIFI-7693
Project: Apache NiFi
I
jdye64 commented on pull request #855:
URL: https://github.com/apache/nifi-minifi-cpp/pull/855#issuecomment-40856
Seems like the only issue with CI here was the job taking too long (and only
for OSX build). I see nothing wrong here and I'm going to merge this.
tpalfy commented on a change in pull request #4438:
URL: https://github.com/apache/nifi/pull/4438#discussion_r463217516
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/processors/azure/storage/ITListAzureDataLakeStorage.java
###
jfrazee commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463197857
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
#
jfrazee commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463196544
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
#
MuazmaZ commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r463176963
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
##
@@
pgyori commented on a change in pull request #4438:
URL: https://github.com/apache/nifi/pull/4438#discussion_r463154726
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/AbstractAzureDataLakeStorageProcessor.java
pgyori commented on a change in pull request #4438:
URL: https://github.com/apache/nifi/pull/4438#discussion_r463151518
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureDataLakeStorage.java
#
tpalfy commented on pull request #4411:
URL: https://github.com/apache/nifi/pull/4411#issuecomment-666508853
The poisoning approach introduces a novel concept to the design that
increases the complexity considerably and it needs to be handled from now on
the existing and any future process
[
https://issues.apache.org/jira/browse/NIFI-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168037#comment-17168037
]
Joe Witt commented on NIFI-7692:
https://issues.apache.org/jira/projects/NIFI/versions/123
Joe Witt created NIFI-7692:
--
Summary: Conduct Apache NiFi 1.12.0 Release
Key: NIFI-7692
URL: https://issues.apache.org/jira/browse/NIFI-7692
Project: Apache NiFi
Issue Type: Task
Reporte
[
https://issues.apache.org/jira/browse/NIFI-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168033#comment-17168033
]
Jon McAlexander commented on NIFI-7689:
---
That may actually be a benefitial thing to
fgerlits commented on a change in pull request #848:
URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463113874
##
File path: extensions/libarchive/BinFiles.h
##
@@ -91,7 +92,7 @@ class Bin {
if (flow->getAttribute(fileCount_, value)) {
try {
fgerlits commented on a change in pull request #848:
URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463111602
##
File path: libminifi/include/io/Serializable.h
##
@@ -44,8 +44,9 @@ Integral byteSwap(Integral i) {
#ifdef htonll
return htonll(i);
#else
-
fgerlits commented on a change in pull request #848:
URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463111602
##
File path: libminifi/include/io/Serializable.h
##
@@ -44,8 +44,9 @@ Integral byteSwap(Integral i) {
#ifdef htonll
return htonll(i);
#else
-
[
https://issues.apache.org/jira/browse/NIFI-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168024#comment-17168024
]
Nathan Gough commented on NIFI-7689:
No as far as I'm aware the only way this is confi
pvillard31 commented on pull request #4420:
URL: https://github.com/apache/nifi/pull/4420#issuecomment-666469978
I've played with it and it looks good to me. That is an awesome addition to
NiFi, thanks @simonbence !
@markap14 - I think it'd be best if you can have a look to the code sinc
szaszm commented on a change in pull request #845:
URL: https://github.com/apache/nifi-minifi-cpp/pull/845#discussion_r463076019
##
File path: libminifi/src/utils/OsUtils.cpp
##
@@ -154,6 +164,41 @@ std::string OsUtils::userIdToUsername(const std::string
&uid) {
return name
szaszm commented on a change in pull request #837:
URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r462925415
##
File path: libminifi/src/core/logging/LoggerConfiguration.cpp
##
@@ -298,22 +299,23 @@ std::shared_ptr
LoggerConfiguration::create_syslog_sink()
szaszm commented on a change in pull request #853:
URL: https://github.com/apache/nifi-minifi-cpp/pull/853#discussion_r463060927
##
File path: .travis.yml
##
@@ -1,189 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
I would
[
https://issues.apache.org/jira/browse/NIFI-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167993#comment-17167993
]
Jon McAlexander commented on NIFI-7689:
---
Thank you Nathan. Is there a configuration
adamdebreceni commented on a change in pull request #848:
URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463060513
##
File path: libminifi/include/io/Serializable.h
##
@@ -44,8 +44,9 @@ Integral byteSwap(Integral i) {
#ifdef htonll
return htonll(i);
#e
adamdebreceni commented on a change in pull request #848:
URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463040371
##
File path: extensions/libarchive/BinFiles.h
##
@@ -91,7 +92,7 @@ class Bin {
if (flow->getAttribute(fileCount_, value)) {
t
joewitt commented on pull request #4169:
URL: https://github.com/apache/nifi/pull/4169#issuecomment-666391898
I should clarify - over this time frame we've moved away from a 'master'
branch and instead to a 'main' branch. We've also made sure contrib-check
works properly/etc.. It would b
[
https://issues.apache.org/jira/browse/NIFI-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167952#comment-17167952
]
Nathan Gough edited comment on NIFI-7689 at 7/30/20, 2:13 PM:
--
[
https://issues.apache.org/jira/browse/NIFI-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167952#comment-17167952
]
Nathan Gough commented on NIFI-7689:
Hi Jon,
I'm not familiar with 'Qualys ID 11827'
joewitt commented on pull request #4169:
URL: https://github.com/apache/nifi/pull/4169#issuecomment-666389788
@si-sun It would be best to update this to base off latest main so all the
appropriate tests/checks can run please.
---
adamdebreceni commented on a change in pull request #849:
URL: https://github.com/apache/nifi-minifi-cpp/pull/849#discussion_r463025104
##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##
@@ -353,7 +354,7 @@ void ConsumeWindowsEventLog::onTrigger(const
std
adamdebreceni commented on a change in pull request #849:
URL: https://github.com/apache/nifi-minifi-cpp/pull/849#discussion_r463025210
##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##
@@ -385,7 +386,7 @@ void ConsumeWindowsEventLog::onTrigger(const
std
Hubi-WanKenobi commented on a change in pull request #4169:
URL: https://github.com/apache/nifi/pull/4169#discussion_r462959361
##
File path:
nifi-nar-bundles/nifi-smb-bundle/nifi-smb-processors/src/main/java/org/apache/nifi/processors/smb/PutSmbFile.java
##
@@ -0,0 +1,334 @@
tirkarthi opened a new pull request #4443:
URL: https://github.com/apache/nifi/pull/4443
Description of PR
Validate request object to be not null to fix NullPointerException fixes bug
NIFI-7691.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR?
[
https://issues.apache.org/jira/browse/NIFI-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167824#comment-17167824
]
Karthikeyan Singaravelan commented on NIFI-7691:
GitHub PR : https://githu
Karthikeyan Singaravelan created NIFI-7691:
--
Summary: Nifi web api crashes due to empty payload causing
NullPointerException
Key: NIFI-7691
URL: https://issues.apache.org/jira/browse/NIFI-7691
fgerlits commented on pull request #854:
URL: https://github.com/apache/nifi-minifi-cpp/pull/854#issuecomment-666282462
> Why change to 32 bit? Why RelWithDebInfo?
I wanted to be as close as possible to `win_build_vs.bat`, which builds a
32-bit Release version by default, but also in
turcsanyip commented on a change in pull request #4423:
URL: https://github.com/apache/nifi/pull/4423#discussion_r462886495
##
File path:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##
@@ -166,13 +166,
szaszm commented on pull request #854:
URL: https://github.com/apache/nifi-minifi-cpp/pull/854#issuecomment-666267382
Why change to 32 bit? Why RelWithDebInfo?
This is an automated message from the Apache Git Service.
To resp
[
https://issues.apache.org/jira/browse/NIFI-7613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Radden updated NIFI-7613:
---
Issue Type: Bug (was: Wish)
> Unpacked unique-named native libraries should be in the work directory
Ferdinand created NIFI-7690:
---
Summary: Make ListS3 processor accept incoming relations
Key: NIFI-7690
URL: https://issues.apache.org/jira/browse/NIFI-7690
Project: Apache NiFi
Issue Type: Wish
szaszm commented on a change in pull request #845:
URL: https://github.com/apache/nifi-minifi-cpp/pull/845#discussion_r462864018
##
File path: libminifi/src/utils/OsUtils.cpp
##
@@ -154,6 +164,41 @@ std::string OsUtils::userIdToUsername(const std::string
&uid) {
return name
turcsanyip commented on pull request #4423:
URL: https://github.com/apache/nifi/pull/4423#issuecomment-666225798
@kent-nguyen Please rebase your branch onto the current main branch instead
of merging the branches. I cannot squash your commits otherwise (getting merge
conflict when squashin
turcsanyip commented on pull request #4423:
URL: https://github.com/apache/nifi/pull/4423#issuecomment-666225798
@kent-nguyen Please rebase your branch onto the current main branch instead
of merging the branches. I cannot squash your commits otherwise (getting merge
conflict when squashin
fgerlits commented on a change in pull request #853:
URL: https://github.com/apache/nifi-minifi-cpp/pull/853#discussion_r462816700
##
File path: .github/workflows/ci.yml
##
@@ -0,0 +1,276 @@
+name: "MiNiFi-CPP CI"
+on: [push, pull_request, workflow_dispatch]
+jobs:
+ macos_xco
adamdebreceni commented on a change in pull request #853:
URL: https://github.com/apache/nifi-minifi-cpp/pull/853#discussion_r462817427
##
File path: .github/workflows/ci.yml
##
@@ -0,0 +1,276 @@
+name: "MiNiFi-CPP CI"
+on: [push, pull_request, workflow_dispatch]
+jobs:
+ maco
Fabryprog commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-666221835
Note: **ci-workflow** failed in other modules. I modified only
**nifi-expression-language**
This is an automated
pvillard31 commented on a change in pull request #4440:
URL: https://github.com/apache/nifi/pull/4440#discussion_r462823173
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteProcess.java
##
@@
turcsanyip commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r462824772
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
##
[
https://issues.apache.org/jira/browse/NIFI-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167732#comment-17167732
]
Sylvain Morin commented on NIFI-528:
Hello,
I fixed the indentation issues of the PR, s
pvillard31 commented on pull request #4442:
URL: https://github.com/apache/nifi/pull/4442#issuecomment-666199151
merged to main, thanks @alopresto
This is an automated message from the Apache Git Service.
To respond to the m
asfgit closed pull request #4442:
URL: https://github.com/apache/nifi/pull/4442
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pvillard31 commented on a change in pull request #4321:
URL: https://github.com/apache/nifi/pull/4321#discussion_r462814180
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestCompressContent.java
#
[
https://issues.apache.org/jira/browse/NIFI-7687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard resolved NIFI-7687.
--
Resolution: Fixed
> NiFi fails to start when running on first release of JDK major version
> ---
[
https://issues.apache.org/jira/browse/NIFI-7687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167721#comment-17167721
]
ASF subversion and git services commented on NIFI-7687:
---
Commit ac60
bbende commented on a change in pull request #232:
URL: https://github.com/apache/nifi-registry/pull/232#discussion_r462560423
##
File path:
nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/security/authorization/util/AccessPolicyProviderUtils.java
###
turcsanyip commented on a change in pull request #4430:
URL: https://github.com/apache/nifi/pull/4430#discussion_r462330562
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/storage/AzureStorageCredentialsControllerServ
alopresto merged pull request #4414:
URL: https://github.com/apache/nifi/pull/4414
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alopresto opened a new pull request #4442:
URL: https://github.com/apache/nifi/pull/4442
Added unit tests.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Fixes run bug on Windows 1
noedetore commented on a change in pull request #4321:
URL: https://github.com/apache/nifi/pull/4321#discussion_r462501409
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CompressContent.java
##
@@
bbende commented on pull request #232:
URL: https://github.com/apache/nifi-registry/pull/232#issuecomment-665903431
Thanks for reviewing! I agree that an IT test would be really nice,
especially given the test container DB profiles you mentioned. I think we
already have a similar example w
kevdoran commented on a change in pull request #232:
URL: https://github.com/apache/nifi-registry/pull/232#discussion_r462516281
##
File path:
nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/security/identity/IdentityMapper.java
##
@@ -0,0 +1,
alopresto commented on pull request #4414:
URL: https://github.com/apache/nifi/pull/4414#issuecomment-665814216
Reviewing...
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
Fabryprog opened a new pull request #4441:
URL: https://github.com/apache/nifi/pull/4441
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables NIFI-7525 functionality_
In order to
asfgit closed pull request #4422:
URL: https://github.com/apache/nifi/pull/4422
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/NIFI-6332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi resolved NIFI-6332.
---
Fix Version/s: 1.12.0
Resolution: Fixed
> PutS3 Processor adding Cache-Control property
85 matches
Mail list logo
