adamdebreceni commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535908118
##
File path: libminifi/include/utils/tls/WindowsCertStoreLocation.h
##
@@ -0,0 +1,52 @@
+/**
+ * Licensed to the Apache Software Foundation (
Martin created NIFI-8072:
Summary: Parameters with spaces don't work within Expression
Language
Key: NIFI-8072
URL: https://issues.apache.org/jira/browse/NIFI-8072
Project: Apache NiFi
Issue Type: B
Gabor Gyimesi created MINIFICPP-1419:
Summary: Stabilize docker tests in Github Actions
Key: MINIFICPP-1419
URL: https://issues.apache.org/jira/browse/MINIFICPP-1419
Project: Apache NiFi MiNiFi C++
[
https://issues.apache.org/jira/browse/MINIFICPP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi reassigned MINIFICPP-1405:
---
Assignee: Adam Hunyadi
> Improperly defined warning flags (Clang 11) break Ninja
adamdebreceni commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535926302
##
File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) unde
adamdebreceni commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535926302
##
File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) unde
lordgamez opened a new pull request #949:
URL: https://github.com/apache/nifi-minifi-cpp/pull/949
There have been cases in the past where test_zero_file.py test was failing
in Github Actions. The test timed out and failed, but the issue could not be
reproduced locally. It is probably due t
adamdebreceni commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535929166
##
File path: libminifi/src/utils/tls/DistinguishedName.cpp
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) unde
[
https://issues.apache.org/jira/browse/MINIFICPP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243853#comment-17243853
]
Adam Hunyadi commented on MINIFICPP-1405:
-
The issue does not seem to be rela
[
https://issues.apache.org/jira/browse/MINIFICPP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1405:
Summary: Fix improperly defined warning flags for civetweb (was:
Improperly defined wa
[
https://issues.apache.org/jira/browse/MINIFICPP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1405:
Description:
*Background:*
Building civetweb is unstable on certain environment (our C
[
https://issues.apache.org/jira/browse/MINIFICPP-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi resolved MINIFICPP-1411.
-
Resolution: Fixed
> Replace \n characters with in agent docs generation
> --
[
https://issues.apache.org/jira/browse/MINIFICPP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1405:
Description:
*Background:*
Building civetweb is unstable on certain environment (our C
[
https://issues.apache.org/jira/browse/MINIFICPP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1405:
Labels: Linux MiNiFi-CPP-Hygiene Ubuntu_16.04 linux ubuntu (was: Linux
Ubuntu_16.04 li
fgerlits commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535961701
##
File path: libminifi/src/utils/tls/DistinguishedName.cpp
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
fgerlits commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535967134
##
File path: libminifi/src/utils/tls/DistinguishedName.cpp
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
fgerlits commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535968353
##
File path: libminifi/include/utils/tls/WindowsCertStoreLocation.h
##
@@ -0,0 +1,52 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
fgerlits commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535968353
##
File path: libminifi/include/utils/tls/WindowsCertStoreLocation.h
##
@@ -0,0 +1,52 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
fgerlits commented on a change in pull request #947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r535969312
##
File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
CefBoud opened a new pull request #4709:
URL: https://github.com/apache/nifi/pull/4709
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Include CN as a SAN entry when generating a self-signed certificate.
_Enables
hunyadi-dev opened a new pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950
Also, disable building duktape and lua support for civetweb.
Seems like civetweb had an issue using the available compiler flags. I
opened a PR for them [here](https://github.com/civet
fgerlits commented on a change in pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950#discussion_r536014970
##
File path: thirdparty/civetweb/civetweb.patch
##
@@ -1,61 +1,45 @@
-diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 2c08bd28..ccb4fd7f 10064
hunyadi-dev commented on a change in pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950#discussion_r536020151
##
File path: thirdparty/civetweb/civetweb.patch
##
@@ -1,61 +1,45 @@
-diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 2c08bd28..ccb4fd7f 10
[
https://issues.apache.org/jira/browse/MINIFICPP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1405:
Description:
*Background:*
Building civetweb is unstable on certain environment (our C
[
https://issues.apache.org/jira/browse/MINIFICPP-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1405:
Description:
*Background:*
Building civetweb is unstable on certain environment (our C
Mohanna Tahanna created NIFI-8073:
-
Summary: SiteToSiteStatusReportingTask - isBackPressureEnabled
field not set correctly
Key: NIFI-8073
URL: https://issues.apache.org/jira/browse/NIFI-8073
Project:
[
https://issues.apache.org/jira/browse/NIFI-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mohanna Tahanna updated NIFI-8073:
--
Affects Version/s: 1.12.1
> SiteToSiteStatusReportingTask - isBackPressureEnabled field not set
[
https://issues.apache.org/jira/browse/NIFI-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243967#comment-17243967
]
ASF subversion and git services commented on NIFI-8042:
---
Commit 29ea
asfgit closed pull request #4685:
URL: https://github.com/apache/nifi/pull/4685
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/NIFI-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Thomsen updated NIFI-8042:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> ReplaceText failing to update tex
asfgit closed pull request #3893:
URL: https://github.com/apache/nifi/pull/3893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/NIFI-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243973#comment-17243973
]
ASF subversion and git services commented on NIFI-6878:
---
Commit 71d5
pvillard31 commented on pull request #4706:
URL: https://github.com/apache/nifi/pull/4706#issuecomment-738762946
Reviewing
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/NIFI-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Thomsen updated NIFI-6878:
---
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> C
[
https://issues.apache.org/jira/browse/NIFI-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard updated NIFI-7844:
-
Fix Version/s: 1.13.0
> substring should return empty instead of throwing IndexOutOfBoundsExceptio
fgerlits commented on a change in pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950#discussion_r536091892
##
File path: cmake/BundledCivetWeb.cmake
##
@@ -30,8 +30,8 @@ function(use_bundled_civetweb SOURCE_DIR BINARY_DIR)
endif()
set(BYPRODU
hunyadi-dev commented on a change in pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950#discussion_r536093777
##
File path: cmake/BundledCivetWeb.cmake
##
@@ -30,8 +30,8 @@ function(use_bundled_civetweb SOURCE_DIR BINARY_DIR)
endif()
set(BYPR
hunyadi-dev commented on a change in pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950#discussion_r536093777
##
File path: cmake/BundledCivetWeb.cmake
##
@@ -30,8 +30,8 @@ function(use_bundled_civetweb SOURCE_DIR BINARY_DIR)
endif()
set(BYPR
exceptionfactory opened a new pull request #4710:
URL: https://github.com/apache/nifi/pull/4710
Description of PR
NIFI-8069 Set Component Validation Status to INVALID when referenced
Controller Services have a state of ENABLING.
In order to streamline the review of the co
[
https://issues.apache.org/jira/browse/NIFI-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-8069:
---
Affects Version/s: 1.12.1
> Keep processors invalid while referenced Controller Services are E
[
https://issues.apache.org/jira/browse/NIFI-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-8069:
---
Status: Patch Available (was: In Progress)
> Keep processors invalid while referenced Control
[
https://issues.apache.org/jira/browse/NIFI-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-8070:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Add a coalesce function to RecordPath
hunyadi-dev commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r536131994
##
File path: encrypt-config/ArgParser.cpp
##
@@ -0,0 +1,178 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
hunyadi-dev commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r536131994
##
File path: encrypt-config/ArgParser.cpp
##
@@ -0,0 +1,178 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
fgerlits commented on a change in pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950#discussion_r536135645
##
File path: cmake/BundledCivetWeb.cmake
##
@@ -30,8 +30,8 @@ function(use_bundled_civetweb SOURCE_DIR BINARY_DIR)
endif()
set(BYPRODU
fgerlits commented on a change in pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950#discussion_r536135645
##
File path: cmake/BundledCivetWeb.cmake
##
@@ -30,8 +30,8 @@ function(use_bundled_civetweb SOURCE_DIR BINARY_DIR)
endif()
set(BYPRODU
arpadboda commented on pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#issuecomment-738839580
Merging this as the comments left unresolved are not showstoppers and the
review is already pretty difficult to follow.
@szaszm @hunyadi-dev please open a follow-u
lordgamez commented on a change in pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950#discussion_r536175275
##
File path: cmake/BundledCivetWeb.cmake
##
@@ -30,8 +30,8 @@ function(use_bundled_civetweb SOURCE_DIR BINARY_DIR)
endif()
set(BYPROD
mattyb149 commented on a change in pull request #4697:
URL: https://github.com/apache/nifi/pull/4697#discussion_r536199849
##
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/UpdateHive3Table.java
##
@@ -322,29 +4
arpadboda closed pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/NIFI-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne resolved NIFI-755.
-
Resolution: Won't Fix
Persistent prov repo is now deprecated. Closing Jira.
> Allow persistent prov repo t
hunyadi-dev commented on a change in pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950#discussion_r536243355
##
File path: cmake/BundledCivetWeb.cmake
##
@@ -30,8 +30,8 @@ function(use_bundled_civetweb SOURCE_DIR BINARY_DIR)
endif()
set(BYPR
pvillard31 commented on pull request #4706:
URL: https://github.com/apache/nifi/pull/4706#issuecomment-738945609
Gave it a try with a use case where I had the same kind of requirement.
Working as expected, merging to main, thanks @markap14 !
---
asfgit closed pull request #4706:
URL: https://github.com/apache/nifi/pull/4706
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/NIFI-8068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244208#comment-17244208
]
ASF subversion and git services commented on NIFI-8068:
---
Commit 37c2
[
https://issues.apache.org/jira/browse/NIFI-8068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard updated NIFI-8068:
-
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
pvillard31 commented on pull request #4705:
URL: https://github.com/apache/nifi/pull/4705#issuecomment-738951544
Hey @r65535 - thanks for this contribution. While the code looks good to
me, can you make sure there is an existing JIRA for this? (or create one if not)
-
[
https://issues.apache.org/jira/browse/NIFI-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi resolved NIFI-8057.
---
Resolution: Won't Do
> Remove truststore check from SslContextFactory.createSslContext()
> ---
58 matches
Mail list logo