[jira] [Assigned] (MINIFICPP-1295) ListenHTTP tests are unstable

2020-12-16 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1295: Assignee: Gabor Gyimesi > ListenHTTP tests are unstable >

[jira] [Resolved] (MINIFICPP-1295) ListenHTTP tests are unstable

2020-12-16 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi resolved MINIFICPP-1295. -- Resolution: Fixed ListenHTTP tests seem to be stable with no transient failures in

[jira] [Created] (NIFI-8099) HTTP Headers is case-insentitive and overwrite attributes values

2020-12-16 Thread Jens M Kofoed (Jira)
Jens M Kofoed created NIFI-8099: --- Summary: HTTP Headers is case-insentitive and overwrite attributes values Key: NIFI-8099 URL: https://issues.apache.org/jira/browse/NIFI-8099 Project: Apache NiFi

[jira] [Commented] (NIFI-4890) OIDC Token Refresh is not done correctly

2020-12-16 Thread Ruben Laguna (Jira)
[ https://issues.apache.org/jira/browse/NIFI-4890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250176#comment-17250176 ] Ruben Laguna commented on NIFI-4890: The token expiration "exp" SHOULD be honored, I t

[jira] [Commented] (NIFI-7922) Add support for GET request in ListenHTTP for health check

2020-12-16 Thread Ruben Laguna (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250182#comment-17250182 ] Ruben Laguna commented on NIFI-7922: Is GET really supported? The [documentation|http

[jira] [Created] (NIFI-8100) Provide a /health endpoint that do not require authentication for use in LoadBalancer

2020-12-16 Thread Ruben Laguna (Jira)
Ruben Laguna created NIFI-8100: -- Summary: Provide a /health endpoint that do not require authentication for use in LoadBalancer Key: NIFI-8100 URL: https://issues.apache.org/jira/browse/NIFI-8100 Project

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #893: MINIFICPP-1288 - FlowController C2 init refactor

2020-12-16 Thread GitBox
hunyadi-dev commented on a change in pull request #893: URL: https://github.com/apache/nifi-minifi-cpp/pull/893#discussion_r544141796 ## File path: libminifi/src/FlowController.cpp ## @@ -216,9 +215,6 @@ bool FlowController::applyConfiguration(const std::string &source, const

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on pull request #893: MINIFICPP-1288 - FlowController C2 init refactor

2020-12-16 Thread GitBox
hunyadi-dev commented on pull request #893: URL: https://github.com/apache/nifi-minifi-cpp/pull/893#issuecomment-745982304 Probably part of #890, not worth rebasing separately. This is an automated message from the Apache Git

[GitHub] [nifi-minifi-cpp] hunyadi-dev closed pull request #893: MINIFICPP-1288 - FlowController C2 init refactor

2020-12-16 Thread GitBox
hunyadi-dev closed pull request #893: URL: https://github.com/apache/nifi-minifi-cpp/pull/893 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #959: MINIFICPP-1424 Stabilize several flaky test suites

2020-12-16 Thread GitBox
lordgamez commented on a change in pull request #959: URL: https://github.com/apache/nifi-minifi-cpp/pull/959#discussion_r544183525 ## File path: libminifi/test/persistence-tests/PersistenceTests.cpp ## @@ -326,11 +335,15 @@ TEST_CASE("Persisted flowFiles are updated on modifi

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #959: MINIFICPP-1424 Stabilize several flaky test suites

2020-12-16 Thread GitBox
lordgamez commented on a change in pull request #959: URL: https://github.com/apache/nifi-minifi-cpp/pull/959#discussion_r544183525 ## File path: libminifi/test/persistence-tests/PersistenceTests.cpp ## @@ -326,11 +335,15 @@ TEST_CASE("Persisted flowFiles are updated on modifi

[GitHub] [nifi] turcsanyip commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP

2020-12-16 Thread GitBox
turcsanyip commented on a change in pull request #4721: URL: https://github.com/apache/nifi/pull/4721#discussion_r544222453 ## File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/AbstractListProcessor.java ##

[jira] [Commented] (NIFI-7922) Add support for GET request in ListenHTTP for health check

2020-12-16 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250263#comment-17250263 ] Pierre Villard commented on NIFI-7922: -- GET has been added just for health check purp

[GitHub] [nifi] pvillard31 commented on pull request #4728: NIFI-8092: Fix ITPutS3Object test failure due to Outposts storage class

2020-12-16 Thread GitBox
pvillard31 commented on pull request #4728: URL: https://github.com/apache/nifi/pull/4728#issuecomment-746159668 Merged to main, thanks @turcsanyip This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi] asfgit closed pull request #4728: NIFI-8092: Fix ITPutS3Object test failure due to Outposts storage class

2020-12-16 Thread GitBox
asfgit closed pull request #4728: URL: https://github.com/apache/nifi/pull/4728 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (NIFI-8092) Fix ITPutS3Object test failure due to Outposts storage class

2020-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250264#comment-17250264 ] ASF subversion and git services commented on NIFI-8092: --- Commit 0266

[jira] [Updated] (NIFI-8092) Fix ITPutS3Object test failure due to Outposts storage class

2020-12-16 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8092: - Fix Version/s: 1.13.0 Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (NIFI-8099) HTTP Headers is case-insentitive and overwrite attributes values

2020-12-16 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250266#comment-17250266 ] Pierre Villard commented on NIFI-8099: -- Not sure what would the correct approach be i

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #959: MINIFICPP-1424 Stabilize several flaky test suites

2020-12-16 Thread GitBox
lordgamez commented on a change in pull request #959: URL: https://github.com/apache/nifi-minifi-cpp/pull/959#discussion_r544237854 ## File path: libminifi/test/persistence-tests/PersistenceTests.cpp ## @@ -326,11 +335,15 @@ TEST_CASE("Persisted flowFiles are updated on modifi

[jira] [Commented] (NIFI-3882) Unable to run NiFi behind AWS Load Balancer

2020-12-16 Thread Ruben Laguna (Jira)
[ https://issues.apache.org/jira/browse/NIFI-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250279#comment-17250279 ] Ruben Laguna commented on NIFI-3882: I guess, that it was really terminating the HTTPS

[GitHub] [nifi-minifi-cpp] dam4rus opened a new pull request #961: MINIFICPP-1440 PublishKafka processor's "security protocol" should ha…

2020-12-16 Thread GitBox
dam4rus opened a new pull request #961: URL: https://github.com/apache/nifi-minifi-cpp/pull/961 …ve allowable values Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] [nifi-registry] exceptionfactory opened a new pull request #314: NIFIREG-434 Added support for BCFKS Keystore Type

2020-12-16 Thread GitBox
exceptionfactory opened a new pull request #314: URL: https://github.com/apache/nifi-registry/pull/314 Description of PR NIFIREG-434 Adds support for Bouncy Castle FIPS Key Store (BCFKS) in NiFi Registry configuration properties. BCFKS provides improved security for storage of

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #901: MINIFICPP-1288 - Refactor YamlConfiguration::parsePropertiesNodeYaml

2020-12-16 Thread GitBox
szaszm commented on a change in pull request #901: URL: https://github.com/apache/nifi-minifi-cpp/pull/901#discussion_r544313026 ## File path: libminifi/src/core/yaml/YamlConfiguration.cpp ## @@ -762,106 +762,109 @@ void YamlConfiguration::parsePortYaml(YAML::Node *portNode, c

[jira] [Assigned] (NIFIREG-434) Support BCFKS Keystore Type

2020-12-16 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFIREG-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFIREG-434: Assignee: David Handermann > Support BCFKS Keystore Type > --

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #961: MINIFICPP-1440 PublishKafka processor's "security protocol" should ha…

2020-12-16 Thread GitBox
szaszm commented on a change in pull request #961: URL: https://github.com/apache/nifi-minifi-cpp/pull/961#discussion_r544326007 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -126,7 +126,11 @@ const core::Property PublishKafka::CompressCodec( const core::Property

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #901: MINIFICPP-1288 - Refactor YamlConfiguration::parsePropertiesNodeYaml

2020-12-16 Thread GitBox
szaszm closed pull request #901: URL: https://github.com/apache/nifi-minifi-cpp/pull/901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Created] (MINIFICPP-1441) Specify Lua version instead of default

2020-12-16 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1441: Summary: Specify Lua version instead of default Key: MINIFICPP-1441 URL: https://issues.apache.org/jira/browse/MINIFICPP-1441 Project: Apache NiFi MiNiFi C++

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez opened a new pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962 Current default Lua version 5.4 on Mac environments in Github actions is unsupported by third party component sol2 2.20. Version 5.3 needs to be installed before flex which would install Lua 5

[jira] [Assigned] (MINIFICPP-1441) Specify Lua version instead of default

2020-12-16 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1441: Assignee: Gabor Gyimesi > Specify Lua version instead of default > ---

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #920: MINIFICPP-1296 - All tests should use volatile state storage

2020-12-16 Thread GitBox
szaszm closed pull request #920: URL: https://github.com/apache/nifi-minifi-cpp/pull/920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (NIFI-3882) Unable to run NiFi behind AWS Load Balancer

2020-12-16 Thread Otto Fowler (Jira)
[ https://issues.apache.org/jira/browse/NIFI-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250369#comment-17250369 ] Otto Fowler commented on NIFI-3882: --- Maybe there would need to be multiple endpoints, wi

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
fgerlits commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544370743 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_depen

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #959: MINIFICPP-1424 Stabilize several flaky test suites

2020-12-16 Thread GitBox
szaszm closed pull request #959: URL: https://github.com/apache/nifi-minifi-cpp/pull/959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #961: MINIFICPP-1440 PublishKafka processor's "security protocol" should ha…

2020-12-16 Thread GitBox
hunyadi-dev commented on a change in pull request #961: URL: https://github.com/apache/nifi-minifi-cpp/pull/961#discussion_r544387125 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -126,7 +126,11 @@ const core::Property PublishKafka::CompressCodec( const core::Prop

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2020-12-16 Thread GitBox
szaszm commented on pull request #472: URL: https://github.com/apache/nifi-minifi-cpp/pull/472#issuecomment-746471822 Closing this because of inactivity This is an automated message from the Apache Git Service. To respond to

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2020-12-16 Thread GitBox
szaszm closed pull request #472: URL: https://github.com/apache/nifi-minifi-cpp/pull/472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #515: MINIFICPP-646 - Re-evaluate passing attributes. Potentially deprecate…

2020-12-16 Thread GitBox
szaszm commented on pull request #515: URL: https://github.com/apache/nifi-minifi-cpp/pull/515#issuecomment-746472846 Closing this because of inactivity This is an automated message from the Apache Git Service. To respond to

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #515: MINIFICPP-646 - Re-evaluate passing attributes. Potentially deprecate…

2020-12-16 Thread GitBox
szaszm closed pull request #515: URL: https://github.com/apache/nifi-minifi-cpp/pull/515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #563: WiP: MINIFICPP-839 - Fix memleaks

2020-12-16 Thread GitBox
szaszm closed pull request #563: URL: https://github.com/apache/nifi-minifi-cpp/pull/563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #563: WiP: MINIFICPP-839 - Fix memleaks

2020-12-16 Thread GitBox
szaszm commented on pull request #563: URL: https://github.com/apache/nifi-minifi-cpp/pull/563#issuecomment-746479797 Closing this because of inactivity. Some of the leaks have been fixed on main, and I'll make sure to check this as reference when similar efforts are underway. --

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #598: MINIFICPP-934: Enable all features again

2020-12-16 Thread GitBox
szaszm closed pull request #598: URL: https://github.com/apache/nifi-minifi-cpp/pull/598 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #598: MINIFICPP-934: Enable all features again

2020-12-16 Thread GitBox
szaszm commented on pull request #598: URL: https://github.com/apache/nifi-minifi-cpp/pull/598#issuecomment-746481596 This has been superseded by github actions CI, where there is a configuration with all stable features enabled. ---

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #603: MINIFICPP-929 mmap

2020-12-16 Thread GitBox
szaszm commented on pull request #603: URL: https://github.com/apache/nifi-minifi-cpp/pull/603#issuecomment-746483791 Closing this because of inactivity. I think the community doesn't have the capacity to review such huge PRs in general. ---

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #603: MINIFICPP-929 mmap

2020-12-16 Thread GitBox
szaszm closed pull request #603: URL: https://github.com/apache/nifi-minifi-cpp/pull/603 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #617: Minificpp 897

2020-12-16 Thread GitBox
szaszm closed pull request #617: URL: https://github.com/apache/nifi-minifi-cpp/pull/617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #617: Minificpp 897

2020-12-16 Thread GitBox
szaszm commented on pull request #617: URL: https://github.com/apache/nifi-minifi-cpp/pull/617#issuecomment-746487461 Closing this because of inactivity This is an automated message from the Apache Git Service. To respond to

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #618: POC: MINIFICPP-985 - Implement listvalidators

2020-12-16 Thread GitBox
szaszm closed pull request #618: URL: https://github.com/apache/nifi-minifi-cpp/pull/618 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #618: POC: MINIFICPP-985 - Implement listvalidators

2020-12-16 Thread GitBox
szaszm commented on pull request #618: URL: https://github.com/apache/nifi-minifi-cpp/pull/618#issuecomment-746490514 Closing this because of inactivity. This is an automated message from the Apache Git Service. To respond to

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #624: CEM-462 CEM-417 Fixed.

2020-12-16 Thread GitBox
szaszm closed pull request #624: URL: https://github.com/apache/nifi-minifi-cpp/pull/624 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #624: CEM-462 CEM-417 Fixed.

2020-12-16 Thread GitBox
szaszm commented on pull request #624: URL: https://github.com/apache/nifi-minifi-cpp/pull/624#issuecomment-746496480 Closing this because of inactivity. It seems to be fixed already, but the issue it not 100% clear from the PR.

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544404215 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_depe

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544404215 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_depe

[GitHub] [nifi] thenatog opened a new pull request #4731: NIFI-8098 - Bump jetty.version from 9.4.34.v20201102 to 9.4.35.v20201120

2020-12-16 Thread GitBox
thenatog opened a new pull request #4731: URL: https://github.com/apache/nifi/pull/4731 dependabot[bot] Updates `jetty-server` from 9.4.34.v20201102 to 9.4.35.v20201120 - [Release notes](https://github.com/eclipse/jetty.project/releases) - [Commits](https://github.com/eclipse/jetty.

[GitHub] [nifi] thenatog commented on pull request #4731: NIFI-8098 - Bump jetty.version from 9.4.34.v20201102 to 9.4.35.v20201120

2020-12-16 Thread GitBox
thenatog commented on pull request #4731: URL: https://github.com/apache/nifi/pull/4731#issuecomment-746515095 Tested upgraded Jetty in a secure cluster. Checked the other web contexts work as expected. Tested out using ListenHTTP, PostHTTP processors, and used Site-To-Site to transmit dat

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
hunyadi-dev commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544411596 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_de

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544419612 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_depe

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
hunyadi-dev commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544411596 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_de

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
hunyadi-dev commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544425110 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_de

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
szaszm commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746574641 Still failing :disappointed: https://github.com/apache/nifi-minifi-cpp/pull/962/checks?check_run_id=1564459700#step:5:10792 ---

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544436458 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_depe

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r50153 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_depe

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r50153 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_depe

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r50153 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_depe

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r50153 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_depe

[GitHub] [nifi] NissimShiman commented on pull request #4620: NIFI-6242 PutFileTransfer generation incorrect provenance event

2020-12-16 Thread GitBox
NissimShiman commented on pull request #4620: URL: https://github.com/apache/nifi/pull/4620#issuecomment-746644194 Code is well structured and unit tested. I compiled and tested on both java 8 and java 11 and issue is fixed. Issue was that transitUri in SEND ProvenanceEvent

[GitHub] [nifi] NissimShiman edited a comment on pull request #4620: NIFI-6242 PutFileTransfer generation incorrect provenance event

2020-12-16 Thread GitBox
NissimShiman edited a comment on pull request #4620: URL: https://github.com/apache/nifi/pull/4620#issuecomment-746644194 Code has been reviewed. It is well structured and unit tested. I compiled and tested on both java 8 and java 11 and issue is fixed. Issue was that trans

[GitHub] [nifi] NissimShiman edited a comment on pull request #4620: NIFI-6242 PutFileTransfer generation incorrect provenance event

2020-12-16 Thread GitBox
NissimShiman edited a comment on pull request #4620: URL: https://github.com/apache/nifi/pull/4620#issuecomment-746644194 Code has been reviewed. It is well structured and unit tested. I compiled and tested on both java 8 and java 11 and issue is fixed. Issue was that trans

[jira] [Created] (MINIFICPP-1442) Uplift sol2 to latest release version

2020-12-16 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1442: Summary: Uplift sol2 to latest release version Key: MINIFICPP-1442 URL: https://issues.apache.org/jira/browse/MINIFICPP-1442 Project: Apache NiFi MiNiFi C++

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 3.2.2

2020-12-16 Thread GitBox
lordgamez opened a new pull request #963: URL: https://github.com/apache/nifi-minifi-cpp/pull/963 Version 3.2.2 released single hpp library was downloaded from https://github.com/ThePhD/sol2/releases Thank you for submitting

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746733014 The issue comes from the compatibility of sol2 library that we use version 2.20.0 of. This release is 2 years old, so it might be more appropriate to uplift this library

[jira] [Updated] (NIFI-6242) PutFileTransfer generating incorrect provenance events

2020-12-16 Thread Tim Smith (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Smith updated NIFI-6242: Status: Patch Available (was: Open) > PutFileTransfer generating incorrect provenance events >

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
szaszm commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746747703 I thought this PR fixes the incompatibility issue by installing 5.3 instead of 5.4 This is an automated me

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746756551 > I thought this PR fixes the incompatibility issue by installing 5.3 instead of 5.4 That was the original idea as sol2 2.20.0 is hardcoded to be incompatible wit

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
szaszm commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746760913 So the original idea was to downgrade Lua, but it didn't work, so you went for the upgrade, which is a better solution anyway, do I understand it right? If so, this PR can

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds

2020-12-16 Thread GitBox
lordgamez commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746767755 Yes, exactly. But before closing this PR I would like to see if the tests pass with the upgraded sol2 version and see if anyone has any objections against the upgrade.

[GitHub] [nifi] tpalfy opened a new pull request #4732: NIFI-8027 Support semicolons in SQL Pre- and Post-Query

2020-12-16 Thread GitBox
tpalfy opened a new pull request #4732: URL: https://github.com/apache/nifi/pull/4732 In AbstractExecuteSQL semicolons can be escaped in SQL Pre- and Post-Query ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit messag

[GitHub] [nifi] turcsanyip commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP

2020-12-16 Thread GitBox
turcsanyip commented on a change in pull request #4721: URL: https://github.com/apache/nifi/pull/4721#discussion_r544536013 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFileTransfer.java ## @

[GitHub] [nifi] turcsanyip commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP

2020-12-16 Thread GitBox
turcsanyip commented on a change in pull request #4721: URL: https://github.com/apache/nifi/pull/4721#discussion_r544537496 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFileTransfer.java ## @

[GitHub] [nifi] turcsanyip commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP

2020-12-16 Thread GitBox
turcsanyip commented on a change in pull request #4721: URL: https://github.com/apache/nifi/pull/4721#discussion_r544542796 ## File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/validator/TimeAdjustmentValidator.java

[GitHub] [nifi] turcsanyip commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP

2020-12-16 Thread GitBox
turcsanyip commented on a change in pull request #4721: URL: https://github.com/apache/nifi/pull/4721#discussion_r544543960 ## File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/validator/TimeAdjustmentValidator.java

[GitHub] [nifi] mattyb149 commented on a change in pull request #4668: NIFI-7991 Flow Configuration History displays "annotation data not fo…

2020-12-16 Thread GitBox
mattyb149 commented on a change in pull request #4668: URL: https://github.com/apache/nifi/pull/4668#discussion_r544549281 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/audit/ProcessorAuditor.java ## @@

[jira] [Commented] (NIFI-3882) Unable to run NiFi behind AWS Load Balancer

2020-12-16 Thread Ruben Laguna (Jira)
[ https://issues.apache.org/jira/browse/NIFI-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250545#comment-17250545 ] Ruben Laguna commented on NIFI-3882: Maybe it would be better to comment that in NIFI-

[jira] [Commented] (NIFI-7922) Add support for GET request in ListenHTTP for health check

2020-12-16 Thread Ruben Laguna (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250549#comment-17250549 ] Ruben Laguna commented on NIFI-7922: Can this be used to determine if the Nifi UI is “

[jira] [Commented] (NIFI-7922) Add support for GET request in ListenHTTP for health check

2020-12-16 Thread Ruben Laguna (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250551#comment-17250551 ] Ruben Laguna commented on NIFI-7922: https://issues.apache.org/jira/plugins/servlet/mo

[jira] [Updated] (MINIFICPP-1442) Uplift sol2 to newer version to support LUA version 5.4

2020-12-16 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi updated MINIFICPP-1442: - Summary: Uplift sol2 to newer version to support LUA version 5.4 (was: Uplift sol2 t

[jira] [Updated] (MINIFICPP-1442) Uplift sol2 to newer version to support LUA version 5.4

2020-12-16 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi updated MINIFICPP-1442: - Description: We should uplift sol2 to support newer LUA versions. (was: Current sol2

[GitHub] [nifi] tpalfy commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP

2020-12-16 Thread GitBox
tpalfy commented on a change in pull request #4721: URL: https://github.com/apache/nifi/pull/4721#discussion_r544562070 ## File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/validator/TimeAdjustmentValidator.java ###

[GitHub] [nifi] tpalfy commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP

2020-12-16 Thread GitBox
tpalfy commented on a change in pull request #4721: URL: https://github.com/apache/nifi/pull/4721#discussion_r544573935 ## File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/validator/TimeAdjustmentValidator.java ###

[GitHub] [nifi] tpalfy commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP

2020-12-16 Thread GitBox
tpalfy commented on a change in pull request #4721: URL: https://github.com/apache/nifi/pull/4721#discussion_r544574271 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFileTransfer.java ## @@ -1

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6

2020-12-16 Thread GitBox
lordgamez commented on pull request #963: URL: https://github.com/apache/nifi-minifi-cpp/pull/963#issuecomment-746910434 Even though the compatibility error disappeared, the build still fails with the following: ``` 2020-12-16T19:36:38.2089590Z /Users/runner/work/nifi-minifi-cpp/nifi

[GitHub] [nifi] mattyb149 commented on pull request #4732: NIFI-8027 Support semicolons in SQL Pre- and Post-Query

2020-12-16 Thread GitBox
mattyb149 commented on pull request #4732: URL: https://github.com/apache/nifi/pull/4732#issuecomment-746921673 +1 LGTM, tested with multiple SET commands on PostgreSQL using Pre- and Post-Query properties. Thanks for the improvement! Merging to main --

[GitHub] [nifi] mattyb149 closed pull request #4732: NIFI-8027 Support semicolons in SQL Pre- and Post-Query

2020-12-16 Thread GitBox
mattyb149 closed pull request #4732: URL: https://github.com/apache/nifi/pull/4732 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (NIFI-8027) Allow semicolons in SQL Pre-Query and SQL Post-Query statements

2020-12-16 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess resolved NIFI-8027. Fix Version/s: 1.13.0 Resolution: Fixed > Allow semicolons in SQL Pre-Query and SQL Post-Quer

[jira] [Commented] (NIFI-8027) Allow semicolons in SQL Pre-Query and SQL Post-Query statements

2020-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250592#comment-17250592 ] ASF subversion and git services commented on NIFI-8027: --- Commit 9892

[jira] [Created] (MINIFICPP-1443) Get rid of most "possible loss of data" warnings

2020-12-16 Thread Ferenc Gerlits (Jira)
Ferenc Gerlits created MINIFICPP-1443: - Summary: Get rid of most "possible loss of data" warnings Key: MINIFICPP-1443 URL: https://issues.apache.org/jira/browse/MINIFICPP-1443 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] dam4rus commented on a change in pull request #961: MINIFICPP-1440 PublishKafka processor's "security protocol" should ha…

2020-12-16 Thread GitBox
dam4rus commented on a change in pull request #961: URL: https://github.com/apache/nifi-minifi-cpp/pull/961#discussion_r544609863 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -126,7 +126,11 @@ const core::Property PublishKafka::CompressCodec( const core::Property

[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

2020-12-16 Thread GitBox
fgerlits opened a new pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964 ... and a few others which were related or nearby in the code. https://issues.apache.org/jira/browse/MINIFICPP-1443 --- Thank you for submitting a contribution to Apache NiFi

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6

2020-12-16 Thread GitBox
lordgamez commented on pull request #963: URL: https://github.com/apache/nifi-minifi-cpp/pull/963#issuecomment-747074012 Summary of the issue from what I gathered: - There are incompatible changes between the Lua 5.3 and 5.4 API that causes the build failure see 8.3 of the [Lua 5.4

[GitHub] [nifi-minifi-cpp] lordgamez edited a comment on pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6

2020-12-16 Thread GitBox
lordgamez edited a comment on pull request #963: URL: https://github.com/apache/nifi-minifi-cpp/pull/963#issuecomment-747074012 Summary of the issue from what I gathered: - There are incompatible changes between the Lua 5.3 and 5.4 API that causes the build failure, see 8.3 of the [L

[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6

2020-12-16 Thread GitBox
lordgamez closed pull request #963: URL: https://github.com/apache/nifi-minifi-cpp/pull/963 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

  1   2   >