[GitHub] [nifi] exceptionfactory commented on pull request #4729: NIFI-8094 Added support for BCFKS Keystore Type

2021-01-09 Thread GitBox
exceptionfactory commented on pull request #4729: URL: https://github.com/apache/nifi/pull/4729#issuecomment-757076803 Thanks for the review and testing @thenatog! This is an automated message from the Apache Git Service. To

[GitHub] [nifi] exceptionfactory commented on pull request #4747: NIFI-8120 Added RuntimeException handling on HttpContextMap.complete()

2021-01-09 Thread GitBox
exceptionfactory commented on pull request #4747: URL: https://github.com/apache/nifi/pull/4747#issuecomment-756821716 @turcsanyip Thanks for the review and detailed feedback. I pushed an update incorporating your recommendations.

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #970: MINIFICPP-1396 Create FetchS3Object processor

2021-01-09 Thread GitBox
arpadboda closed pull request #970: URL: https://github.com/apache/nifi-minifi-cpp/pull/970 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi] turcsanyip commented on a change in pull request #4747: NIFI-8120 Added RuntimeException handling on HttpContextMap.complete()

2021-01-09 Thread GitBox
turcsanyip commented on a change in pull request #4747: URL: https://github.com/apache/nifi/pull/4747#discussion_r554009142 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-09 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-757089861 @turcsanyip The other use of `AvroTypeUtil.LOGICAL_TYPE_DATE` was in the `normalizeValue()`, which was causing the problem with `ConvertRecord`. The use of `new

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #969: MINIFICPP-1439 - Startup without agent class, handle class update

2021-01-09 Thread GitBox
arpadboda closed pull request #969: URL: https://github.com/apache/nifi-minifi-cpp/pull/969 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi] MikeThomsen commented on a change in pull request #4739: NIFI-7906 Fix a Cypher bug that was missed during initial review

2021-01-09 Thread GitBox
MikeThomsen commented on a change in pull request #4739: URL: https://github.com/apache/nifi/pull/4739#discussion_r554147729 ## File path: nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java ##

[GitHub] [nifi] asfgit closed pull request #4747: NIFI-8120 Added RuntimeException handling on HttpContextMap.complete()

2021-01-09 Thread GitBox
asfgit closed pull request #4747: URL: https://github.com/apache/nifi/pull/4747 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4747: NIFI-8120 Added RuntimeException handling on HttpContextMap.complete()

2021-01-09 Thread GitBox
exceptionfactory commented on a change in pull request #4747: URL: https://github.com/apache/nifi/pull/4747#discussion_r554015409 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #895: MINIFICPP-1352 - Comment out unused parameters (for enabling -Wall)

2021-01-09 Thread GitBox
szaszm closed pull request #895: URL: https://github.com/apache/nifi-minifi-cpp/pull/895 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi] thenatog commented on pull request #4729: NIFI-8094 Added support for BCFKS Keystore Type

2021-01-09 Thread GitBox
thenatog commented on pull request #4729: URL: https://github.com/apache/nifi/pull/4729#issuecomment-756837064 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [nifi] moranr commented on pull request #4563: NIFI-7738 Reverse Provenance Query

2021-01-09 Thread GitBox
moranr commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-756752576 @NissimShiman – good catch. That style text is used elsewhere in that way, so I'd say you're correct to apply here as well. Looks good to me; thanks for your work and attention to

[GitHub] [nifi-minifi-cpp] arpadboda commented on pull request #973: MINIFICPP-1446 - SQL extension doesn't compile on Debian

2021-01-09 Thread GitBox
arpadboda commented on pull request #973: URL: https://github.com/apache/nifi-minifi-cpp/pull/973#issuecomment-756765763 > Not debian, but I get this error when trying to build this PR with SQL enabled > `make[2]: *** No rule to make target

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-09 Thread GitBox
szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553850276 ## File path: libminifi/include/utils/ProcessorConfigUtils.h ## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi] lfrancke closed pull request #1941: NIFI-4099

2021-01-09 Thread GitBox
lfrancke closed pull request #1941: URL: https://github.com/apache/nifi/pull/1941 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] heritamas commented on a change in pull request #4730: NIFI-8095: Created StatelessNiFi Sink Connector and Source Connector.…

2021-01-09 Thread GitBox
heritamas commented on a change in pull request #4730: URL: https://github.com/apache/nifi/pull/4730#discussion_r553931809 ## File path: nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSourceTask.java ## @@ -0,0

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #973: MINIFICPP-1446 - SQL extension doesn't compile on Debian

2021-01-09 Thread GitBox
szaszm commented on pull request #973: URL: https://github.com/apache/nifi-minifi-cpp/pull/973#issuecomment-756763519 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [nifi] lfrancke closed pull request #2985: NIFI-5573 Allow overriding of nifi-env.sh

2021-01-09 Thread GitBox
lfrancke closed pull request #2985: URL: https://github.com/apache/nifi/pull/2985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] exceptionfactory commented on pull request #4749: NIFI-8121 Updated ListenHTTP with inferred Client Authentication Policy

2021-01-09 Thread GitBox
exceptionfactory commented on pull request #4749: URL: https://github.com/apache/nifi/pull/4749#issuecomment-756743075 Thanks for the review and testing @turcsanyip! This is an automated message from the Apache Git Service.

[GitHub] [nifi] urbandan commented on a change in pull request #4730: NIFI-8095: Created StatelessNiFi Sink Connector and Source Connector.…

2021-01-09 Thread GitBox
urbandan commented on a change in pull request #4730: URL: https://github.com/apache/nifi/pull/4730#discussion_r553786280 ## File path: nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSinkTask.java ## @@ -0,0

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #895: MINIFICPP-1352 - Comment out unused parameters (for enabling -Wall)

2021-01-09 Thread GitBox
hunyadi-dev commented on a change in pull request #895: URL: https://github.com/apache/nifi-minifi-cpp/pull/895#discussion_r553901250 ## File path: extensions/civetweb/processors/ListenHTTP.cpp ## @@ -211,7 +211,7 @@ void ListenHTTP::onSchedule(core::ProcessContext *context,

[GitHub] [nifi-minifi-cpp] hunyadi-dev closed pull request #911: MINIFICPP-1373 - Add proper FlowFile::getAttribute getter [QoL][mini-PR]

2021-01-09 Thread GitBox
hunyadi-dev closed pull request #911: URL: https://github.com/apache/nifi-minifi-cpp/pull/911 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (NIFI-8128) Nifi fails to communicate with Redis Sentinel

2021-01-09 Thread DEOM Damien (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DEOM Damien updated NIFI-8128: -- Summary: Nifi fails to communicate with Redis Sentinel (was: Nifi fais to communicate with Redis

[jira] [Created] (NIFI-8128) Nifi fais to communicate with Redis Sentinel

2021-01-09 Thread DEOM Damien (Jira)
DEOM Damien created NIFI-8128: - Summary: Nifi fais to communicate with Redis Sentinel Key: NIFI-8128 URL: https://issues.apache.org/jira/browse/NIFI-8128 Project: Apache NiFi Issue Type: Bug

[jira] [Updated] (NIFI-8127) Https work with jdk certificate

2021-01-09 Thread chen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen updated NIFI-8127: --- Summary: Https work with jdk certificate (was: Https use jdk certificate) > Https work with jdk certificate >

[jira] [Updated] (NIFI-8127) Https use jdk certificate

2021-01-09 Thread chen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen updated NIFI-8127: --- Summary: Https use jdk certificate (was: Https) > Https use jdk certificate > - > >

[jira] [Updated] (NIFI-8127) Https

2021-01-09 Thread chen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen updated NIFI-8127: --- Description: Hi.I user invokehttp post a request,but I can't get the result.I don't know how to let the request

[jira] [Updated] (NIFI-8127) Https

2021-01-09 Thread chen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen updated NIFI-8127: --- Attachment: image-2021-01-09-20-57-59-752.png > Https > - > > Key: NIFI-8127 >

[jira] [Updated] (NIFI-8127) Https

2021-01-09 Thread chen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen updated NIFI-8127: --- Attachment: image-2021-01-09-20-57-49-673.png > Https > - > > Key: NIFI-8127 >

[jira] [Updated] (NIFI-8127) Https

2021-01-09 Thread chen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen updated NIFI-8127: --- Attachment: image-2021-01-09-20-56-27-819.png > Https > - > > Key: NIFI-8127 >

[jira] [Updated] (NIFI-8127) Https

2021-01-09 Thread chen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen updated NIFI-8127: --- Attachment: image-2021-01-09-20-55-29-609.png > Https > - > > Key: NIFI-8127 >

[jira] [Created] (NIFI-8127) Https

2021-01-09 Thread chen (Jira)
chen created NIFI-8127: -- Summary: Https Key: NIFI-8127 URL: https://issues.apache.org/jira/browse/NIFI-8127 Project: Apache NiFi Issue Type: Bug Reporter: chen -- This message was

[jira] [Commented] (NIFI-8126) Include Total Queued Duration in metrics reported via ConnectionStatus

2021-01-09 Thread endzeit (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261819#comment-17261819 ] endzeit commented on NIFI-8126: --- I would also advocate for a the maximum queued duration, to watch for files