[GitHub] [nifi] pvillard31 commented on a change in pull request #4826: NIFI-5623 Upgraded OkHttp to 4.9.1 and updated unit tests

2021-02-17 Thread GitBox
pvillard31 commented on a change in pull request #4826: URL: https://github.com/apache/nifi/pull/4826#discussion_r578192600 ## File path: nifi-nar-bundles/nifi-standard-services/nifi-oauth2-provider-bundle/nifi-oauth2-provider-service/pom.xml ## @@ -74,7 +74,7 @@

[jira] [Commented] (NIFI-8233) ListenHTTP - add ability to filter out incoming flowfile attributes

2021-02-17 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286317#comment-17286317 ] Pierre Villard commented on NIFI-8233: -- I may have misunderstood. When using PostHTTP

[jira] [Commented] (NIFI-7936) PutElasticsearchRecord is unable to write to elasticsearch over SSL when using nifi with JDK11

2021-02-17 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286223#comment-17286223 ] David Handermann commented on NIFI-7936: Thanks for providing the additional detai

[GitHub] [nifi] jfrazee opened a new pull request #4829: NIFI-8231 Clarify behavior of allowed values for Memory Pools in MonitorMemory

2021-02-17 Thread GitBox
jfrazee opened a new pull request #4829: URL: https://github.com/apache/nifi/pull/4829 This clarifies some of the behavior of MonitorMemory, in particular for Memory Pools. It also includes a small change to the description for Usage Threshold to mention that Data Size is a valid configura

[GitHub] [nifi-minifi-cpp] szaszm edited a comment on pull request #992: MINIFICPP-1467 Remove mutex from Connection

2021-02-17 Thread GitBox
szaszm edited a comment on pull request #992: URL: https://github.com/apache/nifi-minifi-cpp/pull/992#issuecomment-780928820 About exposing internals: I don't think it's happening here. I view `LockedConcurrentQueue` as an implementation detail of `ConcurrentQueue`, so they are one unit, e

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #992: MINIFICPP-1467 Remove mutex from Connection

2021-02-17 Thread GitBox
szaszm commented on pull request #992: URL: https://github.com/apache/nifi-minifi-cpp/pull/992#issuecomment-780928820 About exposing internals: I don't think it's happening here. I view `LockedConcurrentQueue` as an implementation detail of `ConcurrentQueue`, so they are one unit, even tho

[jira] [Commented] (NIFI-8234) Jetty server does not start up when a keystore with multiple certificates is used on 1.13.0

2021-02-17 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286174#comment-17286174 ] Joe Witt commented on NIFI-8234: It doesn't appear to actually be 1.13. Please ensure you

[jira] [Resolved] (NIFI-8234) Jetty server does not start up when a keystore with multiple certificates is used on 1.13.0

2021-02-17 Thread Adam Turley (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Turley resolved NIFI-8234. --- Resolution: Not A Problem mistake > Jetty server does not start up when a keystore with multiple cert

[jira] [Commented] (NIFI-7936) PutElasticsearchRecord is unable to write to elasticsearch over SSL when using nifi with JDK11

2021-02-17 Thread Adam Turley (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286172#comment-17286172 ] Adam Turley commented on NIFI-7936: --- Using "StandardRestrictedSSLContextServices 1.12.1"

[jira] [Updated] (NIFI-8234) Jetty server does not start up when a keystore with multiple certificates is used on 1.13.0

2021-02-17 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-8234: --- Priority: Major (was: Blocker) > Jetty server does not start up when a keystore with multiple certificates is

[jira] [Assigned] (NIFI-8234) Jetty server does not start up when a keystore with multiple certificates is used on 1.13.0

2021-02-17 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt reassigned NIFI-8234: -- Assignee: (was: Andy LoPresto) > Jetty server does not start up when a keystore with multiple certi

[jira] [Updated] (NIFI-7936) PutElasticsearchRecord is unable to write to elasticsearch over SSL when using nifi with JDK11

2021-02-17 Thread Adam Turley (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Turley updated NIFI-7936: -- Attachment: Screen Shot 2021-02-17 at 3.11.41 PM.png > PutElasticsearchRecord is unable to write to elas

[jira] [Updated] (NIFI-8234) Jetty server does not start up when a keystore with multiple certificates is used on 1.13.0

2021-02-17 Thread Adam Turley (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Turley updated NIFI-8234: -- Description: Seeing following Error in NiFi 1.13.0.  This appears to be the same issue as  NIFI-7730  

[jira] [Updated] (NIFI-8234) Jetty server does not start up when a keystore with multiple certificates is used on 1.13.0

2021-02-17 Thread Adam Turley (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Turley updated NIFI-8234: -- Fix Version/s: (was: 1.12.1) (was: 1.13.0) Affects Version/s: 1.13

[jira] [Created] (NIFI-8234) Jetty server does not start up when a keystore with multiple certificates is used on 1.13.0

2021-02-17 Thread Adam Turley (Jira)
Adam Turley created NIFI-8234: - Summary: Jetty server does not start up when a keystore with multiple certificates is used on 1.13.0 Key: NIFI-8234 URL: https://issues.apache.org/jira/browse/NIFI-8234 Pro

[jira] [Updated] (NIFI-8232) CSVReader no longer detects duplicate header values

2021-02-17 Thread Chris Sampson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-8232: Status: Patch Available (was: In Progress) > CSVReader no longer detects duplicate header values >

[jira] [Commented] (NIFI-8232) CSVReader no longer detects duplicate header values

2021-02-17 Thread Chris Sampson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286162#comment-17286162 ] Chris Sampson commented on NIFI-8232: - Also added the ability for the Jackson CSV Pars

[GitHub] [nifi] ChrisSamo632 opened a new pull request #4828: NIFI-8232 CSV Parsers optionally allow/reject duplicate header names

2021-02-17 Thread GitBox
ChrisSamo632 opened a new pull request #4828: URL: https://github.com/apache/nifi/pull/4828 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR CSVReader provides option to allow/reject duplica

[jira] [Commented] (NIFI-8233) ListenHTTP - add ability to filter out incoming flowfile attributes

2021-02-17 Thread Nissim Shiman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286142#comment-17286142 ] Nissim Shiman commented on NIFI-8233: - Thank you [~pvillard] for your thoughts. PostH

[jira] [Commented] (NIFI-8233) ListenHTTP - add ability to filter out incoming flowfile attributes

2021-02-17 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286140#comment-17286140 ] Pierre Villard commented on NIFI-8233: -- Did you try to use the flow file v3 format? t

[jira] [Assigned] (NIFI-8232) CSVReader no longer detects duplicate header values

2021-02-17 Thread Chris Sampson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson reassigned NIFI-8232: --- Assignee: Chris Sampson > CSVReader no longer detects duplicate header values > -

[jira] [Created] (NIFI-8233) ListenHTTP - add ability to filter out incoming flowfile attributes

2021-02-17 Thread Nissim Shiman (Jira)
Nissim Shiman created NIFI-8233: --- Summary: ListenHTTP - add ability to filter out incoming flowfile attributes Key: NIFI-8233 URL: https://issues.apache.org/jira/browse/NIFI-8233 Project: Apache NiFi

[jira] [Created] (NIFI-8232) CSVReader no longer detects duplicate header values

2021-02-17 Thread Chris Sampson (Jira)
Chris Sampson created NIFI-8232: --- Summary: CSVReader no longer detects duplicate header values Key: NIFI-8232 URL: https://issues.apache.org/jira/browse/NIFI-8232 Project: Apache NiFi Issue Typ

[jira] [Created] (NIFI-8231) Clarify documentation for MonitorMemory Memory Pool allowable values

2021-02-17 Thread Joey Frazee (Jira)
Joey Frazee created NIFI-8231: - Summary: Clarify documentation for MonitorMemory Memory Pool allowable values Key: NIFI-8231 URL: https://issues.apache.org/jira/browse/NIFI-8231 Project: Apache NiFi

[jira] [Updated] (NIFI-6708) Improve DSA/El Gamal PGP compatibility issues

2021-02-17 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-6708: --- Issue Type: Improvement (was: Bug) > Improve DSA/El Gamal PGP compatibility issues >

[jira] [Assigned] (NIFI-2983) EncryptContent PGP mode can't handle signed encrypted files

2021-02-17 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-2983: -- Assignee: David Handermann > EncryptContent PGP mode can't handle signed encrypted file

[jira] [Assigned] (NIFI-1694) EncryptContent processor should accept keyring file or individual key file for PGP encryption/decryption

2021-02-17 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-1694: -- Assignee: David Handermann (was: Andy LoPresto) > EncryptContent processor should acce

[jira] [Assigned] (NIFI-7396) Add encryption metadata attributes for PGP encryption

2021-02-17 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-7396: -- Assignee: David Handermann > Add encryption metadata attributes for PGP encryption > --

[jira] [Assigned] (NIFI-5346) Allow EncryptContent processor to specify PGP key as processor property

2021-02-17 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-5346: -- Assignee: David Handermann (was: Andy LoPresto) > Allow EncryptContent processor to sp

[jira] [Assigned] (NIFI-5335) PGP processor cannot handle multiple passworded keys in a pgp keyring.

2021-02-17 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-5335: -- Assignee: David Handermann (was: Andy LoPresto) > PGP processor cannot handle multiple

[jira] [Assigned] (NIFI-6708) Improve DSA/El Gamal PGP compatibility issues

2021-02-17 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-6708: -- Assignee: David Handermann (was: Andy LoPresto) > Improve DSA/El Gamal PGP compatibili

[jira] [Assigned] (NIFI-8207) Counters in the Wait/Notify pattern do not work as expected

2021-02-17 Thread Peter Gyori (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Gyori reassigned NIFI-8207: - Assignee: Peter Gyori > Counters in the Wait/Notify pattern do not work as expected > ---

[GitHub] [nifi-minifi-cpp] dam4rus commented on pull request #992: MINIFICPP-1467 Remove mutex from Connection

2021-02-17 Thread GitBox
dam4rus commented on pull request #992: URL: https://github.com/apache/nifi-minifi-cpp/pull/992#issuecomment-780677873 TBH, I don't really see how `Connection::poll()` could be refactored, since I'm not super familiar with the code base, to avoid performance degradation with `ConcurrentQue

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577733272 ## File path: extensions/librdkafka/rdkafka_utils.cpp ## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #992: MINIFICPP-1467 Remove mutex from Connection

2021-02-17 Thread GitBox
fgerlits commented on pull request #992: URL: https://github.com/apache/nifi-minifi-cpp/pull/992#issuecomment-780655750 Yes, using (a modified or extended version of) ConcurrentQueue [rather than exposing the internal mutex and deque and using those] would require some refactoring of the C

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577719214 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1005: MINIFICPP-1496 "Enable all extensions" in bootstrap.sh should not enable ASAN_BUILD

2021-02-17 Thread GitBox
fgerlits commented on a change in pull request #1005: URL: https://github.com/apache/nifi-minifi-cpp/pull/1005#discussion_r577715377 ## File path: bootstrap.sh ## @@ -318,14 +315,16 @@ add_dependency TENSORFLOW_ENABLED "tensorflow" add_disabled_option OPC_ENABLED ${FALSE} "ENA

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1002: MINIFICPP-1490: Add ARCH support to bootstrap process

2021-02-17 Thread GitBox
szaszm closed pull request #1002: URL: https://github.com/apache/nifi-minifi-cpp/pull/1002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (MINIFICPP-1496) "Enable all extensions" in boostrap.sh should not enable ASAN

2021-02-17 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-1496: -- Description: If you select option 2, "Enable all extensions", in bootstrap.sh, then

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577708270 ## File path: extensions/librdkafka/ConsumeKafka.h ## @@ -124,6 +124,17 @@ class ConsumeKafka : public core::Processor { // Initialize, overw

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1003: MINIFICPP-1495 - Do not pretty-print windows events

2021-02-17 Thread GitBox
szaszm closed pull request #1003: URL: https://github.com/apache/nifi-minifi-cpp/pull/1003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577701277 ## File path: extensions/librdkafka/ConsumeKafka.h ## @@ -0,0 +1,181 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or m

[jira] [Created] (MINIFICPP-1502) Update processors that take their name/id constructor arguments as values

2021-02-17 Thread Adam Hunyadi (Jira)
Adam Hunyadi created MINIFICPP-1502: --- Summary: Update processors that take their name/id constructor arguments as values Key: MINIFICPP-1502 URL: https://issues.apache.org/jira/browse/MINIFICPP-1502

[jira] [Updated] (NIFI-7662) Add unit tests for Java 8 update 262 TLS v1.3 handling for different vendors

2021-02-17 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-7662: --- Status: Patch Available (was: In Progress) PR 4827 includes new unit tests that include check

[jira] [Updated] (NIFI-8037) Support TLS 1.3 in SSLContextService on Java 8

2021-02-17 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8037: --- Affects Version/s: 1.13.0 Status: Patch Available (was: In Progress) > Support

[jira] [Created] (MINIFICPP-1501) Enforce that Processor::onTrigger calls are always invoked with a valid session

2021-02-17 Thread Adam Hunyadi (Jira)
Adam Hunyadi created MINIFICPP-1501: --- Summary: Enforce that Processor::onTrigger calls are always invoked with a valid session Key: MINIFICPP-1501 URL: https://issues.apache.org/jira/browse/MINIFICPP-1501

[jira] [Updated] (MINIFICPP-1501) Enforce that Processor::onTrigger calls are always invoked with a valid session

2021-02-17 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1501: Description: *Background:* Processor::onTrigger(..., core::ProcessSession*) calls take

[GitHub] [nifi] exceptionfactory opened a new pull request #4827: NIFI-8037 Support TLSv1.3 in SSLContextService on Java 8

2021-02-17 Thread GitBox
exceptionfactory opened a new pull request #4827: URL: https://github.com/apache/nifi/pull/4827 Description of PR NIFI-8037 Updates `StandardSSLContextService` and `StandardRestrictedSSLContextService` to use the internal `TlsPlatform.getSupportedProtocols()` method to determin

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577651674 ## File path: extensions/librdkafka/ConsumeKafka.h ## @@ -124,6 +124,17 @@ class ConsumeKafka : public core::Processor { // Initialize, overwrite

[jira] [Resolved] (NIFIREG-440) Correct GitHub Actions Workflow Build

2021-02-17 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFIREG-440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-440. - Fix Version/s: 0.9.0 Resolution: Fixed > Correct GitHub Actions Workflow Build >

[GitHub] [nifi-registry] bbende merged pull request #315: NIFIREG-440 Corrected GitHub Actions Workflow Build

2021-02-17 Thread GitBox
bbende merged pull request #315: URL: https://github.com/apache/nifi-registry/pull/315 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1007: MINIFICPP-1489 Introduce ccache in MacOS builds

2021-02-17 Thread GitBox
lordgamez commented on pull request #1007: URL: https://github.com/apache/nifi-minifi-cpp/pull/1007#issuecomment-780564281 The macos-xcode builds ran for 34m and 1h 18m with no cache available, but the second CI run after the cache was available ran for only 14 and 13 minutes which looks t

[GitHub] [nifi] turcsanyip commented on a change in pull request #4821: NIFI-8113 Adding persistent status history repository backed by embed…

2021-02-17 Thread GitBox
turcsanyip commented on a change in pull request #4821: URL: https://github.com/apache/nifi/pull/4821#discussion_r577613897 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/status/history/storage/BufferedN

[jira] [Resolved] (MINIFICPP-1498) Libarchive is missing from minimal docker image

2021-02-17 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi resolved MINIFICPP-1498. -- Resolution: Fixed > Libarchive is missing from minimal docker image > -

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #1006: MINIFICPP-1498 Add libarchive to minimal docker image

2021-02-17 Thread GitBox
arpadboda closed pull request #1006: URL: https://github.com/apache/nifi-minifi-cpp/pull/1006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Assigned] (MINIFICPP-1354) Fix minor errors found by the address sanitizer

2021-02-17 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink reassigned MINIFICPP-1354: -- Assignee: Martin Zink > Fix minor errors found by the address sanitizer >

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577519674 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1007: MINIFICPP-1489 Introduce ccache in MacOS builds

2021-02-17 Thread GitBox
lordgamez opened a new pull request #1007: URL: https://github.com/apache/nifi-minifi-cpp/pull/1007 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[jira] [Updated] (MINIFICPP-1489) Introduce caching to Mac CI builds

2021-02-17 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi updated MINIFICPP-1489: - Description: Mac builds sometimes fail when full builds reach the 60 minute time limi

[jira] [Created] (MINIFICPP-1500) ArchiveTests transiently fail

2021-02-17 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1500: Summary: ArchiveTests transiently fail Key: MINIFICPP-1500 URL: https://issues.apache.org/jira/browse/MINIFICPP-1500 Project: Apache NiFi MiNiFi C++

[jira] [Created] (MINIFICPP-1499) Introduce caching to Windows CI builds

2021-02-17 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1499: Summary: Introduce caching to Windows CI builds Key: MINIFICPP-1499 URL: https://issues.apache.org/jira/browse/MINIFICPP-1499 Project: Apache NiFi MiNiFi C++

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577510561 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1005: MINIFICPP-1496 Remove ASAN and JNI from the list of extensions

2021-02-17 Thread GitBox
adamdebreceni commented on a change in pull request #1005: URL: https://github.com/apache/nifi-minifi-cpp/pull/1005#discussion_r577509405 ## File path: bootstrap.sh ## @@ -318,14 +315,16 @@ add_dependency TENSORFLOW_ENABLED "tensorflow" add_disabled_option OPC_ENABLED ${FALSE}

[jira] [Updated] (MINIFICPP-1498) Libarchive is missing from minimal docker image

2021-02-17 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi updated MINIFICPP-1498: - Summary: Libarchive is missing from minimal docker image (was: Libarchive and script

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1005: MINIFICPP-1496 Remove ASAN and JNI from the list of extensions

2021-02-17 Thread GitBox
adamdebreceni commented on a change in pull request #1005: URL: https://github.com/apache/nifi-minifi-cpp/pull/1005#discussion_r577506574 ## File path: bootstrap.sh ## @@ -318,14 +315,16 @@ add_dependency TENSORFLOW_ENABLED "tensorflow" add_disabled_option OPC_ENABLED ${FALSE}

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1005: MINIFICPP-1496 Remove ASAN and JNI from the list of extensions

2021-02-17 Thread GitBox
adamdebreceni commented on a change in pull request #1005: URL: https://github.com/apache/nifi-minifi-cpp/pull/1005#discussion_r577506574 ## File path: bootstrap.sh ## @@ -318,14 +315,16 @@ add_dependency TENSORFLOW_ENABLED "tensorflow" add_disabled_option OPC_ENABLED ${FALSE}

[jira] [Updated] (MINIFICPP-1489) Introduce caching to Mac CI builds

2021-02-17 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi updated MINIFICPP-1489: - Description: Mac builds sometimes fail when full builds reach the 60 minute time limi

[GitHub] [nifi-minifi-cpp] dam4rus commented on pull request #992: MINIFICPP-1467 Remove mutex from Connection

2021-02-17 Thread GitBox
dam4rus commented on pull request #992: URL: https://github.com/apache/nifi-minifi-cpp/pull/992#issuecomment-780465445 I agree that this implementation doesn't fit the current design but to avoid needless lockings and potentially tank the performance I choose this over `push_all`, `pop_all

[jira] [Updated] (MINIFICPP-1489) Introduce caching to Mac CI builds

2021-02-17 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi updated MINIFICPP-1489: - Summary: Introduce caching to Mac CI builds (was: Introduce caching to Mac and Windo

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577502720 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (NIFI-8176) Add indicator flag for Splunk acknowledgements

2021-02-17 Thread Timea Barna (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timea Barna updated NIFI-8176: -- Status: Patch Available (was: In Progress) > Add indicator flag for Splunk acknowledgements > -

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577493724 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577493327 ## File path: extensions/librdkafka/ConsumeKafka.h ## @@ -0,0 +1,181 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577491948 ## File path: extensions/librdkafka/ConsumeKafka.h ## @@ -0,0 +1,181 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577488062 ## File path: libminifi/test/TestBase.cpp ## @@ -61,44 +62,41 @@ TestPlan::~TestPlan() { for (auto& processor : configured_processors_) {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577478587 ## File path: libminifi/test/unit/StringUtilsTests.cpp ## @@ -50,6 +50,16 @@ TEST_CASE("TestStringUtils::split4", "[test split classname]") {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577477152 ## File path: libminifi/test/TestBase.cpp ## @@ -111,28 +109,19 @@ std::shared_ptr TestPlan::addProcessor(const std::shared_ptr node = std::ma

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-02-17 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r577476694 ## File path: libminifi/test/TestBase.cpp ## @@ -150,7 +139,7 @@ std::shared_ptr TestPlan::addProcessor(const std::string &proce } std::sha

[jira] [Updated] (NIFI-7786) Bring back Trusted Hostname property from InvokeHTTP processor

2021-02-17 Thread Chris Sampson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-7786: Affects Version/s: 1.10.0 > Bring back Trusted Hostname property from InvokeHTTP processor > ---

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1006: MINIFICPP-1498 Add libarchive and scripting to minimal docker image

2021-02-17 Thread GitBox
lordgamez opened a new pull request #1006: URL: https://github.com/apache/nifi-minifi-cpp/pull/1006 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[jira] [Created] (MINIFICPP-1498) Libarchive and scripting are missing from minimal docker image

2021-02-17 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1498: Summary: Libarchive and scripting are missing from minimal docker image Key: MINIFICPP-1498 URL: https://issues.apache.org/jira/browse/MINIFICPP-1498 Project:

[GitHub] [nifi] timeabarna commented on pull request #4824: NIFI-8176 adding ackChecked flag to QuerySplunkIndexingStatus.onTrigg…

2021-02-17 Thread GitBox
timeabarna commented on pull request #4824: URL: https://github.com/apache/nifi/pull/4824#issuecomment-78049 @simonbence Documentation has been updated. This is an automated message from the Apache Git Service. To respond

[GitHub] [nifi-minifi-cpp] adamdebreceni removed a comment on pull request #1004: MINIFICPP-1450 - Revive SQL processors

2021-02-17 Thread GitBox
adamdebreceni removed a comment on pull request #1004: URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#issuecomment-780378765 investigating increased runtimes on mac in the CI This is an automated message from the Ap

[jira] [Updated] (MINIFICPP-1496) "Enable all extensions" in boostrap.sh should not enable ASAN

2021-02-17 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-1496: -- Description: If you select option 2, "Enable all extensions", in bootstrap.sh, then

[jira] [Resolved] (MINIFICPP-1443) Get rid of most "possible loss of data" warnings

2021-02-17 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-1443. --- Resolution: Fixed > Get rid of most "possible loss of data" warnings > --

[jira] [Resolved] (MINIFICPP-1485) Replace the 'property is exclusive of' error message with something comprehensible

2021-02-17 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-1485. --- Resolution: Fixed > Replace the 'property is exclusive of' error message with som

[jira] [Assigned] (MINIFICPP-1496) "Enable all extensions" in boostrap.sh should not enable ASAN

2021-02-17 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits reassigned MINIFICPP-1496: - Assignee: Ferenc Gerlits > "Enable all extensions" in boostrap.sh should not

[GitHub] [nifi-minifi-cpp] adamdebreceni edited a comment on pull request #1004: MINIFICPP-1450 - Revive SQL processors

2021-02-17 Thread GitBox
adamdebreceni edited a comment on pull request #1004: URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#issuecomment-780378765 investigating increased runtimes on mac in the CI This is an automated message from the Apa

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on pull request #1004: MINIFICPP-1450 - Revive SQL processors

2021-02-17 Thread GitBox
adamdebreceni commented on pull request #1004: URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#issuecomment-780378765 investigating increased times on mac in the CI This is an automated message from the Apache Git Se