[jira] [Commented] (NIFI-8361) UnpackContent failing for Deflate:Maximum

2021-03-24 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308378#comment-17308378 ] David Handermann commented on NIFI-8361: I submitted a pull request to Zip4j implementing support

[GitHub] [nifi] noblenumbat360 opened a new pull request #4936: NIFI-8271 Expansion of Prometheus metrics and associated testing.

2021-03-24 Thread GitBox
noblenumbat360 opened a new pull request #4936: URL: https://github.com/apache/nifi/pull/4936 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Expands the Prometheus metrics output as

[jira] [Commented] (NIFI-8361) UnpackContent failing for Deflate:Maximum

2021-03-24 Thread Tom P (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308301#comment-17308301 ] Tom P commented on NIFI-8361: - I was partway through writing an update to similar effect, thinking that must

[jira] [Commented] (NIFI-8361) UnpackContent failing for Deflate:Maximum

2021-03-24 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308294#comment-17308294 ] David Handermann commented on NIFI-8361: On further analysis of the file referenced in the

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4918: NIFI-8347 Set ClassLoader for JettyWebSocketServer to resolve runtime exceptions

2021-03-24 Thread GitBox
exceptionfactory commented on a change in pull request #4918: URL: https://github.com/apache/nifi/pull/4918#discussion_r600953627 ## File path: nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/JettyWebSocketServer.java

[GitHub] [nifi] turcsanyip commented on a change in pull request #4918: NIFI-8347 Set ClassLoader for JettyWebSocketServer to resolve runtime exceptions

2021-03-24 Thread GitBox
turcsanyip commented on a change in pull request #4918: URL: https://github.com/apache/nifi/pull/4918#discussion_r600926356 ## File path: nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/JettyWebSocketServer.java

[GitHub] [nifi] mattyb149 commented on a change in pull request #4933: MINIFI-422: Integrate MiNiFi Java codebase into NiFi

2021-03-24 Thread GitBox
mattyb149 commented on a change in pull request #4933: URL: https://github.com/apache/nifi/pull/4933#discussion_r600918317 ## File path: minifi/README.md ## @@ -0,0 +1,163 @@ + +# Apache NiFi - MiNiFi [![Build

[GitHub] [nifi] exceptionfactory commented on pull request #4869: NIFI-8288 Removed nifi-security-utils dependency from nifi-web-utils

2021-03-24 Thread GitBox
exceptionfactory commented on pull request #4869: URL: https://github.com/apache/nifi/pull/4869#issuecomment-806208115 > Things seem good to me, I tried it out with a 3 node secure cluster with secured external ZK. From what I can tell, when this change is rebased onto main, the .zip

[jira] [Commented] (NIFI-7846) Supporting os.arch aarch64 issues

2021-03-24 Thread Lance Kinley (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308193#comment-17308193 ] Lance Kinley commented on NIFI-7846: A workaround is to compile a newer version of snappy-java and

[GitHub] [nifi] thenatog commented on pull request #4869: NIFI-8288 Removed nifi-security-utils dependency from nifi-web-utils

2021-03-24 Thread GitBox
thenatog commented on pull request #4869: URL: https://github.com/apache/nifi/pull/4869#issuecomment-806200033 Things seem good to me, I tried it out with a 3 node secure cluster with secured external ZK. From what I can tell, when this change is rebased onto main, the .zip build size is

[jira] [Updated] (NIFI-8364) TestQuerySolr is unreliable and needs to be reworked

2021-03-24 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8364: --- Status: Patch Available (was: In Progress) > TestQuerySolr is unreliable and needs to be

[GitHub] [nifi] exceptionfactory opened a new pull request #4935: NIFI-8364 Refactored TestQuerySolr and TestGetSolr to reuse SolrClient

2021-03-24 Thread GitBox
exceptionfactory opened a new pull request #4935: URL: https://github.com/apache/nifi/pull/4935 Description of PR NIFI-8364 Refactors `TestQuerySolr` and `TestGetSolr` to reuse the embedded `SolrClient` across test methods as much as possible to reduce overall runtime.

[GitHub] [nifi] joewitt commented on a change in pull request #4933: MINIFI-422: Integrate MiNiFi Java codebase into NiFi

2021-03-24 Thread GitBox
joewitt commented on a change in pull request #4933: URL: https://github.com/apache/nifi/pull/4933#discussion_r600863121 ## File path: minifi/README.md ## @@ -0,0 +1,163 @@ + +# Apache NiFi - MiNiFi [![Build

[GitHub] [nifi] joewitt commented on a change in pull request #4933: MINIFI-422: Integrate MiNiFi Java codebase into NiFi

2021-03-24 Thread GitBox
joewitt commented on a change in pull request #4933: URL: https://github.com/apache/nifi/pull/4933#discussion_r600862132 ## File path: minifi/NOTICE ## @@ -0,0 +1,7 @@ +Apache NiFi - MiNiFi Review comment: this file should go away completely / This is about the source

[GitHub] [nifi] joewitt commented on a change in pull request #4933: MINIFI-422: Integrate MiNiFi Java codebase into NiFi

2021-03-24 Thread GitBox
joewitt commented on a change in pull request #4933: URL: https://github.com/apache/nifi/pull/4933#discussion_r600861959 ## File path: minifi/LICENSE ## @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004

[GitHub] [nifi] joewitt commented on a change in pull request #4933: MINIFI-422: Integrate MiNiFi Java codebase into NiFi

2021-03-24 Thread GitBox
joewitt commented on a change in pull request #4933: URL: https://github.com/apache/nifi/pull/4933#discussion_r600861574 ## File path: minifi/KEYS ## @@ -0,0 +1,404 @@ +This file contains the PGP keys of various developers. Review comment: this file should go away

[GitHub] [nifi] kevdoran commented on pull request #4933: MINIFI-422: Integrate MiNiFi Java codebase into NiFi

2021-03-24 Thread GitBox
kevdoran commented on pull request #4933: URL: https://github.com/apache/nifi/pull/4933#issuecomment-806173518 Nice, @mattyb149! This is cool, can't wait to give it a try. One quick observation - I would remove the `minifi-c2` submodule. That was a PoC based on

[GitHub] [nifi] tpalfy opened a new pull request #4934: NIFI-8365 Fix JSON AbstractJsonRowRecordReader to handle deep CHOICE-typed records properly

2021-03-24 Thread GitBox
tpalfy opened a new pull request #4934: URL: https://github.com/apache/nifi/pull/4934 Change the logic that selects the first compatible schema which can have missing fields compared to the real value and search for a more strict match first and fallback to the existing logic only if not

[GitHub] [nifi] mattyb149 opened a new pull request #4933: MINIFI-422: Integrate MiNiFi Java codebase into NiFi

2021-03-24 Thread GitBox
mattyb149 opened a new pull request #4933: URL: https://github.com/apache/nifi/pull/4933 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Copies the code from nifi-minifi master branch to a

[jira] [Updated] (NIFI-8365) JSON record reader mishandles deep CHOICE types

2021-03-24 Thread Tamas Palfy (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy updated NIFI-8365: -- Description: The AbstractJsonRowRecordReader when trying to find the correct schema for a given record

[jira] [Updated] (NIFI-8365) JSON record reader mishandles deep CHOICE types

2021-03-24 Thread Tamas Palfy (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy updated NIFI-8365: -- Description: The AbstractJsonRowRecordReader when trying to find the correct schema for a given record

[jira] [Created] (NIFI-8365) JSON record reader mishandles deep CHOICE types

2021-03-24 Thread Tamas Palfy (Jira)
Tamas Palfy created NIFI-8365: - Summary: JSON record reader mishandles deep CHOICE types Key: NIFI-8365 URL: https://issues.apache.org/jira/browse/NIFI-8365 Project: Apache NiFi Issue Type: Bug

[jira] [Assigned] (NIFI-8364) TestQuerySolr is unreliable and needs to be reworked

2021-03-24 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-8364: -- Assignee: David Handermann > TestQuerySolr is unreliable and needs to be reworked >

[jira] [Created] (NIFI-8364) TestQuerySolr is unreliable and needs to be reworked

2021-03-24 Thread Joe Witt (Jira)
Joe Witt created NIFI-8364: -- Summary: TestQuerySolr is unreliable and needs to be reworked Key: NIFI-8364 URL: https://issues.apache.org/jira/browse/NIFI-8364 Project: Apache NiFi Issue Type: Task

[jira] [Created] (NIFI-8363) Implement Default Single User LoginIdentityProvider

2021-03-24 Thread David Handermann (Jira)
David Handermann created NIFI-8363: -- Summary: Implement Default Single User LoginIdentityProvider Key: NIFI-8363 URL: https://issues.apache.org/jira/browse/NIFI-8363 Project: Apache NiFi

[jira] [Commented] (NIFI-8339) Input Threads get Interrupted and stuck indefinitely

2021-03-24 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308101#comment-17308101 ] Mark Payne commented on NIFI-8339: -- [~renewei]  Unfortunately I've been unable to replicate any issues

[jira] [Resolved] (NIFI-8356) Add unit test for LongRunningTaskMonitor

2021-03-24 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-8356. Resolution: Fixed Closing this issue after further discussion, additional adjustments can

[GitHub] [nifi] phrocker edited a comment on pull request #4931: NIFI-8283 Value handling in ScanAccumulo processor

2021-03-24 Thread GitBox
phrocker edited a comment on pull request #4931: URL: https://github.com/apache/nifi/pull/4931#issuecomment-805981714 Hi @timeabarna May want to add this as an option that is true by default. Thanks for the change. There are cases where people do not want values and want to only

[jira] [Commented] (NIFI-8283) Value handling in ScanAccumulo processor

2021-03-24 Thread Marc Parisi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307995#comment-17307995 ] Marc Parisi commented on NIFI-8283: --- Thanks for this patch! My apologies, this fell off my radar

[GitHub] [nifi] phrocker commented on pull request #4931: NIFI-8283 Value handling in ScanAccumulo processor

2021-03-24 Thread GitBox
phrocker commented on pull request #4931: URL: https://github.com/apache/nifi/pull/4931#issuecomment-805981714 Hi @timeabarna May want to add this as an option that is true by default. Thanks for the change. There are cases where people do not want values and want to only get the

[jira] [Resolved] (NIFI-8354) ExecuteStreamCommand processor doesn't delete the temp file if the process start failed

2021-03-24 Thread Otto Fowler (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otto Fowler resolved NIFI-8354. --- Resolution: Fixed > ExecuteStreamCommand processor doesn't delete the temp file if the process >

[jira] [Commented] (NIFI-8354) ExecuteStreamCommand processor doesn't delete the temp file if the process start failed

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307981#comment-17307981 ] ASF subversion and git services commented on NIFI-8354: --- Commit

[jira] [Commented] (NIFI-8354) ExecuteStreamCommand processor doesn't delete the temp file if the process start failed

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307982#comment-17307982 ] ASF subversion and git services commented on NIFI-8354: --- Commit

[jira] [Commented] (NIFI-8354) ExecuteStreamCommand processor doesn't delete the temp file if the process start failed

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307980#comment-17307980 ] ASF subversion and git services commented on NIFI-8354: --- Commit

[GitHub] [nifi] ottobackwards merged pull request #4923: NIFI-8354 ExecuteStreamCommand processor doesn't delete the temp file…

2021-03-24 Thread GitBox
ottobackwards merged pull request #4923: URL: https://github.com/apache/nifi/pull/4923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [nifi] timeabarna commented on a change in pull request #4931: NIFI-8283 Value handling in ScanAccumulo processor

2021-03-24 Thread GitBox
timeabarna commented on a change in pull request #4931: URL: https://github.com/apache/nifi/pull/4931#discussion_r600644024 ## File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-processors/src/main/java/org/apache/nifi/accumulo/processors/ScanAccumulo.java ## @@

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1037: MINIFICPP-1520 Fix PublishKafka properties to support expression language

2021-03-24 Thread GitBox
fgerlits commented on a change in pull request #1037: URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600635867 ## File path: PROCESSORS.md ## @@ -971,13 +971,13 @@ In the list below, the names of required properties appear in bold. Any other pr |**Known

[jira] [Reopened] (NIFI-8356) Add unit test for LongRunningTaskMonitor

2021-03-24 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reopened NIFI-8356: Based on additional review, it would be helpful to adjust the log verification assertions to

[jira] [Updated] (NIFI-8356) Add unit test for LongRunningTaskMonitor

2021-03-24 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8356: --- Fix Version/s: 1.14.0 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (NIFI-8356) Add unit test for LongRunningTaskMonitor

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307932#comment-17307932 ] ASF subversion and git services commented on NIFI-8356: --- Commit

[GitHub] [nifi] asfgit closed pull request #4925: NIFI-8356: Add unit test for LongRunningTaskMonitor.

2021-03-24 Thread GitBox
asfgit closed pull request #4925: URL: https://github.com/apache/nifi/pull/4925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Resolved] (NIFI-8143) GetFile: Keep Source File should be true by default

2021-03-24 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt resolved NIFI-8143. Resolution: Won't Do > GetFile: Keep Source File should be true by default >

[GitHub] [nifi] markap14 commented on a change in pull request #4931: NIFI-8283 Value handling in ScanAccumulo processor

2021-03-24 Thread GitBox
markap14 commented on a change in pull request #4931: URL: https://github.com/apache/nifi/pull/4931#discussion_r600590158 ## File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-processors/src/main/java/org/apache/nifi/accumulo/processors/ScanAccumulo.java ## @@

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4925: NIFI-8356: Add unit test for LongRunningTaskMonitor.

2021-03-24 Thread GitBox
exceptionfactory commented on a change in pull request #4925: URL: https://github.com/apache/nifi/pull/4925#discussion_r600589912 ## File path:

[GitHub] [nifi] turcsanyip commented on a change in pull request #4925: NIFI-8356: Add unit test for LongRunningTaskMonitor.

2021-03-24 Thread GitBox
turcsanyip commented on a change in pull request #4925: URL: https://github.com/apache/nifi/pull/4925#discussion_r600584036 ## File path:

[jira] [Commented] (NIFI-8143) GetFile: Keep Source File should be true by default

2021-03-24 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307908#comment-17307908 ] Joe Witt commented on NIFI-8143: GetFile will likely go away in whenever we do a NiFi 2.0 release. The

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1037: MINIFICPP-1520 Fix PublishKafka properties to support expression language

2021-03-24 Thread GitBox
adamdebreceni commented on a change in pull request #1037: URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600565978 ## File path: PROCESSORS.md ## @@ -971,13 +971,13 @@ In the list below, the names of required properties appear in bold. Any other pr

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1037: MINIFICPP-1520 Fix PublishKafka properties to support expression language

2021-03-24 Thread GitBox
adamdebreceni commented on a change in pull request #1037: URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600565978 ## File path: PROCESSORS.md ## @@ -971,13 +971,13 @@ In the list below, the names of required properties appear in bold. Any other pr

[jira] [Resolved] (NIFI-8362) Set KEEP_SOURCE_FILE default to true for GetFile processor

2021-03-24 Thread dml (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dml resolved NIFI-8362. --- Resolution: Won't Do https://github.com/apache/nifi/pull/4932/commits > Set KEEP_SOURCE_FILE default to true for

[jira] [Commented] (NIFI-8362) Set KEEP_SOURCE_FILE default to true for GetFile processor

2021-03-24 Thread dml (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307883#comment-17307883 ] dml commented on NIFI-8362: --- Pull Request [#4932|https://github.com/apache/nifi/pull/4932/commits] rejected and

[GitHub] [nifi] dml872 commented on pull request #4932: changing default value for Keep Source File property on GetFile proce…

2021-03-24 Thread GitBox
dml872 commented on pull request #4932: URL: https://github.com/apache/nifi/pull/4932#issuecomment-805878964 Fair enough, I've often had an issue where a user mistakenly set the directory path to `./` which ended up removing all files from the system including all the configuration files

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1037: MINIFICPP-1520 Fix PublishKafka properties to support expression language

2021-03-24 Thread GitBox
szaszm commented on a change in pull request #1037: URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600542921 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -541,6 +543,11 @@ void PublishKafka::onSchedule(const std::shared_ptr conn_ =

[jira] [Resolved] (NIFI-6999) Encrypt Config Toolkit fails on very large flow.xml.gz files

2021-03-24 Thread Nathan Gough (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Gough resolved NIFI-6999. Fix Version/s: 1.13.0 Resolution: Fixed > Encrypt Config Toolkit fails on very large

[jira] [Updated] (NIFI-8360) SplitContent does not find any 'splits' that occur after about 2 GB into FlowFile

2021-03-24 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8360: - Resolution: Fixed Status: Resolved (was: Patch Available) > SplitContent does not find

[jira] [Commented] (NIFI-8360) SplitContent does not find any 'splits' that occur after about 2 GB into FlowFile

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307859#comment-17307859 ] ASF subversion and git services commented on NIFI-8360: --- Commit

[GitHub] [nifi] asfgit closed pull request #4929: NIFI-8360: Fixed an overflow issue where we used an integer to store …

2021-03-24 Thread GitBox
asfgit closed pull request #4929: URL: https://github.com/apache/nifi/pull/4929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #1037: MINIFICPP-1520 Fix PublishKafka properties to support expression language

2021-03-24 Thread GitBox
arpadboda commented on a change in pull request #1037: URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600527153 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -541,6 +543,11 @@ void PublishKafka::onSchedule(const std::shared_ptr conn_ =

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1037: MINIFICPP-1520 Fix PublishKafka properties to support expression language

2021-03-24 Thread GitBox
fgerlits commented on a change in pull request #1037: URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600526296 ## File path: extensions/librdkafka/tests/CMakeLists.txt ## @@ -29,10 +29,12 @@ FOREACH(testfile ${KAFKA_TESTS})

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1037: MINIFICPP-1520 Fix PublishKafka properties to support expression language

2021-03-24 Thread GitBox
fgerlits commented on a change in pull request #1037: URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600522506 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -541,6 +543,11 @@ void PublishKafka::onSchedule(const std::shared_ptr conn_ =

[GitHub] [nifi] timeabarna commented on a change in pull request #4931: NIFI-8283 Value handling in ScanAccumulo processor

2021-03-24 Thread GitBox
timeabarna commented on a change in pull request #4931: URL: https://github.com/apache/nifi/pull/4931#discussion_r600517501 ## File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-processors/src/main/java/org/apache/nifi/accumulo/processors/ScanAccumulo.java ## @@

[GitHub] [nifi] timeabarna commented on a change in pull request #4931: NIFI-8283 Value handling in ScanAccumulo processor

2021-03-24 Thread GitBox
timeabarna commented on a change in pull request #4931: URL: https://github.com/apache/nifi/pull/4931#discussion_r600516907 ## File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-processors/src/main/java/org/apache/nifi/accumulo/processors/ScanAccumulo.java ## @@

[GitHub] [nifi] joewitt closed pull request #4932: changing default value for Keep Source File property on GetFile proce…

2021-03-24 Thread GitBox
joewitt closed pull request #4932: URL: https://github.com/apache/nifi/pull/4932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] joewitt commented on pull request #4932: changing default value for Keep Source File property on GetFile proce…

2021-03-24 Thread GitBox
joewitt commented on pull request #4932: URL: https://github.com/apache/nifi/pull/4932#issuecomment-805856940 I am strongly opposed to this change. This default value has been in place for a very long time and the decision then was to make the default match the most obvious intent.

[GitHub] [nifi] timeabarna commented on a change in pull request #4931: NIFI-8283 Value handling in ScanAccumulo processor

2021-03-24 Thread GitBox
timeabarna commented on a change in pull request #4931: URL: https://github.com/apache/nifi/pull/4931#discussion_r600515517 ## File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-processors/src/main/java/org/apache/nifi/accumulo/processors/ScanAccumulo.java ## @@

[jira] [Assigned] (NIFI-8206) Allow PropertyDescriptors to drive what type of input they accept

2021-03-24 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne reassigned NIFI-8206: Assignee: Mark Payne > Allow PropertyDescriptors to drive what type of input they accept >

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

2021-03-24 Thread GitBox
szaszm commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600511300 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -353,119 +355,104 @@ class DeviceInfoNode : public DeviceInformation {

[jira] [Resolved] (NIFI-8357) ConsumeKafka(Record)_2_0, ConsumeKafka(Record)_2_6 do not reconnect if using statically assigned partitions

2021-03-24 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi resolved NIFI-8357. --- Resolution: Fixed > ConsumeKafka(Record)_2_0, ConsumeKafka(Record)_2_6 do not reconnect if

[jira] [Commented] (NIFI-8357) ConsumeKafka(Record)_2_0, ConsumeKafka(Record)_2_6 do not reconnect if using statically assigned partitions

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307844#comment-17307844 ] ASF subversion and git services commented on NIFI-8357: --- Commit

[GitHub] [nifi] asfgit closed pull request #4926: NIFI-8357: Updated Kafka 2.0/2.6 processors to automatically handle recreating Consumer Lease objects when an existing one is poisoned, even if using

2021-03-24 Thread GitBox
asfgit closed pull request #4926: URL: https://github.com/apache/nifi/pull/4926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (NIFI-8357) ConsumeKafka(Record)_2_0, ConsumeKafka(Record)_2_6 do not reconnect if using statically assigned partitions

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307843#comment-17307843 ] ASF subversion and git services commented on NIFI-8357: --- Commit

[GitHub] [nifi] dml872 opened a new pull request #4932: changing default value for Keep Source File property on GetFile proce…

2021-03-24 Thread GitBox
dml872 opened a new pull request #4932: URL: https://github.com/apache/nifi/pull/4932 …ssor Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR _Enables X functionality; fixes bug

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1037: MINIFICPP-1520 Fix PublishKafka properties to support expression language

2021-03-24 Thread GitBox
szaszm commented on a change in pull request #1037: URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600491028 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -541,6 +543,11 @@ void PublishKafka::onSchedule(const std::shared_ptr conn_ =

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4931: NIFI-8283 Value handling in ScanAccumulo processor

2021-03-24 Thread GitBox
exceptionfactory commented on a change in pull request #4931: URL: https://github.com/apache/nifi/pull/4931#discussion_r600474873 ## File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-processors/src/main/java/org/apache/nifi/accumulo/processors/ScanAccumulo.java

[GitHub] [nifi] ChrisSamo632 commented on pull request #4854: NIFI-7172: Trim whitespace from NiFi properties

2021-03-24 Thread GitBox
ChrisSamo632 commented on pull request #4854: URL: https://github.com/apache/nifi/pull/4854#issuecomment-805824784 > Thanks for making the adjustments @eaolson. Do you have any additional comments @ChrisSamo632? @exceptionfactory nothing more from me (I can't see how to resolve

[GitHub] [nifi] markap14 commented on a change in pull request #4931: NIFI-8283 Value handling in ScanAccumulo processor

2021-03-24 Thread GitBox
markap14 commented on a change in pull request #4931: URL: https://github.com/apache/nifi/pull/4931#discussion_r600483300 ## File path: nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-processors/src/main/java/org/apache/nifi/accumulo/processors/ScanAccumulo.java ## @@

[jira] [Resolved] (NIFI-8296) Integration with API to retrieve all subjects associated with a schema id for Confluent Schema Registry v5.3.1+

2021-03-24 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-8296. -- Fix Version/s: 1.14.0 Resolution: Fixed > Integration with API to retrieve all subjects

[jira] [Commented] (NIFI-8296) Integration with API to retrieve all subjects associated with a schema id for Confluent Schema Registry v5.3.1+

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307825#comment-17307825 ] ASF subversion and git services commented on NIFI-8296: --- Commit

[GitHub] [nifi] asfgit closed pull request #4872: NIFI-8296: Use API to retrieve all subjects associated with a schema id for Confluent Schema Registry v5.3.1+

2021-03-24 Thread GitBox
asfgit closed pull request #4872: URL: https://github.com/apache/nifi/pull/4872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] pvillard31 commented on pull request #4872: NIFI-8296: Use API to retrieve all subjects associated with a schema id for Confluent Schema Registry v5.3.1+

2021-03-24 Thread GitBox
pvillard31 commented on pull request #4872: URL: https://github.com/apache/nifi/pull/4872#issuecomment-805816849 Merged to main, thanks @diarworld -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nifi] exceptionfactory commented on pull request #4857: NIFI-8230 Removed default Sensitive Properties Key

2021-03-24 Thread GitBox
exceptionfactory commented on pull request #4857: URL: https://github.com/apache/nifi/pull/4857#issuecomment-805814048 Just to summarize the latest changes, after some additional discussion with @markap14, he suggested that implementing a simplified command for setting the Sensitive

[jira] [Resolved] (NIFI-8348) Advanced UI not available when building with Java 11

2021-03-24 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-8348. -- Fix Version/s: (was: 1.13.3) 1.14.0 Resolution: Fixed > Advanced UI not

[jira] [Commented] (NIFI-8348) Advanced UI not available when building with Java 11

2021-03-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307822#comment-17307822 ] ASF subversion and git services commented on NIFI-8348: --- Commit

[GitHub] [nifi] markap14 merged pull request #4919: NIFI-8348: upgrade jersey version to one fully compatible with Java 11

2021-03-24 Thread GitBox
markap14 merged pull request #4919: URL: https://github.com/apache/nifi/pull/4919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] exceptionfactory commented on pull request #4854: NIFI-7172: Trim whitespace from NiFi properties

2021-03-24 Thread GitBox
exceptionfactory commented on pull request #4854: URL: https://github.com/apache/nifi/pull/4854#issuecomment-805791573 Thanks for making the adjustments @eaolson. Do you have any additional comments @ChrisSamo632? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1037: MINIFICPP-1520 Fix PublishKafka properties to support expression language

2021-03-24 Thread GitBox
adamdebreceni commented on a change in pull request #1037: URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600432935 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -541,6 +543,11 @@ void PublishKafka::onSchedule(const std::shared_ptr conn_

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1037: MINIFICPP-1520 Fix PublishKafka properties to support expression language

2021-03-24 Thread GitBox
szaszm commented on a change in pull request #1037: URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600426575 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -541,6 +543,11 @@ void PublishKafka::onSchedule(const std::shared_ptr conn_ =

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1036: MINIFICPP-1352 Fix warnings in JNI and Sensors extensions

2021-03-24 Thread GitBox
szaszm commented on a change in pull request #1036: URL: https://github.com/apache/nifi-minifi-cpp/pull/1036#discussion_r600419189 ## File path: extensions/jni/jvm/JniReferenceObjects.h ## @@ -142,7 +142,7 @@ class JniByteInputStream : public minifi::InputStreamCallback {

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1036: MINIFICPP-1352 Fix warnings in JNI and Sensors extensions

2021-03-24 Thread GitBox
szaszm commented on a change in pull request #1036: URL: https://github.com/apache/nifi-minifi-cpp/pull/1036#discussion_r600419189 ## File path: extensions/jni/jvm/JniReferenceObjects.h ## @@ -142,7 +142,7 @@ class JniByteInputStream : public minifi::InputStreamCallback {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

2021-03-24 Thread GitBox
adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600418932 ## File path: libminifi/test/unit/ResponseNodeValueTests.cpp ## @@ -0,0 +1,113 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi] markobean commented on pull request #4919: NIFI-8348: upgrade jersey version to one fully compatible with Java 11

2021-03-24 Thread GitBox
markobean commented on pull request #4919: URL: https://github.com/apache/nifi/pull/4919#issuecomment-805767465 Thanks @markap14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1039: MINIFICPP-1533

2021-03-24 Thread GitBox
szaszm closed pull request #1039: URL: https://github.com/apache/nifi-minifi-cpp/pull/1039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

2021-03-24 Thread GitBox
adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600410229 ## File path: libminifi/src/utils/SystemCPUUsageTracker.cpp ## @@ -0,0 +1,186 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #979: MINIFICPP-1456 Introduce PutAzureBlobStorage processor

2021-03-24 Thread GitBox
szaszm closed pull request #979: URL: https://github.com/apache/nifi-minifi-cpp/pull/979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [nifi] Lehel44 commented on a change in pull request #4898: NIFI-8325: Improve SNMP processors

2021-03-24 Thread GitBox
Lehel44 commented on a change in pull request #4898: URL: https://github.com/apache/nifi/pull/4898#discussion_r600401175 ## File path: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/helper/SNMPTestUtil.java ## @@ -0,0 +1,100 @@ +/* +

[jira] [Updated] (NIFI-8362) Set KEEP_SOURCE_FILE default to true for GetFile processor

2021-03-24 Thread dml (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dml updated NIFI-8362: -- Description: Currently the default value for the Keep Source File property on the GetFile processor is false. It would

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

2021-03-24 Thread GitBox
adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600388400 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -353,119 +355,104 @@ class DeviceInfoNode : public

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

2021-03-24 Thread GitBox
adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600388400 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -353,119 +355,104 @@ class DeviceInfoNode : public

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

2021-03-24 Thread GitBox
adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600388400 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -353,119 +355,104 @@ class DeviceInfoNode : public

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

2021-03-24 Thread GitBox
adamdebreceni commented on a change in pull request #1032: URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r600388400 ## File path: libminifi/include/core/state/nodes/DeviceInformation.h ## @@ -353,119 +355,104 @@ class DeviceInfoNode : public

[jira] [Created] (NIFI-8362) Set KEEP_SOURCE_FILE default to true for GetFile processor

2021-03-24 Thread dml (Jira)
dml created NIFI-8362: - Summary: Set KEEP_SOURCE_FILE default to true for GetFile processor Key: NIFI-8362 URL: https://issues.apache.org/jira/browse/NIFI-8362 Project: Apache NiFi Issue Type:

  1   2   >