adamdebreceni commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603068827
##
File path: libminifi/include/core/state/Value.h
##
@@ -580,6 +573,10 @@ struct SerializedResponseNode {
SerializedResponseNode(const S
adamdebreceni commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603069419
##
File path: libminifi/include/core/state/nodes/AgentInformation.h
##
@@ -427,13 +427,15 @@ class AgentStatus : public StateMonitorNode {
adamdebreceni commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603098402
##
File path: libminifi/include/core/state/Value.h
##
@@ -228,36 +225,36 @@ class IntValue : public Value {
}
protected:
- virtual b
martinzink commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603114722
##
File path: libminifi/include/core/state/Value.h
##
@@ -580,6 +573,10 @@ struct SerializedResponseNode {
SerializedResponseNode(const Seri
martinzink commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603124037
##
File path: libminifi/include/core/state/Value.h
##
@@ -228,36 +225,36 @@ class IntValue : public Value {
}
protected:
- virtual bool
adamdebreceni commented on a change in pull request #1035:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1035#discussion_r603127503
##
File path: nanofi/tests/CLogAggregatorTests.cpp
##
@@ -31,18 +31,19 @@
#include "CTestsBase.h"
-void test_lists_equal(token_list * t
adamdebreceni commented on a change in pull request #1035:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1035#discussion_r603127503
##
File path: nanofi/tests/CLogAggregatorTests.cpp
##
@@ -31,18 +31,19 @@
#include "CTestsBase.h"
-void test_lists_equal(token_list * t
adamdebreceni commented on a change in pull request #1035:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1035#discussion_r603127503
##
File path: nanofi/tests/CLogAggregatorTests.cpp
##
@@ -31,18 +31,19 @@
#include "CTestsBase.h"
-void test_lists_equal(token_list * t
adamdebreceni commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603132719
##
File path: libminifi/include/core/state/Value.h
##
@@ -228,36 +225,36 @@ class IntValue : public Value {
}
protected:
- virtual b
Lehel44 commented on pull request #4898:
URL: https://github.com/apache/nifi/pull/4898#issuecomment-809228963
@exceptionfactory The change is big and I already started working on a
separate branch. I'd prefer closing this.
--
This is an automated message from the Apache Git Service.
To r
Timea Barna created NIFI-8373:
-
Summary: Add Kerberos support to Accumulo processors
Key: NIFI-8373
URL: https://issues.apache.org/jira/browse/NIFI-8373
Project: Apache NiFi
Issue Type: Improveme
adamdebreceni closed pull request #1033:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
adamdebreceni commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r603164575
##
File path: libminifi/include/utils/Literals.h
##
@@ -0,0 +1,59 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one o
Jose Luis Pedrosa created NIFI-8374:
---
Summary: ApiModelProperty readOnly is deprecated
Key: NIFI-8374
URL: https://issues.apache.org/jira/browse/NIFI-8374
Project: Apache NiFi
Issue Type: I
fgerlits commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603102486
##
File path: libminifi/test/sql-tests/ExecuteSQLTests.cpp
##
@@ -0,0 +1,195 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) und
martinzink commented on a change in pull request #1035:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1035#discussion_r603206890
##
File path: nanofi/tests/CLogAggregatorTests.cpp
##
@@ -31,18 +31,19 @@
#include "CTestsBase.h"
-void test_lists_equal(token_list * tknl
jlpedrosa opened a new pull request #4945:
URL: https://github.com/apache/nifi/pull/4945
Description of PR
readOnly has been deprecated, and should be relaplced by accessMode,
readOnly = true is accessMode.READ_ONLY
### For all changes:
- [x] Is there a JIRA ticket
martinzink commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603214289
##
File path: libminifi/include/core/state/Value.h
##
@@ -228,36 +225,36 @@ class IntValue : public Value {
}
protected:
- virtual bool
adamdebreceni commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r603216459
##
File path: libminifi/include/utils/ValueParser.h
##
@@ -126,6 +126,10 @@ class ValueParser {
}
}
+ std::string rest() const noex
adamdebreceni commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r603216508
##
File path: libminifi/include/utils/StagingQueue.h
##
@@ -0,0 +1,168 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
lordgamez commented on a change in pull request #1036:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1036#discussion_r603220302
##
File path: extensions/jni/jvm/JniReferenceObjects.h
##
@@ -142,7 +142,7 @@ class JniByteInputStream : public
minifi::InputStreamCallback {
adamdebreceni commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603223913
##
File path: libminifi/test/sql-tests/SQLTestPlan.h
##
@@ -0,0 +1,98 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under
fgerlits commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603236080
##
File path: libminifi/test/sql-tests/SQLTestPlan.h
##
@@ -0,0 +1,98 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
adamdebreceni commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603242138
##
File path: libminifi/test/sql-tests/SQLTestPlan.h
##
@@ -0,0 +1,98 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under
adamdebreceni commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603242347
##
File path: extensions/sql/processors/QueryDatabaseTable.cpp
##
@@ -75,361 +72,234 @@ const core::Property
QueryDatabaseTable::s_maxValue
adamdebreceni commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603243373
##
File path: libminifi/test/sql-tests/PutSQLTests.cpp
##
@@ -0,0 +1,78 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) und
adamdebreceni commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603243515
##
File path: libminifi/test/sql-tests/ExecuteSQLTests.cpp
##
@@ -0,0 +1,195 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
adamdebreceni commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603243747
##
File path: libminifi/test/sql-tests/ExecuteSQLTests.cpp
##
@@ -0,0 +1,195 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
adamdebreceni commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603243747
##
File path: libminifi/test/sql-tests/ExecuteSQLTests.cpp
##
@@ -0,0 +1,195 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
adamdebreceni commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603246521
##
File path: .github/workflows/ci.yml
##
@@ -132,12 +142,13 @@ jobs:
run: |
sudo apt-add-repository -y "ppa:ubuntu-tool
Woutifier opened a new pull request #4946:
URL: https://github.com/apache/nifi/pull/4946
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Upgrades datastax cassandra driver to 3.11.0; fixes
szaszm commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r603272527
##
File path: libminifi/test/unit/LoggerTests.cpp
##
@@ -107,3 +110,95 @@ TEST_CASE("Test ShortenNames", "[ttl6]") {
LogTestController::getInstanc
fgerlits commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603274520
##
File path: libminifi/test/sql-tests/ExecuteSQLTests.cpp
##
@@ -0,0 +1,195 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) und
[
https://issues.apache.org/jira/browse/NIFI-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310655#comment-17310655
]
Peter Turcsanyi commented on NIFI-8341:
---
Nabeel,
I see you submitted a Pull Request
szaszm commented on a change in pull request #1036:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1036#discussion_r603284155
##
File path: extensions/jni/jvm/JniReferenceObjects.h
##
@@ -137,12 +137,12 @@ class JniByteInputStream : public
minifi::InputStreamCallback {
lordgamez commented on a change in pull request #1036:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1036#discussion_r603288757
##
File path: extensions/jni/jvm/JniReferenceObjects.h
##
@@ -137,12 +137,12 @@ class JniByteInputStream : public
minifi::InputStreamCallback {
adamdebreceni commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603295791
##
File path: extensions/http-curl/tests/C2VerifyResourceConsumptionInHeartbeat.cpp
##
@@ -0,0 +1,133 @@
+/**
Review comment:
we wil
adamdebreceni commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603298693
##
File path: libminifi/test/sql-tests/ExecuteSQLTests.cpp
##
@@ -0,0 +1,195 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
exceptionfactory commented on a change in pull request #4938:
URL: https://github.com/apache/nifi/pull/4938#discussion_r603300543
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
##
@@ -239,6 +239,11 @@ private D
mattyb149 commented on a change in pull request #4938:
URL: https://github.com/apache/nifi/pull/4938#discussion_r603330567
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcCommon.java
##
@@ -465,7 +474,12 @@
Jose Luis Pedrosa created NIFI-8375:
---
Summary: java.lang.Class#newInstance Is deprecated
Key: NIFI-8375
URL: https://issues.apache.org/jira/browse/NIFI-8375
Project: Apache NiFi
Issue Type:
[
https://issues.apache.org/jira/browse/NIFI-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard reassigned NIFI-8341:
Assignee: Nabeel
> ConsumeAMQP and PublishAMQP Should support multiple hosts
>
[
https://issues.apache.org/jira/browse/NIFI-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310692#comment-17310692
]
Pierre Villard commented on NIFI-8341:
--
I added you to the contributors and assigned
jlpedrosa opened a new pull request #4947:
URL: https://github.com/apache/nifi/pull/4947
Description of PR
#8374 The java method class.newIstance has been deprecated, according to
java official documentation:
The call
clazz.newInstance() can be replaced by
clazz.getDec
[
https://issues.apache.org/jira/browse/NIFI-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310696#comment-17310696
]
Mayki commented on NIFI-6886:
-
Hello,
It seems the error appear again for nifi 1.13.1
1.13.1
exceptionfactory commented on pull request #4898:
URL: https://github.com/apache/nifi/pull/4898#issuecomment-809438279
> @exceptionfactory The change is big and I already started working on a
separate branch. I'd prefer closing this.
@Lehel44 That's fine if you open a new PR, just wa
fgerlits commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603386255
##
File path: .github/workflows/ci.yml
##
@@ -132,12 +142,13 @@ jobs:
run: |
sudo apt-add-repository -y "ppa:ubuntu-toolchain
exceptionfactory commented on pull request #4938:
URL: https://github.com/apache/nifi/pull/4938#issuecomment-809489345
Thanks for making the unit test updates @mattyb149. Verified updated
behavior in `JdbcCommon` and `ResultSetRecordSet`. +1 Merging.
--
This is an automated message fro
[
https://issues.apache.org/jira/browse/NIFI-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310741#comment-17310741
]
Matt Burgess commented on NIFI-6886:
1.13.1 is known to have issues, it was supplanted
asfgit closed pull request #4938:
URL: https://github.com/apache/nifi/pull/4938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
[
https://issues.apache.org/jira/browse/NIFI-8368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310745#comment-17310745
]
ASF subversion and git services commented on NIFI-8368:
---
Commit a5db
[
https://issues.apache.org/jira/browse/NIFI-8368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-8368:
---
Fix Version/s: 1.14.0
Resolution: Fixed
Status: Resolved (was: Patch Availab
Matt Burgess created NIFI-8376:
--
Summary: Gracefully handle SQL exceptions in ResultSetRecordSet
Key: NIFI-8376
URL: https://issues.apache.org/jira/browse/NIFI-8376
Project: Apache NiFi
Issue Ty
Kasonnara created NIFI-8377:
---
Summary: CSVReader: quoting and trimming with value separator
inconsistency
Key: NIFI-8377
URL: https://issues.apache.org/jira/browse/NIFI-8377
Project: Apache NiFi
I
simonbence opened a new pull request #4948:
URL: https://github.com/apache/nifi/pull/4948
[NIFI-8273](https://issues.apache.org/jira/browse/NIFI-8273)
This would be my proposal to add some useful feature for working with
records: the PR contains three processors, similar to the
`Scr
fgerlits commented on a change in pull request #1026:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1026#discussion_r603462998
##
File path: bstrp_functions.sh
##
@@ -75,30 +75,31 @@ set_incompatible_with(){
}
print_multi_option_status(){
- feature="$1"
feature_st
[
https://issues.apache.org/jira/browse/NIFI-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Bence updated NIFI-8273:
--
Status: Patch Available (was: In Progress)
https://github.com/apache/nifi/pull/4948
> Adding Scripted
DEOM Damien created NIFI-8378:
-
Summary: PutDatabaseRecord / MySQL does not allowed queries
Key: NIFI-8378
URL: https://issues.apache.org/jira/browse/NIFI-8378
Project: Apache NiFi
Issue Type: Bu
[
https://issues.apache.org/jira/browse/NIFI-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310866#comment-17310866
]
Roberta commented on NIFI-7222:
---
I have the same problem with the version 1.12.1. How I can
[
https://issues.apache.org/jira/browse/NIFI-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310873#comment-17310873
]
DEOM Damien commented on NIFI-7748:
---
I've implemented your solution succesfully, thanks
[
https://issues.apache.org/jira/browse/NIFI-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
DEOM Damien updated NIFI-8378:
--
Summary: PutDatabaseRecord / MySQL does not allow predefined queries (was:
PutDatabaseRecord / MySQL do
David Handermann created NIFI-8379:
--
Summary: Improve DBCPServiceTest Reliability and Performance
Key: NIFI-8379
URL: https://issues.apache.org/jira/browse/NIFI-8379
Project: Apache NiFi
Iss
[
https://issues.apache.org/jira/browse/NIFI-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-8379:
---
Description:
{{DBCPServiceTest.testDropInvalidConnectionsH2_Default}} recently failed during
[
https://issues.apache.org/jira/browse/NIFI-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann reassigned NIFI-8379:
--
Assignee: David Handermann
> Improve DBCPServiceTest Reliability and Performance
>
Mark Payne created NIFI-8380:
Summary: Stateless NiFi Kafka connector should allow separate
directories for extensions and base nars
Key: NIFI-8380
URL: https://issues.apache.org/jira/browse/NIFI-8380
Pro
exceptionfactory opened a new pull request #4949:
URL: https://github.com/apache/nifi/pull/4949
Description of PR
NIFI-8379 Improves the reliability and performance of `DBCPServiceTest` with
the following changes:
- Removed unreliable H2 network connection test methods
[
https://issues.apache.org/jira/browse/NIFI-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-8379:
---
Status: Patch Available (was: In Progress)
> Improve DBCPServiceTest Reliability and Performa
Andrew created NIFI-8381:
Summary: Unable to use IAM Roles for Service Accounts with Nifi on
kubernetes EKS
Key: NIFI-8381
URL: https://issues.apache.org/jira/browse/NIFI-8381
Project: Apache NiFi
I
[
https://issues.apache.org/jira/browse/NIFI-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310962#comment-17310962
]
Chris Sampson commented on NIFI-2892:
-
Updated based on PR comments:
* added (optional
[
https://issues.apache.org/jira/browse/NIFI-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Sampson updated NIFI-2892:
Attachment: NiFi-2892.json
NIFI-2892.xml
> Implement AWS Kinesis Stream Get Processo
[
https://issues.apache.org/jira/browse/NIFI-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Sampson updated NIFI-2892:
Attachment: (was: NIFI-2892.json)
> Implement AWS Kinesis Stream Get Processor
> ---
[
https://issues.apache.org/jira/browse/NIFI-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Sampson updated NIFI-2892:
Attachment: (was: NIFI-2892.xml)
> Implement AWS Kinesis Stream Get Processor
>
ChrisSamo632 commented on pull request #4822:
URL: https://github.com/apache/nifi/pull/4822#issuecomment-809686439
@turcsanyip updated per your suggestions.
Note that this includes:
- added (optional) Record Reader/Writer (@pvillard31 FYI)
- better Thread/Session handling for th
[
https://issues.apache.org/jira/browse/NIFI-8380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310984#comment-17310984
]
Mark Payne commented on NIFI-8380:
--
I also ran into an issue when we use multiple tasks,
markap14 opened a new pull request #4950:
URL: https://github.com/apache/nifi/pull/4950
…e to place downloaded files. Also fixed an issue that was encountered, when
a Source Processor is scheduled for Primary Node Only but more than 1 task is
set. In that case, even though only a single ta
[
https://issues.apache.org/jira/browse/NIFI-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess reassigned NIFI-8376:
--
Assignee: Matt Burgess
> Gracefully handle SQL exceptions in ResultSetRecordSet
> -
mattyb149 opened a new pull request #4951:
URL: https://github.com/apache/nifi/pull/4951
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Removes the call to `isAfterLast()` in favor of catc
[
https://issues.apache.org/jira/browse/NIFI-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-8376:
---
Status: Patch Available (was: In Progress)
> Gracefully handle SQL exceptions in ResultSetRecordSet
>
[
https://issues.apache.org/jira/browse/NIFI-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311025#comment-17311025
]
Nabeel commented on NIFI-8341:
--
Thank you, is there a list of approvers I can contact to look
exceptionfactory commented on pull request #4517:
URL: https://github.com/apache/nifi/pull/4517#issuecomment-809848974
@agreenburg Updates to `InvokeHTTP` in NIFI-8304 included cleaning up
several methods, such as this one. Other recent updates include upgrading
OkHttp to version 4.9.1.
80 matches
Mail list logo