[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1052: MINIFICPP-1244 Support the Initial Start Position property in TailFile

2021-04-28 Thread GitBox
szaszm commented on a change in pull request #1052: URL: https://github.com/apache/nifi-minifi-cpp/pull/1052#discussion_r622741226 ## File path: extensions/standard-processors/processors/TailFile.h ## @@ -147,13 +166,27 @@ class TailFile : public core::Processor { std::str

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4991: NIFI-7134: Allowing auto-reloading of Jetty key/truststores

2021-04-28 Thread GitBox
exceptionfactory commented on a change in pull request #4991: URL: https://github.com/apache/nifi/pull/4991#discussion_r622716598 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/test/java/org/apache/nifi/web/server/util/TrustStoreScannerTest

[GitHub] [nifi-registry] mtien-apache commented on a change in pull request #319: NIFIREG-395 - Implemented the ability to import and export versioned flows through the UI

2021-04-28 Thread GitBox
mtien-apache commented on a change in pull request #319: URL: https://github.com/apache/nifi-registry/pull/319#discussion_r622688442 ## File path: nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/BucketFlowResource.java ## @@ -291,6 +303,

[GitHub] [nifi-registry] mtien-apache commented on pull request #319: NIFIREG-395 - Implemented the ability to import and export versioned flows through the UI

2021-04-28 Thread GitBox
mtien-apache commented on pull request #319: URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-828895145 Pushed 2 commits: - Handled the scenario when an invalid snapshot file is uploaded during Import New Flow @andrewmlim - Refactored client side API import met

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5041: MINIFI-553: Fix timeout-based tests in StatusLoggerTest

2021-04-28 Thread GitBox
exceptionfactory commented on a change in pull request #5041: URL: https://github.com/apache/nifi/pull/5041#discussion_r622687141 ## File path: minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/status/reporters/StatusLoggerTest.java ## @@ -194,16 +209,81 @

[GitHub] [nifi] mattyb149 commented on a change in pull request #5041: MINIFI-553: Fix timeout-based tests in StatusLoggerTest

2021-04-28 Thread GitBox
mattyb149 commented on a change in pull request #5041: URL: https://github.com/apache/nifi/pull/5041#discussion_r622685681 ## File path: minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/status/reporters/StatusLoggerTest.java ## @@ -194,16 +209,81 @@ publi

[GitHub] [nifi] mattyb149 commented on a change in pull request #5041: MINIFI-553: Fix timeout-based tests in StatusLoggerTest

2021-04-28 Thread GitBox
mattyb149 commented on a change in pull request #5041: URL: https://github.com/apache/nifi/pull/5041#discussion_r622683446 ## File path: minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/status/reporters/StatusLoggerTest.java ## @@ -194,16 +209,81 @@ publi

[jira] [Commented] (NIFI-8500) org.apache.nifi.StdErr Failed to start web server: org.xml.sax.SAXParseException; lineNumber: 434; columnNumber: 9; Character reference "�" is an invalid XML chara

2021-04-28 Thread YE WANG (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335069#comment-17335069 ] YE WANG commented on NIFI-8500: --- 不能有特殊字符,在flow.xml.gz文档里全部替换掉即可开起来nifi,已经解决 > org.apache.ni

[jira] [Created] (NIFI-8500) org.apache.nifi.StdErr Failed to start web server: org.xml.sax.SAXParseException; lineNumber: 434; columnNumber: 9; Character reference "�" is an invalid XML charact

2021-04-28 Thread YE WANG (Jira)
YE WANG created NIFI-8500: - Summary: org.apache.nifi.StdErr Failed to start web server: org.xml.sax.SAXParseException; lineNumber: 434; columnNumber: 9; Character reference "�" is an invalid XML character. Key: NIFI-8500

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5041: MINIFI-553: Fix timeout-based tests in StatusLoggerTest

2021-04-28 Thread GitBox
exceptionfactory commented on a change in pull request #5041: URL: https://github.com/apache/nifi/pull/5041#discussion_r622581289 ## File path: minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/status/reporters/StatusLoggerTest.java ## @@ -194,16 +209,81 @

[GitHub] [nifi] mattyb149 opened a new pull request #5041: MINIFI-553: Fix timeout-based tests in StatusLoggerTest

2021-04-28 Thread GitBox
mattyb149 opened a new pull request #5041: URL: https://github.com/apache/nifi/pull/5041 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Allows the ScheduledExecutorService to be overri

[jira] [Commented] (NIFI-7593) Azure Blob Storage uses sensitive property for account name

2021-04-28 Thread Malthe Borch (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335024#comment-17335024 ] Malthe Borch commented on NIFI-7593: I don't think that's a valid argument since the s

[jira] [Resolved] (NIFI-7593) Azure Blob Storage uses sensitive property for account name

2021-04-28 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee resolved NIFI-7593. --- Resolution: Not A Problem [~malthe] This is intentional as account names can correspond to publicly a

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622559197 ## File path: .github/workflows/ci-workflow.yml ## @@ -234,6 +248,16 @@ jobs: java-version: '8' - name: Build with Maven env: -

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622550084 ## File path: pom.xml ## @@ -435,7 +439,6 @@ true -Xmx1G -Djava.net.preferIPv4

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622548477 ## File path: pom.xml ## @@ -421,8 +421,12 @@ org.apache.maven.plugins maven-surefire-plugin -

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622547695 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java ## @@ -556,7 +

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622542681 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/components/LongRunningTaskMonitorTest.java

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622541103 ## File path: nifi-commons/nifi-utils/src/test/java/org/apache/nifi/util/locale/TestLocaleOfTestSuite.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622540154 ## File path: nifi-commons/nifi-utils/src/test/java/org/apache/nifi/util/locale/TestLocaleOfTestSuite.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache

[jira] [Updated] (NIFI-7593) Azure Blob Storage uses sensitive property for account name

2021-04-28 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee updated NIFI-7593: -- Labels: easyfix (was: easyfix newbie) > Azure Blob Storage uses sensitive property for account name > -

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622537424 ## File path: nifi-commons/nifi-utils/src/test/java/org/apache/nifi/util/locale/TestLocaleOfTestSuite.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622535695 ## File path: nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/xml/XmlUtilsTest.groovy ## @@ -94,7 +94,7 @@ class XmlUtilsTest {

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622532523 ## File path: .github/workflows/ci-workflow.yml ## @@ -234,6 +248,16 @@ jobs: java-version: '8' - name: Build with Maven env: -

[GitHub] [nifi] joewitt commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
joewitt commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622531623 ## File path: .github/workflows/ci-workflow.yml ## @@ -234,6 +248,16 @@ jobs: java-version: '8' - name: Build with Maven env: -

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622528727 ## File path: .github/workflows/ci-workflow.yml ## @@ -234,6 +248,16 @@ jobs: java-version: '8' - name: Build with Maven env: -

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622528727 ## File path: .github/workflows/ci-workflow.yml ## @@ -234,6 +248,16 @@ jobs: java-version: '8' - name: Build with Maven env: -

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622528727 ## File path: .github/workflows/ci-workflow.yml ## @@ -234,6 +248,16 @@ jobs: java-version: '8' - name: Build with Maven env: -

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622522898 ## File path: .github/workflows/ci-workflow.yml ## @@ -91,9 +91,16 @@ jobs: df -h - name: Build with Maven env: - MAVEN_OP

[jira] [Resolved] (NIFI-7548) Nifi embedded secure zookeeper

2021-04-28 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee resolved NIFI-7548. --- Resolution: Duplicate Hi [~santosh239]. Closing this because it's a duplicate of NIFI-7203 which was

[GitHub] [nifi] joewitt commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
joewitt commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622522476 ## File path: .github/workflows/ci-workflow.yml ## @@ -91,9 +91,16 @@ jobs: df -h - name: Build with Maven env: - MAVEN_O

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622521641 ## File path: .github/workflows/ci-workflow.yml ## @@ -91,9 +91,16 @@ jobs: df -h - name: Build with Maven env: - MAVEN_OP

[jira] [Updated] (NIFI-7593) Azure Blob Storage uses sensitive property for account name

2021-04-28 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee updated NIFI-7593: -- Labels: easyfix newbie (was: easyfix) > Azure Blob Storage uses sensitive property for account name > -

[GitHub] [nifi] greyp9 commented on a change in pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 commented on a change in pull request #5040: URL: https://github.com/apache/nifi/pull/5040#discussion_r622519643 ## File path: .github/workflows/ci-workflow.yml ## @@ -91,9 +91,16 @@ jobs: df -h - name: Build with Maven env: - MAVEN_OP

[jira] [Assigned] (NIFI-7598) Add instructions for how to use named volumes to Docker README.md

2021-04-28 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee reassigned NIFI-7598: - Assignee: (was: Joey Frazee) > Add instructions for how to use named volumes to Docker README

[GitHub] [nifi] greyp9 opened a new pull request #5040: NIFI-8478; i18n test issues; CI supplies locale to surefire

2021-04-28 Thread GitBox
greyp9 opened a new pull request #5040: URL: https://github.com/apache/nifi/pull/5040 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Addresses a few i18n issues in project test suite.

[jira] [Assigned] (NIFI-8499) implement encrypted version of FlowFileSwapManager

2021-04-28 Thread Paul Grey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Grey reassigned NIFI-8499: --- Assignee: Paul Grey > implement encrypted version of FlowFileSwapManager > --

[jira] [Updated] (NIFI-8499) implement encrypted version of FlowFileSwapManager

2021-04-28 Thread Paul Grey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Grey updated NIFI-8499: Description: Class org.apache.nifi.controller.FileSystemSwapManager is plaintext implementation of interfac

[jira] [Commented] (NIFI-8478) Unable to build the project (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature")

2021-04-28 Thread Paul Grey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334965#comment-17334965 ] Paul Grey commented on NIFI-8478: - Thanks [~juldrixx] for raising this issue. There was o

[jira] [Created] (NIFI-8499) implement encrypted version of FlowFileSwapManager

2021-04-28 Thread Paul Grey (Jira)
Paul Grey created NIFI-8499: --- Summary: implement encrypted version of FlowFileSwapManager Key: NIFI-8499 URL: https://issues.apache.org/jira/browse/NIFI-8499 Project: Apache NiFi Issue Type: Task

[jira] [Updated] (NIFI-8477) If a node completely dies, can not delete it from the cluster; AKA Zombie Node

2021-04-28 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8477: - Status: Patch Available (was: Open) > If a node completely dies, can not delete it from the cluster; AKA

[GitHub] [nifi] markap14 opened a new pull request #5039: NIFI-8477: If interrupted while waiting for Node Status Update to be …

2021-04-28 Thread GitBox
markap14 opened a new pull request #5039: URL: https://github.com/apache/nifi/pull/5039 …replicated to other nodes, do not throw ProtocolException; instead just log a warning and return. Thank you for submitting a contribution to Apache NiFi. Please provide a short descrip

[jira] [Updated] (NIFI-8498) Optional removal of fields with UpdateRecord

2021-04-28 Thread Peter Gyori (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Gyori updated NIFI-8498: -- Parent: NIFI-8243 Issue Type: Sub-task (was: Improvement) > Optional removal of fields with Upd

[GitHub] [nifi] pgyori opened a new pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-04-28 Thread GitBox
pgyori opened a new pull request #5038: URL: https://github.com/apache/nifi/pull/5038 - Field removal from record - Field removal from recursive record structures (record within record) - Field removal from schema only if there is no data in the record for a field - Unit tests

[jira] [Commented] (NIFI-8497) Add a SlackRecordSink controller service

2021-04-28 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334922#comment-17334922 ] Pierre Villard commented on NIFI-8497: -- We should consider support for proxy. > Add

[jira] [Created] (NIFI-8498) Optional removal of fields with UpdateRecord

2021-04-28 Thread Peter Gyori (Jira)
Peter Gyori created NIFI-8498: - Summary: Optional removal of fields with UpdateRecord Key: NIFI-8498 URL: https://issues.apache.org/jira/browse/NIFI-8498 Project: Apache NiFi Issue Type: Improvem

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1044: MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages

2021-04-28 Thread GitBox
szaszm commented on a change in pull request #1044: URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r622414758 ## File path: extensions/systemd/ConsumeJournald.cpp ## @@ -0,0 +1,254 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Created] (NIFI-8497) Add a SlackRecordSink controller service

2021-04-28 Thread Matt Burgess (Jira)
Matt Burgess created NIFI-8497: -- Summary: Add a SlackRecordSink controller service Key: NIFI-8497 URL: https://issues.apache.org/jira/browse/NIFI-8497 Project: Apache NiFi Issue Type: New Featur

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1044: MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages

2021-04-28 Thread GitBox
szaszm commented on a change in pull request #1044: URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r622403565 ## File path: extensions/systemd/WorkerThread.h ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1044: MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages

2021-04-28 Thread GitBox
szaszm commented on a change in pull request #1044: URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r622396192 ## File path: extensions/systemd/ConsumeJournald.cpp ## @@ -0,0 +1,254 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Created] (NIFI-8496) NiFi returns 500 error when uploading templates

2021-04-28 Thread Matt Burgess (Jira)
Matt Burgess created NIFI-8496: -- Summary: NiFi returns 500 error when uploading templates Key: NIFI-8496 URL: https://issues.apache.org/jira/browse/NIFI-8496 Project: Apache NiFi Issue Type: Bug

[GitHub] [nifi] markap14 commented on a change in pull request #5004: NIFI-8433: Added ability to decommission a node in a cluster

2021-04-28 Thread GitBox
markap14 commented on a change in pull request #5004: URL: https://github.com/apache/nifi/pull/5004#discussion_r622391558 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat/AbstractHea

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1044: MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages

2021-04-28 Thread GitBox
szaszm commented on a change in pull request #1044: URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r622390469 ## File path: CMakeLists.txt ## @@ -564,6 +560,14 @@ if (ENABLE_ALL OR ENABLE_AZURE) createExtension(AZURE-EXTENSIONS "AZURE EXTENSIONS" "T

[GitHub] [nifi-minifi] mattyb149 closed pull request #195: MINIFI-541: Update Dockerfile to Follow Docker Best Practices

2021-04-28 Thread GitBox
mattyb149 closed pull request #195: URL: https://github.com/apache/nifi-minifi/pull/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [nifi-minifi] mattyb149 commented on pull request #195: MINIFI-541: Update Dockerfile to Follow Docker Best Practices

2021-04-28 Thread GitBox
mattyb149 commented on pull request #195: URL: https://github.com/apache/nifi-minifi/pull/195#issuecomment-828633974 I've taken the liberty of migrating this PR to the NiFi repo now that MiNiFi Java is integrated with the NiFi codebase. @SethFalco although the PR is on my fork/branch, you

[GitHub] [nifi] mattyb149 opened a new pull request #5037: MINIFI-541: Update Dockerfile to Follow Docker Best Practices

2021-04-28 Thread GitBox
mattyb149 opened a new pull request #5037: URL: https://github.com/apache/nifi/pull/5037 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Migrating PR https://github.com/apache/nifi-mini

[jira] [Resolved] (MINIFICPP-1551) minifi-cpp 'main' branch fails build with pcap support

2021-04-28 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda resolved MINIFICPP-1551. --- Fix Version/s: 0.9.0 Resolution: Fixed Already fixed > minifi-cpp 'main' branch f

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1044: MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages

2021-04-28 Thread GitBox
fgerlits commented on a change in pull request #1044: URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r622015172 ## File path: bstrp_functions.sh ## @@ -386,7 +390,8 @@ show_supported_features() { read_feature_options(){ local choice - read -r -p "Ent

[jira] [Moved] (MINIFICPP-1552) Allow to reflect the clonning of the git repo, for AWS C++ SDK (extension)

2021-04-28 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess moved MINIFI-534 to MINIFICPP-1552: Component/s: (was: Extensions) Key:

[jira] [Assigned] (NIFI-8477) If a node completely dies, can not delete it from the cluster; AKA Zombie Node

2021-04-28 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne reassigned NIFI-8477: Assignee: Mark Payne > If a node completely dies, can not delete it from the cluster; AKA Zombie No

[jira] [Commented] (NIFI-552) Improve LogAttribute property matching

2021-04-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334835#comment-17334835 ] ASF subversion and git services commented on NIFI-552: -- Commit 93dcf25

[GitHub] [nifi] mattyb149 closed pull request #5036: MINIFI-552 Fix new SSL SAN Behaviour from new Jetty Version

2021-04-28 Thread GitBox
mattyb149 closed pull request #5036: URL: https://github.com/apache/nifi/pull/5036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] mattyb149 commented on pull request #5036: MINIFI-552 Fix new SSL SAN Behaviour from new Jetty Version

2021-04-28 Thread GitBox
mattyb149 commented on pull request #5036: URL: https://github.com/apache/nifi/pull/5036#issuecomment-828577935 +1 LGTM, thanks for the fix! Merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Moved] (MINIFICPP-1551) minifi-cpp 'main' branch fails build with pcap support

2021-04-28 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess moved MINIFI-542 to MINIFICPP-1551: Component/s: (was: Extensions) (was: B

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

2021-04-28 Thread GitBox
lordgamez commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r622308397 ## File path: extensions/standard-processors/tests/unit/GetFileTests.cpp ## @@ -91,12 +113,30 @@ TEST_CASE("GetFile: MaxSize", "[getFileFifo]")

[GitHub] [nifi] turcsanyip commented on a change in pull request #5028: NIFI-8325: Complete SNMP refactor: SNMP GET and SET processors rework, unit tests added

2021-04-28 Thread GitBox
turcsanyip commented on a change in pull request #5028: URL: https://github.com/apache/nifi/pull/5028#discussion_r622299989 ## File path: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/factory/V3SNMPFactory.java ## @@ -0,0 +1,71 @@ +/

[jira] [Moved] (MINIFICPP-1550) CMake Error at libminifi/CMakeLists.txt: Cannot find source file: src/agent/agent_version.cpp (FreeBSD 13.0 x86_64)

2021-04-28 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess moved MINIFI-544 to MINIFICPP-1550: Component/s: (was: Build)

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

2021-04-28 Thread GitBox
szaszm commented on a change in pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r622296205 ## File path: controller/MiNiFiController.cpp ## @@ -167,9 +165,10 @@ int main(int argc, char **argv) { socket = secure_context != nullp

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1052: MINIFICPP-1244 Support the Initial Start Position property in TailFile

2021-04-28 Thread GitBox
lordgamez commented on a change in pull request #1052: URL: https://github.com/apache/nifi-minifi-cpp/pull/1052#discussion_r622276241 ## File path: extensions/standard-processors/processors/TailFile.h ## @@ -179,6 +212,8 @@ class TailFile : public core::Processor {

[jira] [Created] (NIFI-8495) Improve Access Denied Error Log for Missing Cluster Permissions

2021-04-28 Thread Shawn Weeks (Jira)
Shawn Weeks created NIFI-8495: - Summary: Improve Access Denied Error Log for Missing Cluster Permissions Key: NIFI-8495 URL: https://issues.apache.org/jira/browse/NIFI-8495 Project: Apache NiFi

[GitHub] [nifi] gresockj commented on a change in pull request #4991: NIFI-7134: Allowing auto-reloading of Jetty key/truststores

2021-04-28 Thread GitBox
gresockj commented on a change in pull request #4991: URL: https://github.com/apache/nifi/pull/4991#discussion_r622273007 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java ## @@ -15

[jira] [Resolved] (MINIFICPP-1329) Fix implementation and usages of StringUtils::StringToBool

2021-04-28 Thread Amina Dinari (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amina Dinari resolved MINIFICPP-1329. - Resolution: Fixed > Fix implementation and usages of StringUtils::StringToBool >

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1052: MINIFICPP-1244 Support the Initial Start Position property in TailFile

2021-04-28 Thread GitBox
lordgamez commented on a change in pull request #1052: URL: https://github.com/apache/nifi-minifi-cpp/pull/1052#discussion_r622268250 ## File path: extensions/standard-processors/processors/TailFile.h ## @@ -147,13 +166,27 @@ class TailFile : public core::Processor { std::

[jira] [Commented] (MINIFICPP-1329) Fix implementation and usages of StringUtils::StringToBool

2021-04-28 Thread Amina Dinari (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334778#comment-17334778 ] Amina Dinari commented on MINIFICPP-1329: - https://github.com/apache/nifi-min

[GitHub] [nifi] exceptionfactory commented on a change in pull request #4991: NIFI-7134: Allowing auto-reloading of Jetty key/truststores

2021-04-28 Thread GitBox
exceptionfactory commented on a change in pull request #4991: URL: https://github.com/apache/nifi/pull/4991#discussion_r622242626 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-server-nar/pom.xml ## @@ -37,6 +37,11 @@ org.apache.nifi nifi-je

[GitHub] [nifi] Lehel44 commented on a change in pull request #5028: NIFI-8325: Complete SNMP refactor: SNMP GET and SET processors rework, unit tests added

2021-04-28 Thread GitBox
Lehel44 commented on a change in pull request #5028: URL: https://github.com/apache/nifi/pull/5028#discussion_r622240157 ## File path: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/resources/docs/org.apache.nifi.snmp.processors.GetSNMP/additionalDetails.html

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1052: MINIFICPP-1244 Support the Initial Start Position property in TailFile

2021-04-28 Thread GitBox
szaszm commented on a change in pull request #1052: URL: https://github.com/apache/nifi-minifi-cpp/pull/1052#discussion_r622184549 ## File path: extensions/standard-processors/processors/TailFile.h ## @@ -179,6 +212,8 @@ class TailFile : public core::Processor {

[jira] [Updated] (NIFI-8487) Implement Composite Parameter Contexts

2021-04-28 Thread Joseph Gresock (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Gresock updated NIFI-8487: - Description: Allow a ParameterContext to contain an ordered list of other ParameterContexts, givi

[GitHub] [nifi] Lehel44 commented on a change in pull request #5028: NIFI-8325: Complete SNMP refactor: SNMP GET and SET processors rework, unit tests added

2021-04-28 Thread GitBox
Lehel44 commented on a change in pull request #5028: URL: https://github.com/apache/nifi/pull/5028#discussion_r622237614 ## File path: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/AbstractSNMPProcessor.java ## @@ -16,413

[GitHub] [nifi] Lehel44 commented on a change in pull request #5028: NIFI-8325: Complete SNMP refactor: SNMP GET and SET processors rework, unit tests added

2021-04-28 Thread GitBox
Lehel44 commented on a change in pull request #5028: URL: https://github.com/apache/nifi/pull/5028#discussion_r622232273 ## File path: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java ## @@ -151,7 +152,24 @@ public ValidationResult v

[GitHub] [nifi] turcsanyip commented on a change in pull request #4516: NIFI-7788 Start and Stop actions on a Process Group should enable/disable transmission of RPG's

2021-04-28 Thread GitBox
turcsanyip commented on a change in pull request #4516: URL: https://github.com/apache/nifi/pull/4516#discussion_r622204815 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java #

[GitHub] [nifi] turcsanyip commented on a change in pull request #4516: NIFI-7788 Start and Stop actions on a Process Group should enable/disable transmission of RPG's

2021-04-28 Thread GitBox
turcsanyip commented on a change in pull request #4516: URL: https://github.com/apache/nifi/pull/4516#discussion_r622204815 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java #

[GitHub] [nifi] Fabryprog closed pull request #4441: NIFI 7525 - Create a nullValue() Subjectless Functions and support null type on Expression Language

2021-04-28 Thread GitBox
Fabryprog closed pull request #4441: URL: https://github.com/apache/nifi/pull/4441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] simonbence commented on a change in pull request #4516: NIFI-7788 Start and Stop actions on a Process Group should enable/disable transmission of RPG's

2021-04-28 Thread GitBox
simonbence commented on a change in pull request #4516: URL: https://github.com/apache/nifi/pull/4516#discussion_r622183087 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java #

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1065: MINIFICPP-1504: followup review changes

2021-04-28 Thread GitBox
martinzink commented on a change in pull request #1065: URL: https://github.com/apache/nifi-minifi-cpp/pull/1065#discussion_r622167271 ## File path: libminifi/src/utils/OsUtils.cpp ## @@ -168,6 +168,11 @@ std::string OsUtils::userIdToUsername(const std::string &uid) { retur

[jira] [Updated] (NIFI-8494) InvokeScriptedProcessor become invalid after stopped

2021-04-28 Thread Thierry PRATS (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry PRATS updated NIFI-8494: Description: InvokeScriptedProcessor works well when started for the first time. The Processor beco

[jira] [Updated] (NIFI-8494) InvokeScriptedProcessor become invalid after stopped

2021-04-28 Thread Thierry PRATS (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thierry PRATS updated NIFI-8494: Description: InvokeScriptedProcessor works well when started for the first time. The Processor beco

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1065: MINIFICPP-1504: followup review changes

2021-04-28 Thread GitBox
szaszm commented on a change in pull request #1065: URL: https://github.com/apache/nifi-minifi-cpp/pull/1065#discussion_r622147996 ## File path: libminifi/src/utils/OsUtils.cpp ## @@ -168,6 +168,11 @@ std::string OsUtils::userIdToUsername(const std::string &uid) { return na

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1065: MINIFICPP-1504: followup review changes

2021-04-28 Thread GitBox
szaszm commented on a change in pull request #1065: URL: https://github.com/apache/nifi-minifi-cpp/pull/1065#discussion_r622147996 ## File path: libminifi/src/utils/OsUtils.cpp ## @@ -168,6 +168,11 @@ std::string OsUtils::userIdToUsername(const std::string &uid) { return na

[jira] [Created] (NIFI-8494) InvokeScriptedProcessor become invalid after stopped

2021-04-28 Thread Thierry PRATS (Jira)
Thierry PRATS created NIFI-8494: --- Summary: InvokeScriptedProcessor become invalid after stopped Key: NIFI-8494 URL: https://issues.apache.org/jira/browse/NIFI-8494 Project: Apache NiFi Issue Ty

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1065: MINIFICPP-1504: followup review changes

2021-04-28 Thread GitBox
szaszm commented on a change in pull request #1065: URL: https://github.com/apache/nifi-minifi-cpp/pull/1065#discussion_r622081212 ## File path: libminifi/src/utils/OsUtils.cpp ## @@ -168,6 +168,11 @@ std::string OsUtils::userIdToUsername(const std::string &uid) { return na

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1065: MINIFICPP-1504: followup review changes

2021-04-28 Thread GitBox
martinzink commented on a change in pull request #1065: URL: https://github.com/apache/nifi-minifi-cpp/pull/1065#discussion_r622145780 ## File path: libminifi/src/utils/OsUtils.cpp ## @@ -168,6 +168,11 @@ std::string OsUtils::userIdToUsername(const std::string &uid) { retur

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1065: MINIFICPP-1504: followup review changes

2021-04-28 Thread GitBox
szaszm commented on a change in pull request #1065: URL: https://github.com/apache/nifi-minifi-cpp/pull/1065#discussion_r622081212 ## File path: libminifi/src/utils/OsUtils.cpp ## @@ -168,6 +168,11 @@ std::string OsUtils::userIdToUsername(const std::string &uid) { return na

[jira] [Commented] (NIFI-8056) openid integration with nifi is not working (in proxy environment)

2021-04-28 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334704#comment-17334704 ] David Handermann commented on NIFI-8056: [~ramanij] are you able to submit a Pull

[GitHub] [nifi] tpalfy commented on a change in pull request #4516: NIFI-7788 Start and Stop actions on a Process Group should enable/disable transmission of RPG's

2021-04-28 Thread GitBox
tpalfy commented on a change in pull request #4516: URL: https://github.com/apache/nifi/pull/4516#discussion_r622137775 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java #

[jira] [Updated] (NIFI-8493) PutDatabaseRecord incorrect type resolution for auto increment columns

2021-04-28 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian updated NIFI-8493: - Remaining Estimate: (was: 4h) Original Estimate: (was: 4h) > PutDatabaseRecord incorrect type resolut

[GitHub] [nifi] gresockj commented on pull request #4991: NIFI-7134: Allowing auto-reloading of Jetty key/truststores

2021-04-28 Thread GitBox
gresockj commented on pull request #4991: URL: https://github.com/apache/nifi/pull/4991#issuecomment-828407150 Based on David's input, I'm going to simply use Jetty's KeyStoreScanner and add our own TrustStoreScanner to integrate into the Jetty life cycle. -- This is an automated message

[jira] [Updated] (NIFI-8493) PutDatabaseRecord incorrect type resolution for auto increment columns

2021-04-28 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian updated NIFI-8493: - Description: When there is a column where the value is "auto increment/identity", the type resolution fails. Thi

[jira] [Updated] (NIFI-8493) PutDatabaseRecord incorrect type resolution for auto increment columns

2021-04-28 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian updated NIFI-8493: - Description: When there is a column where the value is "auto increment/identity", the type resolution fails. Thi

[jira] [Updated] (NIFI-8493) PutDatabaseRecord incorrect type resolution for auto increment columns

2021-04-28 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian updated NIFI-8493: - Description: When there is a column where the value is "auto increment/identity", the type resolution fails. Thi

  1   2   >