[jira] [Updated] (NIFI-12152) Refactor Security.addProvider References to Bouncy Castle

2023-09-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12152: Status: Patch Available (was: Open) > Refactor Security.addProvider References to Bouncy

[jira] [Comment Edited] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor

2023-09-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770634#comment-17770634 ] David Handermann edited comment on NIFI-11627 at 9/30/23 1:43 AM: --

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7817: NIFI-12151 Fixed StandardPrivateKeyService fails due to missing Bounc…

2023-09-29 Thread via GitHub
exceptionfactory commented on code in PR #7817: URL: https://github.com/apache/nifi/pull/7817#discussion_r1341877948 ## nifi-nar-bundles/nifi-standard-services/nifi-key-service-bundle/nifi-key-service/src/test/java/org/apache/nifi/key/service/StandardPrivateKeyServiceTest.java:

[jira] [Commented] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor

2023-09-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770634#comment-17770634 ] David Handermann commented on NIFI-11627: - Thanks for the reply [~nwchuckster], and thanks for

[jira] [Updated] (NIFI-12143) Update all calcite tables to new API

2023-09-29 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-12143: -- Status: Patch Available (was: Open) > Update all calcite tables to new API >

[GitHub] [nifi] markap14 opened a new pull request, #7820: NIFI-12143: Introduced a new nifi-calcite-utils module and refactored…

2023-09-29 Thread via GitHub
markap14 opened a new pull request, #7820: URL: https://github.com/apache/nifi/pull/7820 … the nifi-sql-reporting-tasks to mamke use of it. This uses the newer calcite api instead of deprecated classes/methods - Refactored QueryRecord / JoinEnrichment to use new nifi-calcite-utils

[jira] [Commented] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor

2023-09-29 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770614#comment-17770614 ] Mark Payne commented on NIFI-11627: --- It does make sense to allow for a reference to be stored in a

[GitHub] [nifi] joewitt opened a new pull request, #7819: NIFI-12147 Cleaned poms, updated Dockerfile, fixed Jersey version to …

2023-09-29 Thread via GitHub
joewitt opened a new pull request, #7819: URL: https://github.com/apache/nifi/pull/7819 …get appropriate bundled ASM # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please

[jira] [Commented] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor

2023-09-29 Thread Chuck Tilly (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770593#comment-17770593 ] Chuck Tilly commented on NIFI-11627: [~exceptionfactory]   A specific use-case would be every single

[GitHub] [nifi] exceptionfactory opened a new pull request, #7818: NIFI-12152 Refactored addProvider() Bouncy Castle references

2023-09-29 Thread via GitHub
exceptionfactory opened a new pull request, #7818: URL: https://github.com/apache/nifi/pull/7818 # Summary [NIFI-12152](https://issues.apache.org/jira/browse/NIFI-12152) Refactors references to `Security.addProvider()` with global registration of the Bouncy Castle Provider.

[jira] [Created] (NIFI-12152) Refactor Security.addProvider References to Bouncy Castle

2023-09-29 Thread David Handermann (Jira)
David Handermann created NIFI-12152: --- Summary: Refactor Security.addProvider References to Bouncy Castle Key: NIFI-12152 URL: https://issues.apache.org/jira/browse/NIFI-12152 Project: Apache NiFi

[jira] [Updated] (NIFI-12151) StandardPrivateKeyService fails due to missing BouncyCastleProvider

2023-09-29 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-12151: --- Fix Version/s: 1.latest 2.latest > StandardPrivateKeyService fails due to

[jira] [Updated] (NIFI-12151) StandardPrivateKeyService fails due to missing BouncyCastleProvider

2023-09-29 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-12151: --- Status: Patch Available (was: Open) > StandardPrivateKeyService fails due to missing

[GitHub] [nifi] turcsanyip opened a new pull request, #7817: NIFI-12151 Fixed StandardPrivateKeyService fails due to missing Bounc…

2023-09-29 Thread via GitHub
turcsanyip opened a new pull request, #7817: URL: https://github.com/apache/nifi/pull/7817 …yCastleProvider # Summary [NIFI-12151](https://issues.apache.org/jira/browse/NIFI-12151) # Tracking Please complete the following tracking steps prior to pull request

[GitHub] [nifi] bbende opened a new pull request, #7816: NIFI-12149 Create nifi-redis-utils and minor improvements to util methods

2023-09-29 Thread via GitHub
bbende opened a new pull request, #7816: URL: https://github.com/apache/nifi/pull/7816 This is the 1.x version of #7812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7781: NIFI-11463 Allow IdentifyMimeType to use custom MIME types in addition to defaults

2023-09-29 Thread via GitHub
exceptionfactory commented on code in PR #7781: URL: https://github.com/apache/nifi/pull/7781#discussion_r1341754971 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java: ## @@ -99,6 +101,9 @@

[jira] [Comment Edited] (NIFI-11841) Nifi in cluster setup doesn't stop within the graceful shutdown period

2023-09-29 Thread Michael W Moser (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770585#comment-17770585 ] Michael W Moser edited comment on NIFI-11841 at 9/29/23 8:07 PM: - I have

[jira] [Commented] (NIFI-11841) Nifi in cluster setup doesn't stop within the graceful shutdown period

2023-09-29 Thread Michael W Moser (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770585#comment-17770585 ] Michael W Moser commented on NIFI-11841: I have duplicated this problem and I will be looking

[jira] [Commented] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor

2023-09-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770584#comment-17770584 ] David Handermann commented on NIFI-11627: - Thanks for the reply [~dstiegli1]. Supporting FlowFile

[jira] [Created] (NIFI-12151) StandardPrivateKeyService fails due to missing BouncyCastleProvider

2023-09-29 Thread Peter Turcsanyi (Jira)
Peter Turcsanyi created NIFI-12151: -- Summary: StandardPrivateKeyService fails due to missing BouncyCastleProvider Key: NIFI-12151 URL: https://issues.apache.org/jira/browse/NIFI-12151 Project:

[jira] [Commented] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor

2023-09-29 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770581#comment-17770581 ] Daniel Stieglitz commented on NIFI-11627: - [~exceptionfactory] I do not have a specific use case

[jira] [Commented] (NIFI-12150) Restore any deleted classes that are still required such as NiFiRegistrySecurityConfig

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770577#comment-17770577 ] ASF subversion and git services commented on NIFI-12150: Commit

[jira] [Updated] (NIFI-12150) Restore any deleted classes that are still required such as NiFiRegistrySecurityConfig

2023-09-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12150: Resolution: Fixed Status: Resolved (was: Patch Available) > Restore any deleted

[jira] [Commented] (NIFI-12147) Update NiFi docker images to use JRE instead of JDK and make NiFi Registry image use Java 21

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770578#comment-17770578 ] ASF subversion and git services commented on NIFI-12147: Commit

[GitHub] [nifi] exceptionfactory closed pull request #7815: NIFI-12150 restoring NiFiRegistrySecurityConfig as it is a key spring…

2023-09-29 Thread via GitHub
exceptionfactory closed pull request #7815: NIFI-12150 restoring NiFiRegistrySecurityConfig as it is a key spring… URL: https://github.com/apache/nifi/pull/7815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (NIFI-12104) Allow Redis DMC to be used by Put/Fetch DMC when Redis is clustered

2023-09-29 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-12104: --- Fix Version/s: 2.0.0 1.24.0 (was: 2.latest) > Allow Redis

[GitHub] [nifi] bbende commented on pull request #7796: NIFI-12104 Separate a non-atomic Redis DMC implementation from the ex…

2023-09-29 Thread via GitHub
bbende commented on PR #7796: URL: https://github.com/apache/nifi/pull/7796#issuecomment-1741389094 Thanks @MikeThomsen and @gresockj I was able to resolve the cherry-pick to `support/nifi-1.x`, it was because there is one change for a new redis processor that was not back-ported

[jira] [Commented] (NIFI-12104) Allow Redis DMC to be used by Put/Fetch DMC when Redis is clustered

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770576#comment-17770576 ] ASF subversion and git services commented on NIFI-12104: Commit

[jira] [Commented] (NIFI-11172) Remove Duplicative Features for 2.0.0

2023-09-29 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770568#comment-17770568 ] Joe Witt commented on NIFI-11172: - yep agreed with Handermann's response > Remove Duplicative Features

[jira] [Commented] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor

2023-09-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770567#comment-17770567 ] David Handermann commented on NIFI-11627: - [~dstiegli1] Can you describe the use case for

[jira] [Commented] (NIFI-11172) Remove Duplicative Features for 2.0.0

2023-09-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770566#comment-17770566 ] David Handermann commented on NIFI-11172: - [~dstiegli1] We should retain both JoltTransformJSON

[jira] [Commented] (NIFI-12100) Remove ConvertExcelToCSVProcessor

2023-09-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770561#comment-17770561 ] David Handermann commented on NIFI-12100: - Thanks for merging the changes [~mthomsen]! Just a

[jira] [Updated] (NIFI-12100) Remove ConvertExcelToCSVProcessor

2023-09-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12100: Fix Version/s: 2.0.0 (was: 2.latest) > Remove

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7740: NIFI-6240 Proxy Support for AzureEventHub processor via Websockets

2023-09-29 Thread via GitHub
exceptionfactory commented on code in PR #7740: URL: https://github.com/apache/nifi/pull/7740#discussion_r1341690686 ## nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/utils/AzureEventHubUtils.java: ## @@ -103,4

[GitHub] [nifi] MikeThomsen commented on pull request #7814: NIFI-12100 Annotated the ConvertExcelToCSVProcessor with the DeprecationNotice annotation and fixed the Checkstyle violation in SplitJson.

2023-09-29 Thread via GitHub
MikeThomsen commented on PR #7814: URL: https://github.com/apache/nifi/pull/7814#issuecomment-1741305081 (Manually closed, github isn't tracking support/nifi-1.x) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [nifi] MikeThomsen closed pull request #7814: NIFI-12100 Annotated the ConvertExcelToCSVProcessor with the DeprecationNotice annotation and fixed the Checkstyle violation in SplitJson.

2023-09-29 Thread via GitHub
MikeThomsen closed pull request #7814: NIFI-12100 Annotated the ConvertExcelToCSVProcessor with the DeprecationNotice annotation and fixed the Checkstyle violation in SplitJson. URL: https://github.com/apache/nifi/pull/7814 -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (NIFI-12100) Remove ConvertExcelToCSVProcessor

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770555#comment-17770555 ] ASF subversion and git services commented on NIFI-12100: Commit

[jira] [Assigned] (NIFI-12143) Update all calcite tables to new API

2023-09-29 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne reassigned NIFI-12143: - Assignee: Mark Payne > Update all calcite tables to new API >

[jira] [Updated] (NIFI-12100) Remove ConvertExcelToCSVProcessor

2023-09-29 Thread Mike Thomsen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen updated NIFI-12100: Fix Version/s: 2.latest Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (NIFI-12100) Remove ConvertExcelToCSVProcessor

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770554#comment-17770554 ] ASF subversion and git services commented on NIFI-12100: Commit

[GitHub] [nifi] asfgit closed pull request #7802: NIFI-12100 Removed the ConvertExcelToCSVProcessor

2023-09-29 Thread via GitHub
asfgit closed pull request #7802: NIFI-12100 Removed the ConvertExcelToCSVProcessor URL: https://github.com/apache/nifi/pull/7802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] joewitt commented on pull request #7815: NIFI-12150 restoring NiFiRegistrySecurityConfig as it is a key spring…

2023-09-29 Thread via GitHub
joewitt commented on PR #7815: URL: https://github.com/apache/nifi/pull/7815#issuecomment-1741244224 commit message should reference NIFI-12142 not NIFI-12147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [nifi] mattyb149 commented on pull request #2275: NIFI-4612: Allow AvroSchemaRegistry to disable name validation

2023-09-29 Thread via GitHub
mattyb149 commented on PR #2275: URL: https://github.com/apache/nifi/pull/2275#issuecomment-1741236344 How do the other apps work with an invalid schema? If you need to "normalize" the names so the schema is valid (and the data is not already in Avro format), I wrote a [blog post

[jira] [Updated] (NIFI-12150) Restore any deleted classes that are still required such as NiFiRegistrySecurityConfig

2023-09-29 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12150: Status: Patch Available (was: Open) > Restore any deleted classes that are still required such as >

[GitHub] [nifi] joewitt opened a new pull request, #7815: NIFI-12150 restoring NiFiRegistrySecurityConfig as it is a key spring…

2023-09-29 Thread via GitHub
joewitt opened a new pull request, #7815: URL: https://github.com/apache/nifi/pull/7815 … bean needed for the registry and was removed mistakenly in NIFI-12147 and updating extractor to match changes in NIFI-12147 for dn extraction

[jira] [Created] (NIFI-12150) Restore any deleted classes that are still required such as NiFiRegistrySecurityConfig

2023-09-29 Thread Joe Witt (Jira)
Joe Witt created NIFI-12150: --- Summary: Restore any deleted classes that are still required such as NiFiRegistrySecurityConfig Key: NIFI-12150 URL: https://issues.apache.org/jira/browse/NIFI-12150 Project:

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1669: MINIFICPP-2210 Add C2 debug command to MiNiFi Controller

2023-09-29 Thread via GitHub
lordgamez commented on code in PR #1669: URL: https://github.com/apache/nifi-minifi-cpp/pull/1669#discussion_r1341548877 ## libminifi/include/utils/file/ArchiveUtils.h: ## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1671: MINIFICPP-1891 Integrate google clang-tidy checks in CI

2023-09-29 Thread via GitHub
lordgamez commented on code in PR #1671: URL: https://github.com/apache/nifi-minifi-cpp/pull/1671#discussion_r1341498042 ## extensions/expression-language/tests/ExpressionLanguageTests.cpp: ## @@ -1321,13 +1321,13 @@ TEST_CASE("Now Date", "[expressionNowDate]") {

[jira] [Updated] (NIFI-12104) Allow Redis DMC to be used by Put/Fetch DMC when Redis is clustered

2023-09-29 Thread Mike Thomsen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen updated NIFI-12104: Fix Version/s: 2.latest Resolution: Fixed Status: Resolved (was: Patch

[GitHub] [nifi] MikeThomsen commented on pull request #7796: NIFI-12104 Separate a non-atomic Redis DMC implementation from the ex…

2023-09-29 Thread via GitHub
MikeThomsen commented on PR #7796: URL: https://github.com/apache/nifi/pull/7796#issuecomment-1741032158 The cherry-pick to 1.x was kinda messy. Looks like `CONNECTION_POOL` was moved to `RedisUtils` in another commit. I'll try to chase that down later. -- This is an automated message

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1671: MINIFICPP-1891 Integrate google clang-tidy checks in CI

2023-09-29 Thread via GitHub
lordgamez commented on code in PR #1671: URL: https://github.com/apache/nifi-minifi-cpp/pull/1671#discussion_r1341470484 ## .clang-tidy: ## Review Comment: You are right, I was thinking about it, but didn't want to remove it before discussing it. Even though there were a

[jira] [Commented] (NIFI-12104) Allow Redis DMC to be used by Put/Fetch DMC when Redis is clustered

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770472#comment-17770472 ] ASF subversion and git services commented on NIFI-12104: Commit

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1671: MINIFICPP-1891 Integrate google clang-tidy checks in CI

2023-09-29 Thread via GitHub
lordgamez commented on code in PR #1671: URL: https://github.com/apache/nifi-minifi-cpp/pull/1671#discussion_r1341466297 ## extensions/expression-language/tests/ExpressionLanguageTests.cpp: ## @@ -1321,13 +1321,13 @@ TEST_CASE("Now Date", "[expressionNowDate]") {

[GitHub] [nifi] asfgit closed pull request #7796: NIFI-12104 Separate a non-atomic Redis DMC implementation from the ex…

2023-09-29 Thread via GitHub
asfgit closed pull request #7796: NIFI-12104 Separate a non-atomic Redis DMC implementation from the ex… URL: https://github.com/apache/nifi/pull/7796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (NIFI-12100) Remove ConvertExcelToCSVProcessor

2023-09-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770471#comment-17770471 ] David Handermann commented on NIFI-12100: - Thanks [~dstiegli1]! > Remove

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1671: MINIFICPP-1891 Integrate google clang-tidy checks in CI

2023-09-29 Thread via GitHub
lordgamez commented on code in PR #1671: URL: https://github.com/apache/nifi-minifi-cpp/pull/1671#discussion_r1341463466 ## extensions/systemd/tests/ConsumeJournaldTest.cpp: ## @@ -90,7 +90,7 @@ struct TestJournal final : libwrapper::Journal { } int

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1669: MINIFICPP-2210 Add C2 debug command to MiNiFi Controller

2023-09-29 Thread via GitHub
szaszm commented on code in PR #1669: URL: https://github.com/apache/nifi-minifi-cpp/pull/1669#discussion_r1341459182 ## libminifi/include/utils/file/ArchiveUtils.h: ## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[jira] [Commented] (NIFI-12100) Remove ConvertExcelToCSVProcessor

2023-09-29 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770461#comment-17770461 ] Daniel Stieglitz commented on NIFI-12100: - [~exceptionfactory] I branched off of support/nifi-1.x

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1671: MINIFICPP-1891 Integrate google clang-tidy checks in CI

2023-09-29 Thread via GitHub
szaszm commented on code in PR #1671: URL: https://github.com/apache/nifi-minifi-cpp/pull/1671#discussion_r1341433299 ## .clang-tidy: ## Review Comment: Just a general comment: If a check produces many false positives, then we shouldn't enable it at all costs. The static

[GitHub] [nifi] dan-s1 opened a new pull request, #7814: Annotated the ConvertExcelToCSVProcessor with the DeprecationNotice annotation and fixed the Checkstyle violation in SplitJson.

2023-09-29 Thread via GitHub
dan-s1 opened a new pull request, #7814: URL: https://github.com/apache/nifi/pull/7814 …e DeprecationNotice annotation and fixed the Checkstyle violation in SplitJson. # Summary

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1671: MINIFICPP-1891 Integrate google clang-tidy checks in CI

2023-09-29 Thread via GitHub
szaszm commented on code in PR #1671: URL: https://github.com/apache/nifi-minifi-cpp/pull/1671#discussion_r1341429719 ## extensions/systemd/tests/ConsumeJournaldTest.cpp: ## @@ -90,7 +90,7 @@ struct TestJournal final : libwrapper::Journal { } int getCursor(gsl::owner*

[GitHub] [nifi] dan-s1 closed pull request #7813: Nifi 12100 deprecate v2

2023-09-29 Thread via GitHub
dan-s1 closed pull request #7813: Nifi 12100 deprecate v2 URL: https://github.com/apache/nifi/pull/7813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (NIFI-12149) Separate RedisUtils into a separate module

2023-09-29 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-12149: --- Status: Patch Available (was: Open) > Separate RedisUtils into a separate module >

[GitHub] [nifi] dan-s1 opened a new pull request, #7813: Nifi 12100 deprecate v2

2023-09-29 Thread via GitHub
dan-s1 opened a new pull request, #7813: URL: https://github.com/apache/nifi/pull/7813 # Summary [ NIFI-12100](https://issues.apache.org/jira/browse/NIFI-12100) # Tracking Please complete the following tracking steps

[GitHub] [nifi] bbende opened a new pull request, #7812: NIFI-12149 Create nifi-redis-utils and minor improvements to util met…

2023-09-29 Thread via GitHub
bbende opened a new pull request, #7812: URL: https://github.com/apache/nifi/pull/7812 …hods # Summary [NIFI-12149](https://issues.apache.org/jira/browse/NIFI-12149) # Tracking Please complete the following

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1671: MINIFICPP-1891 Integrate google clang-tidy checks in CI

2023-09-29 Thread via GitHub
szaszm commented on code in PR #1671: URL: https://github.com/apache/nifi-minifi-cpp/pull/1671#discussion_r1341420013 ## extensions/expression-language/tests/ExpressionLanguageTests.cpp: ## @@ -1321,13 +1321,13 @@ TEST_CASE("Now Date", "[expressionNowDate]") { TEST_CASE("Parse

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1671: MINIFICPP-1891 Integrate google clang-tidy checks in CI

2023-09-29 Thread via GitHub
szaszm commented on code in PR #1671: URL: https://github.com/apache/nifi-minifi-cpp/pull/1671#discussion_r1341418984 ## extensions/standard-processors/processors/PutTCP.cpp: ## @@ -215,7 +215,7 @@ asio::awaitable ConnectionHandler::establishNewConn continue; }

[GitHub] [nifi] dan-s1 closed pull request #7803: NIFI-12100_deprecate Added DeprecationNotice annotation to the ConvertExcelToCSVProcessor

2023-09-29 Thread via GitHub
dan-s1 closed pull request #7803: NIFI-12100_deprecate Added DeprecationNotice annotation to the ConvertExcelToCSVProcessor URL: https://github.com/apache/nifi/pull/7803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [nifi] elcsiga opened a new pull request, #7811: NIFI-12099 Repurpose Template icon in top left bar

2023-09-29 Thread via GitHub
elcsiga opened a new pull request, #7811: URL: https://github.com/apache/nifi/pull/7811 # Summary [NIFI-12099](https://issues.apache.org/jira/browse/NIFI-12099) # Tracking Please complete the following tracking steps

[GitHub] [nifi] exceptionfactory commented on pull request #7803: NIFI-12100_deprecate Added DeprecationNotice annotation to the ConvertExcelToCSVProcessor

2023-09-29 Thread via GitHub
exceptionfactory commented on PR #7803: URL: https://github.com/apache/nifi/pull/7803#issuecomment-1740927375 > @exceptionfactory It resulted in other commits so I created a new branch off of support/nifi-1.x and I will create another PR. Interesting I am doing the build with the contrib

[jira] [Comment Edited] (NIFI-11841) Nifi in cluster setup doesn't stop within the graceful shutdown period

2023-09-29 Thread Dheeraj Joshi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770452#comment-17770452 ] Dheeraj Joshi edited comment on NIFI-11841 at 9/29/23 1:48 PM: --- The logs

[GitHub] [nifi] dan-s1 commented on pull request #7803: NIFI-12100_deprecate Added DeprecationNotice annotation to the ConvertExcelToCSVProcessor

2023-09-29 Thread via GitHub
dan-s1 commented on PR #7803: URL: https://github.com/apache/nifi/pull/7803#issuecomment-1740922914 @exceptionfactory It resulted in other commits so I created a new branch off of support/nifi-1.x and I will create another PR. Interesting I am doing the build with the contrib profile and

[jira] [Commented] (NIFI-11841) Nifi in cluster setup doesn't stop within the graceful shutdown period

2023-09-29 Thread Dheeraj Joshi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770452#comment-17770452 ] Dheeraj Joshi commented on NIFI-11841: -- The logs are from 3 instances running on my local

[GitHub] [nifi] exceptionfactory commented on pull request #7803: NIFI-12100_deprecate Added DeprecationNotice annotation to the ConvertExcelToCSVProcessor

2023-09-29 Thread via GitHub
exceptionfactory commented on PR #7803: URL: https://github.com/apache/nifi/pull/7803#issuecomment-1740913472 > @exceptionfactory Does that mean I have to create a branch off of support/nifi-1.x with my change and then create a new PR or does it just mean editing this PR with the new

[jira] [Assigned] (NIFI-11782) NPE when adding Snippet with label into Process Group

2023-09-29 Thread Nissim Shiman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nissim Shiman reassigned NIFI-11782: Assignee: Nissim Shiman > NPE when adding Snippet with label into Process Group >

[jira] [Created] (NIFI-12149) Separate RedisUtils into a separate module

2023-09-29 Thread Bryan Bende (Jira)
Bryan Bende created NIFI-12149: -- Summary: Separate RedisUtils into a separate module Key: NIFI-12149 URL: https://issues.apache.org/jira/browse/NIFI-12149 Project: Apache NiFi Issue Type:

[jira] [Commented] (NIFI-11841) Nifi in cluster setup doesn't stop within the graceful shutdown period

2023-09-29 Thread Michael W Moser (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770444#comment-17770444 ] Michael W Moser commented on NIFI-11841: [~dheerajjoshim]  It looks like one of your three nodes

[jira] [Resolved] (NIFI-12146) Update nifi cli command list

2023-09-29 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFI-12146. Fix Version/s: 2.0.0 1.24.0 Resolution: Fixed > Update nifi cli command

[jira] [Commented] (NIFI-12146) Update nifi cli command list

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770431#comment-17770431 ] ASF subversion and git services commented on NIFI-12146: Commit

[jira] [Commented] (NIFI-12146) Update nifi cli command list

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770429#comment-17770429 ] ASF subversion and git services commented on NIFI-12146: Commit

[GitHub] [nifi] bbende merged pull request #7807: NIFI-12146: Updating nifi cli command list in documentation

2023-09-29 Thread via GitHub
bbende merged PR #7807: URL: https://github.com/apache/nifi/pull/7807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (NIFI-12148) NiFi Hive3Streaming memory leak

2023-09-29 Thread Dmytro Firsov (Jira)
Dmytro Firsov created NIFI-12148: Summary: NiFi Hive3Streaming memory leak Key: NIFI-12148 URL: https://issues.apache.org/jira/browse/NIFI-12148 Project: Apache NiFi Issue Type: Bug

[jira] [Commented] (NIFI-12095) Increase default Xmx to 1g

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770422#comment-17770422 ] ASF subversion and git services commented on NIFI-12095: Commit

[jira] [Comment Edited] (NIFI-11084) Character/text data "mis-identified" by IdentifyMimeType processor

2023-09-29 Thread Nissim Shiman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768114#comment-17768114 ] Nissim Shiman edited comment on NIFI-11084 at 9/29/23 12:36 PM: Once

[GitHub] [nifi] dan-s1 commented on pull request #7782: NIFI-12116 Configured ObjectMapper to not allow multiline JSON.

2023-09-29 Thread via GitHub
dan-s1 commented on PR #7782: URL: https://github.com/apache/nifi/pull/7782#issuecomment-1740814657 @r-vandenbos I would like to go with @ChrisSamo632 suggestion of two processors. Can you please submit a ticket for your work but creating a new processor that can handle records and I will

[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1672: MINIFICPP-2233 Upgrade bustache to fix gcc13 compatibility

2023-09-29 Thread via GitHub
martinzink opened a new pull request, #1672: URL: https://github.com/apache/nifi-minifi-cpp/pull/1672 We should use the latest commit which includes https://github.com/jamboree/bustache/pull/35 This fixes gcc13 compatibility

[GitHub] [nifi] simonbence commented on a diff in pull request #7661: NIFI-11772 Removing flow.xml support

2023-09-29 Thread via GitHub
simonbence commented on code in PR #7661: URL: https://github.com/apache/nifi/pull/7661#discussion_r1341127238 ## nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/clustering/JoinClusterWithDifferentFlow.java: ## @@ -106,100 +95,57 @@ public

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1670: MINIFICPP-2220 Change core::logging::Logger to use fmt format

2023-09-29 Thread via GitHub
martinzink commented on code in PR #1670: URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1341084547 ## libminifi/src/sitetosite/RawSocketProtocol.cpp: ## @@ -435,8 +431,8 @@ int RawSiteToSiteClient::readRespond(const std::shared_ptr return

[jira] [Updated] (MINIFICPP-2234) C2JstackTest transiently fails on Windows

2023-09-29 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2234: - Description: Assertion failed: root.HasMember("Flowcontroller threadpool #0"), file

[jira] [Updated] (MINIFICPP-2237) C2DescribeCoreComponentStateTest sometimes fail on Windows

2023-09-29 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2237: - Description: Assertion failed: root["corecomponentstate"].HasMember(uuid), file

[jira] [Updated] (MINIFICPP-2237) C2DescribeCoreComponentStateTest sometimes fail on Windows

2023-09-29 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2237: - Description:

[jira] [Created] (MINIFICPP-2237) C2DescribeCoreComponentStateTest sometimes fail in Windows

2023-09-29 Thread Jira
Gábor Gyimesi created MINIFICPP-2237: Summary: C2DescribeCoreComponentStateTest sometimes fail in Windows Key: MINIFICPP-2237 URL: https://issues.apache.org/jira/browse/MINIFICPP-2237 Project:

[jira] [Updated] (MINIFICPP-2237) C2DescribeCoreComponentStateTest sometimes fail on Windows

2023-09-29 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2237: - Summary: C2DescribeCoreComponentStateTest sometimes fail on Windows (was:

[jira] [Updated] (MINIFICPP-2237) C2DescribeCoreComponentStateTest sometimes fail ON Windows

2023-09-29 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2237: - Summary: C2DescribeCoreComponentStateTest sometimes fail ON Windows (was:

[jira] [Updated] (MINIFICPP-2236) SchedulingAgentTests sometimes time out in CI

2023-09-29 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2236: - Summary: SchedulingAgentTests sometimes time out in CI (was: SchedulingAgentTests

[jira] [Created] (MINIFICPP-2236) SchedulingAgentTests sometimes times out in CI

2023-09-29 Thread Jira
Gábor Gyimesi created MINIFICPP-2236: Summary: SchedulingAgentTests sometimes times out in CI Key: MINIFICPP-2236 URL: https://issues.apache.org/jira/browse/MINIFICPP-2236 Project: Apache NiFi

[jira] [Created] (MINIFICPP-2235) ControllerTests sometimes segfault in CI

2023-09-29 Thread Jira
Gábor Gyimesi created MINIFICPP-2235: Summary: ControllerTests sometimes segfault in CI Key: MINIFICPP-2235 URL: https://issues.apache.org/jira/browse/MINIFICPP-2235 Project: Apache NiFi MiNiFi

[jira] [Updated] (MINIFICPP-2234) C2JstackTest transiently fails on Windows

2023-09-29 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2234: - Epic Link: MINIFICPP-1324 > C2JstackTest transiently fails on Windows >

[jira] [Updated] (MINIFICPP-2234) C2JstackTest transiently fails on Windows

2023-09-29 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2234: - Issue Type: Bug (was: Improvement) > C2JstackTest transiently fails on Windows >

[jira] [Created] (MINIFICPP-2234) C2JstackTest transiently fails on Windows

2023-09-29 Thread Jira
Gábor Gyimesi created MINIFICPP-2234: Summary: C2JstackTest transiently fails on Windows Key: MINIFICPP-2234 URL: https://issues.apache.org/jira/browse/MINIFICPP-2234 Project: Apache NiFi MiNiFi

  1   2   >