Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/149
@kevdoran I pushed up a commit to update the filter params documentation. I
decided not to do anything with the lastModified value on the bundle table
because technically nothing on that row
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/149
Thanks for the review, I'll look into that lastModified timestamp issue as
well.
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/149#discussion_r241191410
--- Diff:
nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/bucket/Bucket.java
---
@@ -41,6 +41,8
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/149#discussion_r241190389
--- Diff:
nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ExtensionResource.java
---
@@ -93,15 +94,25
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/149
NIFIREG-215 Extension Bundle Improvements
I left the changes as separate commits in order to more easily review each
change on it's own, but feel free to squash upon merging.
You can
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-maven/pull/7#discussion_r240310495
--- Diff: src/main/java/org/apache/nifi/NarMojo.java ---
@@ -426,12 +479,260 @@
protected boolean cloneDuringInstanceClassLoading
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-maven/pull/7#discussion_r240374218
--- Diff:
src/main/java/org/apache/nifi/extension/definition/extraction/ExtensionDefinitionFactory.java
---
@@ -0,0 +1,247 @@
+/*
+ * Licensed to
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-maven/pull/7#discussion_r240314647
--- Diff: src/main/java/org/apache/nifi/XmlDefinitionWriter.java ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-maven/pull/7#discussion_r240314701
--- Diff: src/main/java/org/apache/nifi/PropertiesDefinitionWriter.java ---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-maven/pull/7#discussion_r240308506
--- Diff: src/main/java/org/apache/nifi/NarMojo.java ---
@@ -426,12 +479,260 @@
protected boolean cloneDuringInstanceClassLoading
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3192
LGTM, going to merge, thanks!
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/3211
NIFI-5884 Bumping hbase-client version from 1.1.2 to 1.1.13
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/3206
NIFI-5877 Protecting against null values when obtaining master address
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3202
Code looks good, verified I can see the debug logging when enabled, going
to merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3202
Will review...
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3192#discussion_r237974350
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-standard-services-api-nar/pom.xml
---
@@ -26,6 +26,12 @@
true
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3192#discussion_r237982934
--- Diff:
nifi-api/src/main/java/org/apache/nifi/documentation/AbstractDocumentationWriter.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to the Apache
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3192#discussion_r237917798
--- Diff:
nifi-api/src/main/java/org/apache/nifi/documentation/AbstractDocumentationWriter.java
---
@@ -0,0 +1,301 @@
+/*
+ * Licensed to the Apache
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3192
Will review...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/148
Just pushed a new commit that allows the client to specify a SHA-256 when
uploading the bundle. If they specify one and it doesn't match what the server
calculates, then it is rejecte
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/148
@kevdoran just pushed a commit that addresses the review comments, let me
know if you find anything else. As an FYI, I did try to change that swagger
annotation for LinkableEntity, but it
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/148#discussion_r237093889
--- Diff:
nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/148#discussion_r236865785
--- Diff:
nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/148#discussion_r236853819
--- Diff:
nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/148#discussion_r236853713
--- Diff:
nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/148#discussion_r236852286
--- Diff:
nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/148#discussion_r236850477
--- Diff:
nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ExtensionRepositoryResource.java
---
@@ -0,0 +1,378
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/148#discussion_r236849819
--- Diff:
nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/service/extension/StandardExtensionService.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/148#discussion_r236849686
--- Diff:
nifi-registry-core/nifi-registry-framework/src/main/resources/db/migration/V3__AddExtensions.sql
---
@@ -0,0 +1,62 @@
+-- Licensed to
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/148#discussion_r236849392
--- Diff:
nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/148
Before releasing any of this we would definitely have sections in the user
guide and admin guide related to extension bundles, but we can't really write
all that until the work is done
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/148
All versioned items (flows and now bundles) live in a bucket, and a bucket
is where security policies are applied. So each bucket can be kind of like a
mini extension repo, there could be a
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/148
NIFIREG-211 Initial work for adding extenion bundles to NiFi Registry
This PR includes the foundational work for adding extension bundles as a
new type of versioned item. With this PR it is
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3173
Code looks good and tests pass, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3171
+1 code looks good, verified functionality, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3171
Reviewing...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3136
Looks good, going to merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3136
Reviewing...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/146
Looks good, going to merge, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3132
Code looks good and have been running this branch this morning and
everything seems to work as expected, so going to merge shortly, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3124
I'm good with removing the README once 1.9.0 is released, or changing it to
a link to the new toolkit docs.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3119
@markap14 additional commit pushed that addresses your initial comments
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3119#discussion_r230134587
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils/src/main/java/org/apache/nifi/nar/NarAutoLoaderTask.java
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/3119
NIFI-5673 Support auto loading of new NARs
This PR introduces a new property in nifi.properties where you can specify
a directory that will be watched for new NARs (defaults ./extensions), and upon
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3118
Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3118
Reviewing...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/144
@kevdoran @ijokarumawak what do you guys think of this?
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/144
NIFIREG-209 Rebuild metadata DB from FlowPersistenceProvider when empâ¦
â¦ty DB AND when instance of MetadataAwareFlowPersistenceProvider
You can merge this pull request into a Git
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3041#discussion_r228563247
--- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/pom.xml ---
@@ -147,6 +147,12 @@
2.2.1
test
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3041#discussion_r228542809
--- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/pom.xml ---
@@ -147,6 +147,12 @@
2.2.1
test
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3106
Looks good, will merge
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/3104
NIFI-5740 Ensuring permissions are restored after test completes in Tâ¦
â¦estFetchFile
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3079#discussion_r227125269
--- Diff:
nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/processors/parquet/utils/ParquetBuilderProperties.java
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3079
Busy with some other things at the moment, but will take a look when I get
a chance.
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/3096
NIFI-5721 Fixing connection handling in MQTT processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user bbende closed the pull request at:
https://github.com/apache/nifi/pull/3095
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/3095
NIFI-5673 Fixing connection handling in MQTT processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3079#discussion_r226020300
--- Diff:
nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/processors/parquet/ConvertAvroToParquet.java
---
@@ -0,0
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3079#discussion_r226017591
--- Diff:
nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/processors/parquet/ConvertAvroToParquet.java
---
@@ -0,0
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3079#discussion_r226021329
--- Diff:
nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/processors/parquet/ConvertAvroToParquet.java
---
@@ -0,0
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3079#discussion_r226019319
--- Diff:
nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/processors/parquet/ConvertAvroToParquet.java
---
@@ -0,0
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3079#discussion_r226018942
--- Diff:
nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/processors/parquet/ConvertAvroToParquet.java
---
@@ -0,0
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3079#discussion_r226017678
--- Diff:
nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/processors/parquet/ConvertAvroToParquet.java
---
@@ -0,0
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/3088
NIFI-5719 Ensuring FetchFile routes to failure if the move completionâ¦
⦠strategy can't be completed
Thank you for submitting a contribution to Apache NiFi.
In ord
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3079
@MikeThomsen the advantage is not having to write the parquet out to local
disk somewhere, and then have a disconnected flow where another part reads it
back in. With this approach the data stays in
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3082
Looks good, verified the functionality and will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3082
Reviewing...
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/3081
NIFI-5708 Fixing the creation of ValidationContextFactory for controlâ¦
â¦ler services so it uses the ComponentVariableRegistry and not the
file-based instance
Thank you for submitting a
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3057
Looks good to me, was able to verify the functionality, going to merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3070
Verified this fixes the issue, looks good to me.
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/3065
NIFI-5680 Handling trailing slashes on URLs of registry clients
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3057
Ok using your test.avro going into PutORC with an AvroReader that uses
embedded schema I can get the error you showed earlier.
I also tested ConvertRecord using the AvroReader and JsonWrtier
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3057
@VikingK in your schema it has OItems defined as an array, but then in the
JSON OItems is not an array, its an object with a field called array. So
running with that schema and example JSON I get
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/3040
I agree with the points made by @joewitt , although this PR did make me
compare what we are doing for processors vs. controller services...
I noticed that for processors the try/catch wraps
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3041#discussion_r222379389
--- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/pom.xml ---
@@ -147,6 +147,12 @@
2.2.1
test
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3041#discussion_r222376374
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrProcessor.java
---
@@ -176,70 +172,11
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3041#discussion_r222377115
--- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-client-api/pom.xml ---
@@ -0,0 +1,68 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmln
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/143
NIFIREG-201 Refactoring project structure to better isolate extensions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/142
This looks good and I'll merge to master.
Something I noticed while reviewing this (not a result of anything in this
PR), is that the nifi-registry-extensions modules are impact
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/142
Reviewing..
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/140
NIFIREG-199 - Adding interfaces to represent configurable components â¦
â¦and extension components
You can merge this pull request into a Git repository by running:
$ git pull https
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/139
+1 looks good and will merge, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2995
I believe the existing code in the finally block was there as a result of
an older approach where locking was being performed in the revision manager,
but since that is no longer needed, I believe it
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2995
NIFI-5577 Fixing update method in NaiveRevisionManager so that failedâ¦
⦠updates don't change the revision
Thank you for submitting a contribution to Apache NiFi.
In ord
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2959
Verified that I am now able to start up a cluster without explicitly
specifying a sensitive properties key, same as it previously worked before this
issue, thanks Andy! Will merge shortly
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2939
Code looks good and verified stats functionality from using the
application, once the license headers are resolved I am a +1
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2939
Just started reviewing, there are a bunch of files with missing license
headers...
```
[WARNING] Files with unapproved licenses:
/home/travis/build/apache/nifi/nifi-nar-bundles/nifi
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/136
Looks good to me, will merge, thanks!
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/136#discussion_r209961895
--- Diff:
nifi-registry-data-model/src/main/java/org/apache/nifi/registry/flow/VersionedConnection.java
---
@@ -134,6 +139,36 @@ public void
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/133#discussion_r209132775
--- Diff:
nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/hook/AbstractEventHookProvider.java
---
@@ -0,0 +1,72
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2939
Will review...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2930
I think the primary concern is ensuring that existing flows behave the same
as they currently do, which means the default behavior needs to apply the file
filter to files and directories, and then
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2930
Will review...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2866
@pepov your description of the various kerberos options is correct, and the
SPNEGO approach is definitely the traditional way kerberos is intended to work.
The direct login is definitely more
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2913
Actually, I take back my last comment, I now see where the value is
obtained and it does have the logic:
```
String propertyValue = propertyDescriptor.isExpressionLanguageSupported
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2913
I think you will also need to find where the group id property is used and
ensure that evaluateAttributeExpressions() is called when obtaining the value.
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r204390557
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/resources/docs/org.apache.nifi.processors.network.ParseNetflowv5
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2820
I haven't looked at any of the code so keep that in mind :)
If we are talking about NiFi templates, then they are just examples of how
to use a processor or set of processors, which yo
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2900
Looks good, merging, thanks!
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2900#discussion_r203060708
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
1 - 100 of 940 matches
Mail list logo
