[GitHub] nifi pull request #3207: NIFI-5879: Fixed bug in FileSystemRepository that c...

2018-12-06 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3207 NIFI-5879: Fixed bug in FileSystemRepository that can occur if an Inp… …utStream is obtained, then more data is written to the Content Claim - the InputStream would end before allowing the

[GitHub] nifi issue #3192: NIFI-5859: Added XML-based documentation writer that can b...

2018-12-05 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3192 OK @bbende I have pushed new commits that I believe address all of the concerns above. ---

[GitHub] nifi pull request #3192: NIFI-5859: Added XML-based documentation writer tha...

2018-12-05 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3192#discussion_r239102417 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-standard-services-api-nar/pom.xml --- @@ -26,6 +26,12 @@ true

[GitHub] nifi pull request #3192: NIFI-5859: Added XML-based documentation writer tha...

2018-12-05 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3192#discussion_r239102517 --- Diff: nifi-api/src/main/java/org/apache/nifi/documentation/AbstractDocumentationWriter.java --- @@ -0,0 +1,301 @@ +/* + * Licensed to the

[GitHub] nifi pull request #3192: NIFI-5859: Added XML-based documentation writer tha...

2018-12-05 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3192#discussion_r239101308 --- Diff: nifi-api/src/main/java/org/apache/nifi/documentation/AbstractDocumentationWriter.java --- @@ -0,0 +1,301 @@ +/* + * Licensed to the

[GitHub] nifi pull request #3202: NIFI-5868: Added instrumentation around ListFile su...

2018-12-05 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3202 NIFI-5868: Added instrumentation around ListFile such that all disk a… …ccesses are timed and any unusually long listing times or disk access operations can be logged. Additionally, information

[GitHub] nifi pull request #3198: NIFI-5867 - add thread() EL function to get thread ...

2018-12-04 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3198#discussion_r238848651 --- Diff: nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/ThreadEvaluator.java

[GitHub] nifi pull request #3192: NIFI-5859: Added XML-based documentation writer tha...

2018-11-30 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3192 NIFI-5859: Added XML-based documentation writer that can be used to d… …ocument a component. - Found several instances of nifi-framework-api's ProviderException being thrown

[GitHub] nifi-maven pull request #7: NIFI-5859: Build NAR Extension Definitions/docs ...

2018-11-30 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi-maven/pull/7 NIFI-5859: Build NAR Extension Definitions/docs at build time You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi-maven NIFI-5859

[GitHub] nifi pull request #3173: NIFI-5824: Added unit test to FlowController to ens...

2018-11-15 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3173 NIFI-5824: Added unit test to FlowController to ensure that the Proce… …ssScheduler that it creates is properly initialized. Also updated the properties file used by TestFlowController to use a

[GitHub] nifi pull request #3171: NIFI-5822: Ensure that we don't call FlowController...

2018-11-15 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3171 NIFI-5822: Ensure that we don't call FlowController.getControllerServ… …iceProvider() before the ControllerServiceProvider has been initialized Thank you for submitting a contrib

[GitHub] nifi pull request #3168: NIFI-5814: Addressed issue in DatabaseReader class ...

2018-11-12 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3168 NIFI-5814: Addressed issue in DatabaseReader class that was attemptin… …g to set values on the JSON returned by MaxMind. Instead of modifying the object directly, we should use an Injectable in

[GitHub] nifi issue #3131: NIFI-3229 When a queue contains only Penalized FlowFile's ...

2018-11-12 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3131 @patricker you're right - it may perform just fine. However, the concern is not that we are holding a lock longer but rather that we are obtaining it twice as often now when there's data q

[GitHub] nifi issue #3111: NIFI-5757 AvroRecordSetWriter - Fix for slow synchronized ...

2018-11-09 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3111 @arkadius I did a good bit of testing and wasn't able to break anything. Thanks for the improvements! +1, I have merged to master. ---

[GitHub] nifi issue #3131: NIFI-3229 When a queue contains only Penalized FlowFile's ...

2018-11-09 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3131 @patricker thanks for the PR! I had gone down this path before but I backed out the changes. The changes in this PR will result in obtaining a Write Lock on the queue of every incoming connection

[GitHub] nifi issue #3100: NIFI-5718: Implemented LineDemarcator and removed NLKBuffe...

2018-11-09 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3100 @patricker done. On a 3-year-old Macbook Pro, looks like the LineDemarcator is able to demarcate 10 MM lines in about 350 millis. Just as a point of reference :) ---

[GitHub] nifi pull request #3163: NIFI-5809: If QueryRecord has a single-column proje...

2018-11-09 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3163 NIFI-5809: If QueryRecord has a single-column projection and that res… …ults in a null value, do not confuse that with a null value being returned from the Record Reader Thank you for

[GitHub] nifi issue #3111: NIFI-5757 AvroRecordSetWriter - Fix for slow synchronized ...

2018-11-09 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3111 @arkadius thanks for the update! Code review looks good. All unit tests and contrib-check pass. This does touch some super heavily used processors, though, like UpdateAttribute, so I'll want to

[GitHub] nifi pull request #3161: Increase timeouts in unit tests to avoid frequent f...

2018-11-09 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/3161 ---

[GitHub] nifi issue #3161: Increase timeouts in unit tests to avoid frequent failures

2018-11-09 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3161 Thanks @ijokarumawak ---

[GitHub] nifi issue #3160: NIFI-5805: Pool the BinaryEncoders used by the WriteAvroRe...

2018-11-09 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3160 New commit pushed. ---

[GitHub] nifi issue #3160: NIFI-5805: Pool the BinaryEncoders used by the WriteAvroRe...

2018-11-09 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3160 @ijokarumawak thanks for the review - and all great points! New commit coming momentarily. ---

[GitHub] nifi pull request #3100: NIFI-5718: Implemented LineDemarcator and removed N...

2018-11-09 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3100#discussion_r232267315 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/RepeatingInputStream.java --- @@ -0,0 +1,103 @@ +/* + * Licensed to the

[GitHub] nifi pull request #3161: Increase timeouts in unit tests to avoid frequent f...

2018-11-08 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3161 Increase timeouts in unit tests to avoid frequent failures Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi issue #3160: NIFI-5805: Pool the BinaryEncoders used by the WriteAvroRe...

2018-11-08 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3160 Performance difference when iterating 10 million times, each time creating a new avro writer and writing a single record, was an improvement from about 58 seconds to about 12 seconds. So

[GitHub] nifi pull request #3160: NIFI-5805: Pool the BinaryEncoders used by the Writ...

2018-11-08 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3160 NIFI-5805: Pool the BinaryEncoders used by the WriteAvroResultWithExt… …ernalSchema writer. Unfortunately, the writer that embeds schemas does not allow for this optimization due to the Avro

[GitHub] nifi pull request #3157: NIFI-5800: Do not recursively call hashCode on chil...

2018-11-07 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3157 NIFI-5800: Do not recursively call hashCode on child schema for Recor… …d Field Types Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #3138: NIFI-5798:Fixed bug in FlattenJson that was escapin...

2018-11-07 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3138 NIFI-5798:Fixed bug in FlattenJson that was escaping text as Java ins… …tead of escaping as JSON Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi pull request #3136: NIFI-5796: Addressed issue that caused Counters' va...

2018-11-06 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3136 NIFI-5796: Addressed issue that caused Counters' values to show the w… …rong value in Status History Thank you for submitting a contribution to Apache NiFi. In ord

[GitHub] nifi pull request #3132: NIFI-5769: Refactored FlowController to use Composi...

2018-11-05 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3132 NIFI-5769: Refactored FlowController to use Composition over Inheritance Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi issue #3111: NIFI-5757 AvroRecordSetWriter - Fix for slow synchronized ...

2018-11-05 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3111 @arkadius thanks for compiling that list. Sorry it took so long to reply! Looking through the list, I do think you're right - these all appear to be the same pattern. I certainly didn't re

[GitHub] nifi issue #3119: NIFI-5673 Support auto loading of new NARs

2018-11-01 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3119 Thanks @bbende all is looking good. Was able to test and everything works as expected. +1 merged to master. ---

[GitHub] nifi pull request #3119: NIFI-5673 Support auto loading of new NARs

2018-11-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3119#discussion_r230116442 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils/src/main/java/org/apache/nifi/nar/NarLoader.java

[GitHub] nifi pull request #3119: NIFI-5673 Support auto loading of new NARs

2018-11-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3119#discussion_r230117182 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils/src/main/java/org/apache/nifi/nar/NarLoader.java

[GitHub] nifi pull request #3119: NIFI-5673 Support auto loading of new NARs

2018-11-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3119#discussion_r230119940 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils/src/main/java/org/apache/nifi/nar/NarAutoLoaderTask.java

[GitHub] nifi pull request #3119: NIFI-5673 Support auto loading of new NARs

2018-11-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3119#discussion_r230120979 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils/src/main/java/org/apache/nifi/nar/NarAutoLoader.java

[GitHub] nifi pull request #3119: NIFI-5673 Support auto loading of new NARs

2018-11-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3119#discussion_r230121837 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils/src/main/java/org/apache/nifi/nar/NarAutoLoaderTask.java

[GitHub] nifi pull request #3119: NIFI-5673 Support auto loading of new NARs

2018-11-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3119#discussion_r230120699 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils/src/main/java/org/apache/nifi/nar/NarAutoLoader.java

[GitHub] nifi issue #3119: NIFI-5673 Support auto loading of new NARs

2018-11-01 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3119 Will review... ---

[GitHub] nifi pull request #3118: NIFI-5771: Ensure that we only increment claimant c...

2018-10-31 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3118 NIFI-5771: Ensure that we only increment claimant count for content c… …laim if we have a FlowFile that references it Thank you for submitting a contribution to Apache NiFi. In

[GitHub] nifi pull request #3100: NIFI-5718: Implemented LineDemarcator and removed N...

2018-10-31 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3100#discussion_r229685801 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/RepeatingInputStream.java --- @@ -0,0 +1,103 @@ +/* + * Licensed to the

[GitHub] nifi pull request #3100: NIFI-5718: Implemented LineDemarcator and removed N...

2018-10-31 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3100#discussion_r229685528 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/RepeatingInputStream.java --- @@ -0,0 +1,103 @@ +/* + * Licensed to the

[GitHub] nifi issue #3111: NIFI-5757 AvroRecordSetWriter - Fix for slow synchronized ...

2018-10-30 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3111 @arkadius I am not familiar with caffeine but it looks promising. A quick glance through the LICENSE indicates that it is compatible and has only a single dependency on Google Guava, which is also

[GitHub] nifi issue #3111: NIFI-5757 AvroRecordSetWriter - Fix for slow synchronized ...

2018-10-29 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3111 @arkadius fair enough. I'd be okay with a soft limit. ---

[GitHub] nifi issue #3111: NIFI-5757 AvroRecordSetWriter - Fix for slow synchronized ...

2018-10-29 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3111 @arkadius thanks for the contribution. I don't think this is the right approach, however, As-is, the code ensures that we don't hold any more than a set number of entries in the cache. Th

[GitHub] nifi pull request #3110: NIFI-5752: Load balancing fails with wildcard certs

2018-10-26 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3110#discussion_r228534325 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server

[GitHub] nifi pull request #3109: NIFI-5746: Use Node Identifier's node address inste...

2018-10-25 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3109#discussion_r228206921 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server

[GitHub] nifi pull request #3109: NIFI-5746: Use Node Identifier's node address inste...

2018-10-24 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3109 NIFI-5746: Use Node Identifier's node address instead of getting from… … socket for RECEIVE prov events; make SEND prov events match syntax of RECEIVE prov events Thank yo

[GitHub] nifi pull request #3108: NIFI-5745: When determining if backpressure should ...

2018-10-24 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3108 NIFI-5745: When determining if backpressure should be applied across … …nodes for load balancing, only consider if the local partition has reached the threshold limits instead of considering

[GitHub] nifi pull request #3106: NIFI-5741: When returning a ConnectionFactory from ...

2018-10-23 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3106 NIFI-5741: When returning a ConnectionFactory from the JndiJmsConnect… …ionFactoryProvider, ensure that we wrap the ConnectionFactory so that any calls to the ConnectionFactory happen within

[GitHub] nifi pull request #3033: NIFI-5629 GetFile vast listing performance

2018-10-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3033#discussion_r227385563 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFile.java --- @@ -308,32

[GitHub] nifi pull request #3033: NIFI-5629 GetFile vast listing performance

2018-10-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3033#discussion_r227081243 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFile.java --- @@ -308,32

[GitHub] nifi issue #3085: NIFI-5711 NLKBufferedReader appears extend and copy portio...

2018-10-22 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3085 @patricker you do have a good point... interestingly, though, that's not a bug introduced in your PR, as the call to `readLine()` that existed before would also never check the max buffer size

[GitHub] nifi pull request #3101: NIFI-5736: Removed 'synchronized' keyword from Swap...

2018-10-22 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3101 NIFI-5736: Removed 'synchronized' keyword from SwappablePriorityQueue… …#getProperties - the method should not be synchronized, as it guards access to member variables via a Read

[GitHub] nifi pull request #3100: NIFI-5718: Implemented LineDemarcator and removed N...

2018-10-22 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3100 NIFI-5718: Implemented LineDemarcator and removed NLKBufferedReader i… …n order to improve performance Thank you for submitting a contribution to Apache NiFi. In order to

[GitHub] nifi issue #3085: NIFI-5711 NLKBufferedReader appears extend and copy portio...

2018-10-17 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3085 @patricker thanks for the submission! I did a code review and everything looks correct to me. I did some testing and verified everything. However, I did notice difference in performance between this

[GitHub] nifi issue #3085: NIFI-5711 NLKBufferedReader appears extend and copy portio...

2018-10-17 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3085 Will review... ---

[GitHub] nifi pull request #3083: NIFI-5709, NIFI-5710: Addressed issue that causes N...

2018-10-16 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3083 NIFI-5709, NIFI-5710: Addressed issue that causes NiFi to not be able… … to read provenance events when the a new FlowFile is created and then auto-terminated in the same session; minor bug

[GitHub] nifi issue #3060: NIFI-5678: Fixed MAP type support of MapRecord objects in ...

2018-10-15 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3060 Thanks @mattyb149 all looks good to me, was able to verify that the unit test performs as expected and manual testing (including the example from the dev@ mailing list, where I think this JIRA

[GitHub] nifi issue #2991: NIFI-3469: multipart request support added to HandleHttpRe...

2018-10-15 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2991 @ekovacs thanks for the improvement! It appears that Koji is happy with everything now, and a quick code review looks good to me as well. I was able to test locally and all works as expected. +1

[GitHub] nifi pull request #3070: NIFI-5695: Fixed bug that caused ports to not prope...

2018-10-12 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3070 NIFI-5695: Fixed bug that caused ports to not properly map to their c… …orrect child group on Flow Import if the child group is independently versioned Thank you for submitting a

[GitHub] nifi issue #3065: NIFI-5680 Handling trailing slashes on URLs of registry cl...

2018-10-12 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3065 Thanks @bbende, all looks good to me. +1 merged to master. ---

[GitHub] nifi issue #3062: NIFI-5686: Updated StandardProcessScheduler so that if it ...

2018-10-12 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3062 @joewitt thanks, I've pushed another commit. ---

[GitHub] nifi issue #2994: NIFI-1490: multipart/form-data support for ListenHTTP proc...

2018-10-11 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2994 Thanks for the PR @ekovacs! This looks good to me. I found a couple of minor typos but just fixed before pushing. Was able to test and verify behavior and code looks great. +1 merged to master. ---

[GitHub] nifi pull request #3064: NIFI-5688: Ensure that when we map our flow to a Ve...

2018-10-11 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3064 NIFI-5688: Ensure that when we map our flow to a VersionedProcessGrou… …p that we include the connections' Load Balance Compression flag Thank you for submitting a contributi

[GitHub] nifi pull request #3052: NIFI-5666 Updated all usages of Spring, beanutils, ...

2018-10-11 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3052#discussion_r224502224 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/scheduling

[GitHub] nifi pull request #3062: NIFI-5686: Updated StandardProcessScheduler so that...

2018-10-11 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3062 NIFI-5686: Updated StandardProcessScheduler so that if it fails to sc… …hedule a Reporting Task, it re-schedules the @OnScheduled task instead of looping and calling Thread.sleep. As it was

[GitHub] nifi pull request #3056: NIFI-5659 Add documentation for Offloading Nodes fu...

2018-10-11 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3056#discussion_r224463328 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -3939,8 +3976,7 @@ to the cluster. It provides an additional layer of security. This

[GitHub] nifi pull request #3054: NIFI-5672: Do not compare Load Balancing address/po...

2018-10-09 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3054 NIFI-5672: Do not compare Load Balancing address/port for logical equ… …ivalence of Node Identifiers. Added more details to logging of Node Identifiers Thank you for submitting a

[GitHub] nifi pull request #3048: NIFI-5663: Ensure that when sort Node Identifiers t...

2018-10-05 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3048 NIFI-5663: Ensure that when sort Node Identifiers that we use both th… …e node's API Address as well as API Port, in case 2 nodes are running on same host. Also ensure that when Local No

[GitHub] nifi pull request #3047: NIFI-5663: Ensure that when sort Node Identifiers t...

2018-10-05 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/3047 ---

[GitHub] nifi pull request #3047: NIFI-5663: Ensure that when sort Node Identifiers t...

2018-10-05 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3047 NIFI-5663: Ensure that when sort Node Identifiers that we use both the node's API Address as well as API Port, in case 2 nodes are running on same host. Also ensure that when Local Node

[GitHub] nifi pull request #2947: NIFI-5516: Implement Load-Balanced Connections

2018-10-04 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/2947 ---

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-10-04 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r222658059 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -3929,6 +3929,13 @@ from the remote node before considering the communication with

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-10-04 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r222658327 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FileSystemSwapManager.java

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-10-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r222331537 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowSynchronizer.java

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-10-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r222331356 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-10-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r222330395 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FileSystemSwapManager.java

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-10-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r221729013 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server

[GitHub] nifi issue #2947: [WIP] NIFI-5516: Implement Load-Balanced Connections

2018-10-01 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2947 @jtstorck @ijokarumawak thanks for the time that you guys have put into reviewing this! I just pushed a new commit, which I believe addresses the feedback above. It also updates the dependency on

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-10-01 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r221641452 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r221013395 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/partition

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r220982191 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r220979881 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r220979549 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/diagnostics

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r220979317 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/diagnostics

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r220978179 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r220976418 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/partition

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r220975941 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/client/async/nio

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r220975792 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/partition

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r220975068 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/AbstractFlowFileQueue.java

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-27 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r220975312 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/client/async/nio

[GitHub] nifi pull request #2979: [WIP] An experiment that I am looking at to elimina...

2018-09-27 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/2979 ---

[GitHub] nifi pull request #3036: NIFI-5640: Improved efficiency of Avro Reader and s...

2018-09-27 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3036 NIFI-5640: Improved efficiency of Avro Reader and some methods of Avr… …oTypeUtil. Also switched ServiceStateTransition to using read/write locks instead of synchronized blocks because

[GitHub] nifi issue #3029: NIFI-5633 - allDelineatedValues can throw ArrayIndexOutOfB...

2018-09-25 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3029 @pvillard31 thanks for the fix and for providing great test cases! +1 merged to master. ---

[GitHub] nifi pull request #3030: NIFI-5634: When merging RPG entities, ensure that w...

2018-09-25 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3030 NIFI-5634: When merging RPG entities, ensure that we only send back t… …he ports that are common to all nodes - even if that means sending back no ports Thank you for submitting a

[GitHub] nifi pull request #3027: NIFI-5618: Avoid NPE when viewing Provenance Event ...

2018-09-24 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3027 NIFI-5618: Avoid NPE when viewing Provenance Event details on a disco… …nnected node Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #3026: NIFI-5630: Ensure that we include counters in Statu...

2018-09-24 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3026 NIFI-5630: Ensure that we include counters in Status History when pre… …sent Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the

[GitHub] nifi pull request #2954: NIFI-5514: Fixed bugs in MergeRecord around minimum...

2018-09-24 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2954#discussion_r219837666 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MergeRecord.java --- @@ -304,13

[GitHub] nifi issue #3010: [WIP] NIFI-5585

2018-09-21 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3010 @jtstorck I did just run into an issue that we will need to address. If we decommission 2 nodes at the same time (say Node 2 and Node 3) then we can end up in a state where Node 2 is trying to send

  1   2   3   4   5   6   7   8   9   10   >