Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r135044207
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/resources/nifi/fingerprint/flow1a.xml
---
@@ -31,7 +31,7
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r135044225
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/resources/nifi/fingerprint/flow1b.xml
---
@@ -33,7 +33,7
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
hey @cammachusa sorry for gap in time, been pretty busy. I don't know if
this is the best way to do it, but here's a shot :)
First reset your `HEAD` inside your branch to the last
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
You could push my force push my commit to this PR and that'll be fine, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
@cammachusa - I updated my branch with a rebase, will you pull it down,
make sure things are good for you and then force push it to this review?
Thanks!!
---
If your project is set up
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
I am going to be going through my final rounds of testing, so by the end of
this week, I promise :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
False alarm, I got it now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
@cammachusa I'm having a hard time getting your new commits...as well as
even understanding how I got them in the first place.
@joewitt am I missing something regarding getting the new
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
@cammachusa seems I can't update this PR with my own code. My changes are
below so you can merge them in and then push them again.
https://github.com/rickysaltzer/nifi/commit
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
I've made some changes that allows the tests to run successfully. I'm going
to test out this in an actual NiFi installation and then provide you my
changes. Unfortunately this may not happen
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
@cammachusa thanks for the reminder :) - I've been a bit busy due to
business travel.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
Hey @cammachusa - I will take a look today..been traveling.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
@cammachusa thanks! I think maybe you need to change the arguments given to
your method once you use `OnEnabled`. I think it switches to
`ConfigurationContext` instead of `ProcessContext
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
@cammach @cammachusa
Still seeing this error - what did you do to fix it?
testSkipHeadLineTrue(org.apache.nifi.processors.kudu.TestPutKudu) Time
elapsed: 0.001 sec
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
I've got your changes locally to do some testing, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r131244333
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
---
@@ -0,0 +1,233
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r131242503
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
---
@@ -0,0 +1,233
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
I will continue reviewing later today or tomorrow, thanks for your
patience.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/2020
@joewitt might be the best person to answer @cammachusa's question
regarding Travis. I seem to recall that it can be finicky, but not 100% the
current state of CI stability.
---
If your
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r130409278
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
---
@@ -0,0 +1,232
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r130400960
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
---
@@ -84,6 +86,14
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r130400374
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
---
@@ -84,6 +86,14
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r130158483
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
---
@@ -0,0 +1,191
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r129937204
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
---
@@ -0,0 +1,191
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r129937107
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
---
@@ -0,0 +1,191
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r129936165
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java
---
@@ -0,0 +1,191
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r129933513
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/PutKudu.java
---
@@ -0,0 +1,120
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2020#discussion_r129928513
--- Diff:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/PutKudu.java
---
@@ -0,0 +1,120
Github user rickysaltzer closed the pull request at:
https://github.com/apache/nifi/pull/188
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rickysaltzer closed the pull request at:
https://github.com/apache/nifi/pull/285
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rickysaltzer commented on the issue:
https://github.com/apache/nifi/pull/285
@trixpan thanks for the reminder, closing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/850#discussion_r75538007
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/TestDeleteHDFS.java
---
@@ -0,0 +1,187
Github user rickysaltzer commented on a diff in the pull request:
https://github.com/apache/nifi/pull/850#discussion_r75537912
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/DeleteHDFS.java
---
@@ -0,0 +1,161
GitHub user rickysaltzer opened a pull request:
https://github.com/apache/nifi/pull/850
NIFI-2547: Add DeleteHDFS Processor
This processor adds the capability to delete files or
directories inside of HDFS.
Paths supports both static and expression language values
34 matches
Mail list logo
