[GitHub] nifi issue #2364: NIFI-4538 - Add Process Group information to...

2018-02-17 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2364 @mcgilman Implementation of the nearest versioned group is done. ---

[GitHub] nifi issue #2364: NIFI-4538 - Add Process Group information to...

2018-02-03 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2364 @mcgilman In my experience, the top level group information was not really as useful as the parent one. So I don't mind the change you proposed. Anyway, @mattyb149 should be asked since he

[GitHub] nifi issue #2364: NIFI-4538 - Add Process Group information to...

2018-01-28 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2364 @mcgilman The merge conflict should be resolved now. ---

[GitHub] nifi issue #2157: NIFI-4390 - Add a keyboard shortcut for Connection...

2018-01-17 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2157 @mcgilman This PR was created solely in order to speed up the connection creation. There was a follow-up discussion at https://issues.apache.org/jira/browse/NIFI-4390. So I'm not sure

[GitHub] nifi pull request #2222: NIFI-3926 - Edit Template information

2018-01-07 Thread yuri1969
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/#discussion_r160052865 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java

[GitHub] nifi issue #2364: NIFI-4538 - Add Process Group information to...

2018-01-05 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2364 @mcgilman OK, I'll redesign the REST API change to a non-breaking one. ---

[GitHub] nifi issue #2364: NIFI-4538 - Add Process Group information to...

2017-12-31 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2364 The PG names/IDs display style improvements are welcomed. Note: The `GET flow/search-results` API was changed. ---

[GitHub] nifi pull request #2364: NIFI-4538 - Add Process Group information to...

2017-12-31 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2364 NIFI-4538 - Add Process Group information to... ...Search results * Separated the search functionality. * Added a unit test. * Added the PG info to UI (a mere draft

[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...

2017-12-18 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2269 About that _close/done/ok_ button, currently the advanced UI is implemented as an `iframe` inside `nfShell`. The close 'X' button is a part of to the `nfShell`. So for closing down the advanced UI

[GitHub] nifi pull request #2269: NIFI-4400 - Advanced UI with code editor for...

2017-12-09 Thread yuri1969
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2269#discussion_r155931362 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-ui/src/main/frontend/package.json --- @@ -0,0 +1,12 @@ +{ + "name&qu

[GitHub] nifi pull request #2269: NIFI-4400 - Advanced UI with code editor for...

2017-12-09 Thread yuri1969
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2269#discussion_r155931287 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-ui/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,61 @@ +nifi-transform-json-ui

[GitHub] nifi pull request #2269: NIFI-4400 - Advanced UI with code editor for...

2017-12-09 Thread yuri1969
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2269#discussion_r155931289 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-ui/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,61 @@ +nifi-transform-json-ui

[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...

2017-11-19 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2269 Good points @moranr. Thanks. ---

[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...

2017-11-14 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2269 @scottyaslan Thank you for the kind words. I'll check the issues you mentioned. The AngularJS choice was made in order to keep it consistent with the rest of the existing advanced UI

[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...

2017-11-11 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2269 @pvillard31 I'll look into the 'X' button behavior. I was thinking about making the 'save' button as save & close as well. But this way it felt more _natural_ to me. I'll think this over, ---

[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...

2017-11-10 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2269 Any suggestions are welcome. I'm not sure whether the license of new CodeMirror modes is handled properly. Please check that, thanks. ---

[GitHub] nifi pull request #2269: NIFI-4400 - Advanced UI with code editor for...

2017-11-10 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2269 NIFI-4400 - Advanced UI with code editor for... ...scripted processors Enabled a simple code editor in a form of an Advanced UI based on the nifi-jolt-transform-json-ui. The editor

[GitHub] nifi pull request #2195: NIFI-4402 - Add component location in Summary view

2017-11-09 Thread yuri1969
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2195#discussion_r150084382 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/summary/nf-summary-table.js --- @@ -417,7 +426,7

[GitHub] nifi pull request #2222: NIFI-3926 - Edit Template information

2017-10-22 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/ NIFI-3926 - Edit Template information * Added a new edit dialog to 'Global Menu - Templates'. * Omitted Process Group Id editing functionality. * Added a unit test for template DAO update

[GitHub] nifi issue #2200: NIFI-4470 - Variables Registry: Increase space...

2017-10-09 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2200 @scottyaslan You are welcome. I'm afraid, I don't have permissions to assign JIRA Issues to myself. Who should I ask to elevate my JIRA permissions? Thanks. ---

[GitHub] nifi pull request #2200: NIFI-4470 - Variables Registry: Increase space...

2017-10-07 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2200 NIFI-4470 - Variables Registry: Increase space... ...between Bulletin icon and Controller Service name Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi pull request #2195: NIFI-4402 - Add component location in Summary view

2017-10-05 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2195 NIFI-4402 - Add component location in Summary view Implemented as described in the issue. Improvements are welcome. Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi issue #2178: NIFI-4423 - Add a confirmation of a Counter...

2017-10-05 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2178 @mcgilman Sorry about that missing sanitization. ---

[GitHub] nifi pull request #2178: NIFI-4423 - Add a confirmation of a Counter...

2017-09-26 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2178 NIFI-4423 - Add a confirmation of a Counter... ...reset action Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi issue #2170: NIFI-3803 - Allow use of up/down arrow keys...

2017-09-23 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2170 @mcgilman - Thanks for pointing out this one. I forgot to include the _Add Reporting Task_ dialog completely... - Now the `nfFilteredDialogCommon` should follow the SlickGrid's PageUp/Down

[GitHub] nifi pull request #2157: NIFI-4390 - Add a keyboard shortcut for Connection....

2017-09-17 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2157 NIFI-4390 - Add a keyboard shortcut for Connection... ...related dialogs Connection related dialogs can be confirmed by the Enter key. Thank you for submitting a contribution

[GitHub] nifi pull request #2152: NIFI-3369 - Disable "Add" button on new connection ...

2017-09-12 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2152 NIFI-3369 - Disable "Add" button on new connection dialog if no relationships selected Disabled confirmation button for both Create and Configure Connection dialogs when no re

[GitHub] nifi pull request #2126: NIFI-4347 - Extend documentation with...

2017-09-03 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2126 NIFI-4347 - Extend documentation with... ...double-click shortcuts info Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #2124: NIFI-3941 - Clarify tab name for controller...

2017-09-01 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2124 @alopresto There already is an info sentence at the bottom. Should the dialog really contain two info sentences? --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request #2124: NIFI-3941 - Clarify tab name for controller...

2017-09-01 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2124 NIFI-3941 - Clarify tab name for controller... ...level controller services dialog * Changed the tab title since sharing the name makes things less clear for newcomers. * Suggested

[GitHub] nifi issue #2100: NIFI-2715 - When performing a Queue Listing, if...

2017-08-23 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2100 @scottyaslan The text's style should match the one used on detail values now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #2102: NIFI-3781 - Controller Service Config Dialog...

2017-08-21 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2102 @moranr @scottyaslan Changed the tooltip to _View Configuration_. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #2102: NIFI-3781 - Controller Service Config Dialog...

2017-08-20 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2102 NIFI-3781 - Controller Service Config Dialog... ..'View Details' button feels confusing and inconsistent with Processors * Merged 'View Details' and 'Edit' buttons to a single 'Configure

[GitHub] nifi pull request #2100: NIFI-2715 - When performing a Queue Listing, if...

2017-08-18 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2100 NIFI-2715 - When performing a Queue Listing, if... ...FlowFile has no content, UI does not indicate this fact For FlowFiles with no content: * Added a simple title replacing the Content

[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...

2017-08-14 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2081 A misclick, sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #2081: NIFI-3780 - Should be able to specify Service...

2017-08-14 Thread yuri1969
GitHub user yuri1969 reopened a pull request: https://github.com/apache/nifi/pull/2081 NIFI-3780 - Should be able to specify Service... ...name when I create a new Controller Service within a Processor/Service configuration dialog I'm not sure how to integrate/style

[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...

2017-08-14 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2081 OK, @scottyaslan and @moranr. I'll try to push an update tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #2081: NIFI-3780 - Should be able to specify Service...

2017-08-14 Thread yuri1969
Github user yuri1969 closed the pull request at: https://github.com/apache/nifi/pull/2081 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #2081: NIFI-3780 - Should be able to specify Service...

2017-08-13 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2081 NIFI-3780 - Should be able to specify Service... ...name when I create a new Controller Service within a Processor/Service configuration dialog I'm not sure how to integrate/style the text

[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config

2017-08-07 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @pvillard31 - The reverting PR is #2064. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #2064: NIFI-4271 - Revert double-click behavior back...

2017-08-07 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2064 NIFI-4271 - Revert double-click behavior back... ...to delete a bend point Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config

2017-08-07 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @pvillard31 - I will submit a new PR to revert the current bend points behavior later today or tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #2059: NIFI-1027 - Treat label and node of a provenance

2017-08-05 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2059 NIFI-1027 - Treat label and node of a provenance ...graph event as one unit The JIRA issue asks for treating both node and its label as one unit. Described cursor issues seems

[GitHub] nifi pull request #2058: NIFI-4266 - Allow double-click to display Event

2017-08-05 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2058 NIFI-4266 - Allow double-click to display Event ...details Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config

2017-07-31 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @scottyaslan OK, but I'm afraid the merged version still has the `quickSelect` activated for mid nodes/bends. It seems this should be removed. --- If your project is set up for it, you can reply

[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config

2017-07-27 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 - I find it natural to double-click on the 'line' when I want to add a new bend. - In order to check connection's config I would try to double-click on its rectangular stats box

[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config

2017-07-27 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @scottyaslan Thanks. So the problem is just with the start and end nodes, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config

2017-07-26 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @scottyaslan It seems I omitted `quickSelect` activation for both start and end "nodes". Please, can you confirm that a double-click displays the connection configuration dialog when

[GitHub] nifi-site pull request #21: NIFI-4219 - Describe partial builds in Quickstar...

2017-07-24 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi-site/pull/21 NIFI-4219 - Describe partial builds in Quickstart ... guide Suggestions are welcome. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi pull request #2009: NIFI-1580 - Allow double-click to display config

2017-07-20 Thread yuri1969
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2009#discussion_r128583974 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-graph.js --- @@ -198,13 +201,13

[GitHub] nifi pull request #2009: NIFI-1580 - Allow double-click to display config

2017-07-17 Thread yuri1969
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2009#discussion_r127677617 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-graph.js --- @@ -198,13 +201,13

[GitHub] nifi pull request #2009: NIFI-1580 - Allow double-click to display config

2017-07-13 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2009 NIFI-1580 - Allow double-click to display config * Added double-click shortcut opening config/details dialog to processors, connections, ports and labels. * Created a base for further

[GitHub] nifi issue #1946: NIFI-4125 - Add basic security settings to TransformXml

2017-06-28 Thread yuri1969
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/1946 Reverted back to turned on by default. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...

2017-06-26 Thread yuri1969
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1946#discussion_r124119598 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java --- @@ -98,6

[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...

2017-06-26 Thread yuri1969
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1946#discussion_r124116697 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java --- @@ -98,6

[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...

2017-06-26 Thread yuri1969
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1946#discussion_r124115889 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java --- @@ -166,8

[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...

2017-06-26 Thread yuri1969
GitHub user yuri1969 reopened a pull request: https://github.com/apache/nifi/pull/1946 NIFI-4125 - Add basic security settings to TransformXml Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...

2017-06-26 Thread yuri1969
Github user yuri1969 closed the pull request at: https://github.com/apache/nifi/pull/1946 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...

2017-06-26 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/1946 NIFI-4125 - Add basic security settings to TransformXml Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #1940: NIFI-4119 - Improve UX of canvas label configuratio...

2017-06-25 Thread yuri1969
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/1940 NIFI-4119 - Improve UX of canvas label configuration Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure