[GitHub] [nifi] exceptionfactory commented on pull request #6995: NIFI-7060 populate NiFi and NiFi Registry properties files using env vars in Docker Containers

2023-03-20 Thread via GitHub
exceptionfactory commented on PR #6995: URL: https://github.com/apache/nifi/pull/6995#issuecomment-1476956461 Thanks @ChrisSamo632, sounds good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] exceptionfactory commented on pull request #6995: NIFI-7060 populate NiFi and NiFi Registry properties files using env vars in Docker Containers

2023-03-16 Thread via GitHub
exceptionfactory commented on PR #6995: URL: https://github.com/apache/nifi/pull/6995#issuecomment-1472970814 @ChrisSamo632 Just following up on this discussion, what do you think about breaking out some of the simpler improvements into separate pull requests, then focusing in on the

[GitHub] [nifi] exceptionfactory commented on pull request #6995: NIFI-7060 populate NiFi and NiFi Registry properties files using env vars in Docker Containers

2023-02-28 Thread via GitHub
exceptionfactory commented on PR #6995: URL: https://github.com/apache/nifi/pull/6995#issuecomment-1449258278 Thanks for the thoughtful reply @ChrisSamo632. For the simple things first, it seems like the following items could be pulled out to a simpler PR: - address shellcheck