[GitHub] [nifi] harjitdotsingh commented on pull request #5046: Fix for #Nifi-8646 Added Support for ParQuet, ORC and DataStoreBackup.

2021-07-15 Thread GitBox
harjitdotsingh commented on pull request #5046: URL: https://github.com/apache/nifi/pull/5046#issuecomment-881018234 @pvillard31 - Added test run integration tests and unit tests without any issues. Pls let me know if there any issues which you see. -- This is an automated message

[GitHub] [nifi] harjitdotsingh commented on pull request #5046: Fix for #Nifi-8646 Added Support for ParQuet, ORC and DataStoreBackup.

2021-07-07 Thread GitBox
harjitdotsingh commented on pull request #5046: URL: https://github.com/apache/nifi/pull/5046#issuecomment-875815456 @pvillard31 - Quick Question. I was planning to write the tests for the formats I had added. Should I create new test for each format or create the tests in the

[GitHub] [nifi] harjitdotsingh commented on pull request #5046: Fix for #Nifi-8646 Added Support for ParQuet, ORC and DataStoreBackup.

2021-05-12 Thread GitBox
harjitdotsingh commented on pull request #5046: URL: https://github.com/apache/nifi/pull/5046#issuecomment-839768161 I knew that was coming. For some reasons my IDE formatted the code. Let me fix that. I will add that. I didn't see tests for any other cases other than JSON so left it