joewitt commented on issue #3917: Adding GetSmbFile and PutSmbFile processors
URL: https://github.com/apache/nifi/pull/3917#issuecomment-605061526
I cancelled the workflow execution as there are other builds going on and
this one isn't helpful until the commits on the PR are fixed.
joewitt commented on issue #3917: Adding GetSmbFile and PutSmbFile processors
URL: https://github.com/apache/nifi/pull/3917#issuecomment-605048656
there should only be commits on this branch that you provided.
Please rebase to latest master and have your commits be the most recent.
joewitt commented on issue #3917: Adding GetSmbFile and PutSmbFile processors
URL: https://github.com/apache/nifi/pull/3917#issuecomment-600645888
..disregard the close - hit the wrong button! reopened. And just learned
that reopening means the new builds are running - wow
joewitt commented on issue #3917: Adding GetSmbFile and PutSmbFile processors
URL: https://github.com/apache/nifi/pull/3917#issuecomment-600645546
this ideally needs to be rebased against latest. The updates to
NOTICE/LiCENSE look really well done. The code itself looks quite thoughtful.
joewitt commented on issue #3917: Adding GetSmbFile and PutSmbFile processors
URL: https://github.com/apache/nifi/pull/3917#issuecomment-576024125
Yep this looks pretty cool but definitely needs NOTICE file updates and
possibly LICENSE. The smbj library itself appears to include a
