markap14 commented on pull request #5072:
URL: https://github.com/apache/nifi/pull/5072#issuecomment-908384999
Thanks for the updates @gresockj! This is a huge improvement. And everything
is looking good from my perspective. I'm a +1 to merge. @mcgilman you okay with
me merging?
--
This
markap14 commented on pull request #5072:
URL: https://github.com/apache/nifi/pull/5072#issuecomment-908384999
Thanks for the updates @gresockj! This is a huge improvement. And everything
is looking good from my perspective. I'm a +1 to merge. @mcgilman you okay with
me merging?
--
This
markap14 commented on pull request #5072:
URL: https://github.com/apache/nifi/pull/5072#issuecomment-902004066
I did confirm that the above issues were addressed though :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
markap14 commented on pull request #5072:
URL: https://github.com/apache/nifi/pull/5072#issuecomment-901976823
One thing that I noticed is that when a parameter context is updated, we
make sure that the user has WRITE permissions to the parameter context and READ
permissions to all inherit
markap14 commented on pull request #5072:
URL: https://github.com/apache/nifi/pull/5072#issuecomment-895421278
Similarly, I just went to the "Kafka" parameter context and tried to change
the name of the topic. It failed with the following error:
```
Unable to complete parameter co
markap14 commented on pull request #5072:
URL: https://github.com/apache/nifi/pull/5072#issuecomment-895417817
Thanks for the newest round of updates @gresockj . I tested the above
scenario again. Kafka, S3 and Kafka to S3 contexts.
I started ConsumeKafka_2_6 and PutS3.
I then upd
markap14 commented on pull request #5072:
URL: https://github.com/apache/nifi/pull/5072#issuecomment-894508221
When testing, I found a couple of interesting things.
When looking at the Parameter Context, it shows all parameters, inherited
and owned by the context you're looking at. T
markap14 commented on pull request #5072:
URL: https://github.com/apache/nifi/pull/5072#issuecomment-894498931
It doesn't look like the Fingerprint Factory was updated. Will need to make
sure it accounts for this.
The only thing in the code that I really don't love is the addition of
