[GitHub] [nifi] mattyb149 commented on pull request #5075: NIFI-8536: PrometheusReportingTask and PrometheusRecordSink do not support variable registry for port property

2021-05-13 Thread GitBox
mattyb149 commented on pull request #5075: URL: https://github.com/apache/nifi/pull/5075#issuecomment-840733896 +1 LGTM, thanks for the fix! Merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [nifi] mattyb149 commented on pull request #5075: NIFI-8536: PrometheusReportingTask and PrometheusRecordSink do not support variable registry for port property

2021-05-13 Thread GitBox
mattyb149 commented on pull request #5075: URL: https://github.com/apache/nifi/pull/5075#issuecomment-840642467 This looks good to me but would like to see a unit test, you could add/change the following in TestPrometheusRecordSink.initTask() for example: ``` final MockVariableReg