pvillard31 commented on issue #4185:
URL: https://github.com/apache/nifi/pull/4185#issuecomment-618334632
No it's not, at the top of the pull request you can see that it contains 13
commits, modified 73 files, adds 2046 lines of code and removes 490 lines of
code which is much more than yo
pvillard31 commented on issue #4185:
URL: https://github.com/apache/nifi/pull/4185#issuecomment-617068158
Can you rebase against master and squash your commits? Right now the PR
include commits already merged to master that are unrelated to your change and
this makes the PR really hard to
pvillard31 commented on issue #4185:
URL: https://github.com/apache/nifi/pull/4185#issuecomment-616639325
It looks good to me. Could you add a unit test to confirm that catalog and
schema are correctly quoted? (cc @mattyb149 to have a second pair of eyes).
For the unit test, I'd dupl
pvillard31 commented on issue #4185: NIFI-7313:fix bug on 'Quote Table
Identifiers'
URL: https://github.com/apache/nifi/pull/4185#issuecomment-615274505
Can you revert the Splunk related change and squash your commits? Thanks
@wanghongqi
--
