[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1382: MINIFICPP-1899 - Fix local Docker build failure

2022-08-08 Thread GitBox
adam-markovics commented on code in PR #1382: URL: https://github.com/apache/nifi-minifi-cpp/pull/1382#discussion_r940359021 ## libminifi/src/utils/BackTrace.cpp: ## @@ -129,9 +129,6 @@ BackTrace TraceResolver::getBackTrace(std::string thread_name, std::thread::nati if (0

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1382: MINIFICPP-1899 - Fix local Docker build failure

2022-08-08 Thread GitBox
adam-markovics commented on code in PR #1382: URL: https://github.com/apache/nifi-minifi-cpp/pull/1382#discussion_r940355679 ## libminifi/src/utils/BackTrace.cpp: ## @@ -54,8 +54,10 @@ namespace { } // namespace #endif +#ifndef HAS_EXECINFO +void pull_trace(uint8_t) {

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1382: MINIFICPP-1899 - Fix local Docker build failure

2022-08-04 Thread GitBox
adam-markovics commented on code in PR #1382: URL: https://github.com/apache/nifi-minifi-cpp/pull/1382#discussion_r938058318 ## libminifi/src/utils/BackTrace.cpp: ## @@ -117,6 +117,8 @@ void pull_trace(uint8_t frames_to_skip /* = 1 */) {