[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635310034 ## File path: libminifi/include/core/logging/Logger.h ## @@ -68,13 +69,32 @@ inline T conditional_conversion(T t) { } template -inline s

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635306229 ## File path: libminifi/src/Configure.cpp ## @@ -37,6 +37,10 @@ bool Configure::get(const std::string& key, std::string& value) const {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635265649 ## File path: libminifi/include/utils/Enum.h ## @@ -60,6 +63,22 @@ namespace utils { #define FOR_EACH_8(fn, delim, _1, _2, _3, _4, _5, _6,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635264523 ## File path: libminifi/src/c2/HeartbeatJsonSerializer.cpp ## @@ -0,0 +1,333 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635264297 ## File path: libminifi/src/Configure.cpp ## @@ -37,6 +37,10 @@ bool Configure::get(const std::string& key, std::string& value) const {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635261808 ## File path: libminifi/include/core/logging/Logger.h ## @@ -68,13 +69,32 @@ inline T conditional_conversion(T t) { } template -inline s

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r634577239 ## File path: libminifi/include/c2/HeartbeatJsonSerializer.h ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r634554213 ## File path: libminifi/include/c2/HeartbeatJsonSerializer.h ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r634554213 ## File path: libminifi/include/c2/HeartbeatJsonSerializer.h ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r634552401 ## File path: libminifi/src/c2/protocols/RESTProtocol.cpp ## @@ -318,133 +178,7 @@ bool RESTProtocol::containsPayload(const C2Payload &o) {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r634551768 ## File path: libminifi/src/c2/HeartbeatJsonSerializer.cpp ## @@ -0,0 +1,333 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r634550117 ## File path: extensions/http-curl/tests/C2LogHeartbeatTest.cpp ## @@ -0,0 +1,58 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r630823120 ## File path: conf/minifi.properties ## @@ -67,6 +67,7 @@ nifi.content.repository.class.name=DatabaseContentRepository ## define protocol p