[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1238: MINIFICPP-1718 - Handle case sensitive column names

2022-01-13 Thread GitBox
adamdebreceni commented on a change in pull request #1238: URL: https://github.com/apache/nifi-minifi-cpp/pull/1238#discussion_r783814194 ## File path: extensions/sql/data/SQLIdentifier.h ## @@ -19,18 +19,40 @@ #pragma once #include -#include +#include -namespace org {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1238: MINIFICPP-1718 - Handle case sensitive column names

2022-01-13 Thread GitBox
adamdebreceni commented on a change in pull request #1238: URL: https://github.com/apache/nifi-minifi-cpp/pull/1238#discussion_r783815264 ## File path: extensions/sql/data/SQLIdentifier.h ## @@ -19,18 +19,40 @@ #pragma once #include -#include +#include -namespace org {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1238: MINIFICPP-1718 - Handle case sensitive column names

2022-01-13 Thread GitBox
adamdebreceni commented on a change in pull request #1238: URL: https://github.com/apache/nifi-minifi-cpp/pull/1238#discussion_r783833399 ## File path: docker/test/integration/features/sql.feature ## @@ -32,6 +32,21 @@ Feature: Executing SQL operations from MiNiFi-C++ When

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1238: MINIFICPP-1718 - Handle case sensitive column names

2022-01-13 Thread GitBox
adamdebreceni commented on a change in pull request #1238: URL: https://github.com/apache/nifi-minifi-cpp/pull/1238#discussion_r783834127 ## File path: extensions/sql/data/SQLIdentifier.cpp ## @@ -16,30 +16,26 @@ * limitations under the License. */ -#include "Utils.h" +#i

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1238: MINIFICPP-1718 - Handle case sensitive column names

2022-01-13 Thread GitBox
adamdebreceni commented on a change in pull request #1238: URL: https://github.com/apache/nifi-minifi-cpp/pull/1238#discussion_r783838662 ## File path: extensions/sql/data/SQLIdentifier.h ## @@ -19,18 +19,40 @@ #pragma once #include -#include +#include -namespace org {